FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.7
Threshold is Low
Effort is Default
Summary
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
1568 | 130 | 0 | 0 |
Files
org.apache.myfaces.trinidad.bean.FacesBeanFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of type in org.apache.myfaces.trinidad.bean.FacesBeanFactory.createFacesBean(String, String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 105 | Medium |
org.apache.myfaces.trinidad.bean.FacesBeanImpl$BehaviorMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.bean.FacesBeanImpl$BehaviorMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 609-754 | Low |
org.apache.myfaces.trinidad.bean.ValueBindingValueExpression$SerializableStateHolderValueBindingValueExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.bean.ValueBindingValueExpression$SerializableStateHolderValueBindingValueExpression implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 221-222 | Low |
org.apache.myfaces.trinidad.bean.ValueBindingValueExpression$SerializableValueBindingValueExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.bean.ValueBindingValueExpression$SerializableValueBindingValueExpression implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 176-177 | Low |
org.apache.myfaces.trinidad.bean.ValueBindingValueExpression$StateHolderValueBindingValueExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.el.ValueBinding to javax.faces.component.StateHolder in new org.apache.myfaces.trinidad.bean.ValueBindingValueExpression$StateHolderValueBindingValueExpression(ValueBinding) | STYLE | BC_UNCONFIRMED_CAST | 188 | Low |
org.apache.myfaces.trinidad.bean.ValueBindingValueExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.bean.ValueBindingValueExpression$StateHolderValueBindingValueExpression doesn't override ValueBindingValueExpression.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 152-158 | Medium |
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding.getValueBinding(ValueExpression), since all javax.el.ValueExpression are instances of java.io.Serializable | STYLE | BC_VACUOUS_INSTANCEOF | 53 | Medium |
Method org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding.getValueBinding(ValueExpression) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 48 | Low |
Method org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding.getValueBinding(ValueExpression) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 53 | Low |
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding$SerializableStateHolderValueExpressionValueBinding
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding$SerializableStateHolderValueExpressionValueBinding is Serializable but its superclass doesn't define an accessible void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR | 204-205 | High |
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding$SerializableValueExpressionValueBinding
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding$SerializableValueExpressionValueBinding is Serializable but its superclass doesn't define an accessible void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR | 160-161 | High |
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding$StateHolderValueExpressionValueBinding
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.el.ValueExpression to javax.faces.component.StateHolder in new org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding$StateHolderValueExpressionValueBinding(ValueExpression) | STYLE | BC_UNCONFIRMED_CAST | 171 | Low |
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.bean.ValueExpressionValueBinding$StateHolderValueExpressionValueBinding doesn't override ValueExpressionValueBinding.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 135-142 | Medium |
org.apache.myfaces.trinidad.bean.util.StateUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 78 | Low |
org.apache.myfaces.trinidad.change.ChangeComponentProxy
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field org.apache.myfaces.trinidad.change.ChangeComponentProxy._class is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
org.apache.myfaces.trinidad.change.MoveChildComponentChange
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field org.apache.myfaces.trinidad.change.MoveChildComponentChange._commonParent is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.trinidad.change.SessionChangeManager$ChangesForView
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.change.SessionChangeManager$ChangesForView defines non-transient non-serializable instance field _renameChanges | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
The field org.apache.myfaces.trinidad.change.SessionChangeManager$ChangesForView._attrRebuildLock is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
The field org.apache.myfaces.trinidad.change.SessionChangeManager$ChangesForView._attrChanges is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
The field org.apache.myfaces.trinidad.change.SessionChangeManager$ChangesForView._renameMap is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.trinidad.component.ChildArrayList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.component.ChildArrayList defines non-transient non-serializable instance field _parent | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidad.component.MethodBindingMethodExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.component.MethodBindingMethodExpression implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 39-90 | Low |
Class org.apache.myfaces.trinidad.component.MethodBindingMethodExpression defines non-transient non-serializable instance field _binding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidad.component.StampState$EVHState
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.trinidad.component.StampState$EVHState.restoreRowState(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 450 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.trinidad.component.StampState$EVHState.saveRowState(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 438 | Low |
org.apache.myfaces.trinidad.component.StampState$SDState
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXShowDetail in org.apache.myfaces.trinidad.component.StampState$SDState.restoreRowState(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 367 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXShowDetail in org.apache.myfaces.trinidad.component.StampState$SDState.saveRowState(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 360 | Low |
org.apache.myfaces.trinidad.component.StampState$TableState
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXCollection in org.apache.myfaces.trinidad.component.StampState$TableState.restoreRowState(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 412 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXCollection in org.apache.myfaces.trinidad.component.StampState$TableState.saveRowState(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 406 | Low |
org.apache.myfaces.trinidad.component.UIXCollection
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Useless control flow to next line in org.apache.myfaces.trinidad.component.UIXCollection.encodeBegin(FacesContext) | CORRECTNESS | UCF_USELESS_CONTROL_FLOW_NEXT_LINE | 581 | High |
Useless control flow to next line in org.apache.myfaces.trinidad.component.UIXCollection.encodeEnd(FacesContext) | CORRECTNESS | UCF_USELESS_CONTROL_FLOW_NEXT_LINE | 591 | High |
org.apache.myfaces.trinidad.component.UIXComponent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to visitResult in org.apache.myfaces.trinidad.component.UIXComponent.visitTree(VisitContext, UIComponent, VisitCallback) | STYLE | DLS_DEAD_LOCAL_STORE | 505 | Low |
org.apache.myfaces.trinidad.component.UIXComponentBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 2153 | Low |
Load of known null value in org.apache.myfaces.trinidad.component.UIXComponentBase.setParent(UIComponent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 531 | Medium |
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidad.component.UIXComponentBase._createType() | STYLE | REC_CATCH_EXCEPTION | 2053 | Low |
org.apache.myfaces.trinidad.component.UIXComponentRef
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.myfaces.trinidad.component.UIXComponentRef._getParent(), since all org.apache.myfaces.trinidad.component.UIXComponentRef are instances of org.apache.myfaces.trinidad.component.UIXComponentRef | STYLE | BC_VACUOUS_INSTANCEOF | 247 | Medium |
org.apache.myfaces.trinidad.component.UIXComponentRef$1
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.apache.myfaces.trinidad.component.UIXComponentRef$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 129-133 | Low |
org.apache.myfaces.trinidad.component.UIXEditableValue
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 595 | Low |
org.apache.myfaces.trinidad.component.UIXFacesBeanImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of component, which is known to be non-null in org.apache.myfaces.trinidad.component.UIXFacesBeanImpl.init(UIXComponent, FacesBean$Type) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 85 | Low |
org.apache.myfaces.trinidad.component.UIXNavigationLevel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.component.UIXNavigationLevel implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 55-265 | Low |
org.apache.myfaces.trinidad.component.UIXNavigationPath
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.component.UIXNavigationPath implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 59-289 | Low |
org.apache.myfaces.trinidad.component.UIXPage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.myfaces.trinidad.component.UIXPage.processFacetsAndChildren(FacesContext, PhaseId) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 162 | Medium |
org.apache.myfaces.trinidad.component.UIXShowOne$UndisclosureCallback
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXShowDetail in org.apache.myfaces.trinidad.component.UIXShowOne$UndisclosureCallback.processComponent(FacesContext, ComponentProcessingContext, UIComponent, UIXShowOne$UndisclosureCallbackState) | STYLE | BC_UNCONFIRMED_CAST | 179 | Low |
Should org.apache.myfaces.trinidad.component.UIXShowOne$UndisclosureCallback be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 164-201 | Medium |
org.apache.myfaces.trinidad.component.UIXTree
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.component.UIXTree implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 155-863 | Low |
org.apache.myfaces.trinidad.component.ValueMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Non serializable java.util.Map written to ObjectOutput in org.apache.myfaces.trinidad.component.ValueMap.writeExternal(ObjectOutput) | STYLE | DMI_NONSERIALIZABLE_OBJECT_WRITTEN | 139 | Low |
org.apache.myfaces.trinidad.context.AccessibilityProfile$SerializableAccessibilityProfile
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.context.AccessibilityProfile$SerializableAccessibilityProfile is Serializable but its superclass doesn't define an accessible void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR | 195-196 | High |
org.apache.myfaces.trinidad.convert.ColorConverter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.convert.ColorConverter.DEFAULT_COLOR_FORMAT_PATTERNS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 149 | Low |
Possible null pointer dereference of patterns on path that might be infeasible in org.apache.myfaces.trinidad.convert.ColorConverter._isEqualPatterns(String[]) | STYLE | NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE | 627 | Medium |
Possible null pointer dereference of thisPattern on path that might be infeasible in org.apache.myfaces.trinidad.convert.ColorConverter._isEqualPatterns(String[]) | STYLE | NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE | 627 | Medium |
org.apache.myfaces.trinidad.convert.DateTimeConverter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 1525 | Low |
The class name org.apache.myfaces.trinidad.convert.DateTimeConverter shadows the simple name of the superclass javax.faces.convert.DateTimeConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 175-1937 | High |
Class org.apache.myfaces.trinidad.convert.DateTimeConverter implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 175-1937 | Low |
org.apache.myfaces.trinidad.convert.NumberConverter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.apache.myfaces.trinidad.convert.NumberConverter shadows the simple name of the superclass javax.faces.convert.NumberConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 118-1427 | High |
org.apache.myfaces.trinidad.convert.RGBColorFormat
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 553 | Low |
org.apache.myfaces.trinidad.event.AttributeChangeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.AttributeChangeListener in org.apache.myfaces.trinidad.event.AttributeChangeEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 77 | Low |
org.apache.myfaces.trinidad.event.ChartDrillDownEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.ChartDrillDownListener in org.apache.myfaces.trinidad.event.ChartDrillDownEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 54 | Low |
Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getSeriesIndices() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 67 | Low |
Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getXValues() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 117 | Low |
Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getYValueIndices() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 84 | Low |
Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getYValues() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 100 | Low |
org.apache.myfaces.trinidad.event.DisclosureEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.DisclosureListener in org.apache.myfaces.trinidad.event.DisclosureEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 48 | Low |
org.apache.myfaces.trinidad.event.FocusEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.FocusListener in org.apache.myfaces.trinidad.event.FocusEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 71 | Low |
org.apache.myfaces.trinidad.event.LaunchEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.LaunchListener in org.apache.myfaces.trinidad.event.LaunchEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 108 | Low |
The field org.apache.myfaces.trinidad.event.LaunchEvent._viewRoot is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.trinidad.event.PollEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.PollListener in org.apache.myfaces.trinidad.event.PollEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 40 | Low |
org.apache.myfaces.trinidad.event.RangeChangeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.RangeChangeListener in org.apache.myfaces.trinidad.event.RangeChangeEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 103 | Low |
org.apache.myfaces.trinidad.event.ReturnEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.ReturnListener in org.apache.myfaces.trinidad.event.ReturnEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 73 | Low |
org.apache.myfaces.trinidad.event.RowDisclosureEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.RowDisclosureListener in org.apache.myfaces.trinidad.event.RowDisclosureEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 62 | Low |
org.apache.myfaces.trinidad.event.SelectionEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.SelectionListener in org.apache.myfaces.trinidad.event.SelectionEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 61 | Low |
org.apache.myfaces.trinidad.event.SortEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to org.apache.myfaces.trinidad.event.SortListener in org.apache.myfaces.trinidad.event.SortEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 63 | Low |
org.apache.myfaces.trinidad.event.WindowLifecycleEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.event.WindowLifecycleEvent.equals(Object) fails for subtypes | BAD_PRACTICE | EQ_GETCLASS_AND_CLASS_CONSTANT | 127 | Medium |
org.apache.myfaces.trinidad.facelets.MethodRule
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.apache.myfaces.trinidad.facelets.MethodRule(String, Class, Class[]) may expose internal representation by storing an externally mutable object into MethodRule.params | MALICIOUS_CODE | EI_EXPOSE_REP2 | 61 | Medium |
org.apache.myfaces.trinidad.menu.GroupNode
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.menu.GroupNode.getIdRefListProperty() may expose internal representation by returning GroupNode._idrefList | MALICIOUS_CODE | EI_EXPOSE_REP | 197 | Medium |
org.apache.myfaces.trinidad.menu.ImmutableGroupNode
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to label in org.apache.myfaces.trinidad.menu.ImmutableGroupNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 319 | Medium |
Dead store to label in org.apache.myfaces.trinidad.menu.ImmutableGroupNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 315 | Low |
Dead store to accessKey in org.apache.myfaces.trinidad.menu.ImmutableGroupNode.getLabel() | STYLE | DLS_DEAD_LOCAL_STORE | 213 | Low |
org.apache.myfaces.trinidad.menu.ImmutableItemNode
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to label in org.apache.myfaces.trinidad.menu.ImmutableItemNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 401 | Medium |
Dead store to label in org.apache.myfaces.trinidad.menu.ImmutableItemNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 397 | Low |
Dead store to accessKey in org.apache.myfaces.trinidad.menu.ImmutableItemNode.getLabel() | STYLE | DLS_DEAD_LOCAL_STORE | 256 | Low |
org.apache.myfaces.trinidad.menu.MenuUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked argument of type Object provided where type String is expected in org.apache.myfaces.trinidad.menu.MenuUtils.loadBundle(String, ThreadLocal) | BAD_PRACTICE | GC_UNCHECKED_TYPE_IN_GENERIC_CALL | 230 | Low |
org.apache.myfaces.trinidad.menu.MenuUtils$_BundleMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of ?, which is known to be non-null in org.apache.myfaces.trinidad.menu.MenuUtils$_BundleMap.containsKey(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 349 | Low |
org.apache.myfaces.trinidad.model.RowKeySetImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Questionable cast from java.util.Set<T> to java.util.HashSet in org.apache.myfaces.trinidad.model.RowKeySetImpl._clone(Set) | STYLE | BC_BAD_CAST_TO_CONCRETE_COLLECTION | 496 | Low |
org.apache.myfaces.trinidad.model.RowKeySetTreeImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method org.apache.myfaces.trinidad.model.RowKeySetTreeImpl._containsDefaultNodes() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 558-568 | Low |
Private method org.apache.myfaces.trinidad.model.RowKeySetTreeImpl._dumpFlags() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 576-586 | Low |
org.apache.myfaces.trinidad.model.SortableModel$Comp
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.model.SortableModel$Comp implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 378-448 | Low |
org.apache.myfaces.trinidad.model.SortableModel$Inverter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.model.SortableModel$Inverter implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 461-467 | Low |
org.apache.myfaces.trinidad.model.XMLMenuModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidad.model.XMLMenuModel._createModel() | STYLE | REC_CATCH_EXCEPTION | 791 | Medium |
org.apache.myfaces.trinidad.resource.AggregatingResourceLoader$AggregatingURLStreamHandler
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.myfaces.trinidad.resource.AggregatingResourceLoader$AggregatingURLStreamHandler be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 146-184 | Medium |
org.apache.myfaces.trinidad.util.ClassLoaderUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidad.util.ClassLoaderUtils.getServices(String) | STYLE | REC_CATCH_EXCEPTION | 275 | Low |
org.apache.myfaces.trinidad.util.CollectionUtils$CheckedSerializationMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidad.util.CollectionUtils$CheckedSerializationMap defines non-transient non-serializable instance field _delegate | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidad.util.CollectionUtils$LenientCompositeSet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.util.CollectionUtils$LenientCompositeSet defines hashCode but not equals | BAD_PRACTICE | HE_HASHCODE_NO_EQUALS | 1096-1121 | Low |
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableCollection
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field org.apache.myfaces.trinidad.util.CollectionUtils$SerializableCollection._delegate is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableExternalAccessHookMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableExternalAccessHookMap is Serializable but its superclass doesn't define an accessible void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR | 1639-1654 | High |
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableFixedCompositeSet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableFixedCompositeSet is Serializable but its superclass doesn't define an accessible void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR | 1004-1005 | High |
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableLenientFixedCompositeSet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableLenientFixedCompositeSet is Serializable but its superclass doesn't define an accessible void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR | 1167-1168 | High |
org.apache.myfaces.trinidad.util.CollectionUtils$SerializableList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field org.apache.myfaces.trinidad.util.CollectionUtils$SerializableList._delegate is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
org.apache.myfaces.trinidad.util.ComponentUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Nullcheck of targetComponent at line 431 of value previously dereferenced in org.apache.myfaces.trinidad.util.ComponentUtils.getScopedIdForComponent(UIComponent, UIComponent) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 429 | Medium |
org.apache.myfaces.trinidad.util.ExternalContextUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidad.util.ExternalContextUtils._runMethod(Object, String) | STYLE | REC_CATCH_EXCEPTION | 527 | Low |
org.apache.myfaces.trinidad.util.LocaleUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of localeStr, which is known to be non-null in org.apache.myfaces.trinidad.util.LocaleUtils._getBundleString(ResourceBundle, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 321 | Low |
org.apache.myfaces.trinidad.util.TransientHolder
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field org.apache.myfaces.trinidad.util.TransientHolder._value is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
org.apache.myfaces.trinidad.util.URLUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.util.URLUtils.getLastModified(URLConnection) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 78 | Low |
org.apache.myfaces.trinidad.validator.DateRestrictionValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of hashCode on array in org.apache.myfaces.trinidad.validator.DateRestrictionValidator.hashCode() | CORRECTNESS | DMI_INVOKING_HASHCODE_ON_ARRAY | 396 | Medium |
Invocation of hashCode on array in org.apache.myfaces.trinidad.validator.DateRestrictionValidator.hashCode() | CORRECTNESS | DMI_INVOKING_HASHCODE_ON_ARRAY | 397 | Medium |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 569 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 554 | Low |
javax.faces.validator.DoubleRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.validator.DoubleRangeValidator doesn't override javax.faces.validator.DoubleRangeValidator.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 313-317 | Medium |
org.apache.myfaces.trinidad.validator.DoubleRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.apache.myfaces.trinidad.validator.DoubleRangeValidator shadows the simple name of the superclass javax.faces.validator.DoubleRangeValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 91-602 | High |
javax.faces.validator.LengthValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.validator.LengthValidator doesn't override javax.faces.validator.LengthValidator.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 253-257 | Medium |
org.apache.myfaces.trinidad.validator.LengthValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.apache.myfaces.trinidad.validator.LengthValidator shadows the simple name of the superclass javax.faces.validator.LengthValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 98-652 | High |
javax.faces.validator.LongRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.validator.LongRangeValidator doesn't override javax.faces.validator.LongRangeValidator.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 311-315 | Medium |
org.apache.myfaces.trinidad.validator.LongRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.apache.myfaces.trinidad.validator.LongRangeValidator shadows the simple name of the superclass javax.faces.validator.LongRangeValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 94-605 | High |
org.apache.myfaces.trinidad.webapp.ResourceServlet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidad.webapp.ResourceServlet._debug is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 588 | Low |
org.apache.myfaces.trinidad.webapp.ResourceServlet._facesContextFactory is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 96 | Low |
org.apache.myfaces.trinidad.webapp.ResourceServlet._lifecycle is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 97 | Low |
org.apache.myfaces.trinidad.webapp.ResourceServlet._loaders is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 95 | Low |
org.apache.myfaces.trinidad.webapp.ResourceServlet._projectStage is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 453 | Low |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet._debug extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 416 | Low |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet._facesContextFactory extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 96 | Low |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet._lifecycle extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 97 | Low |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet._loaders extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 95 | Low |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet._projectStage extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 500 | Low |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet defines non-transient non-serializable instance field _facesContextFactory | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet defines non-transient non-serializable instance field _lifecycle | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.apache.myfaces.trinidad.webapp.ResourceServlet defines non-transient non-serializable instance field _loaders | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidad.webapp.ResourceServlet$_ResourceLifecycle stored into non-transient field ResourceServlet._lifecycle | BAD_PRACTICE | SE_BAD_FIELD_STORE | 133 | Medium |
org.apache.myfaces.trinidad.webapp.ResourceServlet$1
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.apache.myfaces.trinidad.webapp.ResourceServlet$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 338-343 | Low |
org.apache.myfaces.trinidad.webapp.ResourceServlet$_ResourceLifecycle
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.myfaces.trinidad.webapp.ResourceServlet$_ResourceLifecycle.getPhaseListeners() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 642 | Low |
org.apache.myfaces.trinidad.webapp.UIXComponentELTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.myfaces.trinidad.webapp.UIXComponentELTag._parseNameTokens(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 420 | Low |
org.apache.myfaces.trinidad.webapp.UIXComponentTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.myfaces.trinidad.webapp.UIXComponentTag._parseNameTokens(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 496 | Low |