Tag List Report
The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| @todo | 0 | @todo |
| TODO | 100 | TODO |
Each tag is detailed below:
TODO
Number of occurrences found in the code: 100
| org.apache.myfaces.application.ApplicationImpl | Line |
|---|---|
| this check should be performed by the expression factory. It is a requirement of the TCK | 1955 |
| Check if modification occurs often or not, might have to use a synchronized list instead. | 2700 |
| Check if modification occurs often or not, might have to use a synchronized list instead. | 2721 |
| org.apache.myfaces.application.ApplicationImplAnnotationTest | Line |
| need mock objects for VDL/VDLFactory remove from excludes list in pom.xml after complete | 54 |
| org.apache.myfaces.application.ApplicationImplTest | Line |
| need mock objects for VDL/VDLFactory remove from excludes list in pom.xml after complete | 63 |
| org.apache.myfaces.application.NavigationHandlerImpl | Line |
| cache results? | 359 |
| --No comment-- | 542 |
| org.apache.myfaces.application.ResourceHandlerImpl | Line |
| Log using a localized message (which one?) | 427 |
| org.apache.myfaces.application.ViewHandlerImpl | Line |
| JSF 2.0 - need to make sure calculateViewId follows the new algorithm from 7.5.2 | 99 |
| JSF 2.0 - need to make sure calculateViewId follows the new algorithm from 7.5.2 | 117 |
| org.apache.myfaces.application.jsp.JspViewHandlerImplTest | Line |
| --No comment-- | 359 |
| --No comment-- | 368 |
| --No comment-- | 377 |
| --No comment-- | 386 |
| --No comment-- | 395 |
| org.apache.myfaces.component.visit.PartialVisitContext | Line |
| log warning for trailing colon case | 311 |
| smarter initial size? | 346 |
| org.apache.myfaces.config.annotation.AllAnnotationLifecycleProvider | Line |
| @EJBs | 33 |
| where i find WebServiceRef? | 57 |
| org.apache.myfaces.config.annotation.AnnotationConfigurator | Line |
| Implement strategy pattern over this method. | 97 |
| MartinKoci MYFACES-3053 | 161 |
| org.apache.myfaces.config.annotation.NoInjectionAnnotationLifecycleProvider | Line |
| the servlet spec is not clear about searching in superclass?? | 118 |
| the servlet spec is not clear about searching in superclass?? May be only check non private fields and methods | 162 |
| org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider | Line |
| @Resources | 32 |
| local or global JNDI | 183 |
| local or global JNDI | 188 |
| local or global JNDI | 218 |
| local or global JNDI | 223 |
| org.apache.myfaces.config.impl.digester.DigesterFacesConfigUnmarshallerImpl | Line |
| validation set to false during implementation of 1.2 | 43 |
| org.apache.myfaces.config.impl.digester.elements.Behavior | Line |
| what about extensions and descriptionGroup elems? Not addressed in other config objects either. | 36 |
| org.apache.myfaces.context.servlet.PartialViewContextImpl | Line |
| process partial rendering https://issues.apache.org/jira/browse/MYFACES-2118 Collection<String> renderIds = getRenderIds(); | 425 |
| Do not check for a specific instance, just render all children. if (comp instanceof javax.faces.component.html.HtmlBody) { comp.encodeAll (_facesContext); } } | 612 |
| org.apache.myfaces.context.servlet.ServletExternalContextImplTest | Line |
| Invalid test, because EL evaluation should be done before call these methods. | 68 |
| org.apache.myfaces.convert.ConverterUtils | Line |
| Move to util package and rename to better name | 23 |
| org.apache.myfaces.el.unified.FacesELContext | Line |
| decide if we need to implement our own FunctionMapperImpl and VariableMapperImpl instead of relying on Tomcat's version. this.functionMapper = new FunctionMapperImpl(); this.variableMapper = new VariableMapperImpl(); | 44 |
| org.apache.myfaces.event.SetPropertyActionListener | Line |
| use a Converter before calling setValue | 79 |
| org.apache.myfaces.lifecycle.DefaultRestoreViewSupport | Line |
| CJH: I don't think this is correct, considering that getActionURL() expects everything to start with '/', and in the suffix case we only mess with the suffix and leave leading slashes alone. Please review... | 404 |
| org.apache.myfaces.lifecycle.DefaultRestoreViewSupportTest | Line |
| not testable unless static call to RendererUtils is removed | 206 |
| org.apache.myfaces.mc.test.core.AbstractMyFacesRequestTestCase | Line |
| check if this is correct | 98 |
| org.apache.myfaces.mc.test.core.MockDefaultViewDeclarationLanguage | Line |
| VALIDATE - The spec is silent on the following line, but I feel bad if I don't set it | 105 |
| VALIDATE - Spec is silent on the return value when an error was sent | 116 |
| org.apache.myfaces.renderkit.ErrorPageWriterTest | Line |
| remove these two lines once myfaces-test goes alpha, see MYFACES-1155 | 65 |
| org.apache.myfaces.renderkit.NullReturningGetExpressionStringValueExpression | Line |
| Auto-generated method stub | 43 |
| Auto-generated method stub | 51 |
| Auto-generated method stub | 58 |
| Auto-generated method stub | 66 |
| Auto-generated method stub | 72 |
| Auto-generated method stub | 78 |
| Auto-generated method stub | 84 |
| org.apache.myfaces.renderkit.html.HtmlAjaxBehaviorRenderer | Line |
| we may need a proper type handling in this part lets leave it for now as it is quotes etc.. should be transferred directly and the rest is up to the toString properly implemented ANS: Both name and value should be quoted | 280 |
| org.apache.myfaces.renderkit.html.HtmlEscapeRendererTest | Line |
| remove these two lines once myfaces-test goes alpha, see MYFACES-1155 | 90 |
| org.apache.myfaces.renderkit.html.HtmlHeadRenderer | Line |
| Move constants to shared HTML class | 44 |
| org.apache.myfaces.renderkit.html.HtmlLabelRenderer | Line |
| Move to extended component | 183 |
| org.apache.myfaces.renderkit.html.HtmlScriptRenderer | Line |
| target check here | 123 |
| org.apache.myfaces.renderkit.html.HtmlTextRendererTest | Line |
| remove these two lines once myfaces-test goes alpha, see MYFACES-1155 | 75 |
| org.apache.myfaces.taglib.core.LoadBundleTag | Line |
| We should find a way to save loaded bundles in the state, because otherwise on the next request the bundle map will not be present before the render phase and value bindings that reference to the bundle will always log annoying "Variable 'xxx' could not be resolved" error messages. </p> | 49 |
| org.apache.myfaces.view.ViewDeclarationLanguageFactoryImpl | Line |
| It would be nice to be able to preinitialize the factory. However, since it requires access to the ExternalContext it may not be possible, depending on the loading order in the FactoryFinder. Could use ideas here. -= SL =- | 76 |
| org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementStrategy | Line |
| This object should be application scoped and shared between jsp and facelets | 192 |
| Why is necessary enable event processing? ANS: On RestoreViewExecutor, setProcessingEvents is called first to false and then to true when postback. Since we need listeners registered to PostAddToViewEvent event to be handled, we should enable it again. We are waiting a response from EG about the behavior of those listeners, because for partial state saving we need this listeners be called from here and relocate components properly, but for now we have to let this code as is. | 287 |
| ask the EG the this is a spec violation if we do it that way see Section 2.2.1 | 379 |
| Why is necessary enable event processing? ANS: On RestoreViewExecutor, setProcessingEvents is called first to false and then to true when postback. Since we need listeners registered to PostAddToViewEvent event to be handled, we should enable it again. We are waiting a response from EG about the behavior of those listeners (see comment on vdl.buildView). -= Leonardo Uribe =- I think enable event processing in this point does not have any side effect. Enable it allows programatically add components when binding is set with pss enabled. That feature works without pss, so we should preserve backward behavior. Tomahawk t:aliasBean example creating components on binding requires this to work. context.setProcessingEvents(true); try { view.visitTree(VisitContext.createVisitContext(context), new RestoreStateCallback()); } finally { context.setProcessingEvents(oldContextEventState); } | 381 |
| not sure the best way to handle dynamic adds/removes as mandated by the spec. | 700 |
| org.apache.myfaces.view.facelets.FaceletViewDeclarationLanguage | Line |
| Move to shared project | 1775 |
| Auto-generated method stub | 1887 |
| this class and ViewHandlerImpl contain same constant <!--@@JSF_FORM_STATE_MARKER@@--> | 2006 |
| VALIDATE - Is _buildBeforeRestore relevant at all for 2.0? -= SL =- ANS: buildBeforeRestore evolved to partial state saving, so this logic is now on StateManagerStrategy implementation -= Leo U =- | 2122 |
| org.apache.myfaces.view.facelets.PostBuildComponentTreeOnRestoreViewEvent | Line |
| Remove it since after MYFACES-2389 this is not necessary anymore. Now, PostAddToViewEvent can be triggered inclusive on postback and restore view phase, but note RestoreViewExecutor call facesContext.setProcessingEvents(false) and cause the same effect than the check on UIComponent.setParent() (postback and restore view phase). | 27 |
| org.apache.myfaces.view.facelets.component.UIRepeat | Line |
| Auto-generated method stub | 1562 |
| org.apache.myfaces.view.facelets.el.ResourceELUtils | Line |
| check this expression, maybe we can make it simpler, because "resource" implicit object cannot be preceded by anything. | 34 |
| org.apache.myfaces.view.facelets.impl.FaceletCacheImpl | Line |
| Note MyFaces core has another type of Facelet for read composite component metadata. The reason behind do this in MyFaces is to retrieve some information related to insertChildren/insertFacet that can be used as metadata and use that information later to do the hack for composite components using templates, instead rely on component relocation. This is not handled by FaceletCache included here but in practice this should not be a problem, because the intention of this class is handle Facelet instances created using custom ResourceResolver stuff, and usually those pages are for views, not for composite components. Even if that is true, composite component metadata Facelet is smaller (only add cc:xxx stuff) that the other ones used for views or the one used to apply the composite component itself. | 35 |
| org.apache.myfaces.view.facelets.mock.MockRequestDispatcher | Line |
| Auto-generated method stub | 48 |
| Auto-generated method stub | 55 |
| org.apache.myfaces.view.facelets.tag.MetadataImpl | Line |
| PROFILE - Check if saving the _size worth it or if an enhanced for is better | 42 |
| org.apache.myfaces.view.facelets.tag.TagAttributesImpl | Line |
| PROFILE - Explore the possibility of using HashMap instead of sorted arrays. The footprint should be higher, but the instanciation and access speed should be faster Instanciation: from O(n log n) to O(1) Access: from O(log n) to O(1) | 33 |
| org.apache.myfaces.view.facelets.tag.composite.ExtensionHandler | Line |
| In theory the xml data inside this tag should be saved, but the spec does not say where and how this should be done. For now we just prevent execute any handler inside this tag. As soon JSR-276 is available, some behavior for this tag should be added. | 51 |
| org.apache.myfaces.view.facelets.tag.composite.SimpleComponentTagHandler | Line |
| Auto-generated constructor stub | 37 |
| org.apache.myfaces.view.facelets.tag.jsf.BehaviorTagHandlerDelegate | Line |
| check if the behavior could be applied to the current parent For run tests it is not necessary, so we let this one pending. | 154 |
| org.apache.myfaces.view.facelets.tag.jsf.ComponentHandler | Line |
| REFACTOR - "facelets.FACET_NAME" should be a constant somewhere, used to be in FacetHandler from real Facelets | 200 |
| org.apache.myfaces.view.facelets.tag.jsf.core.ActionListenerHandler | Line |
| Document me! | 204 |
| org.apache.myfaces.view.facelets.tag.jsf.core.AjaxHandler | Line |
| The spec is not clear about how to deal with composite component instances. The default one proposed here is use a different stack on DefaultFaceletContext.applyCompositeComponent, so components inside composite:implementation tag will not be affected by f:ajax outsider handlers. | 214 |
| org.apache.myfaces.view.facelets.tag.jsf.core.EventHandler | Line |
| The spec is somewhat vague, but I think we're supposed to throw an exception here. The @NamedEvent javadocs say that if a short name is registered to more than one event class that we must throw an exception listing the short name and the classes in the list _when the application makes reference to it_. I believe processing this tag qualifies as the application "making reference" to the short name. Why the exception isn't thrown when processing the @NamedEvent annotation, I don't know. Perhaps follow up with the EG to see if this is correct. | 203 |
| org.apache.myfaces.view.facelets.tag.jsf.core.SetPropertyActionListenerHandler | Line |
| Document me! | 179 |
| org.apache.myfaces.view.facelets.tag.jsf.core.ValueChangeListenerHandler | Line |
| Document me! | 193 |
| org.apache.myfaces.view.facelets.tag.jsf.core.ValueChangeListenerImpl | Line |
| Auto-generated constructor stub | 30 |
| Auto-generated method stub | 35 |
| org.apache.myfaces.view.facelets.tag.jsf.core.ViewMetadataTestCase | Line |
| Auto-generated method stub | 80 |
| org.apache.myfaces.view.facelets.tag.jsf.html._HtmlOutputScript | Line |
| DOCUMENT ME! <p> This tag is backed using a javax.faces.component.UIOutput component instance. In other words, instances of this component class are created when it is resolved a Resource annotation, so there is no concrete class or specific tag handler for it, but there exists a concrete renderer for it. </p> | 27 |
| org.apache.myfaces.view.facelets.tag.jsf.html._HtmlOutputStylesheet | Line |
| DOCUMENT ME! This class is just for documentation purposes <p> This tag is backed using a javax.faces.component.UIOutput component instance. In other words, instances of this component class are created when it is resolved a Resource annotation, so there is no concrete class or specific tag handler for it, but there exists a concrete renderer for it. </p> | 27 |
| org.apache.myfaces.view.facelets.tag.jstl.core.MappedValueExpression | Line |
| Auto-generated method stub | 180 |
| Auto-generated method stub | 191 |
| org.apache.myfaces.view.facelets.tag.ui.CompositionHandler | Line |
| REFACTOR - This class could easily use a common parent with DecoratorHandler | 44 |
| org.apache.myfaces.view.facelets.tag.ui.DecorateHandler | Line |
| REFACTOR - This class could easily use a common parent with CompositionHandler | 56 |
| org.apache.myfaces.view.facelets.tag.ui.UIDebug | Line |
| Auto-generated method stub | 222 |
| org.apache.myfaces.view.jsp.JspViewDeclarationLanguageStrategy | Line |
| IMPLEMENT HERE | 38 |
| org.apache.myfaces.webapp.AbstractFacesInitializer | Line |
| is it possible to make a real cleanup? | 350 |
| org.apache.myfaces.webapp.Jsp21FacesInitializer | Line |
| this Class.forName will be removed when Tomcat fixes a bug also, we should then be able to remove jasper.jar from the deployment | 84 |
| org.apache.myfaces.webapp.Jsp21FacesInitializerTest | Line |
| adapt this test case for MyFaces 2.0, because currently it checks nothing! | 60 |
| add myfaces specific tests | 82 |
| org.apache.myfaces.webapp.MyFacesServlet | Line |
| who uses this method? | 53 |
| org.apache.myfaces.webapp.StartupServletContextListener | Line |
| who uses this method? | 186 |