PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/application/ApplicationImpl.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'PROJECT_STAGE_PARAM_NAME'. | 149 |
| Avoid empty catch blocks | 804 - 807 |
| Avoid empty catch blocks | 808 - 817 |
| These nested if statements could be combined | 1799 - 1802 |
| These nested if statements could be combined | 2196 - 2199 |
| These nested if statements could be combined | 2345 - 2348 |
| These nested if statements could be combined | 2575 - 2578 |
org/apache/myfaces/application/NavigationHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 475 - 481 |
| These nested if statements could be combined | 659 - 679 |
| These nested if statements could be combined | 688 - 697 |
| Avoid unused method parameters such as 'facesContext'. | 781 - 837 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 860 |
org/apache/myfaces/application/ResourceHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 530 - 533 |
org/apache/myfaces/application/jsp/JspStateManagerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 848 - 855 |
| Avoid empty while statements | 1128 - 1130 |
org/apache/myfaces/application/jsp/JspViewHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'renderKit'. | 480 - 486 |
| Avoid unused method parameters such as 'externalContext'. | 480 - 486 |
org/apache/myfaces/application/viewstate/RandomKeyFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 101 - 105 |
org/apache/myfaces/application/viewstate/SecureRandomKeyFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 123 - 127 |
org/apache/myfaces/application/viewstate/SerializedViewCollection.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 76 - 91 |
| Avoid empty while statements | 96 - 98 |
| Avoid empty while statements | 121 - 123 |
org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 288 - 294 |
| These nested if statements could be combined | 321 - 330 |
org/apache/myfaces/application/viewstate/SessionIdGenerator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 277 - 281 |
org/apache/myfaces/component/visit/PartialVisitContext.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 310 - 312 |
org/apache/myfaces/config/ConfigFilesXmlValidationUtils.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 167 - 171 |
| Avoid empty catch blocks | 278 - 281 |
| Avoid empty catch blocks | 287 - 290 |
| Avoid empty catch blocks | 301 - 303 |
| Avoid empty catch blocks | 452 - 455 |
| Avoid empty catch blocks | 460 - 463 |
| Avoid empty catch blocks | 474 - 476 |
org/apache/myfaces/config/DefaultFacesConfigurationMerger.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 124 - 129 |
| These nested if statements could be combined | 186 - 192 |
| These nested if statements could be combined | 355 - 359 |
org/apache/myfaces/config/annotation/AnnotationConfigurator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 417 - 421 |
| These nested if statements could be combined | 449 - 454 |
org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'STANDARD_FACES_CONFIG_RESOURCE'. | 95 |
| Avoid unused method parameters such as 'context'. | 440 - 528 |
| Avoid empty catch blocks | 497 - 500 |
| Avoid empty catch blocks | 512 - 515 |
| Avoid empty catch blocks | 516 - 519 |
| Avoid empty catch blocks | 635 - 638 |
| Avoid empty catch blocks | 654 - 657 |
| Avoid empty catch blocks | 658 - 661 |
org/apache/myfaces/config/annotation/DefaultLifecycleProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 218 - 221 |
| Avoid empty catch blocks | 222 - 225 |
org/apache/myfaces/config/annotation/Tomcat7AnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'externalContext'. | 46 - 49 |
| Avoid empty catch blocks | 111 - 114 |
org/apache/myfaces/config/annotation/TomcatAnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 79 - 82 |
org/apache/myfaces/config/annotation/_ClassByteCodeAnnotationFilter.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'minorVersion'. | 107 |
org/apache/myfaces/config/util/Vertex.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_seen'. | 41 |
org/apache/myfaces/context/FacesContextFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 89 - 93 |
org/apache/myfaces/context/PartialResponseWriterImpl.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'elem'. | 194 |
| Overriding method merely calls super | 351 - 354 |
org/apache/myfaces/el/unified/resolver/CompositeComponentELResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 105 - 115 |
| These nested if statements could be combined | 120 - 124 |
org/apache/myfaces/el/unified/resolver/ManagedBeanResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 192 - 195 |
| These nested if statements could be combined | 212 - 215 |
org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 567 - 570 |
org/apache/myfaces/renderkit/ErrorPageWriter.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 289 - 292 |
| These nested if statements could be combined | 831 - 838 |
| Avoid empty catch blocks | 1005 - 1008 |
| These nested if statements could be combined | 1198 - 1207 |
| Avoid empty catch blocks | 1332 - 1335 |
| Avoid empty catch blocks | 1352 - 1355 |
org/apache/myfaces/renderkit/RenderKitFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 67 - 70 |
org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 297 - 323 |
org/apache/myfaces/renderkit/html/HtmlCompositeFacetRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 39 |
org/apache/myfaces/renderkit/html/HtmlRenderKitImpl.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'checkNull(Object,String)'. | 359 |
org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 160 - 162 |
org/apache/myfaces/resource/TempDirFileCacheResourceLoader.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 213 - 216 |
| Avoid empty catch blocks | 305 - 308 |
org/apache/myfaces/shared_impl/webapp/webxml/FilterMapping.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 41 - 44 |
org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 263 - 265 |
| Avoid empty if statements | 345 - 347 |
| Avoid empty if statements | 388 - 390 |
org/apache/myfaces/spi/impl/DefaultAnnotationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 96 - 99 |
| Avoid empty catch blocks | 100 - 103 |
org/apache/myfaces/spi/impl/DefaultFaceletConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 82 - 85 |
| Avoid empty catch blocks | 86 - 89 |
org/apache/myfaces/spi/impl/DefaultFacesConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 81 - 84 |
| Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationMergerFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 81 - 84 |
| Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 90 - 93 |
| Avoid empty catch blocks | 94 - 97 |
org/apache/myfaces/spi/impl/DefaultServiceProviderFinder.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 141 - 144 |
org/apache/myfaces/spi/impl/DefaultWebConfigProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 85 - 88 |
| Avoid empty catch blocks | 89 - 92 |
org/apache/myfaces/taglib/core/AttributeTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 123 - 133 |
org/apache/myfaces/taglib/core/DelegateValueChangeListener.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 111 - 115 |
| Avoid empty catch blocks | 139 - 143 |
org/apache/myfaces/taglib/core/GenericMinMaxValidatorTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 84 - 87 |
org/apache/myfaces/taglib/core/ValidateRequiredTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 90 - 93 |
org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 50 - 54 |
org/apache/myfaces/view/ViewDeclarationLanguageFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 167 - 172 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementHelper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 214 - 221 |
| Avoid empty while statements | 478 - 480 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'CHECK_ID_PRODUCTION_MODE_FALSE'. | 162 |
| Avoid unused local variables such as 'viewParameters'. | 245 |
| Avoid unused local variables such as 'externalContext'. | 634 |
| These nested if statements could be combined | 745 - 757 |
| Avoid unused private methods such as 'checkIds(FacesContext,UIComponent,Set)'. | 1182 |
| Avoid unused local variables such as 'children'. | 1185 |
org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 562 - 565 |
| Avoid unused private methods such as '_publishPreRemoveFromViewEvent(FacesContext,UIComponent)'. | 626 |
| These nested if statements could be combined | 1137 - 1142 |
| Avoid unused method parameters such as 'attributeName'. | 1412 - 1440 |
| Avoid unused method parameters such as 'targetAttributeName'. | 1412 - 1440 |
| Avoid unused method parameters such as 'mctx'. | 1412 - 1440 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1412 - 1440 |
| Avoid unused method parameters such as 'attributeName'. | 1442 - 1490 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1442 - 1490 |
| Avoid unused method parameters such as 'attributeName'. | 1492 - 1534 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1492 - 1534 |
| Avoid unused method parameters such as 'attributeName'. | 1536 - 1585 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1536 - 1585 |
| Avoid unused method parameters such as 'elContext'. | 1587 - 1654 |
| Avoid unused local variables such as 'request'. | 2391 |
org/apache/myfaces/view/facelets/FaceletViewHandler.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'developmentMode'. | 130 |
org/apache/myfaces/view/facelets/compiler/Compiler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 194 - 197 |
org/apache/myfaces/view/facelets/compiler/FaceletsProcessingInstructions.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 72 - 94 |
| Unnecessary final modifier in final class | 96 - 123 |
org/apache/myfaces/view/facelets/compiler/NamespaceManager.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 95 - 108 |
org/apache/myfaces/view/facelets/compiler/SAXCompiler.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 143 - 146 |
| Overriding method merely calls super | 349 - 352 |
| Overriding method merely calls super | 572 - 575 |
| These nested if statements could be combined | 590 - 596 |
| These nested if statements could be combined | 704 - 710 |
| Unnecessary final modifier in final class | 894 - 923 |
| Unnecessary final modifier in final class | 925 - 951 |
| These nested if statements could be combined | 939 - 942 |
| Unnecessary final modifier in final class | 953 - 967 |
org/apache/myfaces/view/facelets/compiler/TagLibraryConfig.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 461 - 463 |
| Avoid empty if statements | 506 - 508 |
| Avoid empty if statements | 510 - 512 |
| Avoid empty if statements | 514 - 516 |
| Unnecessary final modifier in final class | 865 - 891 |
org/apache/myfaces/view/facelets/compiler/TextUnit.java
| Violation | Line |
|---|---|
| Do not use if statements that are always true or always false | 389 |
| Unnecessary final modifier in final class | 486 - 510 |
| Unnecessary final modifier in final class | 512 - 598 |
| These nested if statements could be combined | 529 - 532 |
| Unnecessary final modifier in final class | 609 - 760 |
| These nested if statements could be combined | 662 - 665 |
| Avoid unused private methods such as 'getFirstTextCharLocationIgnoringSpacesTabsAndCarriageReturn(String)'. | 762 |
org/apache/myfaces/view/facelets/compiler/_ComponentUtils.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'separatorChar'. | 239 - 261 |
| Avoid unused private methods such as 'dynamicIdIsEqual(String,String)'. | 263 |
org/apache/myfaces/view/facelets/el/ContextAwareTagMethodExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 125 - 128 |
org/apache/myfaces/view/facelets/el/ContextAwareTagValueExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 120 - 123 |
org/apache/myfaces/view/facelets/el/DefaultVariableMapper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 85 - 93 |
| These nested if statements could be combined | 118 - 121 |
org/apache/myfaces/view/facelets/el/ELText.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 520 - 543 |
| These nested if statements could be combined | 522 - 542 |
| These nested if statements could be combined | 605 - 628 |
| These nested if statements could be combined | 607 - 627 |
| Avoid unused local variables such as 'vlen'. | 664 |
| These nested if statements could be combined | 680 - 688 |
| These nested if statements could be combined | 682 - 687 |
org/apache/myfaces/view/facelets/impl/DefaultFacelet.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 231 - 291 |
| Unnecessary final modifier in final class | 293 - 317 |
org/apache/myfaces/view/facelets/impl/FaceletCacheImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 183 - 186 |
org/apache/myfaces/view/facelets/impl/FaceletCompositionContextImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 844 - 855 |
org/apache/myfaces/view/facelets/tag/MetaRulesetImpl.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 238 - 267 |
org/apache/myfaces/view/facelets/tag/composite/AttributeHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 314 - 403 |
| Avoid empty catch blocks | 340 - 343 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentDefinitionTagHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 125 - 129 |
| Avoid unused method parameters such as 'ctx'. | 266 - 272 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentResourceTagHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 535 - 562 |
org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 193 - 197 |
| These nested if statements could be combined | 206 - 224 |
| These nested if statements could be combined | 240 - 270 |
org/apache/myfaces/view/facelets/tag/composite/FacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 288 - 324 |
org/apache/myfaces/view/facelets/tag/composite/InsertFacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'parentCompositeComponent'. | 154 |
| Avoid unused method parameters such as 'parent'. | 162 - 185 |
org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 678 - 748 |
| These nested if statements could be combined | 722 - 726 |
| These nested if statements could be combined | 734 - 743 |
| Avoid unused method parameters such as 'ctx'. | 750 - 797 |
| Avoid unused method parameters such as 'facesContext'. | 813 - 851 |
| Avoid unused method parameters such as 'mctx'. | 813 - 851 |
| These nested if statements could be combined | 836 - 846 |
org/apache/myfaces/view/facelets/tag/jsf/core/SelectItemsHandler.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getNoSelectionValue()'. | 53 |
org/apache/myfaces/view/facelets/tag/jstl/core/ChooseHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 107 - 145 |
| These nested if statements could be combined | 159 - 165 |
| These nested if statements could be combined | 179 - 185 |
org/apache/myfaces/view/facelets/tag/jstl/core/ForEachHandler.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 322 - 329 |
| Unnecessary final modifier in final class | 331 - 338 |
| Unnecessary final modifier in final class | 340 - 347 |
| Unnecessary final modifier in final class | 349 - 356 |
| Unnecessary final modifier in final class | 358 - 365 |
| Unnecessary final modifier in final class | 367 - 382 |
| Unnecessary final modifier in final class | 384 - 391 |
| Unnecessary final modifier in final class | 393 - 400 |
| Unnecessary final modifier in final class | 402 - 425 |
org/apache/myfaces/view/facelets/tag/jstl/core/IfHandler.java
| Violation | Line |
|---|---|
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 110 |
org/apache/myfaces/view/facelets/tag/jstl/core/SetHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 142 - 145 |
org/apache/myfaces/view/facelets/tag/jstl/fn/JstlFunction.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 109 - 111 |
org/apache/myfaces/view/facelets/tag/ui/ParamHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 97 - 101 |
org/apache/myfaces/view/facelets/tag/ui/RepeatHandler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 90 - 93 |
org/apache/myfaces/view/facelets/util/Classpath.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 218 - 220 |
| Avoid empty catch blocks | 351 - 354 |
| Avoid empty catch blocks | 381 - 385 |
org/apache/myfaces/view/facelets/util/FastWriter.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 58 - 66 |
org/apache/myfaces/view/facelets/util/ParameterCheck.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 34 |
org/apache/myfaces/view/facelets/util/Path.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 69 |
| Unnecessary final modifier in final class | 71 - 97 |
| Unnecessary final modifier in final class | 99 - 107 |
org/apache/myfaces/view/facelets/util/Resource.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 78 - 81 |
| Avoid empty catch blocks | 107 - 111 |