PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/application/ApplicationImpl.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'PROJECT_STAGE_PARAM_NAME'. | 148 |
| Avoid empty catch blocks | 795 - 798 |
| Avoid empty catch blocks | 799 - 808 |
| These nested if statements could be combined | 1790 - 1793 |
| These nested if statements could be combined | 2118 - 2121 |
| These nested if statements could be combined | 2267 - 2270 |
| These nested if statements could be combined | 2492 - 2495 |
org/apache/myfaces/application/NavigationHandlerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 184 - 190 |
| Avoid empty catch blocks | 464 - 470 |
| These nested if statements could be combined | 640 - 660 |
| These nested if statements could be combined | 669 - 678 |
| Avoid unused method parameters such as 'facesContext'. | 762 - 818 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 841 |
org/apache/myfaces/application/ResourceHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 524 - 527 |
org/apache/myfaces/application/StateManagerImpl.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'externalContext'. | 224 |
org/apache/myfaces/application/jsp/JspStateManagerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 848 - 855 |
| Avoid empty while statements | 1128 - 1130 |
org/apache/myfaces/application/jsp/JspViewHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'renderKit'. | 466 - 472 |
| Avoid unused method parameters such as 'externalContext'. | 466 - 472 |
org/apache/myfaces/component/visit/PartialVisitContext.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 310 - 312 |
org/apache/myfaces/config/ConfigFilesXmlValidationUtils.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 284 - 287 |
| Avoid empty catch blocks | 293 - 296 |
| Avoid empty catch blocks | 307 - 309 |
| Avoid empty catch blocks | 458 - 461 |
| Avoid empty catch blocks | 466 - 469 |
| Avoid empty catch blocks | 480 - 482 |
org/apache/myfaces/config/DefaultFacesConfigurationMerger.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 124 - 129 |
| These nested if statements could be combined | 186 - 192 |
| These nested if statements could be combined | 355 - 359 |
org/apache/myfaces/config/annotation/AnnotationConfigurator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 416 - 420 |
| These nested if statements could be combined | 448 - 453 |
org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'context'. | 347 - 435 |
| Avoid empty catch blocks | 404 - 407 |
| Avoid empty catch blocks | 419 - 422 |
| Avoid empty catch blocks | 423 - 426 |
| Avoid empty catch blocks | 542 - 545 |
| Avoid empty catch blocks | 561 - 564 |
| Avoid empty catch blocks | 565 - 568 |
org/apache/myfaces/config/annotation/DefaultLifecycleProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 218 - 221 |
| Avoid empty catch blocks | 222 - 225 |
org/apache/myfaces/config/annotation/Tomcat7AnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'externalContext'. | 46 - 49 |
| Avoid empty catch blocks | 111 - 114 |
org/apache/myfaces/config/annotation/TomcatAnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 79 - 82 |
org/apache/myfaces/config/annotation/_ClassByteCodeAnnotationFilter.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'minorVersion'. | 102 |
org/apache/myfaces/config/util/Vertex.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_seen'. | 41 |
org/apache/myfaces/context/FacesContextFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 89 - 93 |
org/apache/myfaces/context/PartialResponseWriterImpl.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'elem'. | 194 |
| Overriding method merely calls super | 351 - 354 |
org/apache/myfaces/el/unified/resolver/CompositeComponentELResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 104 - 114 |
| These nested if statements could be combined | 119 - 123 |
org/apache/myfaces/el/unified/resolver/ManagedBeanResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 192 - 195 |
| These nested if statements could be combined | 212 - 215 |
org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 510 - 513 |
org/apache/myfaces/renderkit/ErrorPageWriter.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 289 - 292 |
| These nested if statements could be combined | 831 - 838 |
| Avoid empty catch blocks | 1003 - 1006 |
| These nested if statements could be combined | 1195 - 1204 |
| Avoid empty catch blocks | 1299 - 1302 |
| Avoid empty catch blocks | 1319 - 1322 |
org/apache/myfaces/renderkit/RenderKitFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 67 - 70 |
org/apache/myfaces/renderkit/ServerSideStateCacheImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 230 - 236 |
| These nested if statements could be combined | 284 - 291 |
| These nested if statements could be combined | 590 - 593 |
| Avoid empty while statements | 597 - 599 |
| Avoid empty while statements | 621 - 623 |
org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 297 - 323 |
org/apache/myfaces/renderkit/html/HtmlCompositeFacetRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 39 |
org/apache/myfaces/renderkit/html/HtmlRenderKitImpl.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'checkNull(Object,String)'. | 353 |
org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 149 - 151 |
org/apache/myfaces/shared_impl/webapp/webxml/FilterMapping.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 41 - 44 |
org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 263 - 265 |
| Avoid empty if statements | 345 - 347 |
| Avoid empty if statements | 388 - 390 |
org/apache/myfaces/spi/impl/DefaultAnnotationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 96 - 99 |
| Avoid empty catch blocks | 100 - 103 |
org/apache/myfaces/spi/impl/DefaultFaceletConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 82 - 85 |
| Avoid empty catch blocks | 86 - 89 |
org/apache/myfaces/spi/impl/DefaultFacesConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 81 - 84 |
| Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationMergerFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 81 - 84 |
| Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 90 - 93 |
| Avoid empty catch blocks | 94 - 97 |
org/apache/myfaces/spi/impl/DefaultServiceProviderFinder.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 141 - 144 |
org/apache/myfaces/spi/impl/DefaultWebConfigProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 85 - 88 |
| Avoid empty catch blocks | 89 - 92 |
org/apache/myfaces/taglib/core/AttributeTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 123 - 133 |
org/apache/myfaces/taglib/core/DelegateValueChangeListener.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 111 - 115 |
| Avoid empty catch blocks | 139 - 143 |
org/apache/myfaces/taglib/core/GenericMinMaxValidatorTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 84 - 87 |
org/apache/myfaces/taglib/core/ValidateRequiredTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 90 - 93 |
org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 50 - 54 |
org/apache/myfaces/view/ViewDeclarationLanguageFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 162 - 167 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementHelper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 214 - 221 |
| Avoid empty while statements | 478 - 480 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'CHECK_ID_PRODUCTION_MODE_FALSE'. | 161 |
| Avoid unused local variables such as 'viewParameters'. | 235 |
| These nested if statements could be combined | 360 - 379 |
| Avoid unused local variables such as 'externalContext'. | 511 |
| These nested if statements could be combined | 618 - 630 |
| Avoid unused private methods such as 'checkIds(FacesContext,UIComponent,Set)'. | 1039 |
| Avoid unused local variables such as 'children'. | 1042 |
org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 554 - 557 |
| Avoid unused private methods such as '_publishPreRemoveFromViewEvent(FacesContext,UIComponent)'. | 618 |
| These nested if statements could be combined | 1129 - 1134 |
| Avoid unused method parameters such as 'attributeName'. | 1404 - 1432 |
| Avoid unused method parameters such as 'targetAttributeName'. | 1404 - 1432 |
| Avoid unused method parameters such as 'mctx'. | 1404 - 1432 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1404 - 1432 |
| Avoid unused method parameters such as 'attributeName'. | 1434 - 1482 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1434 - 1482 |
| Avoid unused method parameters such as 'attributeName'. | 1484 - 1526 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1484 - 1526 |
| Avoid unused method parameters such as 'attributeName'. | 1528 - 1577 |
| Avoid unused method parameters such as 'topLevelComponent'. | 1528 - 1577 |
| Avoid unused method parameters such as 'elContext'. | 1579 - 1646 |
| Avoid unused local variables such as 'request'. | 2382 |
org/apache/myfaces/view/facelets/FaceletViewHandler.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'developmentMode'. | 130 |
org/apache/myfaces/view/facelets/compiler/Compiler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 194 - 197 |
org/apache/myfaces/view/facelets/compiler/FaceletsProcessingInstructions.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 58 - 80 |
org/apache/myfaces/view/facelets/compiler/NamespaceManager.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 95 - 108 |
org/apache/myfaces/view/facelets/compiler/SAXCompiler.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 143 - 146 |
| Overriding method merely calls super | 349 - 352 |
| Overriding method merely calls super | 558 - 561 |
| These nested if statements could be combined | 576 - 582 |
| These nested if statements could be combined | 690 - 696 |
| Unnecessary final modifier in final class | 878 - 907 |
| Unnecessary final modifier in final class | 909 - 935 |
| These nested if statements could be combined | 923 - 926 |
| Unnecessary final modifier in final class | 937 - 951 |
org/apache/myfaces/view/facelets/compiler/TagLibraryConfig.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 462 - 464 |
| Avoid empty if statements | 507 - 509 |
| Avoid empty if statements | 511 - 513 |
| Avoid empty if statements | 515 - 517 |
| Unnecessary final modifier in final class | 858 - 884 |
org/apache/myfaces/view/facelets/compiler/TextUnit.java
| Violation | Line |
|---|---|
| Do not use if statements that are always true or always false | 296 |
| Unnecessary final modifier in final class | 386 - 410 |
org/apache/myfaces/view/facelets/compiler/_ComponentUtils.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'separatorChar'. | 239 - 261 |
| Avoid unused private methods such as 'dynamicIdIsEqual(String,String)'. | 263 |
org/apache/myfaces/view/facelets/el/ContextAwareTagMethodExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 125 - 128 |
org/apache/myfaces/view/facelets/el/ContextAwareTagValueExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 120 - 123 |
org/apache/myfaces/view/facelets/el/DefaultVariableMapper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 85 - 93 |
| These nested if statements could be combined | 98 - 106 |
org/apache/myfaces/view/facelets/el/ELText.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 492 - 515 |
| These nested if statements could be combined | 494 - 514 |
org/apache/myfaces/view/facelets/impl/DefaultFacelet.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 207 - 267 |
| Unnecessary final modifier in final class | 269 - 293 |
org/apache/myfaces/view/facelets/tag/MetaRulesetImpl.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 238 - 267 |
org/apache/myfaces/view/facelets/tag/composite/AttributeHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 314 - 403 |
| Avoid empty catch blocks | 340 - 343 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentDefinitionTagHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 125 - 129 |
| Avoid unused method parameters such as 'ctx'. | 243 - 249 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentResourceTagHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 533 - 560 |
org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 193 - 197 |
| These nested if statements could be combined | 206 - 224 |
| These nested if statements could be combined | 240 - 270 |
org/apache/myfaces/view/facelets/tag/composite/FacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 288 - 324 |
org/apache/myfaces/view/facelets/tag/composite/InsertFacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'parentCompositeComponent'. | 154 |
| Avoid unused method parameters such as 'parent'. | 162 - 185 |
org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 638 - 708 |
| These nested if statements could be combined | 682 - 686 |
| These nested if statements could be combined | 694 - 703 |
| Avoid unused method parameters such as 'ctx'. | 710 - 757 |
| Avoid unused method parameters such as 'facesContext'. | 773 - 811 |
| Avoid unused method parameters such as 'mctx'. | 773 - 811 |
| These nested if statements could be combined | 796 - 806 |
org/apache/myfaces/view/facelets/tag/jsf/core/SelectItemsHandler.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getNoSelectionValue()'. | 53 |
org/apache/myfaces/view/facelets/tag/jstl/core/ChooseHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 107 - 145 |
| These nested if statements could be combined | 159 - 165 |
| These nested if statements could be combined | 179 - 185 |
org/apache/myfaces/view/facelets/tag/jstl/core/ForEachHandler.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 293 - 300 |
| Unnecessary final modifier in final class | 302 - 309 |
| Unnecessary final modifier in final class | 311 - 318 |
| Unnecessary final modifier in final class | 320 - 327 |
| Unnecessary final modifier in final class | 329 - 336 |
| Unnecessary final modifier in final class | 338 - 353 |
| Unnecessary final modifier in final class | 355 - 362 |
| Unnecessary final modifier in final class | 364 - 371 |
| Unnecessary final modifier in final class | 373 - 396 |
org/apache/myfaces/view/facelets/tag/jstl/core/IfHandler.java
| Violation | Line |
|---|---|
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 110 |
org/apache/myfaces/view/facelets/tag/jstl/core/SetHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 142 - 145 |
org/apache/myfaces/view/facelets/tag/jstl/fn/JstlFunction.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 109 - 111 |
org/apache/myfaces/view/facelets/tag/ui/ParamHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 97 - 101 |
org/apache/myfaces/view/facelets/tag/ui/RepeatHandler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 90 - 93 |
org/apache/myfaces/view/facelets/util/Classpath.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 195 - 197 |
| Avoid empty catch blocks | 309 - 312 |
| Avoid empty catch blocks | 339 - 343 |
org/apache/myfaces/view/facelets/util/FastWriter.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 58 - 66 |
org/apache/myfaces/view/facelets/util/ParameterCheck.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 34 |
org/apache/myfaces/view/facelets/util/Path.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 69 |
| Unnecessary final modifier in final class | 71 - 97 |
| Unnecessary final modifier in final class | 99 - 107 |
org/apache/myfaces/view/facelets/util/Resource.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 78 - 81 |
| Avoid empty catch blocks | 107 - 111 |