FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
javax.faces.FactoryFinder
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in javax.faces.FactoryFinder.getInjectionProvider() | STYLE | REC_CATCH_EXCEPTION | 398 | Medium |
Exception is caught when Exception is not thrown in javax.faces.FactoryFinder.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | 154 | Low |
Exception is caught when Exception is not thrown in javax.faces.FactoryFinder.addBeanEntry(Object, Object, List) | STYLE | REC_CATCH_EXCEPTION | 482 | Low |
Exception is caught when Exception is not thrown in javax.faces.FactoryFinder.getClassLoader() | STYLE | REC_CATCH_EXCEPTION | 807 | Low |
Exception is caught when Exception is not thrown in javax.faces.FactoryFinder.injectAndPostConstruct(Object, Object, List) | STYLE | REC_CATCH_EXCEPTION | 418 | Low |
javax.faces._FactoryFinderProviderFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in javax.faces._FactoryFinderProviderFactory.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | 128 | Medium |
javax.faces.application.FacesMessage$Severity
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.application.FacesMessage$Severity defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 286 | Medium |
javax.faces.application.NavigationCase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.application.NavigationCase.getCondition(FacesContext) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 127 | Medium |
javax.faces.application.StateManager$SerializedView
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.application.StateManager$SerializedView be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 331-349 | Medium |
javax.faces.component.UICommand
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method call in javax.faces.component.UICommand.queueEvent(FacesEvent) passes null for nonnull parameter of UIComponentBase.queueEvent(FacesEvent) | CORRECTNESS | NP_NULL_PARAM_DEREF | 143 | Medium |
javax.faces.component.UIComponent$BundleMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of java.util.ResourceBundle.getObject(String), which is known to be non-null in javax.faces.component.UIComponent$BundleMap.containsKey(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1411 | Low |
javax.faces.component.UIComponentBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Questionable cast from java.util.Collection to java.util.ArrayList in javax.faces.component.UIComponentBase.saveAttachedState(FacesContext, Object) | STYLE | BC_BAD_CAST_TO_CONCRETE_COLLECTION | 1808 | High |
javax.faces.component.UIData$EditableValueHolderState
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.UIData$EditableValueHolderState is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 283-296 | Low |
javax.faces.component.UIInput
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 548 | Low |
Nullcheck of UIInput._validatorList at line 904 of value previously dereferenced in javax.faces.component.UIInput.getValidators() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 876 | High |
javax.faces.component.UISelectMany
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 452 | Low |
javax.faces.component.UIViewAction
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of defaultActionListener, which is known to be non-null in javax.faces.component.UIViewAction.broadcast(FacesEvent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 119 | Low |
javax.faces.component.UIViewParameter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method javax.faces.component.UIViewParameter.releaseRenderer() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 270-292 | Low |
javax.faces.component.UIViewRoot
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in javax.faces.component.UIViewRoot.getLocale(), since all java.util.Locale are instances of java.util.Locale | STYLE | BC_VACUOUS_INSTANCEOF | 752 | Medium |
Exception is caught when Exception is not thrown in javax.faces.component.UIViewRoot._broadcastAll(FacesContext, List, Collection) | STYLE | REC_CATCH_EXCEPTION | 1186 | Low |
javax.faces.component._AttachedCollectionStateWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._AttachedCollectionStateWrapper defines non-transient non-serializable instance field _wrappedStateList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._AttachedListStateWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._AttachedListStateWrapper defines non-transient non-serializable instance field _wrappedStateList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ComponentAttributesMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentAttributesMap defines non-transient non-serializable instance field _ccBeanInfo | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentAttributesMap defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.component._ComponentChildrenList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentChildrenList defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentChildrenList defines non-transient non-serializable instance field _list | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ComponentFacetMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _entrySet | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _keySet | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _map | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _valueCollection | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ArrayMap stored into non-transient field _ComponentFacetMap._map | BAD_PRACTICE | SE_BAD_FIELD_STORE | 33 | High |
javax.faces.component._ComponentFacetMap$ComponentFacetEntrySet stored into non-transient field _ComponentFacetMap._entrySet | BAD_PRACTICE | SE_BAD_FIELD_STORE | 98 | Medium |
javax.faces.component._ComponentFacetMap$ComponentFacetKeySet stored into non-transient field _ComponentFacetMap._keySet | BAD_PRACTICE | SE_BAD_FIELD_STORE | 107 | Medium |
javax.faces.component._ComponentFacetMap$ComponentFacetValueCollection stored into non-transient field _ComponentFacetMap._valueCollection | BAD_PRACTICE | SE_BAD_FIELD_STORE | 81 | Medium |
javax.faces.component._DeltaStateHelper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in javax.faces.component._DeltaStateHelper.copyMap(FacesContext, Map, Map), since all java.io.Serializable are instances of java.io.Serializable | STYLE | BC_VACUOUS_INSTANCEOF | 292 | Medium |
javax.faces.component._DeltaStateHelper$InternalDeltaListMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._DeltaStateHelper$InternalDeltaListMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 963-979 | Low |
javax.faces.component._DeltaStateHelper$InternalList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._DeltaStateHelper$InternalList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 986-1037 | Low |
javax.faces.component._DeltaStateHelper$InternalMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._DeltaStateHelper$InternalMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 892-951 | Low |
javax.faces.component._ExternalSpecifications
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Incorrect lazy initialization and update of static field javax.faces.component._ExternalSpecifications.beanValidationAvailable in javax.faces.component._ExternalSpecifications.isBeanValidationAvailable() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 51-57 | Medium |
Incorrect lazy initialization and update of static field javax.faces.component._ExternalSpecifications.cdiAvailable in javax.faces.component._ExternalSpecifications.isCDIAvailable(ExternalContext) | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 127-131 | Medium |
javax.faces.component._LabeledFacesMessage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._LabeledFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34-67 | Low |
javax.faces.component._MethodBindingToMethodExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._MethodBindingToMethodExpression defines non-transient non-serializable instance field methodBinding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._MethodBindingToMethodExpression is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 38-254 | Medium |
javax.faces.component._PassThroughAttributesMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._PassThroughAttributesMap defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.component._PrimitiveArrayIterator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._PrimitiveArrayIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 48 | Medium |
javax.faces.component._SelectItemsIterator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of itemValue in javax.faces.component._SelectItemsIterator.next() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 277 | Medium |
javax.faces.component._SharedRendererUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in javax.faces.component._SharedRendererUtils.getConvertedUISelectManyValue(FacesContext, UISelectMany, String[], boolean) | STYLE | REC_CATCH_EXCEPTION | 244 | Low |
javax.faces.component._ValueBindingToValueExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ValueBindingToValueExpression defines non-transient non-serializable instance field _valueBinding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.component._ViewAttributeMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ViewAttributeMap defines non-transient non-serializable instance field _root | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class javax.faces.component._ViewAttributeMap defines non-transient non-serializable instance field _delegate | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalDeltaListMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalDeltaListMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 633-649 | Low |
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 656-707 | Low |
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 562-621 | Low |
javax.faces.component.behavior._AttachedListStateWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component.behavior._AttachedListStateWrapper defines non-transient non-serializable instance field _wrappedStateList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component.behavior._DeltaStateHelper$InternalDeltaListMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._DeltaStateHelper$InternalDeltaListMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 745-761 | Low |
javax.faces.component.behavior._DeltaStateHelper$InternalList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._DeltaStateHelper$InternalList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 768-819 | Low |
javax.faces.component.behavior._DeltaStateHelper$InternalMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._DeltaStateHelper$InternalMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 674-733 | Low |
javax.faces.component.visit.VisitContext$AllIdsCollection
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.visit.VisitContext$AllIdsCollection is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 61-125 | Low |
javax.faces.context.PartialResponseWriter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method javax.faces.context.PartialResponseWriter.startExtension(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 210 | Medium |
Method javax.faces.context.PartialResponseWriter.updateAttributes(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 254 | Medium |
javax.faces.convert._LabeledFacesMessage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.convert._LabeledFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34-69 | Low |
javax.faces.event.ActionEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.ActionListener in javax.faces.event.ActionEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 48 | Low |
javax.faces.event.AjaxBehaviorEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.AjaxBehaviorListener in javax.faces.event.AjaxBehaviorEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 54 | Low |
javax.faces.event.AjaxBehaviorEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-55 | Low |
javax.faces.event.ExceptionQueuedEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.ExceptionQueuedEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-33 | Low |
javax.faces.event.PhaseEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.event.PhaseEvent defines non-transient non-serializable instance field _facesContext | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.event.PhaseEvent defines non-transient non-serializable instance field _phaseId | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.event.PhaseId
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PhaseId defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 76 | Medium |
javax.faces.event.PostAddToViewEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostAddToViewEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-42 | Low |
javax.faces.event.PostConstructApplicationEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostConstructApplicationEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-41 | Low |
javax.faces.event.PostConstructCustomScopeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostConstructCustomScopeEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32-40 | Low |
javax.faces.event.PostConstructViewMapEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostConstructViewMapEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-34 | Low |
javax.faces.event.PostKeepFlashValueEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostKeepFlashValueEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-33 | Low |
javax.faces.event.PostPutFlashValueEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostPutFlashValueEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-33 | Low |
javax.faces.event.PostRestoreStateEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostRestoreStateEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-39 | Low |
javax.faces.event.PostValidateEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostValidateEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-34 | Low |
javax.faces.event.PreClearFlashEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreClearFlashEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-29 | Low |
javax.faces.event.PreDestroyApplicationEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreDestroyApplicationEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-41 | Low |
javax.faces.event.PreDestroyCustomScopeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreDestroyCustomScopeEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-38 | Low |
javax.faces.event.PreDestroyViewMapEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreDestroyViewMapEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-34 | Low |
javax.faces.event.PreRemoveFlashValueEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreRemoveFlashValueEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-33 | Low |
javax.faces.event.PreRemoveFromViewEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreRemoveFromViewEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-42 | Low |
javax.faces.event.PreRenderComponentEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreRenderComponentEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-34 | Low |
javax.faces.event.PreRenderViewEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreRenderViewEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-34 | Low |
javax.faces.event.PreValidateEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreValidateEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-34 | Low |
javax.faces.event.SystemEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.SystemEventListener in javax.faces.event.SystemEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 40 | Low |
javax.faces.event.ValueChangeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.ValueChangeListener in javax.faces.event.ValueChangeEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 65 | Low |
javax.faces.flow.builder.NavigationCaseBuilder$RedirectBuilder
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.flow.builder.NavigationCaseBuilder$RedirectBuilder be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 44 | Medium |
javax.faces.model.ArrayDataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.ArrayDataModel.getWrappedData() may expose internal representation by returning ArrayDataModel._data | MALICIOUS_CODE | EI_EXPOSE_REP | 79 | Medium |
javax.faces.model.ArrayDataModel.setWrappedData(Object) may expose internal representation by storing an externally mutable object into ArrayDataModel._data | MALICIOUS_CODE | EI_EXPOSE_REP2 | 119 | Medium |
javax.faces.model.DataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.DataModel.getDataModelListeners() may expose internal representation by returning DataModel._cachedListenersArray | MALICIOUS_CODE | EI_EXPOSE_REP | 83 | Medium |
javax.faces.model.ResultDataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.model.ResultDataModel.getRows() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 118 | Low |
javax.faces.model.ResultSetDataModel$WrapResultSetMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.ResultSetDataModel$WrapResultSetMap is serializable but also an inner class of a non-serializable class | BAD_PRACTICE | SE_BAD_FIELD_INNER_CLASS | 249-393 | Low |
javax.faces.model.SelectItemGroup
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.SelectItemGroup.getSelectItems() may expose internal representation by returning SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP | 59 | Medium |
new javax.faces.model.SelectItemGroup(String, String, boolean, SelectItem[]) may expose internal representation by storing an externally mutable object into SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP2 | 53 | Medium |
javax.faces.model.SelectItemGroup.setSelectItems(SelectItem[]) may expose internal representation by storing an externally mutable object into SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP2 | 68 | Medium |
javax.faces.validator.BeanValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.BeanValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 445 | Medium |
Redundant nullcheck of reference, which is known to be non-null in javax.faces.validator.BeanValidator.validate(FacesContext, UIComponent, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 154 | Low |
Redundant nullcheck of valueBaseClass, which is known to be non-null in javax.faces.validator.BeanValidator.validate(FacesContext, UIComponent, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 165 | Low |
Private method javax.faces.validator.BeanValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 452 | Low |
Private method javax.faces.validator.BeanValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 445 | Low |
javax.faces.validator.BeanValidator$1
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class javax.faces.validator.BeanValidator$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 337-340 | Low |
javax.faces.validator.DoubleRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new javax.faces.validator.DoubleRangeValidator(double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 69] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 69 | Low |
Method new javax.faces.validator.DoubleRangeValidator(double, double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 75] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 75 | Low |
Method javax.faces.validator.DoubleRangeValidator.setMaximum(double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 162] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 162 | Low |
Method javax.faces.validator.DoubleRangeValidator.setMinimum(double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 178] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 178 | Low |
javax.faces.validator.DoubleRangeValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 267 | Medium |
Private method javax.faces.validator.DoubleRangeValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 274 | Low |
Private method javax.faces.validator.DoubleRangeValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 267 | Low |
javax.faces.validator.LengthValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.LengthValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 244 | Medium |
Private method javax.faces.validator.LengthValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 251 | Low |
Private method javax.faces.validator.LengthValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 244 | Low |
javax.faces.validator.LongRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method javax.faces.validator.LongRangeValidator.setMinimum(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 179 | Medium |
javax.faces.validator.LongRangeValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 272 | Medium |
Private method javax.faces.validator.LongRangeValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 278 | Low |
Private method javax.faces.validator.LongRangeValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 272 | Low |
javax.faces.validator.MethodExpressionValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of cause, which is known to be non-null in javax.faces.validator.MethodExpressionValidator.validate(FacesContext, UIComponent, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 72 | Low |
javax.faces.validator.RegexValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.RegexValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 244 | Medium |
Private method javax.faces.validator.RegexValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 251 | Low |
Private method javax.faces.validator.RegexValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 244 | Low |
javax.faces.validator.RequiredValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.RequiredValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 94 | Medium |
Private method javax.faces.validator.RequiredValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 101 | Low |
Private method javax.faces.validator.RequiredValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 94 | Low |
javax.faces.validator._ExternalSpecifications
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Incorrect lazy initialization and update of static field javax.faces.validator._ExternalSpecifications.beanValidationAvailable in javax.faces.validator._ExternalSpecifications.isBeanValidationAvailable() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 52-58 | Medium |
javax.faces.validator._LabeledFacesMessage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator._LabeledFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34-69 | Low |
javax.faces.validator._ValueReferenceResolver
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
_ValueReferenceResolver.lastObject not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
javax.faces.view.facelets.CompositeFaceletHandler
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.view.facelets.CompositeFaceletHandler.getHandlers() may expose internal representation by returning CompositeFaceletHandler.children | MALICIOUS_CODE | EI_EXPOSE_REP | 52 | Medium |
new javax.faces.view.facelets.CompositeFaceletHandler(FaceletHandler[]) may expose internal representation by storing an externally mutable object into CompositeFaceletHandler.children | MALICIOUS_CODE | EI_EXPOSE_REP2 | 35 | Medium |
javax.faces.webapp.FacesServlet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.webapp.FacesServlet._facesContextFactory is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 246 | Low |
javax.faces.webapp.FacesServlet._lifecycle is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 195 | Low |
javax.faces.webapp.FacesServlet._servletConfig is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 102 | Low |
javax.faces.webapp.PreJsf2ExceptionHandlerFactory$PreJsf2ExceptionHandlerImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.SystemEvent to javax.faces.event.ExceptionQueuedEvent in javax.faces.webapp.PreJsf2ExceptionHandlerFactory$PreJsf2ExceptionHandlerImpl.processEvent(SystemEvent) | STYLE | BC_UNCONFIRMED_CAST | 280 | Low |