Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
7 0 0 218

Rules

Category Rule Violations Severity
coding AvoidInlineConditionals 3  Error
HiddenField 12  Error
MagicNumber 2  Error
design DesignForExtension 26  Error
FinalClass 1  Error
VisibilityModifier 4  Error
javadoc JavadocMethod 22  Error
JavadocPackage 1  Error
JavadocStyle 2  Error
JavadocType 2  Error
JavadocVariable 39  Error
misc FinalParameters 47  Error
naming ConstantName 2  Error
sizes LineLength 50  Error
whitespace ParenPad 4  Error
WhitespaceAfter 1  Error

Details

org/apache/streams/moreover/MoreoverClient.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 85). 39
 Error javadoc JavadocVariable Missing a Javadoc comment. 39
 Error naming ConstantName Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 39
 Error sizes LineLength Line is longer than 80 characters (found 120). 41
 Error javadoc JavadocVariable Missing a Javadoc comment. 41
 Error javadoc JavadocVariable Missing a Javadoc comment. 42
 Error javadoc JavadocVariable Missing a Javadoc comment. 43
 Error javadoc JavadocVariable Missing a Javadoc comment. 44
 Error javadoc JavadocVariable Missing a Javadoc comment. 46
 Error design VisibilityModifier Variable 'pullTime' must be private and have accessor methods. 46
 Error javadoc JavadocVariable Missing a Javadoc comment. 47
 Error misc FinalParameters Parameter id should be final. 55
 Error coding HiddenField 'id' hides a field. 55
 Error misc FinalParameters Parameter apiKey should be final. 55
 Error coding HiddenField 'apiKey' hides a field. 55
 Error misc FinalParameters Parameter sequence should be final. 55
 Error sizes LineLength Line is longer than 80 characters (found 93). 56
 Error sizes LineLength Line is longer than 80 characters (found 91). 69
 Error misc FinalParameters Parameter sequenceId should be final. 69
 Error misc FinalParameters Parameter limit should be final. 69
 Error sizes LineLength Line is longer than 80 characters (found 110). 73
 Error sizes LineLength Line is longer than 80 characters (found 88). 78
 Error design DesignForExtension Class 'MoreoverClient' looks like designed for extension (can be subclassed), but the method 'getNextBatch' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverClient' final or making the method 'getNextBatch' static/final/abstract/empty, or adding allowed annotation for the method. 83
 Error javadoc JavadocMethod Missing a Javadoc comment. 83
 Error sizes LineLength Line is longer than 80 characters (found 97). 84
 Error coding MagicNumber '500' is a magic number. 85
 Error javadoc JavadocMethod Missing a Javadoc comment. 88
 Error misc FinalParameters Parameter url should be final. 88
 Error sizes LineLength Line is longer than 80 characters (found 117). 94
 Error sizes LineLength Line is longer than 80 characters (found 96). 97
 Error javadoc JavadocMethod Missing a Javadoc comment. 105
 Error misc FinalParameters Parameter url should be final. 105
 Error sizes LineLength Line is longer than 80 characters (found 95). 112

org/apache/streams/moreover/MoreoverJsonActivitySerializer.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 83). 40
 Error sizes LineLength Line is longer than 80 characters (found 101). 42
 Error javadoc JavadocVariable Missing a Javadoc comment. 42
 Error javadoc JavadocMethod Missing a Javadoc comment. 44
 Error design DesignForExtension Class 'MoreoverJsonActivitySerializer' looks like designed for extension (can be subclassed), but the method 'serializationFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverJsonActivitySerializer' final or making the method 'serializationFormat' static/final/abstract/empty, or adding allowed annotation for the method. 47
 Error design DesignForExtension Class 'MoreoverJsonActivitySerializer' looks like designed for extension (can be subclassed), but the method 'serialize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverJsonActivitySerializer' final or making the method 'serialize' static/final/abstract/empty, or adding allowed annotation for the method. 52
 Error misc FinalParameters Parameter deserialized should be final. 53
 Error sizes LineLength Line is longer than 80 characters (found 91). 54
 Error design DesignForExtension Class 'MoreoverJsonActivitySerializer' looks like designed for extension (can be subclassed), but the method 'deserialize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverJsonActivitySerializer' final or making the method 'deserialize' static/final/abstract/empty, or adding allowed annotation for the method. 57
 Error misc FinalParameters Parameter serialized should be final. 58
 Error sizes LineLength Line is longer than 80 characters (found 98). 64
 Error sizes LineLength Line is longer than 80 characters (found 87). 66
 Error sizes LineLength Line is longer than 80 characters (found 84). 67
 Error sizes LineLength Line is longer than 80 characters (found 88). 68
 Error sizes LineLength Line is longer than 80 characters (found 94). 69
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 74
 Error design DesignForExtension Class 'MoreoverJsonActivitySerializer' looks like designed for extension (can be subclassed), but the method 'deserializeAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverJsonActivitySerializer' final or making the method 'deserializeAll' static/final/abstract/empty, or adding allowed annotation for the method. 92
 Error misc FinalParameters Parameter serializedList should be final. 93

org/apache/streams/moreover/MoreoverProvider.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 60
 Error sizes LineLength Line is longer than 80 characters (found 87). 62
 Error javadoc JavadocVariable Missing a Javadoc comment. 62
 Error sizes LineLength Line is longer than 80 characters (found 87). 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 64
 Error design VisibilityModifier Variable 'providerQueue' must be private and have accessor methods. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 66
 Error javadoc JavadocVariable Missing a Javadoc comment. 68
 Error javadoc JavadocVariable Missing a Javadoc comment. 70
 Error misc FinalParameters Parameter moreoverConfiguration should be final. 76
 Error whitespace ParenPad '(' is followed by whitespace. 79
 Error design DesignForExtension Class 'MoreoverProvider' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProvider' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 84
 Error design DesignForExtension Class 'MoreoverProvider' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProvider' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. 89
 Error sizes LineLength Line is longer than 80 characters (found 133). 93
 Error design DesignForExtension Class 'MoreoverProvider' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProvider' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. 100
 Error sizes LineLength Line is longer than 80 characters (found 98). 108
 Error design DesignForExtension Class 'MoreoverProvider' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProvider' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. 115
 Error misc FinalParameters Parameter sequence should be final. 116
 Error design DesignForExtension Class 'MoreoverProvider' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProvider' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. 120
 Error misc FinalParameters Parameter start should be final. 121
 Error misc FinalParameters Parameter end should be final. 121
 Error design DesignForExtension Class 'MoreoverProvider' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProvider' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. 125
 Error design DesignForExtension Class 'MoreoverProvider' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProvider' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 130
 Error misc FinalParameters Parameter configurationObject should be final. 131
 Error javadoc JavadocStyle First sentence should end with a period. 141
 Error sizes LineLength Line is longer than 80 characters (found 117). 151
 Error misc FinalParameters Parameter args should be final. 156
 Error sizes LineLength Line is longer than 80 characters (found 125). 166
 Error sizes LineLength Line is longer than 80 characters (found 98). 170
 Error sizes LineLength Line is longer than 80 characters (found 129). 171
 Error sizes LineLength Line is longer than 80 characters (found 101). 176
 Error sizes LineLength Line is longer than 80 characters (found 111). 180
 Error whitespace ParenPad '(' is followed by whitespace. 191
 Error whitespace ParenPad ')' is preceded with whitespace. 191

org/apache/streams/moreover/MoreoverProviderTask.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 35
 Error sizes LineLength Line is longer than 80 characters (found 85). 36
 Error javadoc JavadocVariable Missing a Javadoc comment. 36
 Error javadoc JavadocVariable Missing a Javadoc comment. 38
 Error javadoc JavadocVariable Missing a Javadoc comment. 39
 Error javadoc JavadocVariable Missing a Javadoc comment. 40
 Error javadoc JavadocVariable Missing a Javadoc comment. 41
 Error javadoc JavadocVariable Missing a Javadoc comment. 42
 Error sizes LineLength Line is longer than 80 characters (found 110). 51
 Error misc FinalParameters Parameter apiId should be final. 51
 Error misc FinalParameters Parameter apiKey should be final. 51
 Error coding HiddenField 'apiKey' hides a field. 51
 Error misc FinalParameters Parameter results should be final. 51
 Error coding HiddenField 'results' hides a field. 51
 Error misc FinalParameters Parameter lastSequence should be final. 51
 Error coding HiddenField 'lastSequence' hides a field. 51
 Error sizes LineLength Line is longer than 80 characters (found 117). 52
 Error design DesignForExtension Class 'MoreoverProviderTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverProviderTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 60
 Error coding MagicNumber '500' is a magic number. 65
 Error javadoc JavadocMethod Missing a Javadoc comment. 79
 Error misc FinalParameters Parameter moClient should be final. 79
 Error coding HiddenField 'moClient' hides a field. 79
 Error javadoc JavadocMethod Missing a Javadoc comment. 90
 Error misc FinalParameters Parameter moClient should be final. 90
 Error coding HiddenField 'moClient' hides a field. 90

org/apache/streams/moreover/MoreoverResult.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 42
 Error sizes LineLength Line is longer than 80 characters (found 85). 44
 Error javadoc JavadocVariable Missing a Javadoc comment. 44
 Error naming ConstantName Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 44
 Error javadoc JavadocVariable Missing a Javadoc comment. 46
 Error javadoc JavadocVariable Missing a Javadoc comment. 48
 Error javadoc JavadocVariable Missing a Javadoc comment. 49
 Error javadoc JavadocVariable Missing a Javadoc comment. 50
 Error javadoc JavadocVariable Missing a Javadoc comment. 51
 Error javadoc JavadocVariable Missing a Javadoc comment. 52
 Error javadoc JavadocVariable Missing a Javadoc comment. 53
 Error javadoc JavadocVariable Missing a Javadoc comment. 54
 Error javadoc JavadocVariable Missing a Javadoc comment. 55
 Error javadoc JavadocVariable Missing a Javadoc comment. 56
 Error javadoc JavadocVariable Missing a Javadoc comment. 58
 Error design VisibilityModifier Variable 'response' must be private and have accessor methods. 58
 Error javadoc JavadocVariable Missing a Javadoc comment. 59
 Error design VisibilityModifier Variable 'list' must be private and have accessor methods. 59
 Error sizes LineLength Line is longer than 80 characters (found 85). 61
 Error javadoc JavadocMethod Missing a Javadoc comment. 61
 Error misc FinalParameters Parameter clientId should be final. 61
 Error coding HiddenField 'clientId' hides a field. 61
 Error misc FinalParameters Parameter xmlString should be final. 61
 Error coding HiddenField 'xmlString' hides a field. 61
 Error misc FinalParameters Parameter start should be final. 61
 Error coding HiddenField 'start' hides a field. 61
 Error misc FinalParameters Parameter end should be final. 61
 Error coding HiddenField 'end' hides a field. 61
 Error design DesignForExtension Class 'MoreoverResult' looks like designed for extension (can be subclassed), but the method 'getClientId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverResult' final or making the method 'getClientId' static/final/abstract/empty, or adding allowed annotation for the method. 113
 Error javadoc JavadocMethod Missing a Javadoc comment. 113
 Error design DesignForExtension Class 'MoreoverResult' looks like designed for extension (can be subclassed), but the method 'getStart' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverResult' final or making the method 'getStart' static/final/abstract/empty, or adding allowed annotation for the method. 117
 Error javadoc JavadocMethod Missing a Javadoc comment. 117
 Error design DesignForExtension Class 'MoreoverResult' looks like designed for extension (can be subclassed), but the method 'getEnd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverResult' final or making the method 'getEnd' static/final/abstract/empty, or adding allowed annotation for the method. 121
 Error javadoc JavadocMethod Missing a Javadoc comment. 121
 Error javadoc JavadocStyle First sentence should end with a period. 125
 Error sizes LineLength Line is longer than 80 characters (found 81). 132
 Error whitespace ParenPad '(' is followed by whitespace. 142
 Error sizes LineLength Line is longer than 80 characters (found 103). 154
 Error design DesignForExtension Class 'MoreoverResult' looks like designed for extension (can be subclassed), but the method 'getXmlString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverResult' final or making the method 'getXmlString' static/final/abstract/empty, or adding allowed annotation for the method. 164
 Error javadoc JavadocMethod Missing a Javadoc comment. 164
 Error design DesignForExtension Class 'MoreoverResult' looks like designed for extension (can be subclassed), but the method 'getMaxSequencedId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverResult' final or making the method 'getMaxSequencedId' static/final/abstract/empty, or adding allowed annotation for the method. 168
 Error javadoc JavadocMethod Missing a Javadoc comment. 168
 Error design DesignForExtension Class 'MoreoverResult' looks like designed for extension (can be subclassed), but the method 'iterator' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverResult' final or making the method 'iterator' static/final/abstract/empty, or adding allowed annotation for the method. 172
 Error javadoc JavadocType Missing a Javadoc comment. 177
 Error javadoc JavadocVariable Missing a Javadoc comment. 179
 Error javadoc JavadocMethod Missing a Javadoc comment. 181
 Error misc FinalParameters Parameter underlying should be final. 181
 Error coding HiddenField 'underlying' hides a field. 181
 Error design DesignForExtension Class 'JsonStringIterator' looks like designed for extension (can be subclassed), but the method 'hasNext' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'JsonStringIterator' final or making the method 'hasNext' static/final/abstract/empty, or adding allowed annotation for the method. 185
 Error design DesignForExtension Class 'JsonStringIterator' looks like designed for extension (can be subclassed), but the method 'next' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'JsonStringIterator' final or making the method 'next' static/final/abstract/empty, or adding allowed annotation for the method. 190
 Error design DesignForExtension Class 'JsonStringIterator' looks like designed for extension (can be subclassed), but the method 'remove' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'JsonStringIterator' final or making the method 'remove' static/final/abstract/empty, or adding allowed annotation for the method. 195

org/apache/streams/moreover/MoreoverUtils.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error design FinalClass Class MoreoverUtils should be declared as final. 47
 Error javadoc JavadocMethod Missing a Javadoc comment. 49
 Error javadoc JavadocVariable Missing a Javadoc comment. 52
 Error misc FinalParameters Parameter article should be final. 59
 Error misc FinalParameters Parameter source should be final. 82
 Error sizes LineLength Line is longer than 80 characters (found 95). 86
 Error misc FinalParameters Parameter author should be final. 98
 Error misc FinalParameters Parameter platformName should be final. 98
 Error sizes LineLength Line is longer than 80 characters (found 81). 103
 Error javadoc JavadocMethod Missing a Javadoc comment. 112
 Error misc FinalParameters Parameter activity should be final. 112
 Error javadoc JavadocMethod Missing a Javadoc comment. 118
 Error misc FinalParameters Parameter article should be final. 118
 Error misc FinalParameters Parameter source should be final. 134
 Error misc FinalParameters Parameter article should be final. 146
 Error sizes LineLength Line is longer than 80 characters (found 95). 152
 Error coding AvoidInlineConditionals Avoid inline conditionals. 152
 Error sizes LineLength Line is longer than 80 characters (found 99). 153
 Error misc FinalParameters Parameter activity should be final. 163
 Error misc FinalParameters Parameter source should be final. 163
 Error sizes LineLength Line is longer than 80 characters (found 92). 164
 Error coding AvoidInlineConditionals Avoid inline conditionals. 166
 Error misc FinalParameters Parameter activity should be final. 180
 Error misc FinalParameters Parameter article should be final. 180
 Error sizes LineLength Line is longer than 80 characters (found 92). 181
 Error javadoc JavadocMethod Missing a Javadoc comment. 188
 Error misc FinalParameters Parameter feed should be final. 188
 Error sizes LineLength Line is longer than 80 characters (found 116). 189
 Error coding AvoidInlineConditionals Avoid inline conditionals. 189
 Error javadoc JavadocMethod Missing a Javadoc comment. 192
 Error misc FinalParameters Parameter feed should be final. 192

org/apache/streams/moreover/MoreoverXmlActivitySerializer.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 92). 38
 Error sizes LineLength Line is longer than 80 characters (found 82). 40
 Error javadoc JavadocVariable Missing a Javadoc comment. 43
 Error javadoc JavadocVariable Missing a Javadoc comment. 44
 Error javadoc JavadocMethod Missing a Javadoc comment. 46
 Error design DesignForExtension Class 'MoreoverXmlActivitySerializer' looks like designed for extension (can be subclassed), but the method 'serializationFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverXmlActivitySerializer' final or making the method 'serializationFormat' static/final/abstract/empty, or adding allowed annotation for the method. 51
 Error design DesignForExtension Class 'MoreoverXmlActivitySerializer' looks like designed for extension (can be subclassed), but the method 'serialize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverXmlActivitySerializer' final or making the method 'serialize' static/final/abstract/empty, or adding allowed annotation for the method. 56
 Error misc FinalParameters Parameter deserialized should be final. 57
 Error sizes LineLength Line is longer than 80 characters (found 86). 58
 Error design DesignForExtension Class 'MoreoverXmlActivitySerializer' looks like designed for extension (can be subclassed), but the method 'deserialize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverXmlActivitySerializer' final or making the method 'deserialize' static/final/abstract/empty, or adding allowed annotation for the method. 61
 Error misc FinalParameters Parameter serialized should be final. 62
 Error design DesignForExtension Class 'MoreoverXmlActivitySerializer' looks like designed for extension (can be subclassed), but the method 'deserializeAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoreoverXmlActivitySerializer' final or making the method 'deserializeAll' static/final/abstract/empty, or adding allowed annotation for the method. 67
 Error misc FinalParameters Parameter serializedList should be final. 68
 Error javadoc JavadocMethod Missing a Javadoc comment. 79
 Error misc FinalParameters Parameter serialized should be final. 79
 Error sizes LineLength Line is longer than 80 characters (found 82). 84
 Error javadoc JavadocMethod Missing a Javadoc comment. 88
 Error misc FinalParameters Parameter serialized should be final. 88
 Error sizes LineLength Line is longer than 80 characters (found 111). 91
 Error sizes LineLength Line is longer than 80 characters (found 82). 93
 Error javadoc JavadocMethod Missing a Javadoc comment. 97
 Error misc FinalParameters Parameter articleClass should be final. 97
 Error sizes LineLength Line is longer than 80 characters (found 115). 100
 Error sizes LineLength Line is longer than 80 characters (found 93). 102