Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
3 0 0 220

Files

File  I  W  E
org/apache/streams/urls/LinkResolver.java 0 0 144
org/apache/streams/urls/LinkResolverHelperFunctions.java 0 0 61
org/apache/streams/urls/LinkResolverProcessor.java 0 0 15

Rules

Category Rule Violations Severity
blocks NeedBraces 27  Error
coding MagicNumber 20  Error
design DesignForExtension 6  Error
javadoc JavadocMethod 10  Error
JavadocPackage 1  Error
JavadocStyle 5  Error
JavadocType 2  Error
JavadocVariable 18  Error
misc FinalParameters 12  Error
modifier ModifierOrder 1  Error
sizes LineLength 98  Error
MethodLength 1  Error
whitespace OperatorWrap 5  Error
WhitespaceAfter 1  Error
WhitespaceAround 13  Error

Details

org/apache/streams/urls/LinkResolver.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 41
 Error sizes LineLength Line is longer than 80 characters (found 92). 45
 Error sizes LineLength Line is longer than 80 characters (found 92). 46
 Error sizes LineLength Line is longer than 80 characters (found 92). 51
 Error sizes LineLength Line is longer than 80 characters (found 82). 52
 Error sizes LineLength Line is longer than 80 characters (found 81). 54
 Error sizes LineLength Line is longer than 80 characters (found 85). 58
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Error sizes LineLength Line is longer than 80 characters (found 147). 60
 Error javadoc JavadocVariable Missing a Javadoc comment. 60
 Error sizes LineLength Line is longer than 80 characters (found 156). 61
 Error javadoc JavadocVariable Missing a Javadoc comment. 61
 Error javadoc JavadocVariable Missing a Javadoc comment. 62
 Error javadoc JavadocVariable Missing a Javadoc comment. 63
 Error sizes LineLength Line is longer than 80 characters (found 98). 66
 Error javadoc JavadocVariable Missing a Javadoc comment. 66
 Error sizes LineLength Line is longer than 80 characters (found 149). 68
 Error sizes LineLength Line is longer than 80 characters (found 84). 73
 Error javadoc JavadocVariable Missing a Javadoc comment. 73
 Error sizes LineLength Line is longer than 80 characters (found 81). 77
 Error sizes LineLength Line is longer than 80 characters (found 95). 78
 Error javadoc JavadocVariable Missing a Javadoc comment. 78
 Error sizes LineLength Line is longer than 80 characters (found 98). 88
 Error sizes LineLength Line is longer than 80 characters (found 90). 91
 Error sizes LineLength Line is longer than 80 characters (found 126). 97
 Error sizes LineLength Line is longer than 80 characters (found 118). 100
 Error sizes LineLength Line is longer than 80 characters (found 92). 105
 Error javadoc JavadocVariable Missing a Javadoc comment. 107
 Error javadoc JavadocVariable Missing a Javadoc comment. 108
 Error javadoc JavadocStyle First sentence should end with a period. 110
 Error sizes LineLength Line is longer than 80 characters (found 122). 113
 Error sizes LineLength Line is longer than 80 characters (found 113). 120
 Error misc FinalParameters Parameter originalURL should be final. 124
 Error design DesignForExtension Class 'LinkResolver' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LinkResolver' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 129
 Error javadoc JavadocMethod Missing a Javadoc comment. 129
 Error sizes LineLength Line is longer than 80 characters (found 96). 135
 Error sizes LineLength Line is longer than 80 characters (found 88). 136
 Error blocks NeedBraces 'for' construct must use '{}'s. 137
 Error coding MagicNumber '3' is a magic number. 137
 Error blocks NeedBraces 'if' construct must use '{}'s. 138
 Error sizes LineLength Line is longer than 80 characters (found 108). 141
 Error blocks NeedBraces 'if' construct must use '{}'s. 142
 Error sizes LineLength Line is longer than 80 characters (found 96). 142
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 142
 Error blocks NeedBraces 'if' construct must use '{}'s. 146
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 146
 Error sizes LineLength Line is longer than 80 characters (found 82). 147
 Error blocks NeedBraces 'if' construct must use '{}'s. 148
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 148
 Error sizes LineLength Line is longer than 80 characters (found 81). 149
 Error design DesignForExtension Class 'LinkResolver' looks like designed for extension (can be subclassed), but the method 'updateTookInMillis' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LinkResolver' final or making the method 'updateTookInMillis' static/final/abstract/empty, or adding allowed annotation for the method. 154
 Error javadoc JavadocMethod Missing a Javadoc comment. 154
 Error sizes LineLength Line is longer than 80 characters (found 109). 156
 Error design DesignForExtension Class 'LinkResolver' looks like designed for extension (can be subclassed), but the method 'unwindLink' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LinkResolver' final or making the method 'unwindLink' static/final/abstract/empty, or adding allowed annotation for the method. 159
 Error sizes MethodLength Method length is 183 lines (max allowed is 150). 159
 Error javadoc JavadocMethod Missing a Javadoc comment. 159
 Error misc FinalParameters Parameter url should be final. 159
 Error sizes LineLength Line is longer than 80 characters (found 92). 172
 Error whitespace OperatorWrap '&&' should be on a new line. 172
 Error sizes LineLength Line is longer than 80 characters (found 103). 173
 Error sizes LineLength Line is longer than 80 characters (found 120). 174
 Error blocks NeedBraces 'if' construct must use '{}'s. 179
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 194
 Error sizes LineLength Line is longer than 80 characters (found 103). 196
 Error whitespace WhitespaceAround 'catch' is not followed by whitespace. 202
 Error blocks NeedBraces 'for' construct must use '{}'s. 214
 Error sizes LineLength Line is longer than 80 characters (found 92). 218
 Error sizes LineLength Line is longer than 80 characters (found 82). 219
 Error sizes LineLength Line is longer than 80 characters (found 90). 220
 Error blocks NeedBraces 'if' construct must use '{}'s. 222
 Error sizes LineLength Line is longer than 80 characters (found 98). 222
 Error sizes LineLength Line is longer than 80 characters (found 92). 223
 Error sizes LineLength Line is longer than 80 characters (found 94). 229
 Error sizes LineLength Line is longer than 80 characters (found 91). 230
 Error blocks NeedBraces 'if' construct must use '{}'s. 235
 Error blocks NeedBraces 'for' construct must use '{}'s. 236
 Error sizes LineLength Line is longer than 80 characters (found 85). 237
 Error sizes LineLength Line is longer than 80 characters (found 82). 241
 Error sizes LineLength Line is longer than 80 characters (found 103). 243
 Error blocks NeedBraces 'if' construct must use '{}'s. 249
 Error sizes LineLength Line is longer than 80 characters (found 88). 250
 Error coding MagicNumber '200' is a magic number. 257
 Error sizes LineLength Line is longer than 80 characters (found 88). 259
 Error coding MagicNumber '300' is a magic number. 262
 Error coding MagicNumber '301' is a magic number. 263
 Error coding MagicNumber '302' is a magic number. 264
 Error coding MagicNumber '303' is a magic number. 265
 Error coding MagicNumber '304' is a magic number. 266
 Error sizes LineLength Line is longer than 80 characters (found 82). 267
 Error coding MagicNumber '306' is a magic number. 267
 Error coding MagicNumber '307' is a magic number. 268
 Error sizes LineLength Line is longer than 80 characters (found 82). 276
 Error sizes LineLength Line is longer than 80 characters (found 82). 277
 Error sizes LineLength Line is longer than 80 characters (found 85). 279
 Error sizes LineLength Line is longer than 80 characters (found 87). 281
 Error sizes LineLength Line is longer than 80 characters (found 84). 282
 Error sizes LineLength Line is longer than 80 characters (found 89). 284
 Error blocks NeedBraces 'if' construct must use '{}'s. 285
 Error sizes LineLength Line is longer than 80 characters (found 121). 285
 Error sizes LineLength Line is longer than 80 characters (found 89). 289
 Error sizes LineLength Line is longer than 80 characters (found 89). 292
 Error sizes LineLength Line is longer than 80 characters (found 88). 293
 Error sizes LineLength Line is longer than 80 characters (found 82). 296
 Error coding MagicNumber '305' is a magic number. 296
 Error coding MagicNumber '401' is a magic number. 298
 Error sizes LineLength Line is longer than 80 characters (found 83). 299
 Error coding MagicNumber '403' is a magic number. 301
 Error sizes LineLength Line is longer than 80 characters (found 88). 304
 Error coding MagicNumber '404' is a magic number. 304
 Error coding MagicNumber '500' is a magic number. 307
 Error coding MagicNumber '501' is a magic number. 308
 Error coding MagicNumber '502' is a magic number. 309
 Error coding MagicNumber '503' is a magic number. 310
 Error coding MagicNumber '504' is a magic number. 311
 Error coding MagicNumber '505' is a magic number. 312
 Error sizes LineLength Line is longer than 80 characters (found 88). 313
 Error sizes LineLength Line is longer than 80 characters (found 107). 316
 Error sizes LineLength Line is longer than 80 characters (found 106). 330
 Error blocks NeedBraces 'if' construct must use '{}'s. 331
 Error sizes LineLength Line is longer than 80 characters (found 92). 336
 Error blocks NeedBraces 'if' construct must use '{}'s. 338
 Error sizes LineLength Line is longer than 80 characters (found 97). 343
 Error javadoc JavadocMethod Missing a Javadoc comment. 343
 Error misc FinalParameters Parameter input should be final. 343
 Error blocks NeedBraces 'for' construct must use '{}'s. 345
 Error blocks NeedBraces 'if' construct must use '{}'s. 346
 Error javadoc JavadocMethod Missing a Javadoc comment. 351
 Error misc FinalParameters Parameter url should be final. 351
 Error sizes LineLength Line is longer than 80 characters (found 88). 352
 Error blocks NeedBraces 'if' construct must use '{}'s. 353
 Error blocks NeedBraces 'for' construct must use '{}'s. 360
 Error sizes LineLength Line is longer than 80 characters (found 87). 363
 Error blocks NeedBraces 'if' construct must use '{}'s. 364
 Error javadoc JavadocStyle First sentence should end with a period. 371
 Error misc FinalParameters Parameter url should be final. 379
 Error blocks NeedBraces 'if' construct must use '{}'s. 391
 Error sizes LineLength Line is longer than 80 characters (found 90). 413
 Error misc FinalParameters Parameter url should be final. 418
 Error sizes LineLength Line is longer than 80 characters (found 91). 421
 Error sizes LineLength Line is longer than 80 characters (found 81). 422
 Error sizes LineLength Line is longer than 80 characters (found 83). 426
 Error blocks NeedBraces 'for' construct must use '{}'s. 429
 Error sizes LineLength Line is longer than 80 characters (found 90). 435
 Error sizes LineLength Line is longer than 80 characters (found 90). 436

org/apache/streams/urls/LinkResolverHelperFunctions.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 39
 Error sizes LineLength Line is longer than 80 characters (found 106). 40
 Error sizes LineLength Line is longer than 80 characters (found 119). 41
 Error whitespace OperatorWrap '+' should be on a new line. 42
 Error sizes LineLength Line is longer than 80 characters (found 115). 43
 Error sizes LineLength Line is longer than 80 characters (found 119). 44
 Error whitespace OperatorWrap '+' should be on a new line. 45
 Error sizes LineLength Line is longer than 80 characters (found 128). 46
 Error sizes LineLength Line is longer than 80 characters (found 169). 47
 Error sizes LineLength Line is longer than 80 characters (found 172). 48
 Error whitespace OperatorWrap '+' should be on a new line. 49
 Error sizes LineLength Line is longer than 80 characters (found 104). 50
 Error sizes LineLength Line is longer than 80 characters (found 106). 51
 Error sizes LineLength Line is longer than 80 characters (found 109). 52
 Error whitespace OperatorWrap '+' should be on a new line. 53
 Error sizes LineLength Line is longer than 80 characters (found 106). 54
 Error sizes LineLength Line is longer than 80 characters (found 108). 55
 Error javadoc JavadocVariable Missing a Javadoc comment. 57
 Error javadoc JavadocVariable Missing a Javadoc comment. 60
 Error javadoc JavadocVariable Missing a Javadoc comment. 61
 Error sizes LineLength Line is longer than 80 characters (found 93). 63
 Error sizes LineLength Line is longer than 80 characters (found 96). 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 66
 Error javadoc JavadocStyle First sentence should end with a period. 68
 Error misc FinalParameters Parameter possibleURL should be final. 75
 Error javadoc JavadocMethod Missing a Javadoc comment. 79
 Error misc FinalParameters Parameter possiblyHasURLs should be final. 79
 Error sizes LineLength Line is longer than 80 characters (found 101). 80
 Error javadoc JavadocMethod Missing a Javadoc comment. 83
 Error javadoc JavadocMethod Missing a Javadoc comment. 87
 Error javadoc JavadocMethod Missing a Javadoc comment. 91
 Error misc FinalParameters Parameter domain should be final. 91
 Error sizes LineLength Line is longer than 80 characters (found 87). 97
 Error blocks NeedBraces 'if' construct must use '{}'s. 98
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 98
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 102
 Error sizes LineLength Line is longer than 80 characters (found 96). 105
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 105
 Error coding MagicNumber '5' is a magic number. 105
 Error blocks NeedBraces 'if' construct must use '{}'s. 108
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 108
 Error sizes LineLength Line is longer than 80 characters (found 95). 109
 Error sizes LineLength Line is longer than 80 characters (found 81). 113
 Error sizes LineLength Line is longer than 80 characters (found 81). 114
 Error sizes LineLength Line is longer than 80 characters (found 91). 119
 Error javadoc JavadocStyle First sentence should end with a period. 126
 Error sizes LineLength Line is longer than 80 characters (found 92). 127
 Error javadoc JavadocStyle First sentence should end with a period. 138
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 147
 Error blocks NeedBraces 'for' construct must use '{}'s. 154
 Error whitespace WhitespaceAround 'for' is not followed by whitespace. 154
 Error blocks NeedBraces 'if' construct must use '{}'s. 155
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 155
 Error blocks NeedBraces 'if' construct must use '{}'s. 158
 Error sizes LineLength Line is longer than 80 characters (found 103). 158
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 158
 Error blocks NeedBraces 'for' construct must use '{}'s. 159
 Error sizes LineLength Line is longer than 80 characters (found 99). 159
 Error whitespace WhitespaceAround 'for' is not followed by whitespace. 159
 Error sizes LineLength Line is longer than 80 characters (found 86). 160

org/apache/streams/urls/LinkResolverProcessor.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 37
 Error javadoc JavadocVariable Missing a Javadoc comment. 39
 Error sizes LineLength Line is longer than 80 characters (found 94). 40
 Error javadoc JavadocVariable Missing a Javadoc comment. 40
 Error javadoc JavadocVariable Missing a Javadoc comment. 41
 Error design DesignForExtension Class 'LinkResolverProcessor' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LinkResolverProcessor' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 43
 Error design DesignForExtension Class 'LinkResolverProcessor' looks like designed for extension (can be subclassed), but the method 'process' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LinkResolverProcessor' final or making the method 'process' static/final/abstract/empty, or adding allowed annotation for the method. 48
 Error misc FinalParameters Parameter entry should be final. 49
 Error sizes LineLength Line is longer than 80 characters (found 85). 53
 Error sizes LineLength Line is longer than 80 characters (found 90). 71
 Error misc FinalParameters Parameter o should be final. 98
 Error design DesignForExtension Class 'LinkResolverProcessor' looks like designed for extension (can be subclassed), but the method 'unwind' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LinkResolverProcessor' final or making the method 'unwind' static/final/abstract/empty, or adding allowed annotation for the method. 108
 Error javadoc JavadocMethod Missing a Javadoc comment. 108
 Error misc FinalParameters Parameter inputLinks should be final. 108