Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
6 0 0 228

Rules

Category Rule Violations Severity
blocks RightCurly 1  Error
coding HiddenField 6  Error
MagicNumber 2  Error
design DesignForExtension 26  Error
FinalClass 2  Error
VisibilityModifier 5  Error
imports UnusedImports
  • processJavadoc: "false"
2  Error
javadoc JavadocMethod 18  Error
JavadocPackage 2  Error
JavadocVariable 23  Error
misc FinalParameters 20  Error
naming StaticVariableName 2  Error
sizes LineLength 21  Error
whitespace ParenPad 39  Error
WhitespaceAfter 18  Error
WhitespaceAround 41  Error

Details

org/apache/streams/riak/binary/RiakBinaryClient.java

Severity Category Rule Message Line
 Error design FinalClass Class RiakBinaryClient should be declared as final. 33
 Error javadoc JavadocVariable Missing a Javadoc comment. 35
 Error javadoc JavadocVariable Missing a Javadoc comment. 38
 Error javadoc JavadocVariable Missing a Javadoc comment. 40
 Error design VisibilityModifier Variable 'config' must be private and have accessor methods. 40
 Error javadoc JavadocMethod Missing a Javadoc comment. 42
 Error misc FinalParameters Parameter config should be final. 42
 Error coding HiddenField 'config' hides a field. 42
 Error sizes LineLength Line is longer than 80 characters (found 99). 52
 Error javadoc JavadocVariable Missing a Javadoc comment. 52
 Error naming StaticVariableName Name 'INSTANCE_MAP' must match pattern '^[a-z][a-zA-Z0-9]*$'. 52
 Error sizes LineLength Line is longer than 80 characters (found 83). 54
 Error javadoc JavadocMethod Missing a Javadoc comment. 54
 Error misc FinalParameters Parameter riakConfiguration should be final. 54
 Error whitespace ParenPad '(' is followed by whitespace. 55
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 61
 Error whitespace ParenPad '(' is followed by whitespace. 61
 Error whitespace ParenPad ')' is preceded with whitespace. 61
 Error javadoc JavadocMethod Missing a Javadoc comment. 70
 Error sizes LineLength Line is longer than 80 characters (found 113). 76
 Error whitespace WhitespaceAround 'assert' is not followed by whitespace. 82
 Error whitespace ParenPad '(' is followed by whitespace. 82
 Error whitespace ParenPad ')' is preceded with whitespace. 82
 Error javadoc JavadocMethod Missing a Javadoc comment. 85
 Error javadoc JavadocMethod Missing a Javadoc comment. 89
 Error javadoc JavadocMethod Missing a Javadoc comment. 93

org/apache/streams/riak/binary/RiakBinaryPersistReader.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 47
 Error javadoc JavadocVariable Missing a Javadoc comment. 48
 Error design VisibilityModifier Variable 'client' must be private and have accessor methods. 48
 Error javadoc JavadocMethod Missing a Javadoc comment. 50
 Error misc FinalParameters Parameter configuration should be final. 50
 Error coding HiddenField 'configuration' hides a field. 50
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 54
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 59
 Error misc FinalParameters Parameter configurationObject should be final. 60
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 64
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'readAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'readAll' static/final/abstract/empty, or adding allowed annotation for the method. 69
 Error sizes LineLength Line is longer than 80 characters (found 105). 74
 Error sizes LineLength Line is longer than 80 characters (found 92). 86
 Error sizes LineLength Line is longer than 80 characters (found 111). 101
 Error blocks RightCurly '}' at column 7 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). 102
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. 113
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. 118
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. 123
 Error misc FinalParameters Parameter sequence should be final. 124
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. 128
 Error misc FinalParameters Parameter start should be final. 129
 Error misc FinalParameters Parameter end should be final. 129
 Error design DesignForExtension Class 'RiakBinaryPersistReader' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistReader' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. 133
 Error javadoc JavadocMethod Missing a Javadoc comment. 138
 Error sizes LineLength Line is longer than 80 characters (found 82). 139
 Error coding MagicNumber '10000' is a magic number. 139

org/apache/streams/riak/binary/RiakBinaryPersistWriter.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error sizes LineLength Line is longer than 80 characters (found 94). 44
 Error javadoc JavadocVariable Missing a Javadoc comment. 44
 Error javadoc JavadocVariable Missing a Javadoc comment. 46
 Error javadoc JavadocVariable Missing a Javadoc comment. 48
 Error javadoc JavadocVariable Missing a Javadoc comment. 49
 Error javadoc JavadocMethod Missing a Javadoc comment. 51
 Error misc FinalParameters Parameter configuration should be final. 51
 Error coding HiddenField 'configuration' hides a field. 51
 Error design DesignForExtension Class 'RiakBinaryPersistWriter' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistWriter' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 55
 Error design DesignForExtension Class 'RiakBinaryPersistWriter' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistWriter' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 60
 Error misc FinalParameters Parameter configurationObject should be final. 61
 Error design DesignForExtension Class 'RiakBinaryPersistWriter' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistWriter' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 65
 Error design DesignForExtension Class 'RiakBinaryPersistWriter' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakBinaryPersistWriter' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. 70
 Error misc FinalParameters Parameter entry should be final. 71
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 81
 Error whitespace ParenPad '(' is followed by whitespace. 81
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 84
 Error whitespace ParenPad '(' is followed by whitespace. 84
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 85
 Error whitespace WhitespaceAround 'catch' is not followed by whitespace. 89
 Error whitespace ParenPad '(' is followed by whitespace. 89
 Error whitespace ParenPad ')' is preceded with whitespace. 89
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 94
 Error whitespace ParenPad '(' is followed by whitespace. 94
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 97
 Error whitespace ParenPad ')' is preceded with whitespace. 97
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 98
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 102
 Error whitespace ParenPad '(' is followed by whitespace. 102
 Error sizes LineLength Line is longer than 80 characters (found 84). 105
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 105
 Error whitespace ParenPad ')' is preceded with whitespace. 105
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 106
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 110
 Error whitespace ParenPad '(' is followed by whitespace. 110
 Error sizes LineLength Line is longer than 80 characters (found 81). 113
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 113
 Error whitespace ParenPad ')' is preceded with whitespace. 113
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 114
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 118
 Error whitespace ParenPad '(' is followed by whitespace. 118
 Error sizes LineLength Line is longer than 80 characters (found 85). 121
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 121
 Error whitespace ParenPad ')' is preceded with whitespace. 121
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 122
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 137
 Error whitespace ParenPad '(' is followed by whitespace. 137

org/apache/streams/riak/http/RiakHttpClient.java

Severity Category Rule Message Line
 Error design FinalClass Class RiakHttpClient should be declared as final. 38
 Error javadoc JavadocVariable Missing a Javadoc comment. 40
 Error javadoc JavadocVariable Missing a Javadoc comment. 43
 Error design VisibilityModifier Variable 'config' must be private and have accessor methods. 43
 Error javadoc JavadocVariable Missing a Javadoc comment. 45
 Error design VisibilityModifier Variable 'client' must be private and have accessor methods. 45
 Error javadoc JavadocVariable Missing a Javadoc comment. 46
 Error design VisibilityModifier Variable 'baseURI' must be private and have accessor methods. 46
 Error javadoc JavadocMethod Missing a Javadoc comment. 48
 Error misc FinalParameters Parameter config should be final. 48
 Error coding HiddenField 'config' hides a field. 48
 Error sizes LineLength Line is longer than 80 characters (found 97). 58
 Error javadoc JavadocVariable Missing a Javadoc comment. 58
 Error naming StaticVariableName Name 'INSTANCE_MAP' must match pattern '^[a-z][a-zA-Z0-9]*$'. 58
 Error sizes LineLength Line is longer than 80 characters (found 81). 60
 Error javadoc JavadocMethod Missing a Javadoc comment. 60
 Error misc FinalParameters Parameter riakConfiguration should be final. 60
 Error whitespace ParenPad '(' is followed by whitespace. 61
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 67
 Error whitespace ParenPad '(' is followed by whitespace. 67
 Error whitespace ParenPad ')' is preceded with whitespace. 67
 Error javadoc JavadocMethod Missing a Javadoc comment. 76
 Error whitespace WhitespaceAround 'assert' is not followed by whitespace. 78
 Error javadoc JavadocMethod Missing a Javadoc comment. 87
 Error whitespace WhitespaceAround 'catch' is not followed by whitespace. 90
 Error whitespace ParenPad '(' is followed by whitespace. 90
 Error whitespace ParenPad '(' is followed by whitespace. 91
 Error whitespace ParenPad ')' is preceded with whitespace. 91
 Error javadoc JavadocMethod Missing a Javadoc comment. 97
 Error javadoc JavadocMethod Missing a Javadoc comment. 101

org/apache/streams/riak/http/RiakHttpPersistReader.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error imports UnusedImports Unused import - org.apache.http.client.ClientProtocolException. 33
 Error imports UnusedImports Unused import - java.net.URI. 43
 Error javadoc JavadocVariable Missing a Javadoc comment. 54
 Error javadoc JavadocVariable Missing a Javadoc comment. 55
 Error sizes LineLength Line is longer than 80 characters (found 92). 57
 Error javadoc JavadocVariable Missing a Javadoc comment. 57
 Error javadoc JavadocVariable Missing a Javadoc comment. 59
 Error javadoc JavadocMethod Missing a Javadoc comment. 61
 Error misc FinalParameters Parameter configuration should be final. 61
 Error coding HiddenField 'configuration' hides a field. 61
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 65
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 70
 Error misc FinalParameters Parameter configurationObject should be final. 71
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 75
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'readAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'readAll' static/final/abstract/empty, or adding allowed annotation for the method. 80
 Error sizes LineLength Line is longer than 80 characters (found 104). 90
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 90
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 90
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 90
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 90
 Error whitespace WhitespaceAround 'while' is not followed by whitespace. 129
 Error whitespace ParenPad '(' is followed by whitespace. 129
 Error sizes LineLength Line is longer than 80 characters (found 111). 138
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 138
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 138
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 138
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 138
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 138
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 138
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. 171
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. 176
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. 181
 Error misc FinalParameters Parameter sequence should be final. 182
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. 186
 Error misc FinalParameters Parameter start should be final. 187
 Error misc FinalParameters Parameter end should be final. 187
 Error design DesignForExtension Class 'RiakHttpPersistReader' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistReader' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. 191
 Error javadoc JavadocMethod Missing a Javadoc comment. 196
 Error sizes LineLength Line is longer than 80 characters (found 82). 197
 Error coding MagicNumber '10000' is a magic number. 197

org/apache/streams/riak/http/RiakHttpPersistWriter.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 47
 Error javadoc JavadocVariable Missing a Javadoc comment. 48
 Error sizes LineLength Line is longer than 80 characters (found 92). 50
 Error javadoc JavadocVariable Missing a Javadoc comment. 50
 Error javadoc JavadocVariable Missing a Javadoc comment. 52
 Error javadoc JavadocMethod Missing a Javadoc comment. 54
 Error misc FinalParameters Parameter configuration should be final. 54
 Error coding HiddenField 'configuration' hides a field. 54
 Error design DesignForExtension Class 'RiakHttpPersistWriter' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistWriter' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 58
 Error design DesignForExtension Class 'RiakHttpPersistWriter' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistWriter' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 63
 Error misc FinalParameters Parameter configurationObject should be final. 64
 Error design DesignForExtension Class 'RiakHttpPersistWriter' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistWriter' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 68
 Error design DesignForExtension Class 'RiakHttpPersistWriter' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RiakHttpPersistWriter' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. 73
 Error misc FinalParameters Parameter entry should be final. 74
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 84
 Error whitespace ParenPad '(' is followed by whitespace. 84
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 87
 Error whitespace ParenPad '(' is followed by whitespace. 87
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 88
 Error whitespace WhitespaceAround 'catch' is not followed by whitespace. 92
 Error whitespace ParenPad '(' is followed by whitespace. 92
 Error whitespace ParenPad ')' is preceded with whitespace. 92
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 97
 Error whitespace ParenPad '(' is followed by whitespace. 97
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 100
 Error whitespace ParenPad ')' is preceded with whitespace. 100
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 101
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 105
 Error whitespace ParenPad '(' is followed by whitespace. 105
 Error sizes LineLength Line is longer than 80 characters (found 84). 108
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 108
 Error whitespace ParenPad ')' is preceded with whitespace. 108
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 109
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 113
 Error whitespace ParenPad '(' is followed by whitespace. 113
 Error sizes LineLength Line is longer than 80 characters (found 81). 116
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 116
 Error whitespace ParenPad ')' is preceded with whitespace. 116
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 117
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 121
 Error whitespace ParenPad '(' is followed by whitespace. 121
 Error sizes LineLength Line is longer than 80 characters (found 85). 124
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 124
 Error whitespace ParenPad ')' is preceded with whitespace. 124
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 125
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 131
 Error whitespace ParenPad '(' is followed by whitespace. 131
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 132
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 132
 Error whitespace WhitespaceAround 'if' is not followed by whitespace. 134
 Error whitespace ParenPad '(' is followed by whitespace. 134
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 135
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 135
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 135
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 135
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 135
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 135