Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
5 0 0 177

Rules

Category Rule Violations Severity
coding HiddenField 4  Error
MagicNumber 1  Error
design DesignForExtension 19  Error
HideUtilityClassConstructor 1  Error
VisibilityModifier 13  Error
javadoc JavadocMethod 9  Error
JavadocPackage 1  Error
JavadocStyle 2  Error
JavadocVariable 41  Error
misc FinalParameters 12  Error
TodoComment 4  Error
sizes LineLength 44  Error
whitespace ParenPad 24  Error
WhitespaceAround 2  Error

Details

org/apache/streams/hdfs/HdfsConstants.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 24
 Error javadoc JavadocVariable Missing a Javadoc comment. 26
 Error javadoc JavadocVariable Missing a Javadoc comment. 27
 Error javadoc JavadocVariable Missing a Javadoc comment. 28
 Error javadoc JavadocVariable Missing a Javadoc comment. 29

org/apache/streams/hdfs/WebHdfsPersistReader.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 89). 65
 Error javadoc JavadocVariable Missing a Javadoc comment. 67
 Error sizes LineLength Line is longer than 80 characters (found 91). 69
 Error javadoc JavadocVariable Missing a Javadoc comment. 69
 Error javadoc JavadocVariable Missing a Javadoc comment. 71
 Error javadoc JavadocVariable Missing a Javadoc comment. 73
 Error design VisibilityModifier Variable 'client' must be private and have accessor methods. 73
 Error javadoc JavadocVariable Missing a Javadoc comment. 74
 Error design VisibilityModifier Variable 'path' must be private and have accessor methods. 74
 Error javadoc JavadocVariable Missing a Javadoc comment. 75
 Error design VisibilityModifier Variable 'status' must be private and have accessor methods. 75
 Error javadoc JavadocVariable Missing a Javadoc comment. 77
 Error design VisibilityModifier Variable 'persistQueue' must be private and have accessor methods. 77
 Error javadoc JavadocVariable Missing a Javadoc comment. 79
 Error design VisibilityModifier Variable 'mapper' must be private and have accessor methods. 79
 Error javadoc JavadocVariable Missing a Javadoc comment. 80
 Error design VisibilityModifier Variable 'lineReaderUtil' must be private and have accessor methods. 80
 Error javadoc JavadocVariable Missing a Javadoc comment. 82
 Error design VisibilityModifier Variable 'hdfsConfiguration' must be private and have accessor methods. 82
 Error javadoc JavadocVariable Missing a Javadoc comment. 83
 Error design VisibilityModifier Variable 'streamsConfiguration' must be private and have accessor methods. 83
 Error javadoc JavadocVariable Missing a Javadoc comment. 85
 Error javadoc JavadocVariable Missing a Javadoc comment. 87
 Error design VisibilityModifier Variable 'countersTotal' must be private and have accessor methods. 87
 Error javadoc JavadocVariable Missing a Javadoc comment. 88
 Error design VisibilityModifier Variable 'countersCurrent' must be private and have accessor methods. 88
 Error javadoc JavadocVariable Missing a Javadoc comment. 89
 Error sizes LineLength Line is longer than 80 characters (found 89). 92
 Error sizes LineLength Line is longer than 80 characters (found 140). 95
 Error misc FinalParameters Parameter hdfsConfiguration should be final. 102
 Error coding HiddenField 'hdfsConfiguration' hides a field. 102
 Error misc TodoComment Comment matches to-do format 'TODO:'. 146
 Error javadoc JavadocMethod Missing a Javadoc comment. 147
 Error sizes LineLength Line is longer than 80 characters (found 105). 150
 Error sizes LineLength Line is longer than 80 characters (found 84). 151
 Error sizes LineLength Line is longer than 80 characters (found 91). 155
 Error sizes LineLength Line is longer than 80 characters (found 106). 163
 Error sizes LineLength Line is longer than 80 characters (found 92). 164
 Error sizes LineLength Line is longer than 80 characters (found 106). 168
 Error sizes LineLength Line is longer than 80 characters (found 89). 169
 Error sizes LineLength Line is longer than 80 characters (found 105). 183
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 188
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 193
 Error misc FinalParameters Parameter configurationObject should be final. 194
 Error sizes LineLength Line is longer than 80 characters (found 94). 198
 Error whitespace ParenPad '(' is followed by whitespace. 202
 Error whitespace ParenPad '(' is followed by whitespace. 207
 Error sizes LineLength Line is longer than 80 characters (found 131). 220
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readAll' static/final/abstract/empty, or adding allowed annotation for the method. 230
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. 243
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. 249
 Error whitespace ParenPad '(' is followed by whitespace. 254
 Error whitespace ParenPad ')' is preceded with whitespace. 254
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. 266
 Error javadoc JavadocMethod Missing a Javadoc comment. 266
 Error whitespace ParenPad '(' is followed by whitespace. 266
 Error misc FinalParameters Parameter entry should be final. 266
 Error whitespace ParenPad ')' is preceded with whitespace. 266
 Error whitespace ParenPad '(' is followed by whitespace. 269
 Error whitespace ParenPad ')' is preceded with whitespace. 269
 Error whitespace ParenPad '(' is followed by whitespace. 274
 Error whitespace ParenPad ')' is preceded with whitespace. 274
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. 277
 Error misc FinalParameters Parameter sequence should be final. 278
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. 282
 Error misc FinalParameters Parameter start should be final. 283
 Error misc FinalParameters Parameter end should be final. 283
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. 287
 Error design DesignForExtension Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'getDatumStatusCounter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'getDatumStatusCounter' static/final/abstract/empty, or adding allowed annotation for the method. 292

org/apache/streams/hdfs/WebHdfsPersistReaderTask.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 36
 Error sizes LineLength Line is longer than 80 characters (found 95). 42
 Error javadoc JavadocVariable Missing a Javadoc comment. 42
 Error javadoc JavadocVariable Missing a Javadoc comment. 44
 Error javadoc JavadocMethod Missing a Javadoc comment. 46
 Error misc FinalParameters Parameter reader should be final. 46
 Error coding HiddenField 'reader' hides a field. 46
 Error design DesignForExtension Class 'WebHdfsPersistReaderTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReaderTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 50
 Error whitespace ParenPad '(' is followed by whitespace. 55
 Error whitespace ParenPad ')' is preceded with whitespace. 55
 Error whitespace ParenPad '(' is followed by whitespace. 59
 Error whitespace ParenPad ')' is preceded with whitespace. 59
 Error sizes LineLength Line is longer than 80 characters (found 84). 63
 Error whitespace ParenPad '(' is followed by whitespace. 63
 Error sizes LineLength Line is longer than 80 characters (found 99). 64
 Error whitespace ParenPad '(' is followed by whitespace. 65
 Error sizes LineLength Line is longer than 80 characters (found 171). 68
 Error whitespace ParenPad '(' is followed by whitespace. 71
 Error sizes LineLength Line is longer than 80 characters (found 105). 74
 Error sizes LineLength Line is longer than 80 characters (found 85). 77
 Error whitespace ParenPad '(' is followed by whitespace. 88
 Error whitespace ParenPad ')' is preceded with whitespace. 88
 Error coding MagicNumber '15' is a magic number. 113

org/apache/streams/hdfs/WebHdfsPersistWriter.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 111). 57
 Error javadoc JavadocVariable Missing a Javadoc comment. 59
 Error sizes LineLength Line is longer than 80 characters (found 91). 61
 Error javadoc JavadocVariable Missing a Javadoc comment. 61
 Error javadoc JavadocVariable Missing a Javadoc comment. 63
 Error javadoc JavadocVariable Missing a Javadoc comment. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 65
 Error javadoc JavadocVariable Missing a Javadoc comment. 66
 Error javadoc JavadocVariable Missing a Javadoc comment. 67
 Error javadoc JavadocVariable Missing a Javadoc comment. 68
 Error javadoc JavadocVariable Missing a Javadoc comment. 69
 Error javadoc JavadocVariable Missing a Javadoc comment. 71
 Error javadoc JavadocVariable Missing a Javadoc comment. 72
 Error javadoc JavadocVariable Missing a Javadoc comment. 73
 Error javadoc JavadocVariable Missing a Javadoc comment. 74
 Error javadoc JavadocVariable Missing a Javadoc comment. 76
 Error design VisibilityModifier Variable 'terminate' must be private and have accessor methods. 76
 Error javadoc JavadocVariable Missing a Javadoc comment. 78
 Error design VisibilityModifier Variable 'persistQueue' must be private and have accessor methods. 78
 Error javadoc JavadocVariable Missing a Javadoc comment. 80
 Error javadoc JavadocVariable Missing a Javadoc comment. 81
 Error javadoc JavadocVariable Missing a Javadoc comment. 83
 Error design VisibilityModifier Variable 'hdfsConfiguration' must be private and have accessor methods. 83
 Error javadoc JavadocMethod Missing a Javadoc comment. 85
 Error sizes LineLength Line is longer than 80 characters (found 140). 86
 Error javadoc JavadocMethod Missing a Javadoc comment. 89
 Error misc FinalParameters Parameter hdfsConfiguration should be final. 89
 Error coding HiddenField 'hdfsConfiguration' hides a field. 89
 Error misc TodoComment Comment matches to-do format 'TODO:'. 99
 Error sizes LineLength Line is longer than 80 characters (found 89). 105
 Error misc TodoComment Comment matches to-do format 'TODO:'. 116
 Error misc TodoComment Comment matches to-do format 'TODO:'. 125
 Error javadoc JavadocMethod Missing a Javadoc comment. 134
 Error sizes LineLength Line is longer than 80 characters (found 105). 137
 Error sizes LineLength Line is longer than 80 characters (found 84). 138
 Error sizes LineLength Line is longer than 80 characters (found 93). 143
 Error sizes LineLength Line is longer than 80 characters (found 108). 149
 Error sizes LineLength Line is longer than 80 characters (found 94). 150
 Error sizes LineLength Line is longer than 80 characters (found 108). 154
 Error sizes LineLength Line is longer than 80 characters (found 91). 155
 Error sizes LineLength Line is longer than 80 characters (found 109). 171
 Error design DesignForExtension Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 176
 Error design DesignForExtension Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. 181
 Error misc FinalParameters Parameter streamsDatum should be final. 182
 Error sizes LineLength Line is longer than 80 characters (found 85). 185
 Error sizes LineLength Line is longer than 80 characters (found 85). 186
 Error whitespace ParenPad '(' is followed by whitespace. 191
 Error sizes LineLength Line is longer than 80 characters (found 135). 204
 Error javadoc JavadocMethod Missing a Javadoc comment. 211
 Error misc FinalParameters Parameter line should be final. 211
 Error sizes LineLength Line is longer than 80 characters (found 100). 220
 Error sizes LineLength Line is longer than 80 characters (found 101). 226
 Error design DesignForExtension Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'flush' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'flush' static/final/abstract/empty, or adding allowed annotation for the method. 234
 Error javadoc JavadocMethod Missing a Javadoc comment. 242
 Error sizes LineLength Line is longer than 80 characters (found 113). 249
 Error sizes LineLength Line is longer than 80 characters (found 95). 251
 Error whitespace ParenPad '(' is followed by whitespace. 251
 Error sizes LineLength Line is longer than 80 characters (found 113). 267
 Error sizes LineLength Line is longer than 80 characters (found 97). 272
 Error whitespace ParenPad '(' is followed by whitespace. 272
 Error sizes LineLength Line is longer than 80 characters (found 99). 273
 Error design DesignForExtension Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'close' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'close' static/final/abstract/empty, or adding allowed annotation for the method. 289
 Error design DesignForExtension Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 299
 Error misc FinalParameters Parameter configurationObject should be final. 300
 Error sizes LineLength Line is longer than 80 characters (found 91). 304
 Error design DesignForExtension Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 307
 Error design DesignForExtension Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'getDatumStatusCounter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'getDatumStatusCounter' static/final/abstract/empty, or adding allowed annotation for the method. 321

org/apache/streams/hdfs/WebHdfsPersistWriterTask.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 28
 Error sizes LineLength Line is longer than 80 characters (found 95). 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 36
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error misc FinalParameters Parameter writer should be final. 38
 Error coding HiddenField 'writer' hides a field. 38
 Error design DesignForExtension Class 'WebHdfsPersistWriterTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriterTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 42
 Error whitespace ParenPad '(' is followed by whitespace. 46
 Error whitespace ParenPad ')' is preceded with whitespace. 46
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 56
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 56