The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
coding | HiddenField | 4 | ![]() |
MagicNumber | 1 | ![]() | |
design | DesignForExtension | 19 | ![]() |
HideUtilityClassConstructor | 1 | ![]() | |
VisibilityModifier | 13 | ![]() | |
javadoc | JavadocMethod | 9 | ![]() |
JavadocPackage | 1 | ![]() | |
JavadocStyle | 2 | ![]() | |
JavadocVariable | 41 | ![]() | |
misc | FinalParameters | 12 | ![]() |
TodoComment | 4 | ![]() | |
sizes | LineLength | 44 | ![]() |
whitespace | ParenPad | 24 | ![]() |
WhitespaceAround | 2 | ![]() |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. | |
![]() |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 24 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 80 characters (found 89). | 65 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 91). | 69 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 71 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 73 |
![]() |
design | VisibilityModifier | Variable 'client' must be private and have accessor methods. | 73 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 74 |
![]() |
design | VisibilityModifier | Variable 'path' must be private and have accessor methods. | 74 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
![]() |
design | VisibilityModifier | Variable 'status' must be private and have accessor methods. | 75 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
![]() |
design | VisibilityModifier | Variable 'persistQueue' must be private and have accessor methods. | 77 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 79 |
![]() |
design | VisibilityModifier | Variable 'mapper' must be private and have accessor methods. | 79 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 80 |
![]() |
design | VisibilityModifier | Variable 'lineReaderUtil' must be private and have accessor methods. | 80 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 82 |
![]() |
design | VisibilityModifier | Variable 'hdfsConfiguration' must be private and have accessor methods. | 82 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 83 |
![]() |
design | VisibilityModifier | Variable 'streamsConfiguration' must be private and have accessor methods. | 83 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 85 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 87 |
![]() |
design | VisibilityModifier | Variable 'countersTotal' must be private and have accessor methods. | 87 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 88 |
![]() |
design | VisibilityModifier | Variable 'countersCurrent' must be private and have accessor methods. | 88 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 89 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 89). | 92 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 140). | 95 |
![]() |
misc | FinalParameters | Parameter hdfsConfiguration should be final. | 102 |
![]() |
coding | HiddenField | 'hdfsConfiguration' hides a field. | 102 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 146 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 147 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 105). | 150 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 84). | 151 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 91). | 155 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 106). | 163 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 92). | 164 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 106). | 168 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 89). | 169 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 105). | 183 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 188 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. | 193 |
![]() |
misc | FinalParameters | Parameter configurationObject should be final. | 194 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 94). | 198 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 202 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 207 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 131). | 220 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readAll' static/final/abstract/empty, or adding allowed annotation for the method. | 230 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. | 243 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. | 249 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 254 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 254 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. | 266 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 266 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 266 |
![]() |
misc | FinalParameters | Parameter entry should be final. | 266 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 266 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 269 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 269 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 274 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 274 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. | 277 |
![]() |
misc | FinalParameters | Parameter sequence should be final. | 278 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. | 282 |
![]() |
misc | FinalParameters | Parameter start should be final. | 283 |
![]() |
misc | FinalParameters | Parameter end should be final. | 283 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. | 287 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReader' looks like designed for extension (can be subclassed), but the method 'getDatumStatusCounter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReader' final or making the method 'getDatumStatusCounter' static/final/abstract/empty, or adding allowed annotation for the method. | 292 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 36 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 95). | 42 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 46 |
![]() |
misc | FinalParameters | Parameter reader should be final. | 46 |
![]() |
coding | HiddenField | 'reader' hides a field. | 46 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistReaderTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistReaderTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 55 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 55 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 59 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 59 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 84). | 63 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 63 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 99). | 64 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 65 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 171). | 68 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 71 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 105). | 74 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 77 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 88 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 88 |
![]() |
coding | MagicNumber | '15' is a magic number. | 113 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 80 characters (found 111). | 57 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 91). | 61 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 65 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 71 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 72 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 73 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 74 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 76 |
![]() |
design | VisibilityModifier | Variable 'terminate' must be private and have accessor methods. | 76 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 78 |
![]() |
design | VisibilityModifier | Variable 'persistQueue' must be private and have accessor methods. | 78 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 80 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 81 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 83 |
![]() |
design | VisibilityModifier | Variable 'hdfsConfiguration' must be private and have accessor methods. | 83 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 85 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 140). | 86 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 89 |
![]() |
misc | FinalParameters | Parameter hdfsConfiguration should be final. | 89 |
![]() |
coding | HiddenField | 'hdfsConfiguration' hides a field. | 89 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 99 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 89). | 105 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 116 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 125 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 134 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 105). | 137 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 84). | 138 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 93). | 143 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 108). | 149 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 94). | 150 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 108). | 154 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 91). | 155 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 109). | 171 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 176 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. | 181 |
![]() |
misc | FinalParameters | Parameter streamsDatum should be final. | 182 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 185 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 186 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 191 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 135). | 204 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 211 |
![]() |
misc | FinalParameters | Parameter line should be final. | 211 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 100). | 220 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 101). | 226 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'flush' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'flush' static/final/abstract/empty, or adding allowed annotation for the method. | 234 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 242 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 113). | 249 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 95). | 251 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 251 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 113). | 267 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 97). | 272 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 272 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 99). | 273 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'close' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'close' static/final/abstract/empty, or adding allowed annotation for the method. | 289 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. | 299 |
![]() |
misc | FinalParameters | Parameter configurationObject should be final. | 300 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 91). | 304 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. | 307 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriter' looks like designed for extension (can be subclassed), but the method 'getDatumStatusCounter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriter' final or making the method 'getDatumStatusCounter' static/final/abstract/empty, or adding allowed annotation for the method. | 321 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 28 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 95). | 34 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 38 |
![]() |
misc | FinalParameters | Parameter writer should be final. | 38 |
![]() |
coding | HiddenField | 'writer' hides a field. | 38 |
![]() |
design | DesignForExtension | Class 'WebHdfsPersistWriterTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WebHdfsPersistWriterTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 46 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 46 |
![]() |
whitespace | WhitespaceAround | '{' is not followed by whitespace. | 56 |
![]() |
whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 56 |