Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
5 0 0 113

Files

File  I  W  E
org/apache/streams/hbase/HbasePersistReader.java 0 0 47
org/apache/streams/hbase/HbasePersistReaderTask.java 0 0 10
org/apache/streams/hbase/HbasePersistWriter.java 0 0 45
org/apache/streams/hbase/HbasePersistWriterTask.java 0 0 11

Rules

Category Rule Violations Severity
blocks EmptyBlock 1  Error
coding HiddenField 4  Error
MagicNumber 2  Error
design DesignForExtension 20  Error
VisibilityModifier 10  Error
javadoc JavadocMethod 10  Error
JavadocPackage 1  Error
JavadocStyle 1  Error
JavadocType 2  Error
JavadocVariable 23  Error
misc FinalParameters 12  Error
TodoComment 2  Error
modifier ModifierOrder 1  Error
sizes LineLength 18  Error
whitespace ParenPad 4  Error
WhitespaceAfter 1  Error
WhitespaceAround 1  Error

Details

org/apache/streams/hbase/HbasePersistReader.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 42
 Error javadoc JavadocVariable Missing a Javadoc comment. 44
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 44
 Error sizes LineLength Line is longer than 80 characters (found 91). 46
 Error javadoc JavadocVariable Missing a Javadoc comment. 46
 Error javadoc JavadocVariable Missing a Javadoc comment. 48
 Error design VisibilityModifier Variable 'lock' must be private and have accessor methods. 48
 Error javadoc JavadocVariable Missing a Javadoc comment. 50
 Error design VisibilityModifier Variable 'running' must be private and have accessor methods. 50
 Error javadoc JavadocVariable Missing a Javadoc comment. 52
 Error design VisibilityModifier Variable 'persistQueue' must be private and have accessor methods. 52
 Error javadoc JavadocVariable Missing a Javadoc comment. 54
 Error javadoc JavadocVariable Missing a Javadoc comment. 56
 Error design VisibilityModifier Variable 'config' must be private and have accessor methods. 56
 Error javadoc JavadocVariable Missing a Javadoc comment. 58
 Error design VisibilityModifier Variable 'props' must be private and have accessor methods. 58
 Error javadoc JavadocVariable Missing a Javadoc comment. 60
 Error javadoc JavadocMethod Missing a Javadoc comment. 62
 Error sizes LineLength Line is longer than 80 characters (found 83). 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 67
 Error javadoc JavadocMethod Missing a Javadoc comment. 69
 Error misc FinalParameters Parameter config should be final. 69
 Error coding HiddenField 'config' hides a field. 69
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'setConfig' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'setConfig' static/final/abstract/empty, or adding allowed annotation for the method. 73
 Error javadoc JavadocMethod Missing a Javadoc comment. 73
 Error misc FinalParameters Parameter config should be final. 73
 Error coding HiddenField 'config' hides a field. 73
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 77
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. 82
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'readAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'readAll' static/final/abstract/empty, or adding allowed annotation for the method. 93
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. 98
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'constructQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'constructQueue' static/final/abstract/empty, or adding allowed annotation for the method. 116
 Error javadoc JavadocMethod Missing a Javadoc comment. 116
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. 120
 Error misc FinalParameters Parameter bigInteger should be final. 121
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. 125
 Error misc FinalParameters Parameter dateTime should be final. 126
 Error misc FinalParameters Parameter dateTime2 should be final. 126
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. 130
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 135
 Error misc FinalParameters Parameter configurationObject should be final. 136
 Error sizes LineLength Line is longer than 80 characters (found 100). 142
 Error sizes LineLength Line is longer than 80 characters (found 102). 143
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 151
 Error design DesignForExtension Class 'HbasePersistReader' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReader' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. 162
 Error javadoc JavadocMethod Missing a Javadoc comment. 162
 Error misc FinalParameters Parameter streamsDatum should be final. 162

org/apache/streams/hbase/HbasePersistReaderTask.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 24
 Error sizes LineLength Line is longer than 80 characters (found 95). 26
 Error javadoc JavadocVariable Missing a Javadoc comment. 26
 Error javadoc JavadocVariable Missing a Javadoc comment. 28
 Error javadoc JavadocMethod Missing a Javadoc comment. 30
 Error misc FinalParameters Parameter reader should be final. 30
 Error coding HiddenField 'reader' hides a field. 30
 Error design DesignForExtension Class 'HbasePersistReaderTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistReaderTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 34
 Error whitespace WhitespaceAround 'while' is not followed by whitespace. 37
 Error blocks EmptyBlock Must have at least one statement. 37

org/apache/streams/hbase/HbasePersistWriter.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 87). 50
 Error javadoc JavadocVariable Missing a Javadoc comment. 52
 Error sizes LineLength Line is longer than 80 characters (found 89). 54
 Error javadoc JavadocVariable Missing a Javadoc comment. 54
 Error javadoc JavadocVariable Missing a Javadoc comment. 56
 Error design VisibilityModifier Variable 'connection' must be private and have accessor methods. 56
 Error javadoc JavadocVariable Missing a Javadoc comment. 57
 Error design VisibilityModifier Variable 'pool' must be private and have accessor methods. 57
 Error javadoc JavadocVariable Missing a Javadoc comment. 58
 Error design VisibilityModifier Variable 'table' must be private and have accessor methods. 58
 Error javadoc JavadocVariable Missing a Javadoc comment. 59
 Error design VisibilityModifier Variable 'descriptor' must be private and have accessor methods. 59
 Error javadoc JavadocVariable Missing a Javadoc comment. 61
 Error design VisibilityModifier Variable 'persistQueue' must be private and have accessor methods. 61
 Error javadoc JavadocVariable Missing a Javadoc comment. 63
 Error javadoc JavadocVariable Missing a Javadoc comment. 65
 Error sizes LineLength Line is longer than 80 characters (found 82). 68
 Error sizes LineLength Line is longer than 80 characters (found 81). 72
 Error misc TodoComment Comment matches to-do format 'TODO:'. 80
 Error misc FinalParameters Parameter hbaseConfiguration should be final. 81
 Error javadoc JavadocMethod Missing a Javadoc comment. 86
 Error misc TodoComment Comment matches to-do format 'TODO:'. 88
 Error sizes LineLength Line is longer than 80 characters (found 100). 95
 Error coding MagicNumber '1000' is a magic number. 96
 Error coding MagicNumber '1000' is a magic number. 98
 Error sizes LineLength Line is longer than 80 characters (found 103). 129
 Error design DesignForExtension Class 'HbasePersistWriter' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistWriter' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 134
 Error design DesignForExtension Class 'HbasePersistWriter' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistWriter' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. 139
 Error misc FinalParameters Parameter streamsDatum should be final. 140
 Error whitespace ParenPad '(' is followed by whitespace. 150
 Error whitespace ParenPad ')' is preceded with whitespace. 150
 Error sizes LineLength Line is longer than 80 characters (found 86). 152
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 152
 Error sizes LineLength Line is longer than 80 characters (found 88). 160
 Error sizes LineLength Line is longer than 80 characters (found 88). 163
 Error sizes LineLength Line is longer than 80 characters (found 88). 177
 Error sizes LineLength Line is longer than 80 characters (found 88). 180
 Error sizes LineLength Line is longer than 80 characters (found 85). 189
 Error design DesignForExtension Class 'HbasePersistWriter' looks like designed for extension (can be subclassed), but the method 'flush' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistWriter' final or making the method 'flush' static/final/abstract/empty, or adding allowed annotation for the method. 194
 Error javadoc JavadocMethod Missing a Javadoc comment. 194
 Error design DesignForExtension Class 'HbasePersistWriter' looks like designed for extension (can be subclassed), but the method 'close' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistWriter' final or making the method 'close' static/final/abstract/empty, or adding allowed annotation for the method. 198
 Error javadoc JavadocMethod Missing a Javadoc comment. 198
 Error design DesignForExtension Class 'HbasePersistWriter' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistWriter' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 202
 Error misc FinalParameters Parameter configurationObject should be final. 203
 Error design DesignForExtension Class 'HbasePersistWriter' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistWriter' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 218

org/apache/streams/hbase/HbasePersistWriterTask.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocStyle First sentence should end with a period. 28
 Error sizes LineLength Line is longer than 80 characters (found 93). 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 36
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error misc FinalParameters Parameter writer should be final. 38
 Error coding HiddenField 'writer' hides a field. 38
 Error design DesignForExtension Class 'HbasePersistWriterTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HbasePersistWriterTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 42
 Error whitespace ParenPad '(' is followed by whitespace. 46
 Error whitespace ParenPad ')' is preceded with whitespace. 46