streams-persist-cassandra – Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
3	0	0	183

Files

File	I	W	E
org/apache/streams/cassandra/CassandraClient.java	0	0	42
org/apache/streams/cassandra/CassandraPersistReader.java	0	0	72
org/apache/streams/cassandra/CassandraPersistWriter.java	0	0	69

Rules

Category	Rule	Violations	Severity
coding	HiddenField	7	Error
	MagicNumber	6	Error
	SimplifyBooleanExpression	1	Error
design	DesignForExtension	29	Error
	VisibilityModifier	8	Error
imports	UnusedImports processJavadoc: `"false"`	13	Error
javadoc	JavadocMethod	23	Error
	JavadocPackage	1	Error
	JavadocType	3	Error
	JavadocVariable	28	Error
misc	FinalParameters	15	Error
	NewlineAtEndOfFile	2	Error
sizes	LineLength	28	Error
whitespace	OperatorWrap	1	Error
	ParenPad	8	Error
	WhitespaceAround	10	Error

Details

org/apache/streams/cassandra/CassandraClient.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocType	Missing a Javadoc comment.	46
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	48
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	51
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	52
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	54
Error	design	VisibilityModifier	Variable 'config' must be private and have accessor methods.	54
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	56
Error	misc	FinalParameters	Parameter config should be final.	56
Error	coding	HiddenField	'config' hides a field.	56
Error	design	DesignForExtension	Class 'CassandraClient' looks like designed for extension (can be subclassed), but the method 'start' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraClient' final or making the method 'start' static/final/abstract/empty, or adding allowed annotation for the method.	61
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	61
Error	whitespace	WhitespaceAround	'*' is not preceded with whitespace.	73
Error	whitespace	WhitespaceAround	'*' is not followed by whitespace.	73
Error	coding	MagicNumber	'10' is a magic number.	73
Error	whitespace	WhitespaceAround	'*' is not preceded with whitespace.	74
Error	whitespace	WhitespaceAround	'*' is not followed by whitespace.	74
Error	coding	MagicNumber	'10' is a magic number.	74
Error	whitespace	WhitespaceAround	'if' is not followed by whitespace.	77
Error	whitespace	ParenPad	'(' is followed by whitespace.	77
Error	coding	SimplifyBooleanExpression	Expression can be simplified.	77
Error	sizes	LineLength	Line is longer than 80 characters (found 107).	88
Error	sizes	LineLength	Line is longer than 80 characters (found 101).	91
Error	sizes	LineLength	Line is longer than 80 characters (found 94).	107
Error	whitespace	WhitespaceAround	'if' is not followed by whitespace.	112
Error	whitespace	ParenPad	'(' is followed by whitespace.	112
Error	whitespace	OperatorWrap	'&&' should be on a new line.	112
Error	whitespace	ParenPad	'(' is followed by whitespace.	124
Error	whitespace	ParenPad	')' is preceded with whitespace.	124
Error	whitespace	WhitespaceAround	'catch' is not followed by whitespace.	128
Error	whitespace	ParenPad	'(' is followed by whitespace.	128
Error	whitespace	ParenPad	')' is preceded with whitespace.	128
Error	whitespace	WhitespaceAround	'catch' is not followed by whitespace.	135
Error	whitespace	ParenPad	'(' is followed by whitespace.	135
Error	whitespace	ParenPad	')' is preceded with whitespace.	135
Error	design	DesignForExtension	Class 'CassandraClient' looks like designed for extension (can be subclassed), but the method 'stop' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraClient' final or making the method 'stop' static/final/abstract/empty, or adding allowed annotation for the method.	144
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	144
Error	design	DesignForExtension	Class 'CassandraClient' looks like designed for extension (can be subclassed), but the method 'config' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraClient' final or making the method 'config' static/final/abstract/empty, or adding allowed annotation for the method.	149
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	149
Error	design	DesignForExtension	Class 'CassandraClient' looks like designed for extension (can be subclassed), but the method 'client' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraClient' final or making the method 'client' static/final/abstract/empty, or adding allowed annotation for the method.	153
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	153
Error	design	DesignForExtension	Class 'CassandraClient' looks like designed for extension (can be subclassed), but the method 'cluster' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraClient' final or making the method 'cluster' static/final/abstract/empty, or adding allowed annotation for the method.	157
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	157

org/apache/streams/cassandra/CassandraPersistReader.java

Severity	Category	Rule	Message	Line
Error	misc	NewlineAtEndOfFile	File does not end with a newline.
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.Cluster.	29
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.DataType.	30
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.KeyspaceMetadata.	31
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.Metadata.	32
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.Session.	35
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.TableMetadata.	36
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.schemabuilder.SchemaBuilder.	38
Error	imports	UnusedImports	Unused import - org.apache.commons.lang3.StringUtils.	42
Error	imports	UnusedImports	Unused import - java.util.HashMap.	49
Error	imports	UnusedImports	Unused import - java.util.Map.	51
Error	imports	UnusedImports	Unused import - java.util.Objects.	52
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	67
Error	sizes	LineLength	Line is longer than 80 characters (found 92).	69
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	69
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	71
Error	design	VisibilityModifier	Variable 'persistQueue' must be private and have accessor methods.	71
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	73
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	75
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	76
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	76
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	78
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	79
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	81
Error	design	VisibilityModifier	Variable 'rowIterator' must be private and have accessor methods.	81
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	83
Error	design	VisibilityModifier	Variable 'lock' must be private and have accessor methods.	83
Error	sizes	LineLength	Line is longer than 80 characters (found 95).	86
Error	sizes	LineLength	Line is longer than 80 characters (found 83).	90
Error	misc	FinalParameters	Parameter config should be final.	97
Error	coding	HiddenField	'config' hides a field.	97
Error	misc	FinalParameters	Parameter persistQueue should be final.	105
Error	coding	HiddenField	'persistQueue' hides a field.	105
Error	sizes	LineLength	Line is longer than 80 characters (found 83).	107
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'setPersistQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'setPersistQueue' static/final/abstract/empty, or adding allowed annotation for the method.	111
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	111
Error	misc	FinalParameters	Parameter persistQueue should be final.	111
Error	coding	HiddenField	'persistQueue' hides a field.	111
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'getPersistQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'getPersistQueue' static/final/abstract/empty, or adding allowed annotation for the method.	115
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	115
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	119
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method.	122
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method.	127
Error	misc	FinalParameters	Parameter configurationObject should be final.	128
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method.	150
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'prepareDatum' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'prepareDatum' static/final/abstract/empty, or adding allowed annotation for the method.	155
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	155
Error	misc	FinalParameters	Parameter row should be final.	155
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	169
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'readAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'readAll' static/final/abstract/empty, or adding allowed annotation for the method.	175
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method.	189
Error	sizes	LineLength	Line is longer than 80 characters (found 81).	192
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method.	207
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method.	224
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	224
Error	misc	FinalParameters	Parameter entry should be final.	224
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method.	238
Error	misc	FinalParameters	Parameter sequence should be final.	239
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method.	243
Error	misc	FinalParameters	Parameter start should be final.	244
Error	misc	FinalParameters	Parameter end should be final.	244
Error	design	DesignForExtension	Class 'CassandraPersistReader' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReader' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method.	248
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	253
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	254
Error	coding	MagicNumber	'10000' is a magic number.	254
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	257
Error	javadoc	JavadocType	Missing a Javadoc comment.	263
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	265
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	267
Error	misc	FinalParameters	Parameter reader should be final.	267
Error	coding	HiddenField	'reader' hides a field.	267
Error	design	DesignForExtension	Class 'CassandraPersistReaderTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistReaderTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method.	271

org/apache/streams/cassandra/CassandraPersistWriter.java

Severity	Category	Rule	Message	Line
Error	misc	NewlineAtEndOfFile	File does not end with a newline.
Error	javadoc	JavadocPackage	Missing package-info.java file.
Error	imports	UnusedImports	Unused import - com.datastax.driver.core.Cluster.	30
Error	imports	UnusedImports	Unused import - org.apache.commons.lang3.StringUtils.	42
Error	sizes	LineLength	Line is longer than 80 characters (found 101).	65
Error	javadoc	JavadocType	Missing a Javadoc comment.	65
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	67
Error	sizes	LineLength	Line is longer than 80 characters (found 93).	69
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	69
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	71
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	73
Error	design	VisibilityModifier	Variable 'persistQueue' must be private and have accessor methods.	73
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	75
Error	sizes	LineLength	Line is longer than 80 characters (found 85).	76
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	76
Error	sizes	LineLength	Line is longer than 80 characters (found 102).	77
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	77
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	79
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	80
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	82
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	84
Error	design	VisibilityModifier	Variable 'insertStatement' must be private and have accessor methods.	84
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	86
Error	design	VisibilityModifier	Variable 'insertBatch' must be private and have accessor methods.	86
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	88
Error	design	VisibilityModifier	Variable 'lock' must be private and have accessor methods.	88
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	90
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	92
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	95
Error	misc	FinalParameters	Parameter config should be final.	95
Error	coding	HiddenField	'config' hides a field.	95
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'setPersistQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'setPersistQueue' static/final/abstract/empty, or adding allowed annotation for the method.	99
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	99
Error	misc	FinalParameters	Parameter persistQueue should be final.	99
Error	coding	HiddenField	'persistQueue' hides a field.	99
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'getPersistQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'getPersistQueue' static/final/abstract/empty, or adding allowed annotation for the method.	103
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	103
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method.	107
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method.	112
Error	misc	FinalParameters	Parameter streamsDatum should be final.	113
Error	sizes	LineLength	Line is longer than 80 characters (found 87).	119
Error	whitespace	WhitespaceAround	'if' is not followed by whitespace.	124
Error	sizes	LineLength	Line is longer than 80 characters (found 85).	128
Error	sizes	LineLength	Line is longer than 80 characters (found 88).	131
Error	whitespace	WhitespaceAround	'if' is not followed by whitespace.	141
Error	sizes	LineLength	Line is longer than 80 characters (found 85).	145
Error	sizes	LineLength	Line is longer than 80 characters (found 88).	148
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'flush' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'flush' static/final/abstract/empty, or adding allowed annotation for the method.	156
Error	sizes	LineLength	Line is longer than 80 characters (found 84).	159
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'close' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'close' static/final/abstract/empty, or adding allowed annotation for the method.	173
Error	coding	MagicNumber	'15' is a magic number.	220
Error	coding	MagicNumber	'15' is a magic number.	223
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method.	235
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method.	254
Error	misc	FinalParameters	Parameter configurationObject should be final.	255
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method.	260
Error	design	DesignForExtension	Class 'CassandraPersistWriter' looks like designed for extension (can be subclassed), but the method 'flushIfNecessary' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CassandraPersistWriter' final or making the method 'flushIfNecessary' static/final/abstract/empty, or adding allowed annotation for the method.	265
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	265
Error	sizes	LineLength	Line is longer than 80 characters (found 115).	267
Error	sizes	LineLength	Line is longer than 80 characters (found 103).	269
Error	coding	MagicNumber	'100' is a magic number.	269
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	278
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	282
Error	sizes	LineLength	Line is longer than 80 characters (found 89).	285
Error	sizes	LineLength	Line is longer than 80 characters (found 91).	290
Error	sizes	LineLength	Line is longer than 80 characters (found 117).	301
Error	sizes	LineLength	Line is longer than 80 characters (found 100).	303
Error	sizes	LineLength	Line is longer than 80 characters (found 97).	304
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	310