Violation | Line |
---|---|
DE: org.apache.turbine.Turbine.handleException(org.apache.turbine.util.RunData,javax.servlet.http.HttpServletResponse,Throwable) might ignore java.lang.Exception | 1021 |
Dm: org.apache.turbine.Turbine.destroy() forces garbage collection; extremely dubious except in benchmarking code | 632 |
ST: Write to static field org.apache.turbine.Turbine.initFailure from instance method org.apache.turbine.Turbine.init() | 214 |
ST: Write to static field org.apache.turbine.Turbine.firstInit from instance method org.apache.turbine.Turbine.destroy() | 634 |
ST: Write to static field org.apache.turbine.Turbine.firstDoGet from instance method org.apache.turbine.Turbine.destroy() | 635 |
DLS: Dead store to local variable in method org.apache.turbine.Turbine.configure(javax.servlet.ServletConfig,javax.servlet.ServletContext) | 293 |
REC: Method org.apache.turbine.Turbine.handleException(org.apache.turbine.util.RunData,javax.servlet.http.HttpServletResponse,Throwable) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 1056 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 160 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 163 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 166 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 201 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 202 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 389 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 670 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 685 |
MTIA: Class org.apache.turbine.Turbine extends Servlet class and uses instance variables. | 769 |
Violation | Line |
---|---|
CN: clone method org.apache.turbine.util.ServerData.clone() does not call super.clone() | 136 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.util.ObjectUtils.deserialize(byte[]) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 158 |
Violation | Line |
---|---|
SA: Self assignment of local variable in org.apache.turbine.util.ServletUtils.expandRelative(javax.servlet.ServletConfig,String) | 99 |
Violation | Line |
---|---|
HE: org.apache.turbine.util.StringStackBuffer defines equals and uses Object.hashCode() | 0 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.util.ContentURI.init(RunData) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 94 |
Violation | Line |
---|---|
Dm: Method org.apache.turbine.modules.ActionEvent.formatString(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 229 |
SA: Self assignment of local variable in org.apache.turbine.modules.ActionEvent.formatString(String) | 232 |
Violation | Line |
---|---|
EI: org.apache.turbine.services.template.BaseTemplateEngineService.getTemplateEngineServiceConfiguration() may expose internal representation by returning org.apache.turbine.services.template.BaseTemplateEngineService.configuration | 64 |
MF: Class org.apache.turbine.services.template.BaseTemplateEngineService defines field that obscures superclass field org.apache.turbine.services.BaseService.configuration | 0 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.naming.TurbineNamingService.init(org.apache.turbine.util.RunData) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 158 |
Violation | Line |
---|---|
Nm: The method name org.apache.turbine.util.pool.RecyclableSupport.Recyclable() doesn't start with an lower case letter | 39 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.pool.TurbinePoolService$PoolBuffer.poll(Object[],String[]) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 226 |
IS2: Inconsistent synchronization of org.apache.turbine.services.pool.TurbinePoolService$PoolBuffer.recyclers; locked 75% of time | 286 |
Violation | Line |
---|---|
SA: Self assignment of local variable in org.apache.turbine.services.pool.TurbinePoolService.getCapacity(String) | 551 |
SA: Self assignment of local variable in org.apache.turbine.services.pool.TurbinePoolService.setCapacity(String,int) | 574 |
UwF: Field not initialized in constructor: org.apache.turbine.services.pool.TurbinePoolService.factoryService | 0 |
Violation | Line |
---|---|
DE: org.apache.turbine.services.intake.TurbineIntakeService.getFieldSetter(String,String) might ignore java.lang.Exception | 705 |
DE: org.apache.turbine.services.intake.TurbineIntakeService.getFieldGetter(String,String) might ignore java.lang.Exception | 790 |
RV: org.apache.turbine.services.intake.TurbineIntakeService.saveSerialized(String,java.util.Map) ignores return value of java.io.File.createNewFile() | 451 |
RV: org.apache.turbine.services.intake.TurbineIntakeService.releaseGroup(org.apache.turbine.services.intake.model.Group) ignores return value of org.apache.turbine.services.intake.IntakeException.<init>(String,Throwable) | 570 |
SA: Self assignment of local variable in org.apache.turbine.services.intake.TurbineIntakeService.init() | 176 |
ITA: Method org.apache.turbine.services.intake.TurbineIntakeService.getGroupNames() uses Collection.toArray() with zero-length array argument | 606 |
DLS: Dead store to local variable in method org.apache.turbine.services.intake.TurbineIntakeService.saveSerialized(String,java.util.Map) | 476 |
WMI: Method org.apache.turbine.services.intake.TurbineIntakeService.init() makes inefficient use of keySet iterator instead of entrySet iterator | 239 |
REC: Method org.apache.turbine.services.intake.TurbineIntakeService.init() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 274 |
REC: Method org.apache.turbine.services.intake.TurbineIntakeService.loadSerialized(String,long) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 398 |
REC: Method org.apache.turbine.services.intake.TurbineIntakeService.saveSerialized(String,java.util.Map) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 480 |
UwF: Field not initialized in constructor: org.apache.turbine.services.intake.TurbineIntakeService.getterMap | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.services.intake.TurbineIntakeService.groupKeyMap | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.services.intake.TurbineIntakeService.groupNameMap | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.services.intake.TurbineIntakeService.groupNames | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.services.intake.TurbineIntakeService.keyedPools | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.services.intake.TurbineIntakeService.setterMap | 0 |
Violation | Line |
---|---|
RCN: Redundant nullcheck of value known to be non-null org.apache.turbine.services.pull.TurbinePullService.populateWithSessionTools(java.util.List,org.apache.velocity.context.Context,org.apache.turbine.util.RunData,org.apache.turbine.om.security.User) | 512 |
Violation | Line |
---|---|
DE: org.apache.turbine.services.velocity.TurbineVelocityService.handleRequest(org.apache.velocity.context.Context,String,java.io.OutputStream) might ignore java.lang.Exception | 343 |
DE: org.apache.turbine.services.velocity.TurbineVelocityService.handleRequest(org.apache.velocity.context.Context,String,java.io.Writer) might ignore java.lang.Exception | 383 |
Violation | Line |
---|---|
Dm: Method org.apache.turbine.services.security.BaseSecurityService.encryptPassword(String,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 151 |
DC: Possible doublecheck on org.apache.turbine.services.security.BaseSecurityService.globalGroup in org.apache.turbine.services.security.BaseSecurityService.getGlobalGroup() | 952 |
No: Using notify rather than notifyAll in org.apache.turbine.services.security.BaseSecurityService.unlockShared() | 906 |
ITA: Method org.apache.turbine.services.security.BaseSecurityService.getUsers(org.apache.torque.util.Criteria) uses Collection.toArray() with zero-length array argument | 727 |
PS: Class org.apache.turbine.services.security.BaseSecurityService exposes synchronization and semaphores in its public interface. | 906 |
Violation | Line |
---|---|
PZLA: Should org.apache.turbine.services.factory.TurbineFactoryService.getSignature(Class,Object[],String[]) return a zero length array rather than null? | 454 |
ST: Write to static field org.apache.turbine.services.factory.TurbineFactoryService.primitiveClasses from instance method org.apache.turbine.services.factory.TurbineFactoryService.<init>() | 62 |
REC: Method org.apache.turbine.services.factory.TurbineFactoryService.switchObjectContext(Object,ClassLoader) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 490 |
Violation | Line |
---|---|
ST: Write to static field org.apache.turbine.services.uniqueid.TurbineUniqueIdService.turbineId from instance method org.apache.turbine.services.uniqueid.TurbineUniqueIdService.init() | 81 |
REC: Method org.apache.turbine.services.uniqueid.TurbineUniqueIdService.init() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 87 |
MS: org.apache.turbine.services.uniqueid.TurbineUniqueIdService.turbineId should be package protected | 0 |
MS: org.apache.turbine.services.uniqueid.TurbineUniqueIdService.turbineURL isn't final but should be | 0 |
MS: org.apache.turbine.services.uniqueid.TurbineUniqueIdService.counter should be package protected | 0 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.xmlrpc.TurbineXmlRpcService.init() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 242 |
Violation | Line |
---|---|
ST: Write to static field org.apache.turbine.services.xslt.TurbineXSLTService.tfactory from instance method org.apache.turbine.services.xslt.TurbineXSLTService.init() | 92 |
UwF: Field not initialized in constructor: org.apache.turbine.services.xslt.TurbineXSLTService.tfactory | 0 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from org.apache.turbine.services.cache.CachedObject to class org.apache.turbine.services.cache.RefreshableCachedObject in org.apache.turbine.services.cache.TurbineGlobalCacheService.clearCache() | 296 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.util.MissingResourceException in org.apache.turbine.services.localization.TurbineLocalizationService.cacheBundle(String,java.util.Locale) | 365 |
IS2: Inconsistent synchronization of org.apache.turbine.services.localization.TurbineLocalizationService.bundles; locked 75% of time | 317 |
Violation | Line |
---|---|
EI: org.apache.turbine.services.schedule.BaseJobEntry.getProperty() may expose internal representation by returning org.apache.turbine.services.schedule.BaseJobEntry.property | 299 |
EI2: org.apache.turbine.services.schedule.BaseJobEntry.setProperty(byte[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.schedule.BaseJobEntry.property | 313 |
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.schedule.BaseJobEntry.setPrimaryKey(org.apache.torque.om.ObjectKey) | 578 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in org.apache.turbine.services.schedule.BaseJobEntryPeer.setDbName(org.apache.torque.util.Criteria) | 843 |
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.lang.Error in org.apache.turbine.services.schedule.BaseJobEntryPeer.initClass(String) | 142 |
Violation | Line |
---|---|
No: Using notify rather than notifyAll in org.apache.turbine.services.schedule.TurbineSchedulerService.restart() | 336 |
PS: Class org.apache.turbine.services.schedule.TurbineSchedulerService exposes synchronization and semaphores in its public interface. | 336 |
Violation | Line |
---|---|
RCN: Redundant nullcheck of value known to be non-null org.apache.turbine.services.schedule.TurbineNonPersistentSchedulerService.init() | 142 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.avaloncomponent.TurbineAvalonComponentService.initialize() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 192 |
Violation | Line |
---|---|
Dm: Method org.apache.turbine.services.upload.BaseUploadService.init() invokes toString() method on a String; just use the String | 57 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.services.upload.TurbineUpload.isAvailable() | 64 |
Violation | Line |
---|---|
Dm: org.apache.turbine.util.parser.BaseValueParser.getBool(String,boolean) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | 471 |
PZLA: Should org.apache.turbine.util.parser.BaseValueParser.getParam(String) return a zero length array rather than null? | 1826 |
Violation | Line |
---|---|
EI2: org.apache.turbine.util.parser.DefaultParameterParser.setUploadData(byte[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.parser.DefaultParameterParser.uploadData | 264 |
EI: org.apache.turbine.util.parser.DefaultParameterParser.getUploadData() may expose internal representation by returning org.apache.turbine.util.parser.DefaultParameterParser.uploadData | 274 |
PZLA: Should org.apache.turbine.util.parser.DefaultParameterParser.getFileItemParam(String) return a zero length array rather than null? | 395 |
REC: Method org.apache.turbine.util.parser.DefaultParameterParser.setRequest(javax.servlet.http.HttpServletRequest) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 236 |
RI: Class org.apache.turbine.util.parser.DefaultParameterParser implements same interface as superclass. | 0 |
Violation | Line |
---|---|
Dm: Method org.apache.turbine.util.parser.ParserUtils.convertAndTrim(String,int) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 105 |
Dm: Method org.apache.turbine.util.parser.ParserUtils.convertAndTrim(String,int) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 110 |
Dm: Method org.apache.turbine.util.parser.ParserUtils.getUrlFolding() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 133 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.util.parser.DefaultCookieParser implements same interface as superclass. | 0 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.util.uri.DataURI implements same interface as superclass. | 0 |
Violation | Line |
---|---|
ITA: Method org.apache.turbine.util.security.RoleSet.getRolesArray() uses Collection.toArray() with zero-length array argument | 195 |
Violation | Line |
---|---|
ITA: Method org.apache.turbine.util.security.PermissionSet.getPermissionsArray() uses Collection.toArray() with zero-length array argument | 197 |
Violation | Line |
---|---|
ITA: Method org.apache.turbine.util.security.GroupSet.getGroupsArray() uses Collection.toArray() with zero-length array argument | 195 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.util.security.TurbineAccessControlList.hasRole(String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 209 |
REC: Method org.apache.turbine.util.security.TurbineAccessControlList.hasRole(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 277 |
REC: Method org.apache.turbine.util.security.TurbineAccessControlList.hasPermission(String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 344 |
REC: Method org.apache.turbine.util.security.TurbineAccessControlList.hasPermission(String,org.apache.turbine.om.security.Group) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 364 |
REC: Method org.apache.turbine.util.security.TurbineAccessControlList.hasPermission(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 432 |
Violation | Line |
---|---|
DE: org.apache.turbine.util.template.TemplateInfo.setScreenTemplate(String) might ignore java.lang.Exception | 111 |
Violation | Line |
---|---|
EI2: org.apache.turbine.util.template.SelectorBox.<init>(String,Object[],Object[],int,boolean[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.template.SelectorBox.names | 138 |
EI2: org.apache.turbine.util.template.SelectorBox.<init>(String,Object[],Object[],int,boolean[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.template.SelectorBox.values | 139 |
EI2: org.apache.turbine.util.template.SelectorBox.<init>(String,Object[],Object[],int,boolean[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.template.SelectorBox.selected | 141 |
EI2: org.apache.turbine.util.template.SelectorBox.setSelected(boolean[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.template.SelectorBox.selected | 289 |
Violation | Line |
---|---|
HE: org.apache.turbine.util.db.TableColumn defines equals and uses Object.hashCode() | 0 |
Violation | Line |
---|---|
RV: org.apache.turbine.util.db.UUIdGenerator.<init>() checks to see if result of String.indexOf is positive | 102 |
RV: org.apache.turbine.util.db.UUIdGenerator.<init>() checks to see if result of String.indexOf is positive | 131 |
IS2: Inconsistent synchronization of org.apache.turbine.util.db.UUIdGenerator.counter; locked 66% of time | 196 |
Violation | Line |
---|---|
EI2: org.apache.turbine.util.mail.ByteArrayDataSource.<init>(byte[],String) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.mail.ByteArrayDataSource.data | 61 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.util.mail.Email.send() | 400 |
REC: Method org.apache.turbine.util.mail.Email.setFrom(String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 228 |
UwF: Field not initialized in constructor: org.apache.turbine.util.mail.Email.bccList | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.util.mail.Email.ccList | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.util.mail.Email.replyList | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.util.mail.Email.toList | 0 |
Violation | Line |
---|---|
EI2: org.apache.turbine.util.mail.MailMessage.setBcc(javax.mail.internet.InternetAddress[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.mail.MailMessage.bcc | 474 |
EI2: org.apache.turbine.util.mail.MailMessage.setCc(javax.mail.internet.InternetAddress[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.mail.MailMessage.cc | 506 |
EI2: org.apache.turbine.util.mail.MailMessage.setHeaders(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.mail.MailMessage.headers | 598 |
EI2: org.apache.turbine.util.mail.MailMessage.setReplyTo(javax.mail.internet.InternetAddress[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.mail.MailMessage.replyTo | 619 |
EI2: org.apache.turbine.util.mail.MailMessage.setTo(javax.mail.internet.InternetAddress[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.util.mail.MailMessage.to | 651 |
UR: Uninitialized read of org.apache.turbine.util.mail.MailMessage.cc in org.apache.turbine.util.mail.MailMessage.<init>(String,String,String,String,String,String,String,boolean) | 181 |
Violation | Line |
---|---|
EI: org.apache.turbine.util.upload.FileItem.get() may expose internal representation by returning org.apache.turbine.util.upload.FileItem.content | 199 |
RR: org.apache.turbine.util.upload.FileItem.get() ignores result of java.io.FileInputStream.read(byte[]) | 186 |
NP: Possible null pointer dereference in org.apache.turbine.util.upload.FileItem.write(String) on exception path | 413 |
NP: Possible null pointer dereference in org.apache.turbine.util.upload.FileItem.write(String) on exception path | 421 |
OS: org.apache.turbine.util.upload.FileItem.get() may fail to close stream | 185 |
REC: Method org.apache.turbine.util.upload.FileItem.get() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 188 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.util.upload.MultipartStream.readBodyData(java.io.OutputStream) | 415 |
DLS: Dead store to local variable in method org.apache.turbine.util.upload.MultipartStream.discardBodyData() | 486 |
MS: org.apache.turbine.util.upload.MultipartStream.HEADER_SEPARATOR should be package protected | 0 |
MS: org.apache.turbine.util.upload.MultipartStream.FIELD_SEPARATOR should be package protected | 0 |
MS: org.apache.turbine.util.upload.MultipartStream.STREAM_TERMINATOR should be package protected | 0 |
Violation | Line |
---|---|
Nm: The field name org.apache.turbine.util.validation.InputValidator.NullInputError doesn't start with an lower case letter | 0 |
Nm: The field name org.apache.turbine.util.validation.InputValidator.MaxSizeExceededError doesn't start with an lower case letter | 0 |
UrF: Unread field: org.apache.turbine.util.validation.InputValidator.argv | 0 |
Violation | Line |
---|---|
EI: org.apache.turbine.om.security.TurbineUser.getCreateDate() may expose internal representation by returning org.apache.turbine.om.security.TurbineUser.createDate | 125 |
EI: org.apache.turbine.om.security.TurbineUser.getLastAccessDate() may expose internal representation by returning org.apache.turbine.om.security.TurbineUser.lastAccessDate | 140 |
EI: org.apache.turbine.om.security.TurbineUser.getPermStorage() may expose internal representation by returning org.apache.turbine.om.security.TurbineUser.permStorage | 212 |
EI2: org.apache.turbine.om.security.TurbineUser.setCreateDate(java.util.Date) may expose internal representation by storing an externally mutable object into org.apache.turbine.om.security.TurbineUser.createDate | 393 |
EI2: org.apache.turbine.om.security.TurbineUser.setPermStorage(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org.apache.turbine.om.security.TurbineUser.permStorage | 438 |
EI: org.apache.turbine.om.security.TurbineUser.getTempStorage() may expose internal representation by returning org.apache.turbine.om.security.TurbineUser.tempStorage | 453 |
EI2: org.apache.turbine.om.security.TurbineUser.setTempStorage(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org.apache.turbine.om.security.TurbineUser.tempStorage | 464 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.modules.actions.LoginUser.doPerform(org.apache.turbine.util.RunData) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 111 |
Violation | Line |
---|---|
WMI: Method org.apache.turbine.modules.actions.InitContextsAction.doPerform(org.apache.turbine.util.RunData) makes inefficient use of keySet iterator instead of entrySet iterator | 86 |
Violation | Line |
---|---|
DE: org.apache.turbine.modules.screens.TemplateScreen.setTemplate(org.apache.turbine.util.RunData,String) might ignore java.lang.Exception | 133 |
Violation | Line |
---|---|
WMI: Method org.apache.turbine.modules.screens.Error.doBuild(org.apache.turbine.util.RunData) makes inefficient use of keySet iterator instead of entrySet iterator | 74 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.template.mapper.ClassMapper.doMapping(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 147 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.services.template.mapper.ScreenDefaultTemplateMapper.doMapping(String) | 79 |
Violation | Line |
---|---|
DE: org.apache.turbine.services.intake.model.Group.setValidProperties(Object) might ignore java.lang.Exception | 398 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from org.apache.turbine.util.parser.ValueParser to class org.apache.turbine.util.parser.ParameterParser in org.apache.turbine.services.intake.model.FileItemField.init(org.apache.turbine.util.parser.ValueParser) | 119 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.services.intake.validator.LongValidator.assertValidity(String) | 113 |
Violation | Line |
---|---|
Dm: Method org.apache.turbine.services.intake.xmlmodel.XmlField.getVariable() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 323 |
Violation | Line |
---|---|
Dm: Method org.apache.turbine.services.intake.xmlmodel.XmlGroup.getVariable() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 255 |
Violation | Line |
---|---|
UI: Usage of GetResource in org.apache.turbine.services.intake.transform.DTDResolver.<init>() may be unsafe if class is extended | 58 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.pull.util.UIManager.loadSkin() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 438 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.init(org.apache.commons.configuration.Configuration) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 146 |
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.buildCriteria(org.apache.turbine.om.security.Role) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 384 |
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.doUpdate(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 412 |
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.doInsert(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 438 |
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.doSelect(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 468 |
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.doDelete(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 505 |
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.getPersistenceClass() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 661 |
REC: Method org.apache.turbine.services.security.torque.RolePeerManager.getNewRole(org.apache.torque.om.Persistent) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 696 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.turbine.services.security.torque.TorqueRole in org.apache.turbine.services.security.torque.RolePeerManager.buildCriteria(org.apache.turbine.om.security.Role) | 377 |
Violation | Line |
---|---|
EI: org.apache.turbine.services.security.torque.TorqueUser.getLastAccessDate() may expose internal representation by returning org.apache.turbine.services.security.torque.TorqueUser.lastAccessDate | 531 |
EI: org.apache.turbine.services.security.torque.TorqueUser.getPermStorage() may expose internal representation by returning org.apache.turbine.services.security.torque.TorqueUser.permStorage | 567 |
EI2: org.apache.turbine.services.security.torque.TorqueUser.setPermStorage(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.torque.TorqueUser.permStorage | 580 |
EI: org.apache.turbine.services.security.torque.TorqueUser.getTempStorage() may expose internal representation by returning org.apache.turbine.services.security.torque.TorqueUser.tempStorage | 596 |
EI2: org.apache.turbine.services.security.torque.TorqueUser.setTempStorage(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.torque.TorqueUser.tempStorage | 609 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.TorqueGroup implements same interface as superclass. | 0 |
CD: Class org.apache.turbine.services.security.torque.TorqueGroup has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.TorqueRole implements same interface as superclass. | 0 |
CD: Class org.apache.turbine.services.security.torque.TorqueRole has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.init(org.apache.commons.configuration.Configuration) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 146 |
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.buildCriteria(org.apache.turbine.om.security.Permission) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 404 |
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.doUpdate(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 432 |
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.doInsert(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 458 |
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.doSelect(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 488 |
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.doDelete(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 526 |
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.getPersistenceClass() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 682 |
REC: Method org.apache.turbine.services.security.torque.PermissionPeerManager.getNewPermission(org.apache.torque.om.Persistent) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 716 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.turbine.services.security.torque.TorquePermission in org.apache.turbine.services.security.torque.PermissionPeerManager.buildCriteria(org.apache.turbine.om.security.Permission) | 397 |
Violation | Line |
---|---|
ITA: Method org.apache.turbine.services.security.torque.TorqueUserManager.retrieve(org.apache.torque.util.Criteria) uses Collection.toArray() with zero-length array argument | 189 |
Violation | Line |
---|---|
PZLA: Should org.apache.turbine.services.security.torque.UserPeerManager.getUserObjectdata(org.apache.torque.om.Persistent) return a zero length array rather than null? | 1354 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.init(org.apache.commons.configuration.Configuration) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 281 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.buildCriteria(org.apache.turbine.om.security.User) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 650 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.doUpdate(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 678 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.doInsert(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 704 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.doSelect(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 734 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.doDelete(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 771 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.getPersistenceClass() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 1461 |
REC: Method org.apache.turbine.services.security.torque.UserPeerManager.getNewUser(org.apache.torque.om.Persistent) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 1495 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.turbine.services.security.torque.TorqueUser in org.apache.turbine.services.security.torque.UserPeerManager.buildCriteria(org.apache.turbine.om.security.User) | 643 |
CD: Class org.apache.turbine.services.security.torque.UserPeerManager has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.services.security.torque.TorqueSecurityService.getGroups(org.apache.torque.util.Criteria) | 506 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.torque.TorqueSecurityService.getRoles(org.apache.torque.util.Criteria) | 537 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.torque.TorqueSecurityService.getPermissions(org.apache.torque.util.Criteria) | 568 |
WMI: Method org.apache.turbine.services.security.torque.TorqueSecurityService.getGroups(org.apache.torque.util.Criteria) makes inefficient use of keySet iterator instead of entrySet iterator | 503 |
WMI: Method org.apache.turbine.services.security.torque.TorqueSecurityService.getRoles(org.apache.torque.util.Criteria) makes inefficient use of keySet iterator instead of entrySet iterator | 534 |
WMI: Method org.apache.turbine.services.security.torque.TorqueSecurityService.getPermissions(org.apache.torque.util.Criteria) makes inefficient use of keySet iterator instead of entrySet iterator | 565 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.init(org.apache.commons.configuration.Configuration) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 129 |
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.buildCriteria(org.apache.turbine.om.security.Group) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 348 |
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.doUpdate(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 376 |
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.doInsert(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 402 |
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.doSelect(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 431 |
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.doDelete(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 469 |
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.getPersistenceClass() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 626 |
REC: Method org.apache.turbine.services.security.torque.GroupPeerManager.getNewGroup(org.apache.torque.om.Persistent) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 660 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.turbine.services.security.torque.TorqueGroup in org.apache.turbine.services.security.torque.GroupPeerManager.buildCriteria(org.apache.turbine.om.security.Group) | 341 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.TorquePermission implements same interface as superclass. | 0 |
CD: Class org.apache.turbine.services.security.torque.TorquePermission has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.services.security.ldap.LDAPSecurityService.getACL(org.apache.turbine.om.security.User) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 136 |
Violation | Line |
---|---|
EI: org.apache.turbine.services.security.ldap.LDAPUser.getCreateDate() may expose internal representation by returning org.apache.turbine.services.security.ldap.LDAPUser.createDate | 338 |
EI: org.apache.turbine.services.security.ldap.LDAPUser.getLastAccessDate() may expose internal representation by returning org.apache.turbine.services.security.ldap.LDAPUser.lastAccessDate | 387 |
EI: org.apache.turbine.services.security.ldap.LDAPUser.getPermStorage() may expose internal representation by returning org.apache.turbine.services.security.ldap.LDAPUser.permStorage | 458 |
EI2: org.apache.turbine.services.security.ldap.LDAPUser.setCreateDate(java.util.Date) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.ldap.LDAPUser.createDate | 665 |
EI2: org.apache.turbine.services.security.ldap.LDAPUser.setPermStorage(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.ldap.LDAPUser.permStorage | 738 |
EI: org.apache.turbine.services.security.ldap.LDAPUser.getTempStorage() may expose internal representation by returning org.apache.turbine.services.security.ldap.LDAPUser.tempStorage | 753 |
EI2: org.apache.turbine.services.security.ldap.LDAPUser.setTempStorage(java.util.Hashtable) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.ldap.LDAPUser.tempStorage | 764 |
RCN: Redundant nullcheck of value known to be non-null org.apache.turbine.services.security.ldap.LDAPUser.getLDAPAttributes() | 181 |
RCN: Redundant nullcheck of value known to be non-null org.apache.turbine.services.security.ldap.LDAPUser.getLDAPAttributes() | 185 |
Nm: Confusing to have methods org.apache.turbine.services.security.ldap.LDAPUser.getUserName() and org.apache.turbine.util.db.map.TurbineMapBuilder.getUsername() | 0 |
Violation | Line |
---|---|
ITA: Method org.apache.turbine.services.security.ldap.LDAPUserManager.retrieve(org.apache.torque.util.Criteria) uses Collection.toArray() with zero-length array argument | 249 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.ldap.LDAPUserManager.accountExists(String) | 105 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.turbine.services.security.ldap.LDAPUser in org.apache.turbine.services.security.ldap.LDAPUserManager.store(org.apache.turbine.om.security.User) | 353 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.turbine.services.security.ldap.LDAPUser in org.apache.turbine.services.security.ldap.LDAPUserManager.authenticate(org.apache.turbine.om.security.User,String) | 408 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.turbine.services.security.ldap.LDAPUser in org.apache.turbine.services.security.ldap.LDAPUserManager.createAccount(org.apache.turbine.om.security.User,String) | 489 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.turbine.services.security.ldap.LDAPUser in org.apache.turbine.services.security.ldap.LDAPUserManager.removeAccount(org.apache.turbine.om.security.User) | 521 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.services.security.db.DBSecurityService.getGroups(org.apache.torque.util.Criteria) | 477 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.db.DBSecurityService.getRoles(org.apache.torque.util.Criteria) | 507 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.db.DBSecurityService.getPermissions(org.apache.torque.util.Criteria) | 538 |
WMI: Method org.apache.turbine.services.security.db.DBSecurityService.getGroups(org.apache.torque.util.Criteria) makes inefficient use of keySet iterator instead of entrySet iterator | 475 |
WMI: Method org.apache.turbine.services.security.db.DBSecurityService.getRoles(org.apache.torque.util.Criteria) makes inefficient use of keySet iterator instead of entrySet iterator | 505 |
WMI: Method org.apache.turbine.services.security.db.DBSecurityService.getPermissions(org.apache.torque.util.Criteria) makes inefficient use of keySet iterator instead of entrySet iterator | 535 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.grant(org.apache.turbine.om.security.User,org.apache.turbine.om.security.Group,org.apache.turbine.om.security.Role) | 180 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.grant(org.apache.turbine.om.security.User,org.apache.turbine.om.security.Group,org.apache.turbine.om.security.Role) | 182 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.grant(org.apache.turbine.om.security.User,org.apache.turbine.om.security.Group,org.apache.turbine.om.security.Role) | 184 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.revoke(org.apache.turbine.om.security.User,org.apache.turbine.om.security.Group,org.apache.turbine.om.security.Role) | 241 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.revoke(org.apache.turbine.om.security.User,org.apache.turbine.om.security.Group,org.apache.turbine.om.security.Role) | 243 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.revoke(org.apache.turbine.om.security.User,org.apache.turbine.om.security.Group,org.apache.turbine.om.security.Role) | 245 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.revokeAll(org.apache.turbine.om.security.User) | 297 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.grant(org.apache.turbine.om.security.Role,org.apache.turbine.om.security.Permission) | 337 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.grant(org.apache.turbine.om.security.Role,org.apache.turbine.om.security.Permission) | 339 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.revoke(org.apache.turbine.om.security.Role,org.apache.turbine.om.security.Permission) | 387 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.revoke(org.apache.turbine.om.security.Role,org.apache.turbine.om.security.Permission) | 389 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBSecurityService.revokeAll(org.apache.turbine.om.security.Role) | 436 |
Violation | Line |
---|---|
ITA: Method org.apache.turbine.services.security.db.DBUserManager.retrieve(org.apache.torque.util.Criteria) uses Collection.toArray() with zero-length array argument | 243 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.User to class org.apache.torque.om.BaseObject in org.apache.turbine.services.security.db.DBUserManager.createAccount(org.apache.turbine.om.security.User,String) | 500 |
Violation | Line |
---|---|
DLS: Dead store to local variable in method org.apache.turbine.services.xmlrpc.util.FileTransfer.send(String,String,String,String,String) | 78 |
DLS: Dead store to local variable in method org.apache.turbine.services.xmlrpc.util.FileTransfer.send(String,String,String,String,String,String,String) | 132 |
REC: Method org.apache.turbine.services.xmlrpc.util.FileTransfer.send(String,String,String,String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 82 |
REC: Method org.apache.turbine.services.xmlrpc.util.FileTransfer.send(String,String,String,String,String,String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 140 |
REC: Method org.apache.turbine.services.xmlrpc.util.FileTransfer.get(String,String,String,String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 190 |
REC: Method org.apache.turbine.services.xmlrpc.util.FileTransfer.get(String,String,String,String,String,String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 248 |
REC: Method org.apache.turbine.services.xmlrpc.util.FileTransfer.remove(String,String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 285 |
REC: Method org.apache.turbine.services.xmlrpc.util.FileTransfer.remove(String,String,String,String,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 330 |
Violation | Line |
---|---|
Dm: org.apache.turbine.services.xmlrpc.util.AuthenticatedFileHandler.execute(String,java.util.Vector,String,String) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | 71 |
Violation | Line |
---|---|
DE: org.apache.turbine.services.xmlrpc.util.FileHandler.readFileContents(String,String) might ignore java.lang.Exception | 232 |
DE: org.apache.turbine.services.xmlrpc.util.FileHandler.writeFileContents(String,String,String) might ignore java.lang.Exception | 318 |
OS: org.apache.turbine.services.xmlrpc.util.FileHandler.readFileContents(String,String) may fail to close stream on exception | 198 |
DLS: Dead store to local variable in method org.apache.turbine.services.xmlrpc.util.FileHandler.readFileContents(String,String) | 178 |
Violation | Line |
---|---|
SBSC: Method org.apache.turbine.services.mimetype.util.MimeTypeMapper.parse(java.io.BufferedReader) concatenates strings using + in a loop | 159 |
IS2: Inconsistent synchronization of org.apache.turbine.services.mimetype.util.MimeTypeMapper.extensionMimeTypes; locked 66% of time | 140 |
IS2: Inconsistent synchronization of org.apache.turbine.services.mimetype.util.MimeTypeMapper.mimeTypeExtensions; locked 66% of time | 129 |
Violation | Line |
---|---|
CN: Class org.apache.turbine.services.mimetype.util.MimeType implements Cloneable but does not define or use clone method | 0 |
EI2: org.apache.turbine.services.mimetype.util.MimeType.<init>(String,String,String[],String[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.mimetype.util.MimeType.parameterNames | 306 |
EI2: org.apache.turbine.services.mimetype.util.MimeType.<init>(String,String,String[],String[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.mimetype.util.MimeType.parameterValues | 307 |
EI2: org.apache.turbine.services.mimetype.util.MimeType.addParameters(String[],String[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.mimetype.util.MimeType.parameterNames | 488 |
EI2: org.apache.turbine.services.mimetype.util.MimeType.addParameters(String[],String[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.mimetype.util.MimeType.parameterValues | 489 |
UG: org.apache.turbine.services.mimetype.util.MimeType.getParameter(String) is unsynchronized, org.apache.turbine.services.mimetype.util.MimeType.setParameter(String,String) is synchronized | 409 |
MS: org.apache.turbine.services.mimetype.util.MimeType.TEXT_HTML isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.TEXT_WML isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.TEXT_HDML isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.TEXT_CHTML isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.TEXT_PLAIN isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.MULTIPART isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.MULTIPART_FORM_DATA isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.APPLICATION_POSTSCRIPT isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.APPLICATION_OCTET_STREAM isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.APPLICATION_X_JAVA_AGENT isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.APPLICATION_X_WWW_FORM_URLENCODED isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.MESSAGE_HTTP isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.TEXT_CSS isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.TEXT isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.IMAGE_GIF isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.IMAGE_JPEG isn't final but should be | 0 |
MS: org.apache.turbine.services.mimetype.util.MimeType.IMAGE_WBMP isn't final but should be | 0 |
Nm: Confusing to have methods org.apache.turbine.services.mimetype.util.MimeType.getSubtype() and org.apache.commons.mail.MultiPartEmail.getSubType() | 0 |
IS2: Inconsistent synchronization of org.apache.turbine.services.mimetype.util.MimeType.parameterNames; locked 83% of time | 386 |
IS2: Inconsistent synchronization of org.apache.turbine.services.mimetype.util.MimeType.parameterValues; locked 87% of time | 412 |
Violation | Line |
---|---|
DE: org.apache.turbine.services.mimetype.util.MimeTypeMap.<init>() might ignore java.lang.Exception | 163 |
REC: Method org.apache.turbine.services.mimetype.util.MimeTypeMap.<init>() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 163 |
REC: Method org.apache.turbine.services.mimetype.util.MimeTypeMap.<init>() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 174 |
UG: org.apache.turbine.services.mimetype.util.MimeTypeMap.getContentType(String,String) is unsynchronized, org.apache.turbine.services.mimetype.util.MimeTypeMap.setContentType(String) is synchronized | 280 |
Violation | Line |
---|---|
DE: org.apache.turbine.services.mimetype.util.CharSetMap.<init>() might ignore java.lang.Exception | 200 |
REC: Method org.apache.turbine.services.mimetype.util.CharSetMap.<init>() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 200 |
REC: Method org.apache.turbine.services.mimetype.util.CharSetMap.<init>() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 211 |
BC: Questionable cast from java.util.Map to concrete class java.util.HashMap in org.apache.turbine.services.mimetype.util.CharSetMap.setCharSet(String,String) | 284 |
UG: org.apache.turbine.services.mimetype.util.CharSetMap.getCharSet(String,String) is unsynchronized, org.apache.turbine.services.mimetype.util.CharSetMap.setCharSet(String,String) is synchronized | 420 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.om.security.peer.RolePeer.doSelect(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 163 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.torque.om.BaseObject in org.apache.turbine.om.security.peer.RolePeer.buildCriteria(org.apache.turbine.om.security.Role) | 178 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.torque.om.BaseObject in org.apache.turbine.om.security.peer.RolePeer.buildCriteria(org.apache.turbine.om.security.Role) | 180 |
Violation | Line |
---|---|
Dm: org.apache.turbine.om.security.peer.TurbineUserPeer.populateObject(com.workingdogs.village.Record,int,org.apache.turbine.om.security.User) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | 304 |
REC: Method org.apache.turbine.om.security.peer.TurbineUserPeer.populateObject(com.workingdogs.village.Record,int,org.apache.turbine.om.security.User) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 330 |
REC: Method org.apache.turbine.om.security.peer.TurbineUserPeer.row2Object(com.workingdogs.village.Record,int,Class) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 457 |
MS: org.apache.turbine.om.security.peer.TurbineUserPeer.columnNames is a mutable array | 0 |
MS: org.apache.turbine.om.security.peer.TurbineUserPeer.criteriaKeys should be both final and package protected | 0 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.om.security.peer.PermissionPeer.doSelect(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 167 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Role to class org.apache.turbine.om.security.TurbineRole in org.apache.turbine.om.security.peer.PermissionPeer.retrieveSet(org.apache.turbine.om.security.Role) | 103 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.torque.om.BaseObject in org.apache.turbine.om.security.peer.PermissionPeer.buildCriteria(org.apache.turbine.om.security.Permission) | 182 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.turbine.om.security.SecurityObject in org.apache.turbine.om.security.peer.PermissionPeer.buildCriteria(org.apache.turbine.om.security.Permission) | 187 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.torque.om.BaseObject in org.apache.turbine.om.security.peer.PermissionPeer.buildCriteria(org.apache.turbine.om.security.Permission) | 184 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.turbine.om.security.SecurityObject in org.apache.turbine.om.security.peer.PermissionPeer.checkExists(org.apache.turbine.om.security.Permission) | 236 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Permission to class org.apache.turbine.om.security.SecurityObject in org.apache.turbine.om.security.peer.PermissionPeer.checkExists(org.apache.turbine.om.security.Permission) | 240 |
Violation | Line |
---|---|
REC: Method org.apache.turbine.om.security.peer.GroupPeer.doSelect(org.apache.torque.util.Criteria) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 153 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.turbine.om.security.SecurityObject in org.apache.turbine.om.security.peer.GroupPeer.checkExists(org.apache.turbine.om.security.Group) | 189 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.turbine.om.security.TurbineGroup in org.apache.turbine.om.security.peer.GroupPeer.checkExists(org.apache.turbine.om.security.Group) | 193 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.turbine.om.security.SecurityObject in org.apache.turbine.om.security.peer.GroupPeer.buildCriteria(org.apache.turbine.om.security.Group) | 233 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.torque.om.BaseObject in org.apache.turbine.om.security.peer.GroupPeer.buildCriteria(org.apache.turbine.om.security.Group) | 234 |
BC: Unchecked/unconfirmed cast from org.apache.turbine.om.security.Group to class org.apache.torque.om.BaseObject in org.apache.turbine.om.security.peer.GroupPeer.buildCriteria(org.apache.turbine.om.security.Group) | 236 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in org.apache.turbine.services.security.torque.om.BaseTurbinePermissionPeer.setDbName(org.apache.torque.util.Criteria) | 795 |
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.lang.Error in org.apache.turbine.services.security.torque.om.BaseTurbinePermissionPeer.initClass(String) | 121 |
CD: Class org.apache.turbine.services.security.torque.om.BaseTurbinePermissionPeer has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.om.TurbinePermission implements same interface as superclass. | 0 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbinePermission.setPrimaryKey(org.apache.torque.om.ObjectKey) | 558 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.om.TurbineRolePermission implements same interface as superclass. | 0 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineRolePermission.setTurbineRoleKey(org.apache.torque.om.ObjectKey) | 175 |
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineRolePermission.setTurbinePermissionKey(org.apache.torque.om.ObjectKey) | 237 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in org.apache.turbine.services.security.torque.om.BaseTurbineRolePermissionPeer.setDbName(org.apache.torque.util.Criteria) | 963 |
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.lang.Error in org.apache.turbine.services.security.torque.om.BaseTurbineRolePermissionPeer.initClass(String) | 123 |
CD: Class org.apache.turbine.services.security.torque.om.BaseTurbineRolePermissionPeer has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.om.TurbineRole implements same interface as superclass. | 0 |
CD: Class org.apache.turbine.services.security.torque.om.TurbineRole has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineRole.setPrimaryKey(org.apache.torque.om.ObjectKey) | 897 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in org.apache.turbine.services.security.torque.om.BaseTurbineRolePeer.setDbName(org.apache.torque.util.Criteria) | 795 |
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.lang.Error in org.apache.turbine.services.security.torque.om.BaseTurbineRolePeer.initClass(String) | 121 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.om.TurbineUserGroupRole implements same interface as superclass. | 0 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRole.setTurbineUserKey(org.apache.torque.om.ObjectKey) | 212 |
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRole.setTurbineGroupKey(org.apache.torque.om.ObjectKey) | 274 |
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRole.setTurbineRoleKey(org.apache.torque.om.ObjectKey) | 336 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRolePeer.setDbName(org.apache.torque.util.Criteria) | 1336 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRolePeer.doSelectJoinAllExceptTurbineUser(org.apache.torque.util.Criteria) | 1057 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRolePeer.doSelectJoinAllExceptTurbineGroup(org.apache.torque.util.Criteria) | 1153 |
DLS: Dead store to local variable in method org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRolePeer.doSelectJoinAllExceptTurbineRole(org.apache.torque.util.Criteria) | 1248 |
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.lang.Error in org.apache.turbine.services.security.torque.om.BaseTurbineUserGroupRolePeer.initClass(String) | 127 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.om.TurbineUser implements same interface as superclass. | 0 |
Violation | Line |
---|---|
EI: org.apache.turbine.services.security.torque.om.BaseTurbineUser.getModified() may expose internal representation by returning org.apache.turbine.services.security.torque.om.BaseTurbineUser.modified | 287 |
EI2: org.apache.turbine.services.security.torque.om.BaseTurbineUser.setModified(java.util.Date) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.torque.om.BaseTurbineUser.modified | 301 |
EI: org.apache.turbine.services.security.torque.om.BaseTurbineUser.getCreateDate() may expose internal representation by returning org.apache.turbine.services.security.torque.om.BaseTurbineUser.createDate | 315 |
EI2: org.apache.turbine.services.security.torque.om.BaseTurbineUser.setCreateDate(java.util.Date) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.torque.om.BaseTurbineUser.createDate | 329 |
EI: org.apache.turbine.services.security.torque.om.BaseTurbineUser.getLastLogin() may expose internal representation by returning org.apache.turbine.services.security.torque.om.BaseTurbineUser.lastLogin | 343 |
EI2: org.apache.turbine.services.security.torque.om.BaseTurbineUser.setLastLogin(java.util.Date) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.torque.om.BaseTurbineUser.lastLogin | 357 |
EI: org.apache.turbine.services.security.torque.om.BaseTurbineUser.getObjectdata() may expose internal representation by returning org.apache.turbine.services.security.torque.om.BaseTurbineUser.objectdata | 371 |
EI2: org.apache.turbine.services.security.torque.om.BaseTurbineUser.setObjectdata(byte[]) may expose internal representation by storing an externally mutable object into org.apache.turbine.services.security.torque.om.BaseTurbineUser.objectdata | 385 |
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineUser.setPrimaryKey(org.apache.torque.om.ObjectKey) | 1005 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in org.apache.turbine.services.security.torque.om.BaseTurbineUserPeer.setDbName(org.apache.torque.util.Criteria) | 857 |
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.lang.Error in org.apache.turbine.services.security.torque.om.BaseTurbineUserPeer.initClass(String) | 148 |
Violation | Line |
---|---|
RI: Class org.apache.turbine.services.security.torque.om.TurbineGroup implements same interface as superclass. | 0 |
CD: Class org.apache.turbine.services.security.torque.om.TurbineGroup has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
BC: Unchecked/unconfirmed cast from org.apache.torque.om.ObjectKey to class org.apache.torque.om.NumberKey in org.apache.turbine.services.security.torque.om.BaseTurbineGroup.setPrimaryKey(org.apache.torque.om.ObjectKey) | 609 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in org.apache.turbine.services.security.torque.om.BaseTurbineGroupPeer.setDbName(org.apache.torque.util.Criteria) | 795 |
BC: Unchecked/unconfirmed cast from java.lang.Throwable to class java.lang.Error in org.apache.turbine.services.security.torque.om.BaseTurbineGroupPeer.initClass(String) | 121 |
Violation | Line |
---|---|
Dm: Method org.apache.turbine.services.assemblerbroker.util.python.PythonBaseFactory.getAssembler(String,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 93 |
Violation | Line |
---|---|
Nm: Confusing to have methods org.apache.turbine.services.rundata.DefaultTurbineRunData.setCharSet(String) and org.apache.turbine.util.mail.Email.setCharset(String) | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.services.rundata.DefaultTurbineRunData.action | 0 |
Violation | Line |
---|---|
UwF: Field not initialized in constructor: org.apache.java.security.MD5.state | 0 |
UwF: Field not initialized in constructor: org.apache.java.security.MD5.x | 0 |
Violation | Line |
---|---|
UwF: Field not initialized in constructor: org.apache.turbine.services.intake.IntakeTool.pp | 0 |
Violation | Line |
---|---|
UwF: Field not initialized in constructor: org.apache.turbine.services.mimetype.TurbineMimeTypeService.charSetMap | 0 |
UwF: Field not initialized in constructor: org.apache.turbine.services.mimetype.TurbineMimeTypeService.mimeTypeMap | 0 |
Violation | Line |
---|---|
UwF: Field not initialized in constructor: org.apache.turbine.services.pull.util.SessionData.dataStorage | 0 |
Violation | Line |
---|---|
UwF: Field not initialized in constructor: org.apache.turbine.services.session.TurbineSessionService.activeSessions | 0 |
Violation | Line |
---|---|
UwF: Unwritten field: org.apache.turbine.om.OMTool.omFactory | 0 |
Violation | Line |
---|---|
SIC: Should org.apache.turbine.services.localization.LocaleTokenizer$AcceptLanguage be a _static_ inner class? | 0 |
Violation | Line |
---|---|
UrF: Unread field: org.apache.turbine.services.localization.LocalizationTool.bundle | 0 |
UrF: Unread field: org.apache.turbine.services.localization.LocalizationTool.bundleName | 0 |
Violation | Line |
---|---|
SIC: Should org.apache.turbine.services.pool.TurbinePoolService$PoolBuffer$Recycler be a _static_ inner class? | 0 |
Violation | Line |
---|---|
SIC: The class org.apache.turbine.services.schedule.JobQueue$1 could be refactored into a named _static_ inner class | 0 |
Violation | Line |
---|---|
UrF: Unread field: org.apache.turbine.util.parser.DataStreamParser.fieldSeparator | 0 |
Violation | Line |
---|---|
SIC: Should org.apache.turbine.util.template.HtmlPageAttributes$StyleSheet be a _static_ inner class? | 0 |
Violation | Line |
---|---|
SIC: Should org.apache.turbine.util.upload.MultipartStream$IllegalBoundaryException be a _static_ inner class? | 0 |
Violation | Line |
---|---|
SIC: Should org.apache.turbine.util.upload.MultipartStream$MalformedStreamException be a _static_ inner class? | 0 |
Violation | Line |
---|---|
CD: Class org.apache.turbine.services.intake.model.FieldFactory has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
CD: Class org.apache.turbine.services.intake.model.Field has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
CD: Class org.apache.turbine.services.security.torque.om.TurbineGroupPeer has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
CD: Class org.apache.turbine.services.schedule.JobEntryPeer has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
CD: Class org.apache.turbine.services.intake.xmlmodel.AppData has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
CD: Class org.apache.turbine.modules.ActionLoader has a circular dependency with other classes. | 0 |
Violation | Line |
---|---|
CD: Class org.apache.turbine.modules.PageLoader has a circular dependency with other classes. | 0 |