The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | LeftCurly | 1 | Error |
coding | HiddenField | 17 | Error |
MagicNumber | 1 | Error | |
SimplifyBooleanExpression | 2 | Error | |
design | DesignForExtension | 28 | Error |
VisibilityModifier | 4 | Error | |
javadoc | JavadocMethod | 20 | Error |
JavadocPackage | 2 | Error | |
JavadocStyle | 1 | Error | |
JavadocType | 3 | Error | |
JavadocVariable | 22 | Error | |
misc | FinalParameters | 47 | Error |
NewlineAtEndOfFile | 1 | Error | |
naming | ConstantName | 1 | Error |
MethodName | 2 | Error | |
regexp | RegexpSingleline
|
12 | Error |
sizes | LineLength | 25 | Error |
whitespace | ParenPad | 5 | Error |
WhitespaceAfter | 1 | Error |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | javadoc | JavadocType | Missing a Javadoc comment. | 22 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
Error | sizes | LineLength | Line is longer than 80 characters (found 85). | 48 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 51 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 61 |
Error | misc | FinalParameters | Parameter id should be final. | 66 |
Error | coding | HiddenField | 'id' hides a field. | 66 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'withId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'withId' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 70 |
Error | misc | FinalParameters | Parameter id should be final. | 70 |
Error | coding | HiddenField | 'id' hides a field. | 70 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 76 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 86 |
Error | misc | FinalParameters | Parameter hash should be final. | 91 |
Error | coding | HiddenField | 'hash' hides a field. | 91 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'withHash' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'withHash' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 95 |
Error | misc | FinalParameters | Parameter hash should be final. | 95 |
Error | coding | HiddenField | 'hash' hides a field. | 95 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 101 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 111 |
Error | misc | FinalParameters | Parameter hashType should be final. | 116 |
Error | coding | HiddenField | 'hashType' hides a field. | 116 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'withHashType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'withHashType' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 120 |
Error | misc | FinalParameters | Parameter hashType should be final. | 120 |
Error | coding | HiddenField | 'hashType' hides a field. | 120 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 126 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 136 |
Error | misc | FinalParameters | Parameter count should be final. | 141 |
Error | coding | HiddenField | 'count' hides a field. | 141 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'withCount' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'withCount' static/final/abstract/empty, or adding allowed annotation for the method. | 145 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 145 |
Error | misc | FinalParameters | Parameter count should be final. | 145 |
Error | coding | HiddenField | 'count' hides a field. | 145 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 151 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 161 |
Error | misc | FinalParameters | Parameter deliveredAt should be final. | 166 |
Error | coding | HiddenField | 'deliveredAt' hides a field. | 166 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'withDeliveredAt' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'withDeliveredAt' static/final/abstract/empty, or adding allowed annotation for the method. | 170 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 170 |
Error | misc | FinalParameters | Parameter deliveredAt should be final. | 170 |
Error | coding | HiddenField | 'deliveredAt' hides a field. | 170 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 176 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 186 |
Error | misc | FinalParameters | Parameter data should be final. | 191 |
Error | coding | HiddenField | 'data' hides a field. | 191 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'withData' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'withData' static/final/abstract/empty, or adding allowed annotation for the method. | 195 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 195 |
Error | misc | FinalParameters | Parameter data should be final. | 195 |
Error | coding | HiddenField | 'data' hides a field. | 195 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 200 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'getAdditionalProperties' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'getAdditionalProperties' static/final/abstract/empty, or adding allowed annotation for the method. | 205 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 205 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'setAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'setAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 210 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 210 |
Error | misc | FinalParameters | Parameter name should be final. | 211 |
Error | misc | FinalParameters | Parameter value should be final. | 211 |
Error | sizes | LineLength | Line is longer than 80 characters (found 81). | 215 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'withAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'withAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 215 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 215 |
Error | misc | FinalParameters | Parameter name should be final. | 215 |
Error | misc | FinalParameters | Parameter value should be final. | 215 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 220 |
Error | sizes | LineLength | Line is longer than 80 characters (found 167). | 222 |
Error | design | DesignForExtension | Class 'GenericWebhookData' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookData' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 225 |
Error | misc | FinalParameters | Parameter other should be final. | 226 |
Error | coding | SimplifyBooleanExpression | Expression can be simplified. | 230 |
Error | sizes | LineLength | Line is longer than 80 characters (found 259). | 234 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | misc | NewlineAtEndOfFile | File does not end with a newline. | |
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 65 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
Error | naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 68 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 71 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 73 |
Error | design | VisibilityModifier | Variable 'providerQueue' must be private and have accessor methods. | 73 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
Error | design | VisibilityModifier | Variable 'lock' must be private and have accessor methods. | 75 |
Error | sizes | LineLength | Line is longer than 80 characters (found 94). | 77 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
Error | design | DesignForExtension | Class 'GenericWebhookResource' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookResource' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
Error | misc | FinalParameters | Parameter headers should be final. | 92 |
Error | misc | FinalParameters | Parameter body should be final. | 93 |
Error | naming | MethodName | Name 'json_new_line' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 134 |
Error | misc | FinalParameters | Parameter headers should be final. | 134 |
Error | misc | FinalParameters | Parameter body should be final. | 135 |
Error | naming | MethodName | Name 'json_meta' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 190 |
Error | misc | FinalParameters | Parameter headers should be final. | 190 |
Error | misc | FinalParameters | Parameter body should be final. | 191 |
Error | sizes | LineLength | Line is longer than 80 characters (found 90). | 208 |
Error | whitespace | ParenPad | '(' is followed by whitespace. | 210 |
Error | design | DesignForExtension | Class 'GenericWebhookResource' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookResource' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. | 241 |
Error | design | DesignForExtension | Class 'GenericWebhookResource' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookResource' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. | 255 |
Error | misc | FinalParameters | Parameter sequence should be final. | 256 |
Error | design | DesignForExtension | Class 'GenericWebhookResource' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookResource' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. | 260 |
Error | misc | FinalParameters | Parameter start should be final. | 261 |
Error | misc | FinalParameters | Parameter end should be final. | 261 |
Error | design | DesignForExtension | Class 'GenericWebhookResource' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GenericWebhookResource' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. | 265 |
Error | misc | FinalParameters | Parameter configurationObject should be final. | 271 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | sizes | LineLength | Line is longer than 80 characters (found 82). | 32 |
Error | sizes | LineLength | Line is longer than 80 characters (found 81). | 35 |
Error | sizes | LineLength | Line is longer than 80 characters (found 90). | 37 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 39 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 43 |
Error | misc | FinalParameters | Parameter streamConfig should be final. | 43 |
Error | sizes | LineLength | Line is longer than 80 characters (found 90). | 44 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 47 |
Error | misc | FinalParameters | Parameter streamConfig should be final. | 47 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 51 |
Error | misc | FinalParameters | Parameter maxQueueCapacity should be final. | 51 |
Error | sizes | LineLength | Line is longer than 80 characters (found 90). | 55 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 55 |
Error | misc | FinalParameters | Parameter maxQueueCapacity should be final. | 55 |
Error | misc | FinalParameters | Parameter streamConfig should be final. | 55 |
Error | design | DesignForExtension | Class 'StreamDropwizardBuilder' looks like designed for extension (can be subclassed), but the method 'newPerpetualStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamDropwizardBuilder' final or making the method 'newPerpetualStream' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 60 |
Error | misc | FinalParameters | Parameter streamId should be final. | 60 |
Error | misc | FinalParameters | Parameter provider should be final. | 60 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | sizes | LineLength | Line is longer than 80 characters (found 85). | 54 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
Error | design | VisibilityModifier | Variable 'mapper' must be private and have accessor methods. | 59 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
Error | design | VisibilityModifier | Variable 'builder' must be private and have accessor methods. | 61 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
Error | sizes | LineLength | Line is longer than 80 characters (found 128). | 68 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 70 |
Error | design | DesignForExtension | Class 'StreamsApplication' looks like designed for extension (can be subclassed), but the method 'initialize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsApplication' final or making the method 'initialize' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
Error | misc | FinalParameters | Parameter bootstrap should be final. | 79 |
Error | design | DesignForExtension | Class 'StreamsApplication' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsApplication' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
Error | sizes | LineLength | Line is longer than 80 characters (found 124). | 95 |
Error | misc | FinalParameters | Parameter streamsDropwizardConfiguration should be final. | 95 |
Error | misc | FinalParameters | Parameter environment should be final. | 95 |
Error | sizes | LineLength | Line is longer than 80 characters (found 112). | 99 |
Error | whitespace | ParenPad | '(' is followed by whitespace. | 99 |
Error | whitespace | ParenPad | ')' is preceded with whitespace. | 99 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 100 |
Error | whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 100 |
Error | whitespace | ParenPad | '(' is followed by whitespace. | 101 |
Error | sizes | LineLength | Line is longer than 80 characters (found 107). | 110 |
Error | sizes | LineLength | Line is longer than 80 characters (found 81). | 114 |
Error | coding | MagicNumber | '10000' is a magic number. | 117 |
Error | sizes | LineLength | Line is longer than 80 characters (found 113). | 132 |
Error | misc | FinalParameters | Parameter streamsConfiguration should be final. | 132 |
Error | coding | HiddenField | 'streamsConfiguration' hides a field. | 132 |
Error | misc | FinalParameters | Parameter resourceProviders should be final. | 132 |
Error | coding | HiddenField | 'resourceProviders' hides a field. | 132 |
Error | coding | HiddenField | 'builder' hides a field. | 134 |
Error | whitespace | ParenPad | '(' is followed by whitespace. | 137 |
Error | javadoc | JavadocType | Missing a Javadoc comment. | 146 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 148 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 150 |
Error | sizes | LineLength | Line is longer than 80 characters (found 105). | 152 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 152 |
Error | misc | FinalParameters | Parameter builder should be final. | 152 |
Error | coding | HiddenField | 'builder' hides a field. | 152 |
Error | misc | FinalParameters | Parameter streamsConfiguration should be final. | 152 |
Error | coding | HiddenField | 'streamsConfiguration' hides a field. | 152 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 165 |
Error | misc | FinalParameters | Parameter args should be final. | 174 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocType | Missing a Javadoc comment. | 16 |
Error | blocks | LeftCurly | '{' at column 1 should be on the previous line. | 20 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
Error | sizes | LineLength | Line is longer than 80 characters (found 85). | 23 |
Error | design | DesignForExtension | Class 'StreamsDropwizardConfiguration' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardConfiguration' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
Error | design | DesignForExtension | Class 'StreamsDropwizardConfiguration' looks like designed for extension (can be subclassed), but the method 'getAdditionalProperties' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardConfiguration' final or making the method 'getAdditionalProperties' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 30 |
Error | design | DesignForExtension | Class 'StreamsDropwizardConfiguration' looks like designed for extension (can be subclassed), but the method 'setAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardConfiguration' final or making the method 'setAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 35 |
Error | misc | FinalParameters | Parameter name should be final. | 36 |
Error | misc | FinalParameters | Parameter value should be final. | 36 |
Error | sizes | LineLength | Line is longer than 80 characters (found 93). | 40 |
Error | design | DesignForExtension | Class 'StreamsDropwizardConfiguration' looks like designed for extension (can be subclassed), but the method 'withAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardConfiguration' final or making the method 'withAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 40 |
Error | misc | FinalParameters | Parameter name should be final. | 40 |
Error | misc | FinalParameters | Parameter value should be final. | 40 |
Error | design | DesignForExtension | Class 'StreamsDropwizardConfiguration' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardConfiguration' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
Error | design | DesignForExtension | Class 'StreamsDropwizardConfiguration' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardConfiguration' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
Error | misc | FinalParameters | Parameter other should be final. | 51 |
Error | coding | SimplifyBooleanExpression | Expression can be simplified. | 55 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 58 |
Error | sizes | LineLength | Line is longer than 80 characters (found 101). | 59 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | design | DesignForExtension | Class 'StreamsDropwizardModule' looks like designed for extension (can be subclassed), but the method 'configure' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardModule' final or making the method 'configure' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
Error | design | DesignForExtension | Class 'StreamsDropwizardModule' looks like designed for extension (can be subclassed), but the method 'providesStreamsConfiguration' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StreamsDropwizardModule' final or making the method 'providesStreamsConfiguration' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 42 |