Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
6 0 0 177

Rules

Category Rule Violations Severity
blocks LeftCurly 1  Error
coding HiddenField 17  Error
MagicNumber 3  Error
SimplifyBooleanExpression 1  Error
design DesignForExtension 30  Error
VisibilityModifier 3  Error
javadoc JavadocMethod 17  Error
JavadocPackage 2  Error
JavadocStyle 15  Error
JavadocType 1  Error
JavadocVariable 20  Error
misc FinalParameters 29  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
12  Error
sizes LineLength 20  Error
whitespace ParenPad 3  Error
WhitespaceAfter 3  Error

Details

org/apache/streams/kafka/KafkaConfiguration.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 19
 Error blocks LeftCurly '{' at column 1 should be on the previous line. 28
 Error javadoc JavadocStyle First sentence should end with a period. 30
 Error regexp RegexpSingleline Line has trailing spaces. 32
 Error javadoc JavadocStyle First sentence should end with a period. 37
 Error regexp RegexpSingleline Line has trailing spaces. 39
 Error javadoc JavadocStyle First sentence should end with a period. 44
 Error regexp RegexpSingleline Line has trailing spaces. 46
 Error javadoc JavadocStyle First sentence should end with a period. 51
 Error regexp RegexpSingleline Line has trailing spaces. 53
 Error javadoc JavadocVariable Missing a Javadoc comment. 58
 Error sizes LineLength Line is longer than 80 characters (found 85). 59
 Error javadoc JavadocStyle First sentence should end with a period. 61
 Error regexp RegexpSingleline Line has trailing spaces. 63
 Error javadoc JavadocStyle First sentence should end with a period. 73
 Error regexp RegexpSingleline Line has trailing spaces. 75
 Error misc FinalParameters Parameter brokerlist should be final. 81
 Error coding HiddenField 'brokerlist' hides a field. 81
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'withBrokerlist' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'withBrokerlist' static/final/abstract/empty, or adding allowed annotation for the method. 85
 Error javadoc JavadocMethod Missing a Javadoc comment. 85
 Error misc FinalParameters Parameter brokerlist should be final. 85
 Error coding HiddenField 'brokerlist' hides a field. 85
 Error javadoc JavadocStyle First sentence should end with a period. 90
 Error regexp RegexpSingleline Line has trailing spaces. 92
 Error javadoc JavadocStyle First sentence should end with a period. 102
 Error regexp RegexpSingleline Line has trailing spaces. 104
 Error misc FinalParameters Parameter zkconnect should be final. 110
 Error coding HiddenField 'zkconnect' hides a field. 110
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'withZkconnect' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'withZkconnect' static/final/abstract/empty, or adding allowed annotation for the method. 114
 Error javadoc JavadocMethod Missing a Javadoc comment. 114
 Error misc FinalParameters Parameter zkconnect should be final. 114
 Error coding HiddenField 'zkconnect' hides a field. 114
 Error javadoc JavadocStyle First sentence should end with a period. 119
 Error regexp RegexpSingleline Line has trailing spaces. 121
 Error javadoc JavadocStyle First sentence should end with a period. 131
 Error regexp RegexpSingleline Line has trailing spaces. 133
 Error misc FinalParameters Parameter topic should be final. 139
 Error coding HiddenField 'topic' hides a field. 139
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'withTopic' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'withTopic' static/final/abstract/empty, or adding allowed annotation for the method. 143
 Error javadoc JavadocMethod Missing a Javadoc comment. 143
 Error misc FinalParameters Parameter topic should be final. 143
 Error coding HiddenField 'topic' hides a field. 143
 Error javadoc JavadocStyle First sentence should end with a period. 148
 Error regexp RegexpSingleline Line has trailing spaces. 150
 Error javadoc JavadocStyle First sentence should end with a period. 160
 Error regexp RegexpSingleline Line has trailing spaces. 162
 Error misc FinalParameters Parameter groupId should be final. 168
 Error coding HiddenField 'groupId' hides a field. 168
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'withGroupId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'withGroupId' static/final/abstract/empty, or adding allowed annotation for the method. 172
 Error javadoc JavadocMethod Missing a Javadoc comment. 172
 Error misc FinalParameters Parameter groupId should be final. 172
 Error coding HiddenField 'groupId' hides a field. 172
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. 177
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'getAdditionalProperties' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'getAdditionalProperties' static/final/abstract/empty, or adding allowed annotation for the method. 182
 Error javadoc JavadocMethod Missing a Javadoc comment. 182
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'setAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'setAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. 188
 Error javadoc JavadocMethod Missing a Javadoc comment. 188
 Error misc FinalParameters Parameter name should be final. 190
 Error misc FinalParameters Parameter value should be final. 190
 Error sizes LineLength Line is longer than 80 characters (found 81). 194
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'withAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'withAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. 194
 Error javadoc JavadocMethod Missing a Javadoc comment. 194
 Error misc FinalParameters Parameter name should be final. 194
 Error misc FinalParameters Parameter value should be final. 194
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. 199
 Error sizes LineLength Line is longer than 80 characters (found 146). 201
 Error design DesignForExtension Class 'KafkaConfiguration' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaConfiguration' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. 204
 Error misc FinalParameters Parameter other should be final. 205
 Error coding SimplifyBooleanExpression Expression can be simplified. 209
 Error sizes LineLength Line is longer than 80 characters (found 223). 213

org/apache/streams/kafka/KafkaPersistReader.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocVariable Missing a Javadoc comment. 54
 Error sizes LineLength Line is longer than 80 characters (found 89). 56
 Error javadoc JavadocVariable Missing a Javadoc comment. 56
 Error javadoc JavadocVariable Missing a Javadoc comment. 58
 Error design VisibilityModifier Variable 'persistQueue' must be private and have accessor methods. 58
 Error javadoc JavadocVariable Missing a Javadoc comment. 60
 Error javadoc JavadocVariable Missing a Javadoc comment. 62
 Error javadoc JavadocVariable Missing a Javadoc comment. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 66
 Error design VisibilityModifier Variable 'inStreams' must be private and have accessor methods. 66
 Error javadoc JavadocVariable Missing a Javadoc comment. 68
 Error sizes LineLength Line is longer than 80 characters (found 83). 71
 Error sizes LineLength Line is longer than 80 characters (found 81). 75
 Error misc FinalParameters Parameter persistQueue should be final. 82
 Error coding HiddenField 'persistQueue' hides a field. 82
 Error javadoc JavadocMethod Expected @param tag for 'persistQueue'. 82
 Error sizes LineLength Line is longer than 80 characters (found 81). 84
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'setConfig' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'setConfig' static/final/abstract/empty, or adding allowed annotation for the method. 88
 Error javadoc JavadocMethod Missing a Javadoc comment. 88
 Error misc FinalParameters Parameter config should be final. 88
 Error coding HiddenField 'config' hides a field. 88
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 92
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. 97
 Error sizes LineLength Line is longer than 80 characters (found 128). 110
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'readAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'readAll' static/final/abstract/empty, or adding allowed annotation for the method. 118
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. 123
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. 128
 Error misc FinalParameters Parameter bigInteger should be final. 129
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. 133
 Error misc FinalParameters Parameter dateTime should be final. 134
 Error misc FinalParameters Parameter dateTime2 should be final. 134
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. 138
 Error sizes LineLength Line is longer than 80 characters (found 88). 143
 Error javadoc JavadocMethod Missing a Javadoc comment. 143
 Error misc FinalParameters Parameter zookeeper should be final. 143
 Error misc FinalParameters Parameter groupId should be final. 143
 Error misc FinalParameters Parameter configurationObject should be final. 154
 Error design DesignForExtension Class 'KafkaPersistReader' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReader' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 158
 Error whitespace ParenPad '(' is followed by whitespace. 161
 Error coding MagicNumber '5' is a magic number. 163

org/apache/streams/kafka/KafkaPersistReaderTask.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 30
 Error sizes LineLength Line is longer than 80 characters (found 93). 36
 Error javadoc JavadocVariable Missing a Javadoc comment. 36
 Error javadoc JavadocVariable Missing a Javadoc comment. 38
 Error javadoc JavadocVariable Missing a Javadoc comment. 39
 Error whitespace WhitespaceAfter ',' is not followed by whitespace. 39
 Error sizes LineLength Line is longer than 80 characters (found 95). 41
 Error javadoc JavadocMethod Missing a Javadoc comment. 41
 Error misc FinalParameters Parameter reader should be final. 41
 Error coding HiddenField 'reader' hides a field. 41
 Error misc FinalParameters Parameter stream should be final. 41
 Error whitespace WhitespaceAfter ',' is not followed by whitespace. 41
 Error coding HiddenField 'stream' hides a field. 41
 Error design DesignForExtension Class 'KafkaPersistReaderTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistReaderTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 46
 Error whitespace WhitespaceAfter ',' is not followed by whitespace. 49
 Error coding MagicNumber '100' is a magic number. 57

org/apache/streams/kafka/KafkaPersistWriter.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 89). 43
 Error javadoc JavadocVariable Missing a Javadoc comment. 45
 Error sizes LineLength Line is longer than 80 characters (found 89). 47
 Error javadoc JavadocVariable Missing a Javadoc comment. 47
 Error javadoc JavadocVariable Missing a Javadoc comment. 49
 Error design VisibilityModifier Variable 'persistQueue' must be private and have accessor methods. 49
 Error javadoc JavadocVariable Missing a Javadoc comment. 51
 Error javadoc JavadocVariable Missing a Javadoc comment. 53
 Error javadoc JavadocVariable Missing a Javadoc comment. 55
 Error sizes LineLength Line is longer than 80 characters (found 83). 58
 Error sizes LineLength Line is longer than 80 characters (found 81). 62
 Error misc FinalParameters Parameter persistQueue should be final. 69
 Error coding HiddenField 'persistQueue' hides a field. 69
 Error javadoc JavadocMethod Expected @param tag for 'persistQueue'. 69
 Error sizes LineLength Line is longer than 80 characters (found 81). 71
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'setConfig' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'setConfig' static/final/abstract/empty, or adding allowed annotation for the method. 75
 Error javadoc JavadocMethod Missing a Javadoc comment. 75
 Error misc FinalParameters Parameter config should be final. 75
 Error coding HiddenField 'config' hides a field. 75
 Error javadoc JavadocStyle First sentence should end with a period. 79
 Error sizes LineLength Line is longer than 80 characters (found 82). 87
 Error coding HiddenField 'config' hides a field. 90
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'stop' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'stop' static/final/abstract/empty, or adding allowed annotation for the method. 97
 Error javadoc JavadocMethod Missing a Javadoc comment. 97
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'setPersistQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'setPersistQueue' static/final/abstract/empty, or adding allowed annotation for the method. 101
 Error javadoc JavadocMethod Missing a Javadoc comment. 101
 Error misc FinalParameters Parameter persistQueue should be final. 101
 Error coding HiddenField 'persistQueue' hides a field. 101
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'getPersistQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'getPersistQueue' static/final/abstract/empty, or adding allowed annotation for the method. 105
 Error javadoc JavadocMethod Missing a Javadoc comment. 105
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 109
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'write' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'write' static/final/abstract/empty, or adding allowed annotation for the method. 114
 Error misc FinalParameters Parameter entry should be final. 115
 Error sizes LineLength Line is longer than 80 characters (found 92). 123
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 132
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. 137
 Error misc FinalParameters Parameter configurationObject should be final. 138
 Error design DesignForExtension Class 'KafkaPersistWriter' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriter' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. 142

org/apache/streams/kafka/KafkaPersistWriterTask.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 28
 Error sizes LineLength Line is longer than 80 characters (found 93). 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 36
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error misc FinalParameters Parameter writer should be final. 38
 Error coding HiddenField 'writer' hides a field. 38
 Error design DesignForExtension Class 'KafkaPersistWriterTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'KafkaPersistWriterTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. 42
 Error whitespace ParenPad '(' is followed by whitespace. 46
 Error whitespace ParenPad ')' is preceded with whitespace. 46
 Error coding MagicNumber '100' is a magic number. 55