The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | LeftCurly | 4 | Error |
coding | HiddenField | 8 | Error |
SimplifyBooleanExpression | 2 | Error | |
design | DesignForExtension | 18 | Error |
VisibilityModifier | 2 | Error | |
javadoc | JavadocMethod | 16 | Error |
JavadocPackage | 2 | Error | |
JavadocStyle | 12 | Error | |
JavadocType | 2 | Error | |
JavadocVariable | 8 | Error | |
misc | FinalParameters | 22 | Error |
modifier | ModifierOrder | 4 | Error |
regexp | RegexpSingleline
|
24 | Error |
sizes | LineLength | 30 | Error |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | sizes | LineLength | Line is longer than 80 characters (found 82). | 34 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 38 |
Error | sizes | LineLength | Line is longer than 80 characters (found 88). | 40 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
Error | modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 40 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
Error | design | VisibilityModifier | Variable 'config' must be private and have accessor methods. | 42 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 44 |
Error | sizes | LineLength | Line is longer than 80 characters (found 129). | 45 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 48 |
Error | misc | FinalParameters | Parameter reindex should be final. | 48 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 52 |
Error | misc | FinalParameters | Parameter args should be final. | 52 |
Error | blocks | LeftCurly | '{' at column 3 should be on the previous line. | 53 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfs' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfs' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
Error | sizes | LineLength | Line is longer than 80 characters (found 111). | 62 |
Error | sizes | LineLength | Line is longer than 80 characters (found 95). | 63 |
Error | sizes | LineLength | Line is longer than 80 characters (found 132). | 66 |
Error | sizes | LineLength | Line is longer than 80 characters (found 112). | 69 |
Error | sizes | LineLength | Line is longer than 80 characters (found 158). | 70 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | javadoc | JavadocType | Missing a Javadoc comment. | 22 |
Error | blocks | LeftCurly | '{' at column 1 should be on the previous line. | 29 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 31 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 32 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 34 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 40 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 41 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 43 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
Error | sizes | LineLength | Line is longer than 80 characters (found 85). | 50 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 52 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 53 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 55 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 64 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 65 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 67 |
Error | misc | FinalParameters | Parameter source should be final. | 72 |
Error | coding | HiddenField | 'source' hides a field. | 72 |
Error | sizes | LineLength | Line is longer than 80 characters (found 95). | 76 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'withSource' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'withSource' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 76 |
Error | misc | FinalParameters | Parameter source should be final. | 76 |
Error | coding | HiddenField | 'source' hides a field. | 76 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 81 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 82 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 84 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 93 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 94 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 96 |
Error | misc | FinalParameters | Parameter destination should be final. | 101 |
Error | coding | HiddenField | 'destination' hides a field. | 101 |
Error | sizes | LineLength | Line is longer than 80 characters (found 96). | 105 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'withDestination' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'withDestination' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 105 |
Error | misc | FinalParameters | Parameter destination should be final. | 105 |
Error | coding | HiddenField | 'destination' hides a field. | 105 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'getAdditionalProperties' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'getAdditionalProperties' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 115 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'setAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'setAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 120 |
Error | misc | FinalParameters | Parameter name should be final. | 121 |
Error | misc | FinalParameters | Parameter value should be final. | 121 |
Error | sizes | LineLength | Line is longer than 80 characters (found 93). | 125 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'withAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'withAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 125 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 125 |
Error | misc | FinalParameters | Parameter name should be final. | 125 |
Error | misc | FinalParameters | Parameter value should be final. | 125 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 130 |
Error | sizes | LineLength | Line is longer than 80 characters (found 114). | 132 |
Error | design | DesignForExtension | Class 'ElasticsearchHdfsConfiguration' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ElasticsearchHdfsConfiguration' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
Error | misc | FinalParameters | Parameter other should be final. | 136 |
Error | coding | SimplifyBooleanExpression | Expression can be simplified. | 140 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 143 |
Error | sizes | LineLength | Line is longer than 80 characters (found 165). | 144 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | sizes | LineLength | Line is longer than 80 characters (found 82). | 34 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 38 |
Error | sizes | LineLength | Line is longer than 80 characters (found 88). | 40 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
Error | modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 40 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
Error | design | VisibilityModifier | Variable 'config' must be private and have accessor methods. | 42 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 44 |
Error | sizes | LineLength | Line is longer than 80 characters (found 129). | 45 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 48 |
Error | misc | FinalParameters | Parameter reindex should be final. | 48 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 52 |
Error | misc | FinalParameters | Parameter args should be final. | 52 |
Error | blocks | LeftCurly | '{' at column 3 should be on the previous line. | 53 |
Error | design | DesignForExtension | Class 'HdfsElasticsearch' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearch' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
Error | sizes | LineLength | Line is longer than 80 characters (found 93). | 62 |
Error | sizes | LineLength | Line is longer than 80 characters (found 116). | 63 |
Error | sizes | LineLength | Line is longer than 80 characters (found 132). | 66 |
Error | sizes | LineLength | Line is longer than 80 characters (found 100). | 69 |
Error | sizes | LineLength | Line is longer than 80 characters (found 167). | 70 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocType | Missing a Javadoc comment. | 22 |
Error | blocks | LeftCurly | '{' at column 1 should be on the previous line. | 29 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 31 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 32 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 34 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 40 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 41 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 43 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
Error | sizes | LineLength | Line is longer than 80 characters (found 85). | 50 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 52 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 53 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 55 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 64 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 65 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 67 |
Error | misc | FinalParameters | Parameter source should be final. | 72 |
Error | coding | HiddenField | 'source' hides a field. | 72 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 76 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'withSource' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'withSource' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 76 |
Error | misc | FinalParameters | Parameter source should be final. | 76 |
Error | coding | HiddenField | 'source' hides a field. | 76 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 81 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 82 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 84 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 93 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 94 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 96 |
Error | misc | FinalParameters | Parameter destination should be final. | 101 |
Error | coding | HiddenField | 'destination' hides a field. | 101 |
Error | sizes | LineLength | Line is longer than 80 characters (found 105). | 105 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'withDestination' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'withDestination' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 105 |
Error | misc | FinalParameters | Parameter destination should be final. | 105 |
Error | coding | HiddenField | 'destination' hides a field. | 105 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'getAdditionalProperties' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'getAdditionalProperties' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 115 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'setAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'setAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 120 |
Error | misc | FinalParameters | Parameter name should be final. | 121 |
Error | misc | FinalParameters | Parameter value should be final. | 121 |
Error | sizes | LineLength | Line is longer than 80 characters (found 93). | 125 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'withAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'withAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 125 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 125 |
Error | misc | FinalParameters | Parameter name should be final. | 125 |
Error | misc | FinalParameters | Parameter value should be final. | 125 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 130 |
Error | sizes | LineLength | Line is longer than 80 characters (found 114). | 132 |
Error | design | DesignForExtension | Class 'HdfsElasticsearchConfiguration' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HdfsElasticsearchConfiguration' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
Error | misc | FinalParameters | Parameter other should be final. | 136 |
Error | coding | SimplifyBooleanExpression | Expression can be simplified. | 140 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 143 |
Error | sizes | LineLength | Line is longer than 80 characters (found 165). | 144 |