The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference in org.apache.maven.archetype.DefaultArchetypeManager.zipper(ZipOutputStream, int, File) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 117 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.DefaultArchetypeManager.zip(File, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 93 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.getArchetypeJarLoader(File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | MALICIOUS_CODE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 109 | Medium |
Load of known null value in org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.loadFileSetArchetypeDescriptor(ZipFile) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 518 | Medium |
Load of known null value in org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.loadOldArchetypeDescriptor(ZipFile) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 548 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.common.DefaultArchetypeFilesResolver.resolveFiles(File, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 305 | Medium |
Useless object stored in variable includes of method org.apache.maven.archetype.common.DefaultArchetypeFilesResolver.findOtherResources(int, List, List, String) | STYLE | UC_USELESS_OBJECT | 111 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.common.DefaultPomManager.mergeModelBase(ModelBase, ModelBase) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 447 | Medium |
org.apache.maven.archetype.common.DefaultPomManager.mergeReportPlugins(Model, Model) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 480 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.common.MavenJDOMWriter.findAndReplaceProperties(MavenJDOMWriter$Counter, Element, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 198 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.maven.archetype.common.MavenJDOMWriter$Counter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 2304-2346 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in new org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy(Format, String) | STYLE | REC_CATCH_EXCEPTION | 500 | Medium |
Exception is caught when Exception is not thrown in org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy.shouldEscape(char) | STYLE | REC_CATCH_EXCEPTION | 529 | Medium |
Should org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 470-536 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.common.util.ListScanner.DEFAULTEXCLUDES is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 118 | High |
Unread public/protected field: org.apache.maven.archetype.common.util.ListScanner.everythingIncluded | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 157 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.maven.archetype.common.util.XMLOutputter$NamespaceStack be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1791 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.copyFiles(File, File, String, List, boolean, String, Properties) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 812 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetype(ArchetypeCreationRequest, ArchetypeCreationResult) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 131 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeBasicIt(ArchetypeDescriptor, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 324 | Medium |
Exceptional return value of java.io.File.delete() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 890 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 878 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeProjectPom(MavenProject, ProjectBuildingRequest, Properties, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 457 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModule(Properties, String, String, String, File, File, List, List, String, boolean, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1011 | Medium |
Exceptional return value of java.io.File.delete() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1119 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1107 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.processFileSet(File, File, String, List, boolean, String, Properties, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1336 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createFileSets(List, int, boolean, String, boolean, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 986 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of request in org.apache.maven.archetype.generator.DefaultArchetypeGenerator.getArchetypeFile(ArchetypeGenerationRequest, ArtifactRepository) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 86 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.copyFile(File, String, boolean, ZipFile) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 302 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processFilesetModule(String, String, List, File, ZipFile, String, File, File, String, AbstractArchetypeDescriptor, Context) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 589 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplate(File, Context, String, String, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 752 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplates(String, File, Context, AbstractArchetypeDescriptor, List, ZipFile, String, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 812 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Boxing/unboxing to parse a primitive org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 392 | High |
Boxing/unboxing to parse a primitive org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 422 | High |
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 177 | Medium |
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getDateValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 265 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.old.DefaultOldArchetype.createArchetype(ArchetypeGenerationRequest, File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | MALICIOUS_CODE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 181 | Medium |
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.old.DefaultOldArchetype.processTemplate(String, Context, String, TemplateDescriptor, boolean, String, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 839 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.apache.maven.archetype.old.descriptor.TemplateDescriptor.getDefaultEncoding(): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 67 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exceptional return value of java.io.File.delete() ignored in org.apache.maven.archetype.source.RemoteCatalogArchetypeDataSource.downloadCatalog(ArtifactRepository) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 171 | Medium |