Apache logging services logo Apache log4j logo

PMD Results

The following document contains the results of PMD 5.3.5.

Files

org/apache/logging/log4j/core/appender/AsyncAppender.java

Violation Line
Avoid empty catch blocks 408410
Avoid empty catch blocks 453455

org/apache/logging/log4j/core/appender/ConsoleAppender.java

Violation Line
Useless parentheses. 229

org/apache/logging/log4j/core/appender/MemoryMappedFileManager.java

Violation Line
Useless parentheses. 348

org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java

Violation Line
Avoid unused constructor parameters such as 'bufferSize'. 59

org/apache/logging/log4j/core/appender/SocketAppender.java

Violation Line
Do not use if statements that are always true or always false 286

org/apache/logging/log4j/core/appender/db/jdbc/ColumnConfig.java

Violation Line
Useless parentheses. 120
Useless parentheses. 120
Useless parentheses. 120

org/apache/logging/log4j/core/appender/db/jpa/converter/StackTraceElementAttributeConverter.java

Violation Line
Avoid empty catch blocks 7173

org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java

Violation Line
Avoid empty catch blocks 8183

org/apache/logging/log4j/core/appender/rolling/CronTriggeringPolicy.java

Violation Line
These nested if statements could be combined 6870

org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java

Violation Line
Avoid unused private methods such as 'patternContains(String,char)'. 298

org/apache/logging/log4j/core/appender/rolling/RollingFileManager.java

Violation Line
Avoid unused constructor parameters such as 'bufferSize'. 68

org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java

Violation Line
Avoid unused constructor parameters such as 'immediateFlush'. 51

org/apache/logging/log4j/core/appender/rolling/action/Duration.java

Violation Line
These nested if statements could be combined 122138
Useless parentheses. 168

org/apache/logging/log4j/core/appender/rolling/action/FileRenameAction.java

Violation Line
Useless parentheses. 105
Useless parentheses. 107

org/apache/logging/log4j/core/appender/rolling/action/ScriptCondition.java

Violation Line
These nested if statements could be combined 111114

org/apache/logging/log4j/core/async/AsyncLogger.java

Violation Line
Avoid unused local variables such as 'value'. 322

org/apache/logging/log4j/core/async/AsyncLoggerConfigDisruptor.java

Violation Line
Useless parentheses. 200

org/apache/logging/log4j/core/async/RingBufferLogEvent.java

Violation Line
Useless parentheses. 216
These nested if statements could be combined 307309
These nested if statements could be combined 318320

org/apache/logging/log4j/core/config/ConfigurationSource.java

Violation Line
Avoid empty catch blocks 144146
Avoid empty catch blocks 158160

org/apache/logging/log4j/core/config/LoggerConfig.java

Violation Line
Overriding method merely calls super 160162

org/apache/logging/log4j/core/config/plugins/visitors/PluginElementVisitor.java

Violation Line
Avoid empty if statements 100102

org/apache/logging/log4j/core/config/xml/XmlConfiguration.java

Violation Line
Useless parentheses. 297

org/apache/logging/log4j/core/filter/MapFilter.java

Violation Line
Useless parentheses. 81
Useless parentheses. 81
Useless parentheses. 93
Useless parentheses. 93

org/apache/logging/log4j/core/filter/ScriptFilter.java

Violation Line
These nested if statements could be combined 145148

org/apache/logging/log4j/core/filter/StructuredDataFilter.java

Violation Line
Useless parentheses. 76
Useless parentheses. 76

org/apache/logging/log4j/core/filter/ThreadContextMapFilter.java

Violation Line
Useless parentheses. 105
Useless parentheses. 105

org/apache/logging/log4j/core/impl/Log4jContextFactory.java

Violation Line
Useless parentheses. 259

org/apache/logging/log4j/core/impl/ThrowableFormatOptions.java

Violation Line
Avoid empty if statements 252254

org/apache/logging/log4j/core/impl/ThrowableProxy.java

Violation Line
Avoid empty catch blocks 543545
Avoid unused method parameters such as 'stackTraceElement'. 573
Avoid empty catch blocks 594596

org/apache/logging/log4j/core/jackson/ExtendedStackTraceElementMixIn.java

Violation Line
Avoid unused constructor parameters such as 'declaringClass'. 41
Avoid unused constructor parameters such as 'methodName'. 42
Avoid unused constructor parameters such as 'fileName'. 43
Avoid unused constructor parameters such as 'lineNumber'. 44
Avoid unused constructor parameters such as 'exact'. 45
Avoid unused constructor parameters such as 'location'. 46
Avoid unused constructor parameters such as 'version'. 47

org/apache/logging/log4j/core/jackson/Log4jStackTraceElementDeserializer.java

Violation Line
Avoid empty if statements 7274

org/apache/logging/log4j/core/jackson/MarkerMixIn.java

Violation Line
Avoid unused constructor parameters such as 'name'. 61

org/apache/logging/log4j/core/jackson/StackTraceElementMixIn.java

Violation Line
Avoid unused constructor parameters such as 'declaringClass'. 37
Avoid unused constructor parameters such as 'methodName'. 38
Avoid unused constructor parameters such as 'fileName'. 39
Avoid unused constructor parameters such as 'lineNumber'. 40

org/apache/logging/log4j/core/jackson/ThrowableProxyMixIn.java

Violation Line
Avoid unused private fields such as 'causeProxy'. 34
Avoid unused private fields such as 'commonElementCount'. 38
Avoid unused private fields such as 'extendedStackTrace'. 43
Avoid unused private fields such as 'localizedMessage'. 47
Avoid unused private fields such as 'message'. 51
Avoid unused private fields such as 'name'. 55
Avoid unused private fields such as 'throwable'. 58

org/apache/logging/log4j/core/jackson/ThrowableProxyWithoutStacktraceMixIn.java

Violation Line
Avoid unused private fields such as 'causeProxy'. 33
Avoid unused private fields such as 'commonElementCount'. 37
Avoid unused private fields such as 'extendedStackTrace'. 40
Avoid unused private fields such as 'localizedMessage'. 44
Avoid unused private fields such as 'message'. 48
Avoid unused private fields such as 'name'. 52
Avoid unused private fields such as 'throwable'. 55

org/apache/logging/log4j/core/jmx/Server.java

Violation Line
Avoid unused method parameters such as 'executor'. 279
Avoid unused method parameters such as 'executor'. 351
Avoid unused method parameters such as 'executor'. 368

org/apache/logging/log4j/core/layout/HtmlLayout.java

Violation Line
Avoid empty catch blocks 231233

org/apache/logging/log4j/core/layout/LockingStringBuilderEncoder.java

Violation Line
Avoid unused private methods such as 'getCharBuffer()'. 48
Avoid unused method parameters such as 'destination'. 66

org/apache/logging/log4j/core/layout/Rfc5424Layout.java

Violation Line
Avoid unused private fields such as 'eventPrefix'. 107
Useless parentheses. 335
Useless parentheses. 358
Useless parentheses. 498

org/apache/logging/log4j/core/layout/ScriptPatternSelector.java

Violation Line
These nested if statements could be combined 113116

org/apache/logging/log4j/core/layout/StringBuilderEncoder.java

Violation Line
Avoid unused method parameters such as 'destination'. 125

org/apache/logging/log4j/core/net/MulticastDnsAdvertiser.java

Violation Line
Avoid empty catch blocks 9294
Avoid empty catch blocks 197199

org/apache/logging/log4j/core/net/TcpSocketManager.java

Violation Line
Avoid empty catch blocks 228230

org/apache/logging/log4j/core/net/server/AbstractSocketServer.java

Violation Line
Avoid empty catch blocks 128130
Avoid empty catch blocks 135137
Avoid empty catch blocks 137139
Avoid empty catch blocks 146148

org/apache/logging/log4j/core/net/server/TcpSocketServer.java

Violation Line
Avoid empty catch blocks 99101

org/apache/logging/log4j/core/pattern/AnsiEscape.java

Violation Line
Avoid empty catch blocks 326328

org/apache/logging/log4j/core/pattern/CachedDateFormat.java

Violation Line
Useless parentheses. 211
Useless parentheses. 268
Useless parentheses. 268
Useless parentheses. 268
Useless parentheses. 381
Useless parentheses. 381

org/apache/logging/log4j/core/pattern/HtmlTextRenderer.java

Violation Line
Avoid unused constructor parameters such as 'formats'. 24

org/apache/logging/log4j/core/pattern/JAnsiTextRenderer.java

Violation Line
Too many static imports may lead to messy code 17332
Avoid unused private methods such as 'render(Ansi,Code...)'. 249

org/apache/logging/log4j/core/pattern/MarkerPatternConverter.java

Violation Line
Avoid unused constructor parameters such as 'options'. 34

org/apache/logging/log4j/core/pattern/MarkerSimpleNamePatternConverter.java

Violation Line
Avoid unused constructor parameters such as 'options'. 34

org/apache/logging/log4j/core/pattern/NameAbbreviator.java

Violation Line
Useless parentheses. 292

org/apache/logging/log4j/core/pattern/NanoTimePatternConverter.java

Violation Line
Avoid unused constructor parameters such as 'options'. 35

org/apache/logging/log4j/core/pattern/PatternParser.java

Violation Line
Avoid unused constructor parameters such as 'expectedClass'. 127
These nested if statements could be combined 180182

org/apache/logging/log4j/core/pattern/UuidPatternConverter.java

Violation Line
Useless parentheses. 53

org/apache/logging/log4j/core/util/Booleans.java

Violation Line
Useless parentheses. 37

org/apache/logging/log4j/core/util/Closer.java

Violation Line
Avoid empty catch blocks 7274
Avoid empty catch blocks 9799
Avoid empty catch blocks 123125
Avoid empty catch blocks 149151

org/apache/logging/log4j/core/util/CronExpression.java

Violation Line
Useless parentheses. 294
Useless parentheses. 294
Useless parentheses. 294
These nested if statements could be combined 483486
Useless parentheses. 505
Useless parentheses. 505
Useless parentheses. 505
Useless parentheses. 505
Useless parentheses. 505
Useless parentheses. 575
Useless parentheses. 623
Useless parentheses. 625
Useless parentheses. 627
Useless parentheses. 629
Useless parentheses. 768
Useless parentheses. 938
Useless parentheses. 944
Useless parentheses. 949
Useless parentheses. 950
Useless parentheses. 955
These nested if statements could be combined 960964
Useless parentheses. 960
Useless parentheses. 961
Useless parentheses. 1113
Unnecessary use of fully qualified name 'java.util.Calendar' due to existing import 'java.util.Calendar' 1262
Unnecessary use of fully qualified name 'java.util.Calendar.getInstance' due to existing import 'java.util.Calendar' 1262
Unnecessary use of fully qualified name 'java.util.Calendar.getInstance' due to existing import 'java.util.Calendar' 1298
Unnecessary use of fully qualified name 'java.util.Calendar' due to existing import 'java.util.Calendar' 1298
Unnecessary use of fully qualified name 'java.util.Calendar.HOUR_OF_DAY' due to existing import 'java.util.Calendar' 1562
Unnecessary use of fully qualified name 'java.util.Calendar.HOUR_OF_DAY' due to existing import 'java.util.Calendar' 1563
Unnecessary use of fully qualified name 'java.util.Calendar.HOUR_OF_DAY' due to existing import 'java.util.Calendar' 1564
Useless parentheses. 1587
Useless parentheses. 1587
Useless parentheses. 1596

org/apache/logging/log4j/core/util/FileUtils.java

Violation Line
Useless parentheses. 5556
Useless parentheses. 5556

org/apache/logging/log4j/core/util/IOUtils.java

Violation Line
Avoid unused imports such as 'java.io.InputStream' 20
Avoid unused imports such as 'java.io.OutputStream' 21

org/apache/logging/log4j/core/util/JsonUtils.java

Violation Line
Useless parentheses. 72

org/apache/logging/log4j/core/util/Log4jThreadFactory.java

Violation Line
Avoid using java.lang.ThreadGroup; it is not thread safe 77

org/apache/logging/log4j/core/util/StringEncoder.java

Violation Line
Useless parentheses. 81
Useless parentheses. 97
Useless parentheses. 97
Useless parentheses. 98
Useless parentheses. 105

org/apache/logging/log4j/core/util/Throwables.java

Violation Line
Avoid empty catch blocks 6264

org/apache/logging/log4j/core/util/Transform.java

Violation Line
Useless parentheses. 5053
Useless parentheses. 127134

org/apache/logging/log4j/core/util/TypeUtil.java

Violation Line
Useless parentheses. 219
Useless parentheses. 219
Useless parentheses. 219

org/apache/logging/log4j/core/util/UuidUtil.java

Violation Line
Useless parentheses. 143
Useless parentheses. 143144
Avoid empty catch blocks 183185