Apache logging services logo Apache log4j logo

Checkstyle Results

The following document contains the results of Checkstyle 6.11.2 with /Users/rgoers/projects/apache/logging/log4j/log4j2/log4j-2.7/logging-log4j2/log4j-api/../checkstyle.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
108 2 0 196

Files

File  I  W  E
org/apache/logging/log4j/CloseableThreadContext.java 0 0 8
org/apache/logging/log4j/LogManager.java 1 0 0
org/apache/logging/log4j/Logger.java 0 0 31
org/apache/logging/log4j/MarkerManager.java 1 0 0
org/apache/logging/log4j/message/AbstractMessageFactory.java 0 0 17
org/apache/logging/log4j/message/DefaultFlowMessageFactory.java 0 0 6
org/apache/logging/log4j/message/EntryMessage.java 0 0 1
org/apache/logging/log4j/message/ExitMessage.java 0 0 1
org/apache/logging/log4j/message/FlowMessage.java 0 0 2
org/apache/logging/log4j/message/FormattedMessage.java 0 0 5
org/apache/logging/log4j/message/FormattedMessageFactory.java 0 0 7
org/apache/logging/log4j/message/LocalizedMessageFactory.java 0 0 1
org/apache/logging/log4j/message/Message.java 0 0 2
org/apache/logging/log4j/message/MessageFormatMessageFactory.java 0 0 7
org/apache/logging/log4j/message/ParameterizedMessage.java 0 0 7
org/apache/logging/log4j/message/ParameterizedMessageFactory.java 0 0 7
org/apache/logging/log4j/message/ParameterizedNoReferenceMessageFactory.java 0 0 4
org/apache/logging/log4j/message/ReusableParameterizedMessage.java 0 0 31
org/apache/logging/log4j/message/ReusableSimpleMessage.java 0 0 2
org/apache/logging/log4j/message/SimpleMessage.java 0 0 1
org/apache/logging/log4j/message/SimpleMessageFactory.java 0 0 7
org/apache/logging/log4j/message/StringFormatterMessageFactory.java 0 0 7
org/apache/logging/log4j/simple/SimpleLoggerContext.java 0 0 2
org/apache/logging/log4j/spi/AbstractLogger.java 0 0 12
org/apache/logging/log4j/spi/CopyOnWriteSortedArrayThreadContextMap.java 0 0 2
org/apache/logging/log4j/spi/DefaultThreadContextMap.java 0 0 1
org/apache/logging/log4j/spi/GarbageFreeSortedArrayThreadContextMap.java 0 0 2
org/apache/logging/log4j/spi/LoggerContextKey.java 0 0 1
org/apache/logging/log4j/spi/LoggerRegistry.java 0 0 1
org/apache/logging/log4j/spi/MutableThreadContextStack.java 0 0 2
org/apache/logging/log4j/util/Constants.java 0 0 1
org/apache/logging/log4j/util/LambdaUtil.java 0 0 1
org/apache/logging/log4j/util/LoaderUtil.java 0 0 2
org/apache/logging/log4j/util/LowLevelLogUtil.java 0 0 2
org/apache/logging/log4j/util/MessageSupplier.java 0 0 1
org/apache/logging/log4j/util/PerformanceSensitive.java 0 0 1
org/apache/logging/log4j/util/PropertiesUtil.java 0 0 1
org/apache/logging/log4j/util/ProviderUtil.java 0 0 1
org/apache/logging/log4j/util/ReadOnlyStringMap.java 0 0 1
org/apache/logging/log4j/util/SortedArrayStringMap.java 0 0 2
org/apache/logging/log4j/util/StringMap.java 0 0 1
org/apache/logging/log4j/util/Strings.java 0 0 1
org/apache/logging/log4j/util/Unbox.java 0 0 4

Details

org/apache/logging/log4j/CloseableThreadContext.java

Severity Category Rule Message Line
 Error design FinalClass Class CloseableThreadContext should be declared as final. 36
 Error design FinalClass Class Instance should be declared as final. 77
 Error javadoc JavadocType Missing a Javadoc comment. 77
 Error sizes LineLength Line is longer than 120 characters (found 124). 86
 Error sizes LineLength Line is longer than 120 characters (found 124). 99
 Error sizes LineLength Line is longer than 120 characters (found 123). 114
 Error sizes LineLength Line is longer than 120 characters (found 142). 136
 Error whitespace EmptyForIteratorPad ';' is followed by whitespace. 146

org/apache/logging/log4j/LogManager.java

Severity Category Rule Message Line
 Info misc TodoComment Comment matches to-do format 'TODO:'. 172

org/apache/logging/log4j/Logger.java

Severity Category Rule Message Line
 Error imports UnusedImports Unused import - org.apache.logging.log4j.message.MessageFactory2. 22
 Error sizes LineLength Line is longer than 120 characters (found 122). 458
 Error sizes LineLength Line is longer than 120 characters (found 122). 476
 Error sizes LineLength Line is longer than 120 characters (found 122). 495
 Error sizes LineLength Line is longer than 120 characters (found 124). 634
 Error sizes LineLength Line is longer than 120 characters (found 122). 1020
 Error sizes LineLength Line is longer than 120 characters (found 122). 1038
 Error sizes LineLength Line is longer than 120 characters (found 122). 1057
 Error sizes LineLength Line is longer than 120 characters (found 122). 1576
 Error sizes LineLength Line is longer than 120 characters (found 122). 1594
 Error sizes LineLength Line is longer than 120 characters (found 122). 1613
 Error javadoc JavadocMethod Expected @param tag for '<MF>'. 1761
 Error sizes LineLength Line is longer than 120 characters (found 121). 2137
 Error sizes LineLength Line is longer than 120 characters (found 121). 2155
 Error sizes LineLength Line is longer than 120 characters (found 121). 2174
 Error sizes LineLength Line is longer than 120 characters (found 121). 2478
 Error sizes LineLength Line is longer than 120 characters (found 121). 2626
 Error sizes LineLength Line is longer than 120 characters (found 123). 2786
 Error sizes LineLength Line is longer than 120 characters (found 122). 2802
 Error sizes LineLength Line is longer than 120 characters (found 133). 2820
 Error sizes LineLength Line is longer than 120 characters (found 133). 2839
 Error sizes LineLength Line is longer than 120 characters (found 133). 2859
 Error sizes LineLength Line is longer than 120 characters (found 130). 2960
 Error sizes LineLength Line is longer than 120 characters (found 129). 2977
 Error sizes LineLength Line is longer than 120 characters (found 129). 2996
 Error sizes LineLength Line is longer than 120 characters (found 122). 3418
 Error sizes LineLength Line is longer than 120 characters (found 122). 3436
 Error sizes LineLength Line is longer than 120 characters (found 122). 3455
 Error sizes LineLength Line is longer than 120 characters (found 121). 4135
 Error sizes LineLength Line is longer than 120 characters (found 121). 4153
 Error sizes LineLength Line is longer than 120 characters (found 121). 4172

org/apache/logging/log4j/MarkerManager.java

Severity Category Rule Message Line
 Info misc TodoComment Comment matches to-do format 'TODO:'. 144

org/apache/logging/log4j/message/AbstractMessageFactory.java

Severity Category Rule Message Line
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 67
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 75
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 83
 Error sizes LineLength Line is longer than 120 characters (found 121). 90
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 91
 Error sizes LineLength Line is longer than 120 characters (found 138). 98
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 99
 Error sizes LineLength Line is longer than 120 characters (found 155). 106
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 107
 Error sizes LineLength Line is longer than 120 characters (found 153). 114
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 116
 Error sizes LineLength Line is longer than 120 characters (found 153). 123
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 125
 Error sizes LineLength Line is longer than 120 characters (found 153). 132
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 134
 Error sizes LineLength Line is longer than 120 characters (found 153). 141
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 143

org/apache/logging/log4j/message/DefaultFlowMessageFactory.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 53
 Error javadoc JavadocType Missing a Javadoc comment. 107
 Error javadoc JavadocType Missing a Javadoc comment. 117
 Error sizes LineLength Line is longer than 120 characters (found 125). 188
 Error sizes LineLength Line is longer than 120 characters (found 143). 198
 Error sizes LineLength Line is longer than 120 characters (found 138). 208

org/apache/logging/log4j/message/EntryMessage.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 19

org/apache/logging/log4j/message/ExitMessage.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 19

org/apache/logging/log4j/message/FlowMessage.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 19
 Error javadoc JavadocStyle First sentence should end with a period. 33

org/apache/logging/log4j/message/FormattedMessage.java

Severity Category Rule Message Line
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 55
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 67
 Error sizes LineLength Line is longer than 120 characters (found 132). 89
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 102
 Error whitespace NoWhitespaceAfter '{' is followed by whitespace. 112

org/apache/logging/log4j/message/FormattedMessageFactory.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 121). 81
 Error sizes LineLength Line is longer than 120 characters (found 138). 89
 Error sizes LineLength Line is longer than 120 characters (found 155). 97
 Error sizes LineLength Line is longer than 120 characters (found 153). 105
 Error sizes LineLength Line is longer than 120 characters (found 153). 114
 Error sizes LineLength Line is longer than 120 characters (found 153). 123
 Error sizes LineLength Line is longer than 120 characters (found 153). 132

org/apache/logging/log4j/message/LocalizedMessageFactory.java

Severity Category Rule Message Line
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 35

org/apache/logging/log4j/message/Message.java

Severity Category Rule Message Line
 Error imports ImportOrder 'org.apache.logging.log4j.util.StringBuilderFormattable' should be separated from previous imports. 20
 Error imports UnusedImports Unused import - org.apache.logging.log4j.util.StringBuilderFormattable. 20

org/apache/logging/log4j/message/MessageFormatMessageFactory.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 121). 79
 Error sizes LineLength Line is longer than 120 characters (found 138). 87
 Error sizes LineLength Line is longer than 120 characters (found 155). 95
 Error sizes LineLength Line is longer than 120 characters (found 153). 103
 Error sizes LineLength Line is longer than 120 characters (found 153). 112
 Error sizes LineLength Line is longer than 120 characters (found 153). 121
 Error sizes LineLength Line is longer than 120 characters (found 153). 130

org/apache/logging/log4j/message/ParameterizedMessage.java

Severity Category Rule Message Line
 Error coding DeclarationOrder Variable access definition in wrong order. 39
 Error coding DeclarationOrder Variable access definition in wrong order. 43
 Error coding DeclarationOrder Variable access definition in wrong order. 48
 Error coding DeclarationOrder Variable access definition in wrong order. 53
 Error coding DeclarationOrder Variable access definition in wrong order. 58
 Error coding DeclarationOrder Variable access definition in wrong order. 63
 Error coding HiddenField 'messagePattern' hides a field. 143

org/apache/logging/log4j/message/ParameterizedMessageFactory.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 121). 94
 Error sizes LineLength Line is longer than 120 characters (found 138). 102
 Error sizes LineLength Line is longer than 120 characters (found 155). 110
 Error sizes LineLength Line is longer than 120 characters (found 153). 118
 Error sizes LineLength Line is longer than 120 characters (found 153). 127
 Error sizes LineLength Line is longer than 120 characters (found 153). 136
 Error sizes LineLength Line is longer than 120 characters (found 153). 145

org/apache/logging/log4j/message/ParameterizedNoReferenceMessageFactory.java

Severity Category Rule Message Line
 Error imports UnusedImports Unused import - org.apache.logging.log4j.status.StatusLogger. 19
 Error modifier RedundantModifier Redundant 'public' modifier. 52
 Error coding DeclarationOrder Static variable definition in wrong order. 88
 Error coding DeclarationOrder Variable access definition in wrong order. 88

org/apache/logging/log4j/message/ReusableParameterizedMessage.java

Severity Category Rule Message Line
 Error coding MagicNumber '256' is a magic number. 41
 Error coding DeclarationOrder Variable access definition in wrong order. 45
 Error design VisibilityModifier Variable 'reserved' must be private and have accessor methods. 45
 Error coding HiddenField 'messagePattern' hides a field. 108
 Error coding HiddenField 'argCount' hides a field. 108
 Error coding HiddenField 'params' hides a field. 126
 Error coding HiddenField 'argCount' hides a field. 126
 Error coding HiddenField 'messagePattern' hides a field. 134
 Error coding HiddenField 'messagePattern' hides a field. 140
 Error coding HiddenField 'messagePattern' hides a field. 146
 Error coding HiddenField 'messagePattern' hides a field. 153
 Error sizes LineLength Line is longer than 120 characters (found 135). 161
 Error coding HiddenField 'messagePattern' hides a field. 161
 Error sizes LineLength Line is longer than 120 characters (found 152). 170
 Error coding HiddenField 'messagePattern' hides a field. 170
 Error sizes LineLength Line is longer than 120 characters (found 169). 180
 Error coding HiddenField 'messagePattern' hides a field. 180
 Error sizes LineLength Line is longer than 120 characters (found 167). 191
 Error coding HiddenField 'messagePattern' hides a field. 191
 Error sizes LineLength Line is longer than 120 characters (found 167). 204
 Error coding HiddenField 'messagePattern' hides a field. 204
 Error coding MagicNumber '8' is a magic number. 214
 Error sizes LineLength Line is longer than 120 characters (found 167). 218
 Error coding HiddenField 'messagePattern' hides a field. 218
 Error coding MagicNumber '8' is a magic number. 228
 Error coding MagicNumber '9' is a magic number. 229
 Error sizes LineLength Line is longer than 120 characters (found 167). 233
 Error coding HiddenField 'messagePattern' hides a field. 233
 Error coding MagicNumber '8' is a magic number. 243
 Error coding MagicNumber '9' is a magic number. 244
 Error coding MagicNumber '10' is a magic number. 245

org/apache/logging/log4j/message/ReusableSimpleMessage.java

Severity Category Rule Message Line
 Error naming StaticVariableName Name 'EMPTY_PARAMS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 28
 Error coding HiddenField 'charSequence' hides a field. 35

org/apache/logging/log4j/message/SimpleMessage.java

Severity Category Rule Message Line
 Error imports ImportOrder 'org.apache.logging.log4j.util.StringBuilderFormattable' should be separated from previous imports. 22

org/apache/logging/log4j/message/SimpleMessageFactory.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 121). 92
 Error sizes LineLength Line is longer than 120 characters (found 138). 100
 Error sizes LineLength Line is longer than 120 characters (found 155). 108
 Error sizes LineLength Line is longer than 120 characters (found 153). 116
 Error sizes LineLength Line is longer than 120 characters (found 153). 125
 Error sizes LineLength Line is longer than 120 characters (found 153). 134
 Error sizes LineLength Line is longer than 120 characters (found 153). 143

org/apache/logging/log4j/message/StringFormatterMessageFactory.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 121). 93
 Error sizes LineLength Line is longer than 120 characters (found 138). 101
 Error sizes LineLength Line is longer than 120 characters (found 155). 109
 Error sizes LineLength Line is longer than 120 characters (found 153). 117
 Error sizes LineLength Line is longer than 120 characters (found 153). 126
 Error sizes LineLength Line is longer than 120 characters (found 153). 135
 Error sizes LineLength Line is longer than 120 characters (found 153). 144

org/apache/logging/log4j/simple/SimpleLoggerContext.java

Severity Category Rule Message Line
 Error coding DeclarationOrder Variable access definition in wrong order. 41
 Error coding DeclarationOrder Variable access definition in wrong order. 44

org/apache/logging/log4j/spi/AbstractLogger.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 98
 Error sizes LineLength Line is longer than 120 characters (found 136). 203
 Error sizes LineLength Line is longer than 120 characters (found 130). 1769
 Error sizes LineLength Line is longer than 120 characters (found 128). 1774
 Error sizes LineLength Line is longer than 120 characters (found 128). 1780
 Error sizes LineLength Line is longer than 120 characters (found 128). 1786
 Error sizes LineLength Line is longer than 120 characters (found 128). 1792
 Error sizes LineLength Line is longer than 120 characters (found 128). 1798
 Error sizes LineLength Line is longer than 120 characters (found 128). 1804
 Error sizes LineLength Line is longer than 120 characters (found 135). 2425
 Error sizes LineLength Line is longer than 120 characters (found 135). 2433
 Error sizes LineLength Line is longer than 120 characters (found 135). 2442

org/apache/logging/log4j/spi/CopyOnWriteSortedArrayThreadContextMap.java

Severity Category Rule Message Line
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.util.PropertiesUtil' import. 26
 Error modifier RedundantModifier Redundant 'public' modifier. 62

org/apache/logging/log4j/spi/DefaultThreadContextMap.java

Severity Category Rule Message Line
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.util.PropertiesUtil' import. 25

org/apache/logging/log4j/spi/GarbageFreeSortedArrayThreadContextMap.java

Severity Category Rule Message Line
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.util.PropertiesUtil' import. 25
 Error modifier RedundantModifier Redundant 'public' modifier. 57

org/apache/logging/log4j/spi/LoggerContextKey.java

Severity Category Rule Message Line
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 28

org/apache/logging/log4j/spi/LoggerRegistry.java

Severity Category Rule Message Line
 Error javadoc JavadocType Type Javadoc comment is missing an @param <T> tag. 32

org/apache/logging/log4j/spi/MutableThreadContextStack.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 26
 Error javadoc JavadocMethod Expected @param tag for 'list'. 50

org/apache/logging/log4j/util/Constants.java

Severity Category Rule Message Line
 Error coding DeclarationOrder Constructor definition in wrong order. 60

org/apache/logging/log4j/util/LambdaUtil.java

Severity Category Rule Message Line
 Error javadoc JavadocMethod Expected @param tag for 'messageFactory'. 87

org/apache/logging/log4j/util/LoaderUtil.java

Severity Category Rule Message Line
 Error javadoc JavadocMethod Expected @param tag for '<T>'. 155
 Error javadoc JavadocMethod Expected @param tag for '<T>'. 178

org/apache/logging/log4j/util/LowLevelLogUtil.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 123). 26
 Error coding DeclarationOrder Constructor definition in wrong order. 65

org/apache/logging/log4j/util/MessageSupplier.java

Severity Category Rule Message Line
 Error regexp RegexpSingleline Line has trailing spaces. 31

org/apache/logging/log4j/util/PerformanceSensitive.java

Severity Category Rule Message Line
 Error javadoc JavadocMethod Expected an @return tag. 36

org/apache/logging/log4j/util/PropertiesUtil.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 122). 131

org/apache/logging/log4j/util/ProviderUtil.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 120 characters (found 124). 57

org/apache/logging/log4j/util/ReadOnlyStringMap.java

Severity Category Rule Message Line
 Error javadoc JavadocMethod Expected @param tag for '<V>'. 92

org/apache/logging/log4j/util/SortedArrayStringMap.java

Severity Category Rule Message Line
 Error coding MagicNumber '37' is a magic number. 412
 Error naming LocalFinalVariableName Name 'BITS_PER_INT' must match pattern '^[a-z][a-zA-Z0-9]*$'. 486

org/apache/logging/log4j/util/StringMap.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline.

org/apache/logging/log4j/util/Strings.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 140

org/apache/logging/log4j/util/Unbox.java

Severity Category Rule Message Line
 Error design FinalClass Class Unbox should be declared as final. 48
 Error coding MagicNumber '21' is a magic number. 74
 Error javadoc JavadocType Missing a Javadoc comment. 99
 Error coding MagicNumber '21' is a magic number. 104