Apache logging services logo Apache log4j logo
Apache Log4j Core ™

PMD Results

The following document contains the results of PMD 5.1.2.

Files

org/apache/logging/log4j/core/LoggerContext.java

ViolationLine
Avoid unused imports such as 'org.apache.logging.log4j.core.config.ConfigurationSource'38
Avoid unused private methods such as 'firePropertyChangeEvent(PropertyChangeEvent)'.382

org/apache/logging/log4j/core/appender/AsyncAppender.java

ViolationLine
Avoid empty catch blocks244–246
Avoid empty catch blocks290–292

org/apache/logging/log4j/core/appender/ConsoleAppender.java

ViolationLine
Avoid unused private methods such as 'getManager(boolean,Target,Layout)'.102

org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java

ViolationLine
Avoid unused constructor parameters such as 'bufferSize'.58

org/apache/logging/log4j/core/appender/TlsSyslogFrame.java

ViolationLine
Overriding method merely calls super59–61
Ensure you override both equals() and hashCode()59

org/apache/logging/log4j/core/appender/db/jdbc/ColumnConfig.java

ViolationLine
Useless parentheses.120
Useless parentheses.120
Useless parentheses.120

org/apache/logging/log4j/core/appender/db/jpa/converter/StackTraceElementAttributeConverter.java

ViolationLine
Avoid empty catch blocks71–73

org/apache/logging/log4j/core/appender/db/jpa/converter/ThrowableAttributeConverter.java

ViolationLine
Avoid unused private methods such as 'getThrowable(Class,String,Throwable)'.184
Avoid unused private methods such as 'getThrowable(Class,Throwable)'.206
Avoid unused private methods such as 'getThrowable(Class)'.231

org/apache/logging/log4j/core/appender/rewrite/RewriteAppender.java

ViolationLine
Avoid unused imports such as 'java.util.Map'19
Overriding method merely calls super73–75

org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java

ViolationLine
Useless parentheses.183
Avoid unused private methods such as 'patternContains(String,char)'.272

org/apache/logging/log4j/core/appender/rolling/SizeBasedTriggeringPolicy.java

ViolationLine
Avoid unused private methods such as 'valueOf(String)'.127

org/apache/logging/log4j/core/async/DaemonThreadFactory.java

ViolationLine
Avoid using java.lang.ThreadGroup; it is not thread safe35

org/apache/logging/log4j/core/async/RingBufferLogEvent.java

ViolationLine
These nested if statements could be combined163–165
These nested if statements could be combined174–176

org/apache/logging/log4j/core/config/AbstractConfiguration.java

ViolationLine
Avoid empty if statements178–186

org/apache/logging/log4j/core/config/ConfigurationFactory.java

ViolationLine
Avoid unused private methods such as 'addFactory(Collection,String)'.164

org/apache/logging/log4j/core/config/FileConfigurationMonitor.java

ViolationLine
Useless parentheses.77
Useless parentheses.77

org/apache/logging/log4j/core/config/LoggerConfig.java

ViolationLine
Overriding method merely calls super152–154

org/apache/logging/log4j/core/config/LoggersPlugin.java

ViolationLine
No need to import a type that lives in the same package22
No need to import a type that lives in the same package23

org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java

ViolationLine
Avoid unused private methods such as 'collectPlugins(Iterable)'.86

org/apache/logging/log4j/core/config/plugins/util/PluginManager.java

ViolationLine
Avoid unused method parameters such as 'preLoad'.163
Avoid unused method parameters such as 'start'.163
These nested if statements could be combined165–167

org/apache/logging/log4j/core/config/plugins/util/ResolverUtil.java

ViolationLine
Avoid unused private methods such as 'close(JarInputStream,Object)'.317
Avoid unused private methods such as 'loadImplementationsInJar(Test,String,String,JarInputStream)'.336–337

org/apache/logging/log4j/core/config/plugins/util/TypeConverters.java

ViolationLine
Avoid unused private fields such as 'INSTANCE'.221

org/apache/logging/log4j/core/config/plugins/visitors/AbstractPluginVisitor.java

ViolationLine
Avoid unused local variables such as 'a'.60

org/apache/logging/log4j/core/config/xml/XmlConfiguration.java

ViolationLine
Useless parentheses.273

org/apache/logging/log4j/core/filter/MapFilter.java

ViolationLine
Useless parentheses.82
Useless parentheses.82

org/apache/logging/log4j/core/filter/StructuredDataFilter.java

ViolationLine
Useless parentheses.74
Useless parentheses.74

org/apache/logging/log4j/core/impl/ThrowableFormatOptions.java

ViolationLine
Avoid empty if statements208–210

org/apache/logging/log4j/core/impl/ThrowableProxy.java

ViolationLine
Avoid unused method parameters such as 'element'.259
Avoid empty catch blocks504–506
Avoid unused method parameters such as 'stackTraceElement'.532
Avoid empty catch blocks553–555

org/apache/logging/log4j/core/jackson/ExtendedStackTraceElementMixIn.java

ViolationLine
Avoid unused constructor parameters such as 'declaringClass'.41
Avoid unused constructor parameters such as 'methodName'.42
Avoid unused constructor parameters such as 'fileName'.43
Avoid unused constructor parameters such as 'lineNumber'.44
Avoid unused constructor parameters such as 'exact'.45
Avoid unused constructor parameters such as 'location'.46
Avoid unused constructor parameters such as 'version'.47

org/apache/logging/log4j/core/jackson/Log4jStackTraceElementDeserializer.java

ViolationLine
Avoid empty if statements72–74

org/apache/logging/log4j/core/jackson/MarkerMixIn.java

ViolationLine
Avoid unused imports such as 'com.fasterxml.jackson.annotation.JsonIgnore'22
Avoid unused constructor parameters such as 'name'.61

org/apache/logging/log4j/core/jackson/StackTraceElementMixIn.java

ViolationLine
Avoid unused constructor parameters such as 'declaringClass'.37
Avoid unused constructor parameters such as 'methodName'.38
Avoid unused constructor parameters such as 'fileName'.39
Avoid unused constructor parameters such as 'lineNumber'.40

org/apache/logging/log4j/core/jackson/ThrowableProxyMixIn.java

ViolationLine
Avoid unused private fields such as 'causeProxy'.34
Avoid unused private fields such as 'commonElementCount'.38
Avoid unused private fields such as 'extendedStackTrace'.43
Avoid unused private fields such as 'localizedMessage'.47
Avoid unused private fields such as 'message'.51
Avoid unused private fields such as 'name'.55
Avoid unused private fields such as 'throwable'.58

org/apache/logging/log4j/core/jmx/Server.java

ViolationLine
Avoid unused method parameters such as 'executor'.251
Avoid unused method parameters such as 'executor'.319
Avoid unused method parameters such as 'executor'.336
Avoid unused private methods such as 'register(MBeanServer,Object,ObjectName)'.354

org/apache/logging/log4j/core/jmx/StatusLoggerAdminMBean.java

ViolationLine
Avoid modifiers which are implied by the context70

org/apache/logging/log4j/core/layout/HtmlLayout.java

ViolationLine
Avoid empty catch blocks230–232

org/apache/logging/log4j/core/layout/JsonLayout.java

ViolationLine
Useless parentheses.826

org/apache/logging/log4j/core/layout/Rfc5424Layout.java

ViolationLine
Avoid unused private fields such as 'eventPrefix'.103
Useless parentheses.327
Useless parentheses.349
Useless parentheses.492

org/apache/logging/log4j/core/layout/XmlLayout.java

ViolationLine
Useless parentheses.233

org/apache/logging/log4j/core/lookup/StrSubstitutor.java

ViolationLine
Useless parentheses.840
Useless parentheses.939
Useless parentheses.939

org/apache/logging/log4j/core/net/MulticastDnsAdvertiser.java

ViolationLine
Avoid empty catch blocks90–92
Avoid empty catch blocks218–220

org/apache/logging/log4j/core/net/TcpSocketManager.java

ViolationLine
Avoid empty catch blocks201–203

org/apache/logging/log4j/core/net/server/AbstractSocketServer.java

ViolationLine
Avoid empty catch blocks66–68
Avoid empty catch blocks73–75
Avoid empty catch blocks75–77
Avoid empty catch blocks84–86

org/apache/logging/log4j/core/net/server/TcpSocketServer.java

ViolationLine
Avoid empty catch blocks74–76

org/apache/logging/log4j/core/net/ssl/SslConfiguration.java

ViolationLine
Avoid unused imports such as 'java.security.KeyStore'20

org/apache/logging/log4j/core/pattern/AnsiEscape.java

ViolationLine
Avoid empty catch blocks326–328

org/apache/logging/log4j/core/pattern/CachedDateFormat.java

ViolationLine
Useless parentheses.211
Useless parentheses.268
Useless parentheses.268
Useless parentheses.268
Useless parentheses.380
Useless parentheses.380

org/apache/logging/log4j/core/pattern/MarkerPatternConverter.java

ViolationLine
Avoid unused constructor parameters such as 'options'.34

org/apache/logging/log4j/core/pattern/PatternParser.java

ViolationLine
Avoid unused constructor parameters such as 'expectedClass'.125
Useless parentheses.524

org/apache/logging/log4j/core/pattern/StyleConverter.java

ViolationLine
Useless parentheses.61

org/apache/logging/log4j/core/pattern/UuidPatternConverter.java

ViolationLine
Useless parentheses.53

org/apache/logging/log4j/core/selector/ClassLoaderContextSelector.java

ViolationLine
Avoid empty catch blocks115–117
Avoid empty catch blocks145–147

org/apache/logging/log4j/core/util/Booleans.java

ViolationLine
Useless parentheses.37

org/apache/logging/log4j/core/util/Closer.java

ViolationLine
Avoid empty catch blocks45–47
Avoid empty catch blocks70–72
Avoid empty catch blocks95–97
Avoid empty catch blocks121–123
Avoid empty catch blocks147–149

org/apache/logging/log4j/core/util/FileUtils.java

ViolationLine
Useless parentheses.56–57
Useless parentheses.57

org/apache/logging/log4j/core/util/JndiCloser.java

ViolationLine
Avoid empty catch blocks50–52

org/apache/logging/log4j/core/util/Throwables.java

ViolationLine
Avoid empty catch blocks126–128

org/apache/logging/log4j/core/util/Transform.java

ViolationLine
Useless parentheses.50–53
Useless parentheses.128–135

org/apache/logging/log4j/core/util/UuidUtil.java

ViolationLine
Avoid empty catch blocks99–101
Useless parentheses.177–178
Useless parentheses.177
Useless parentheses.178

Copyright © 1999-2014 Apache Software Foundation. All Rights Reserved.

Apache Logging, Apache Log4j, Log4j, Apache, the Apache feather logo, and the Apache Logging project logo are trademarks of The Apache Software Foundation.

Site powered by Twitter Bootstrap. Icons from Glyphicons Free.