FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.7
Threshold is Low
Effort is Default
Summary
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 3828 | 396 | 0 | 0 |
Files
org.apache.myfaces.trinidadinternal.agent.AgentFactoryImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 220 | Low |
| Load of known null value in org.apache.myfaces.trinidadinternal.agent.AgentFactoryImpl._populateAgentImpl(FacesContext, Map, AgentImpl) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 81 | Medium |
| Redundant nullcheck of userAgent, which is known to be non-null in org.apache.myfaces.trinidadinternal.agent.AgentFactoryImpl._populateAgentImpl(FacesContext, Map, AgentImpl) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 113 | Medium |
| Redundant nullcheck of userAgent, which is known to be non-null in org.apache.myfaces.trinidadinternal.agent.AgentFactoryImpl._populateAgentImpl(FacesContext, Map, AgentImpl) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 96 | Low |
| org.apache.myfaces.trinidadinternal.agent.AgentFactoryImpl._populateSafariAgentImpl(String, AgentImpl) checks to see if result of String.indexOf is positive | STYLE | RV_CHECK_FOR_POSITIVE_INDEXOF | 780 | Low |
org.apache.myfaces.trinidadinternal.agent.AgentNameUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.agent.AgentNameUtil.getPlatformName(int) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 124 | Low |
org.apache.myfaces.trinidadinternal.agent.CapabilitiesProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.agent.CapabilitiesProvider._providerMap is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | Not available | High |
| org.apache.myfaces.trinidadinternal.agent.CapabilitiesProvider._getProviderMap() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 142 | High |
| org.apache.myfaces.trinidadinternal.agent.CapabilitiesProvider.getCapabilitiesProvider(URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 63 | High |
org.apache.myfaces.trinidadinternal.agent.CapabilitiesProvider$CacheKey
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of org.apache.myfaces.trinidadinternal.agent.CapabilitiesProvider$CacheKey._hardwareMakeModel which is known to be null in new org.apache.myfaces.trinidadinternal.agent.CapabilitiesProvider$CacheKey(Agent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 169 | Low |
org.apache.myfaces.trinidadinternal.agent.TrinidadAgentImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.agent.TrinidadAgentImpl.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 202-204 | Medium |
org.apache.myfaces.trinidadinternal.agent.parse.CapabilitiesDocument
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.agent.parse.CapabilitiesDocument._includeNodeBySrcCaps is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | Not available | High |
| org.apache.myfaces.trinidadinternal.agent.parse.CapabilitiesDocument._getCapabilities(URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 312 | High |
| org.apache.myfaces.trinidadinternal.agent.parse.CapabilitiesDocument._getCapabilities(URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 320 | High |
| org.apache.myfaces.trinidadinternal.agent.parse.CapabilitiesDocument._getCapabilities(URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 312 | High |
| org.apache.myfaces.trinidadinternal.agent.parse.CapabilitiesDocument.getCapabilities(Agent) may expose internal representation by returning CapabilitiesDocument._defaultAgentCapabilities | MALICIOUS_CODE | EI_EXPOSE_REP | 108 | Medium |
org.apache.myfaces.trinidadinternal.agent.parse.NameVersion
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.agent.parse.NameVersion._matchName(NameVersion$NameEntry, String) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 339 | Low |
| Questionable use of non-short-circuit logic in org.apache.myfaces.trinidadinternal.agent.parse.NameVersion.match(String, VersionId) | STYLE | NS_NON_SHORT_CIRCUIT | 68 | Low |
| Should org.apache.myfaces.trinidadinternal.agent.parse.NameVersion._parseEntries(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 100 | Low |
org.apache.myfaces.trinidadinternal.agent.parse.VersionId$VIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.agent.parse.VersionId$VIterator could be refactored into a _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS | 160-181 | Low |
org.apache.myfaces.trinidadinternal.application.StateManagerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 731 | Low |
| Method org.apache.myfaces.trinidadinternal.application.StateManagerImpl.<static initializer>() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 1480 | Medium |
org.apache.myfaces.trinidadinternal.application.StateManagerImpl$PageState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field org.apache.myfaces.trinidadinternal.application.StateManagerImpl$PageState._cachedState is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl._delegate; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 71 | Low |
| Suspicious comparison of Long references in org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.createView(FacesContext, String) | BAD_PRACTICE | RC_REF_COMPARISON | 89 | High |
| Suspicious comparison of Long references in org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.restoreView(FacesContext, String) | BAD_PRACTICE | RC_REF_COMPARISON | 209 | High |
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl._initIfNeeded(FacesContext) | STYLE | REC_CATCH_EXCEPTION | 309 | Low |
org.apache.myfaces.trinidadinternal.binding.AccessKeyBinding
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.binding.AccessKeyBinding implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 41-109 | Low |
org.apache.myfaces.trinidadinternal.binding.StripAccessKeyBinding
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.binding.StripAccessKeyBinding implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 39-101 | Low |
org.apache.myfaces.trinidadinternal.change.NullChangeManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.change.NullChangeManager shadows the simple name of the superclass org.apache.myfaces.trinidad.change.NullChangeManager | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 26 | High |
org.apache.myfaces.trinidadinternal.config.CheckSerializationConfigurator$MutatedBeanChecker
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.config.CheckSerializationConfigurator$MutatedBeanChecker.checkForMutations() ignores return value of Object.equals(Object) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 531 | Low |
org.apache.myfaces.trinidadinternal.config.CheckSerializationConfigurator$SerializationChecker$SessionBeanTracker$SessionWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Confusing to have methods org.apache.myfaces.trinidadinternal.config.CheckSerializationConfigurator$SerializationChecker$SessionBeanTracker$SessionWrapper.getId() and org.apache.myfaces.trinidadinternal.ui.beans.BaseWebBean.getID() | BAD_PRACTICE | NM_CONFUSING | 1114 | Low |
org.apache.myfaces.trinidadinternal.config.ConfigParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.config.ConfigParser.parseConfigFile(ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 145 | Low |
org.apache.myfaces.trinidadinternal.config.upload.CompositeUploadedFileProcessorImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to test in org.apache.myfaces.trinidadinternal.config.upload.CompositeUploadedFileProcessorImpl.processFile(Object, UploadedFile) | STYLE | DLS_DEAD_LOCAL_STORE | 113 | Medium |
org.apache.myfaces.trinidadinternal.config.upload.CompositeUploadedFileProcessorImpl$WrappedUploadedFileImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.config.upload.CompositeUploadedFileProcessorImpl$WrappedUploadedFileImpl defines non-transient non-serializable instance field files | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.config.upload.CompositeUploadedFileProcessorImpl$WrappedUploadedFileImpl defines non-transient non-serializable instance field original | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidadinternal.config.upload.FileUploadConfiguratorImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.config.upload.FileUploadConfiguratorImpl._getActionRequestWrapper(ExternalContext, Map) | STYLE | REC_CATCH_EXCEPTION | 308 | Low |
org.apache.myfaces.trinidadinternal.config.upload.UploadRequestManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.config.upload.UploadRequestManager.getParameterValues(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 141 | Low |
org.apache.myfaces.trinidadinternal.config.upload.UploadedFileImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.config.upload.UploadedFileImpl.dispose() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 145 | Medium |
| org.apache.myfaces.trinidadinternal.config.upload.UploadedFileImpl.loadFile(UploadedFile, long, long, String) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 233 | Medium |
| The field org.apache.myfaces.trinidadinternal.config.upload.UploadedFileImpl._buffers is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
| The field org.apache.myfaces.trinidadinternal.config.upload.UploadedFileImpl._file is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
| The field org.apache.myfaces.trinidadinternal.config.upload.UploadedFileImpl._length is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
| The field org.apache.myfaces.trinidadinternal.config.upload.UploadedFileImpl._sizeOfLastBuffer is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.trinidadinternal.config.upload.UploadedFiles$FixFilename
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.config.upload.UploadedFiles$FixFilename defines non-transient non-serializable instance field _file | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidadinternal.config.xmlHttp.XmlHttpConfigurator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.config.xmlHttp.XmlHttpConfigurator.handleError(ExternalContext, Throwable) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 115 | Low |
org.apache.myfaces.trinidadinternal.config.xmlHttp.XmlHttpServletResponse
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.config.xmlHttp.XmlHttpServletResponse.sendError(int, String) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 91 | Low |
org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl$CacheRenderKit
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl$CacheRenderKit.getRenderKit() | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 151 | Medium |
org.apache.myfaces.trinidadinternal.context.PageFlowScopeMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.context.PageFlowScopeMap._token; locked 57% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 395 | Medium |
org.apache.myfaces.trinidadinternal.context.PageFlowScopeProviderImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of pageFlowScope, which is known to be non-null in org.apache.myfaces.trinidadinternal.context.PageFlowScopeProviderImpl.encodeCurrentPageFlowScopeURL(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 116 | Low |
org.apache.myfaces.trinidadinternal.context.RequestContextFactoryImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.context.RequestContextFactoryImpl._pageFlowScopeProvider; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 59 | Medium |
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.context.RequestContextFactoryImpl._pageResolver; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 58 | Medium |
org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$EntrySet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of ?, which is known to be non-null in org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$EntrySet.remove(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 236 | Low |
org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$KeyIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$KeyIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 269-270 | Low |
org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$KeySet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of ?, which is known to be non-null in org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$KeySet.remove(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 291 | Low |
org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$ValuesIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.context.external.AbstractAttributeMap$ValuesIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 335-336 | Low |
org.apache.myfaces.trinidadinternal.context.external.PortletRequestParameterValuesMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.context.external.PortletRequestParameterValuesMap.getAttribute(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 43 | Low |
org.apache.myfaces.trinidadinternal.context.external.ServletExternalContext
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.servlet.ServletResponse to javax.servlet.http.HttpServletResponse in new org.apache.myfaces.trinidadinternal.context.external.ServletExternalContext(ServletContext, ServletRequest, ServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 74 | Low |
org.apache.myfaces.trinidadinternal.context.external.ServletRequestHeaderValuesMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.context.external.ServletRequestHeaderValuesMap.getAttribute(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 59 | Low |
org.apache.myfaces.trinidadinternal.context.external.ServletRequestParameterValuesMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.context.external.ServletRequestParameterValuesMap.getAttribute(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 45 | Low |
org.apache.myfaces.trinidadinternal.convert.ByteConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.ByteConverter shadows the simple name of the superclass javax.faces.convert.ByteConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 35-143 | High |
org.apache.myfaces.trinidadinternal.convert.ColorConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.ColorConverter shadows the simple name of the superclass org.apache.myfaces.trinidad.convert.ColorConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 39-248 | High |
org.apache.myfaces.trinidadinternal.convert.ConverterUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.convert.ConverterUtils.getIntegerConverterException(FacesContext, UIComponent, ConverterException, String, String, String, String, String, String) ignores return value of new java.math.BigInteger(String) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 68 | Medium |
org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 269 | Low |
| org.apache.myfaces.trinidadinternal.convert.DateTimeConverter.<static initializer>() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 629 | Medium |
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.convert.DateTimeConverter.getJSPattern(FacesContext) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 507 | Low |
| The class name org.apache.myfaces.trinidadinternal.convert.DateTimeConverter shadows the simple name of the superclass org.apache.myfaces.trinidad.convert.DateTimeConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 64-639 | High |
org.apache.myfaces.trinidadinternal.convert.DoubleConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.DoubleConverter shadows the simple name of the superclass javax.faces.convert.DoubleConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 34-102 | High |
org.apache.myfaces.trinidadinternal.convert.FloatConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.FloatConverter shadows the simple name of the superclass javax.faces.convert.FloatConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 34-104 | High |
org.apache.myfaces.trinidadinternal.convert.IntegerConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.IntegerConverter shadows the simple name of the superclass javax.faces.convert.IntegerConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 36-153 | High |
org.apache.myfaces.trinidadinternal.convert.LongConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.LongConverter shadows the simple name of the superclass javax.faces.convert.LongConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 37-149 | High |
org.apache.myfaces.trinidadinternal.convert.NumberConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.NumberConverter shadows the simple name of the superclass org.apache.myfaces.trinidad.convert.NumberConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 42-239 | High |
org.apache.myfaces.trinidadinternal.convert.ShortConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.convert.ShortConverter shadows the simple name of the superclass javax.faces.convert.ShortConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 35-146 | High |
org.apache.myfaces.trinidadinternal.facelets.DatePropertyTagRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.apache.myfaces.trinidadinternal.facelets.DatePropertyTagRule.Instance doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Low |
org.apache.myfaces.trinidadinternal.facelets.FileDownloadActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ActionSource in org.apache.myfaces.trinidadinternal.facelets.FileDownloadActionListenerTag.apply(FaceletContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 93 | Low |
org.apache.myfaces.trinidadinternal.facelets.LocalePropertyTagRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.apache.myfaces.trinidadinternal.facelets.LocalePropertyTagRule.Instance doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Low |
org.apache.myfaces.trinidadinternal.facelets.MethodRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.facelets.MethodRule shadows the simple name of the superclass org.apache.myfaces.trinidad.facelets.MethodRule | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 29-30 | High |
org.apache.myfaces.trinidadinternal.facelets.ResetActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ActionSource in org.apache.myfaces.trinidadinternal.facelets.ResetActionListenerTag.apply(FaceletContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 53 | Low |
org.apache.myfaces.trinidadinternal.facelets.ReturnActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ActionSource in org.apache.myfaces.trinidadinternal.facelets.ReturnActionListenerTag.apply(FaceletContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 57 | Low |
org.apache.myfaces.trinidadinternal.facelets.SetActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ActionSource in org.apache.myfaces.trinidadinternal.facelets.SetActionListenerTag.apply(FaceletContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 58 | Low |
org.apache.myfaces.trinidadinternal.facelets.StringArrayPropertyTagRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.facelets.StringArrayPropertyTagRule._coerceToStringArray(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 104 | Low |
org.apache.myfaces.trinidadinternal.facelets.TimezonePropertyTagRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.apache.myfaces.trinidadinternal.facelets.TimezonePropertyTagRule.Instance doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Low |
org.apache.myfaces.trinidadinternal.facelets.TrinidadComponentHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Boolean references in org.apache.myfaces.trinidadinternal.facelets.TrinidadComponentHandler.onComponentPopulated(FaceletContext, UIComponent, UIComponent) | BAD_PRACTICE | RC_REF_COMPARISON | 90 | Medium |
org.apache.myfaces.trinidadinternal.facelets.ValueExpressionTagRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.apache.myfaces.trinidadinternal.facelets.ValueExpressionTagRule.Instance doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Low |
org.apache.myfaces.trinidadinternal.image.ImageTypeManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.image.ImageTypeManager._sDefaultInstance in org.apache.myfaces.trinidadinternal.image.ImageTypeManager.getDefaultImageTypeManager() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 60-64 | Low |
org.apache.myfaces.trinidadinternal.image.cache.Cache
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 171 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 80 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 200 | Low |
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.image.cache.Cache._supportsEncoding(CacheEntry, boolean, boolean) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 301 | Low |
org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Bitwise OR of signed byte value computed in org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._readColorizedIconData(ImageContext, Map, Map) | CORRECTNESS | BIT_IOR_OF_SIGNED_BYTE | 1693 | Medium |
| Method org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._loadImage(ImageContext, Cache, File, XMLProvider) may fail to clean up stream or resource of type java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 668 | Medium |
| Method org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._writeImageFile(ImageContext, ImageType, String, byte[], Map) may fail to clean up stream or resource of type java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 1020 | Medium |
| org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._loadImage(ImageContext, Cache, File, XMLProvider) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 668 | Low |
| org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._writeImageFile(ImageContext, ImageType, String, byte[], Map) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 1020 | Low |
| Should org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._readColorizedIconData(ImageContext, Map, Map) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 1646 | Low |
| Should org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._readSourceIconData(InputStreamProvider) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 976 | Low |
| Should org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._renderImageLocal(ImageContext, ImageType, Map, Map) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 906 | Low |
| Redundant nullcheck of imageFile, which is known to be non-null in org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._generateImage(ImageContext, ImageType, ImageProviderRequest, Cache, Object, Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 631 | Low |
| Redundant nullcheck of parser, which is known to be non-null in org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._getXMLProvider(ImageContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1602 | Low |
| org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._checkCacheExists(ImageContext, ImageType) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1181 | Medium |
| org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._generateImage(ImageContext, ImageType, ImageProviderRequest, Cache, Object, Map) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 633 | Medium |
| org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._removeImageFromFileSystem(CacheEntry) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 843 | Medium |
| org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache._writeImageMetadataFile(ImageContext, ImageType, String, Map, Map) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1085 | Medium |
org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache$IMXFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache$IMXFilter._sInstance in org.apache.myfaces.trinidadinternal.image.cache.FileSystemImageCache$IMXFilter.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 1713-1714 | Low |
org.apache.myfaces.trinidadinternal.image.laf.browser.BlafImageUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.image.laf.browser.BlafImageUtils._sDialogPadding in org.apache.myfaces.trinidadinternal.image.laf.browser.BlafImageUtils.__getDialogPadding() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 254-295 | Low |
org.apache.myfaces.trinidadinternal.image.laf.browser.ButtonImageRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.image.laf.browser.ButtonImageRenderer._sDialogButtonPainter in org.apache.myfaces.trinidadinternal.image.laf.browser.ButtonImageRenderer.getPainter(ImageContext, Map) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 81-82 | Low |
org.apache.myfaces.trinidadinternal.image.laf.browser.ColorizedIconImageRenderer$ColorizingFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.image.laf.browser.ColorizedIconImageRenderer$ColorizingFilter._last; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 240 | Medium |
org.apache.myfaces.trinidadinternal.image.painter.ImmInsets
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.image.painter.ImmInsets.equals(Object) checks for operand being a java.awt.Insets | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | 126 | High |
org.apache.myfaces.trinidadinternal.image.painter.NullPainter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.image.painter.NullPainter._sPainter in org.apache.myfaces.trinidadinternal.image.painter.NullPainter.getPainter() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 55-57 | Low |
org.apache.myfaces.trinidadinternal.image.xml.parse.ImageParseUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.image.xml.parse.ImageParseUtils.getBooleanAttributeValue(ParseContext, Attributes, String) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 49 | Medium |
org.apache.myfaces.trinidadinternal.image.xml.parse.TextParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of value, which is known to be non-null in org.apache.myfaces.trinidadinternal.image.xml.parse.TextParser.endElement(ParseContext, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 95 | Low |
org.apache.myfaces.trinidadinternal.io.DebugHtmlResponseWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 73 | Low |
org.apache.myfaces.trinidadinternal.io.IndentingResponseWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 230 | Low |
org.apache.myfaces.trinidadinternal.menu.GroupNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.menu.GroupNode.getIdRefListProperty() may expose internal representation by returning GroupNode._idrefList | MALICIOUS_CODE | EI_EXPOSE_REP | 198 | Medium |
org.apache.myfaces.trinidadinternal.menu.ImmutableGroupNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to label in org.apache.myfaces.trinidadinternal.menu.ImmutableGroupNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 322 | Medium |
| Dead store to label in org.apache.myfaces.trinidadinternal.menu.ImmutableGroupNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 318 | Low |
| Dead store to accessKey in org.apache.myfaces.trinidadinternal.menu.ImmutableGroupNode.getLabel() | STYLE | DLS_DEAD_LOCAL_STORE | 216 | Low |
org.apache.myfaces.trinidadinternal.menu.ImmutableItemNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to label in org.apache.myfaces.trinidadinternal.menu.ImmutableItemNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 403 | Medium |
| Dead store to label in org.apache.myfaces.trinidadinternal.menu.ImmutableItemNode.getAccessKey() | STYLE | DLS_DEAD_LOCAL_STORE | 399 | Low |
| Dead store to accessKey in org.apache.myfaces.trinidadinternal.menu.ImmutableItemNode.getLabel() | STYLE | DLS_DEAD_LOCAL_STORE | 258 | Low |
org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to npe in org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl.startElement(String, String, String, Attributes) | STYLE | DLS_DEAD_LOCAL_STORE | 336 | High |
| Dead store to modelStr in org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl.startElement(String, String, String, Attributes) | STYLE | DLS_DEAD_LOCAL_STORE | 270 | Low |
| Integer is incompatible with expected argument type String in org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl.getRootModel() | CORRECTNESS | GC_UNRELATED_TYPES | 571 | High |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl defines non-transient non-serializable instance field _attrMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl defines non-transient non-serializable instance field _idNodeMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl defines non-transient non-serializable instance field _menuList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl defines non-transient non-serializable instance field _menuNodes | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl defines non-transient non-serializable instance field _nodeFocusPathMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerImpl defines non-transient non-serializable instance field _viewIdFocusPathMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to npe in org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl.startElement(String, String, String, Attributes) | STYLE | DLS_DEAD_LOCAL_STORE | 339 | High |
| Dead store to modelStr in org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl.startElement(String, String, String, Attributes) | STYLE | DLS_DEAD_LOCAL_STORE | 273 | Low |
| Integer is incompatible with expected argument type String in org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl.getRootModel() | CORRECTNESS | GC_UNRELATED_TYPES | 574 | High |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl defines non-transient non-serializable instance field _attrMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl defines non-transient non-serializable instance field _idNodeMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl defines non-transient non-serializable instance field _menuList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl defines non-transient non-serializable instance field _menuNodes | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl defines non-transient non-serializable instance field _nodeFocusPathMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.menu.MenuContentHandlerUsingApiImpl defines non-transient non-serializable instance field _viewIdFocusPathMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.trinidadinternal.menu.MenuNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Confusing to have methods org.apache.myfaces.trinidadinternal.menu.MenuNode.setId(String) and org.apache.myfaces.trinidadinternal.ui.BaseMutableUINode.setID(String) | BAD_PRACTICE | NM_CONFUSING | 471-472 | Low |
org.apache.myfaces.trinidadinternal.menu.MenuUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked argument of type Object provided where type String is expected in org.apache.myfaces.trinidadinternal.menu.MenuUtils.loadBundle(String, ThreadLocal) | BAD_PRACTICE | GC_UNCHECKED_TYPE_IN_GENERIC_CALL | 230 | Low |
org.apache.myfaces.trinidadinternal.menu.MenuUtils$_BundleMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of ?, which is known to be non-null in org.apache.myfaces.trinidadinternal.menu.MenuUtils$_BundleMap.containsKey(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 349 | Low |
org.apache.myfaces.trinidadinternal.renderkit.RenderKitBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.trinidadinternal.renderkit.RenderKitBase._loadRenderKitMap(String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 269 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderKit$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderKit$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 549-578 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderer shadows the simple name of the superclass org.apache.myfaces.trinidad.render.CoreRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 28-29 | High |
org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderingContext
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderingContext.getStyleClass(String) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 327 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.StyleContextImpl$NullStyleProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.renderkit.core.StyleContextImpl$NullStyleProvider._sInstance in org.apache.myfaces.trinidadinternal.renderkit.core.StyleContextImpl$NullStyleProvider.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 291-292 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.desktop.DesktopTableRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless control flow in org.apache.myfaces.trinidadinternal.renderkit.core.desktop.DesktopTableRenderer.renderTableContent(FacesContext, RenderingContext, TableRenderingContext, UIComponent) | STYLE | UCF_USELESS_CONTROL_FLOW | 287 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.desktop.TrainRenderer$Train
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.trinidadinternal.renderkit.core.desktop.TrainRenderer$Train._resolveStandard() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 1251 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.desktop.TreeTableRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext in org.apache.myfaces.trinidadinternal.renderkit.core.desktop.TreeTableRenderer._renderBreadCrumbs(FacesContext, RenderingContext, TableRenderingContext, UIComponent, FacesBean) | STYLE | BC_UNCONFIRMED_CAST | 477 | Low |
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext in org.apache.myfaces.trinidadinternal.renderkit.core.desktop.TreeTableRenderer.renderControlBarLinks(FacesContext, RenderingContext, TableRenderingContext, UIComponent, boolean) | STYLE | BC_UNCONFIRMED_CAST | 281 | Low |
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext in org.apache.myfaces.trinidadinternal.renderkit.core.desktop.TreeTableRenderer.renderSpecialColumns(FacesContext, RenderingContext, TableRenderingContext, UIComponent, int) | STYLE | BC_UNCONFIRMED_CAST | 364 | Low |
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext in org.apache.myfaces.trinidadinternal.renderkit.core.desktop.TreeTableRenderer.renderTableRows(FacesContext, RenderingContext, TableRenderingContext, UIComponent, FacesBean) | STYLE | BC_UNCONFIRMED_CAST | 397 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.pages.FredJSP
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.renderkit.core.pages.FredJSP._getQueryString(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 283 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.pda.PdaNavigationPaneRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.trinidadinternal.renderkit.core.pda.PdaNavigationPaneRenderer.renderNonOverlappingItem(FacesContext, RenderingContext, ResponseWriter, Map, boolean, boolean, boolean) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 203 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.ppr.ScriptBufferingResponseWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of value, which is known to be non-null in org.apache.myfaces.trinidadinternal.renderkit.core.ppr.ScriptBufferingResponseWriter.writeAttribute(String, Object, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 239 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.ColumnGroupRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.ColumnGroupRenderer.getSortingOnclick(RenderingContext, TableRenderingContext, UIComponent, int) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 551 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.ColumnRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.ColumnRenderer.encodeAll(FacesContext, RenderingContext, UIComponent, FacesBean) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 96 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.FormRenderer$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.FormRenderer$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 401-404 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 130-137 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HiddenLabelUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HiddenLabelUtils.supportsHiddenLabels(RenderingContext) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 67 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.MediaRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 808 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.NavigationPaneRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String parameter using == or != in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.NavigationPaneRenderer.renderNonCommandChild(int, FacesContext, RenderingContext, UIComponent, boolean, String) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 1117 | High |
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.NavigationPaneRenderer._writeInlineTbodyStyles(RenderingContext, ResponseWriter) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 558 | Low |
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.NavigationPaneRenderer.renderNonOverlappingItem(FacesContext, RenderingContext, ResponseWriter, Map, boolean, boolean, boolean) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 901 | Low |
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.NavigationPaneRenderer.renderTabItem(FacesContext, RenderingContext, ResponseWriter, Map, boolean) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 1378 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelFormLayoutRenderer$RenderedItemExtractor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelFormLayoutRenderer$RenderedItemExtractor be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1302-1324 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelListRenderer$GroupingCallback
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelListRenderer$GroupingCallback be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 265-294 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SelectManyShuttleRenderer$Box
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of footer, which is known to be non-null in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SelectManyShuttleRenderer$Box.encodeAllChildren(FacesContext, UIComponent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1272 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.ShowDetailRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to linkId in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.ShowDetailRenderer._encodedParam(FacesContext, RenderingContext, UIComponent, FacesBean, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 533 | Medium |
| Redundant nullcheck of linkId, which is known to be non-null in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.ShowDetailRenderer._generateOnClickString(FacesContext, RenderingContext, UIComponent, FacesBean, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 486 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputColorRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputColorRenderer.queueActionEvent(FacesContext, UIComponent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 113 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputTextRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputTextRenderer.renderAllAttributes(FacesContext, RenderingContext, UIComponent, FacesBean, boolean), since all Number are instances of Number | STYLE | BC_VACUOUS_INSTANCEOF | 183 | Medium |
| Redundant nullcheck of textValue, which is known to be non-null in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputTextRenderer.renderContent(FacesContext, RenderingContext, UIComponent, FacesBean, boolean, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 405 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TableRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TableRenderer._renderControlBar(FacesContext, RenderingContext, TableRenderingContext, UIComponent, boolean) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 803 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TreeRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to showLines in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TreeRenderer.getIconBackgroundIcon(FacesContext, RenderingContext, boolean, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 335 | Medium |
| Dead store to nodeDepth in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TreeRenderer._renderNodeChildren(FacesContext, RenderingContext, UIXHierarchy, FacesBean, UIComponent, String, RowKeySet, Map, Boolean[], boolean, boolean, boolean, int) | STYLE | DLS_DEAD_LOCAL_STORE | 1012 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlRenderer.getPartialTriggers(UIComponent, FacesBean) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 1090 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.ConfigurationScriptlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.ConfigurationScriptlet._sInstance in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.ConfigurationScriptlet.sharedInstance() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 47-49 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.DialogStyleScriptlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.DialogStyleScriptlet._sInstance in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.DialogStyleScriptlet.sharedInstance() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 48-50 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.GlobalVariablesScriptlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.GlobalVariablesScriptlet._sInstance in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.GlobalVariablesScriptlet.sharedInstance() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 49-51 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.LocaleInfoScriptlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 174 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.CellUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.CellUtils.BORDER_CLASS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 294 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.FocusColumnRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.FocusColumnRenderer.renderKids(FacesContext, RenderingContext, TableRenderingContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 71 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.CollectionComponent in new org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext(FacesContext, RenderingContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 54 | Low |
| org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext.getHiddenColumns() may expose internal representation by returning TableRenderingContext._hiddenColumns | MALICIOUS_CODE | EI_EXPOSE_REP | 363 | Medium |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeNodeColumnRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TableRenderingContext to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeNodeColumnRenderer.renderKids(FacesContext, RenderingContext, TableRenderingContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 52 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableNavRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableNavRenderer.encodeAll(FacesContext, RenderingContext, UIComponent, FacesBean) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 72 | Low |
| Redundant nullcheck of text, which is known to be non-null in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableNavRenderer._writeCellContents(FacesContext, RenderingContext, TreeTableRenderingContext, UIXTreeTable, String, boolean, boolean, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 252 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXTreeTable in new org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeTableRenderingContext(FacesContext, RenderingContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 60 | Low |
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXHierarchy in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeUtils.decodeExpandEvents(Map, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 399 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXHierarchy in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeUtils.decodeFocusEvent(Map, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 337 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXHierarchy in org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.TreeUtils.decodeGotoEvent(Map, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 313 | Low |
org.apache.myfaces.trinidadinternal.renderkit.htmlBasic.HtmlCommandButtonRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UICommand in org.apache.myfaces.trinidadinternal.renderkit.htmlBasic.HtmlCommandButtonRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 57 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 83 | Low |
org.apache.myfaces.trinidadinternal.renderkit.htmlBasic.HtmlCommandLinkRenderer$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.renderkit.htmlBasic.HtmlCommandLinkRenderer$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 83-128 | Low |
org.apache.myfaces.trinidadinternal.renderkit.htmlBasic.HtmlFormRenderer$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.renderkit.htmlBasic.HtmlFormRenderer$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 71-110 | Low |
org.apache.myfaces.trinidadinternal.renderkit.uix.PageRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXPage in org.apache.myfaces.trinidadinternal.renderkit.uix.PageRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 54 | Low |
org.apache.myfaces.trinidadinternal.renderkit.uix.ProcessRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXProcess in org.apache.myfaces.trinidadinternal.renderkit.uix.ProcessRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 97 | Low |
org.apache.myfaces.trinidadinternal.renderkit.uix.ProgressRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXProgress in org.apache.myfaces.trinidadinternal.renderkit.uix.ProgressRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 47 | Low |
| Redundant nullcheck of modelValue, which is known to be non-null in org.apache.myfaces.trinidadinternal.renderkit.uix.ProgressRenderer.decode(FacesContext, UIComponent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 54 | Low |
org.apache.myfaces.trinidadinternal.renderkit.uix.SingleStepRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXSingleStep in org.apache.myfaces.trinidadinternal.renderkit.uix.SingleStepRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 79 | Low |
org.apache.myfaces.trinidadinternal.renderkit.uix.SubformRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXSubform in org.apache.myfaces.trinidadinternal.renderkit.uix.SubformRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 59 | Low |
org.apache.myfaces.trinidadinternal.renderkit.uix.TreeRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXTree in org.apache.myfaces.trinidadinternal.renderkit.uix.TreeRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 77 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXTree in org.apache.myfaces.trinidadinternal.renderkit.uix.TreeRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 48 | Low |
org.apache.myfaces.trinidadinternal.resource.LocaleElementsResourceLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.resource.LocaleElementsResourceLoader.getURL(String) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 85 | Low |
org.apache.myfaces.trinidadinternal.share.data.ServletRequestParameters
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.share.data.ServletRequestParameters._processParameters(Map, int) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 487 | Medium |
org.apache.myfaces.trinidadinternal.share.expl.Coercions
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.share.expl.Coercions.toBoolean(Object) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 321 | Medium |
java.awt.Color
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.share.expl.Coercions$ParsedColor doesn't override java.awt.Color.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 677 | Medium |
org.apache.myfaces.trinidadinternal.share.nls.LocaleContextImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.share.nls.MutableLocaleContext doesn't override LocaleContextImpl.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 381-389 | Medium |
org.apache.myfaces.trinidadinternal.share.text.RGBColorFormat
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 544 | Low |
org.apache.myfaces.trinidadinternal.share.util.CaboHttpUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.share.util.CaboHttpUtils.decodeQValueString(String) invokes inefficient Float.valueOf(float) constructor; use CaboHttpUtils.java:[line 156] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 156 | Low |
org.apache.myfaces.trinidadinternal.share.util.FastMessageFormat
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.share.util.FastMessageFormat shadows the simple name of the superclass org.apache.myfaces.trinidad.util.FastMessageFormat | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 34-35 | High |
org.apache.myfaces.trinidadinternal.share.util.MultipartFormHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to offset in org.apache.myfaces.trinidadinternal.share.util.MultipartFormHandler._readLine(byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 300 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 401 | Low |
org.apache.myfaces.trinidadinternal.share.util.MultipartFormHandler$Disposition
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 808 | Low |
org.apache.myfaces.trinidadinternal.share.xml.NamespaceSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.share.xml.NamespaceSupport.processName(String, String[], boolean) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 297 | Low |
org.apache.myfaces.trinidadinternal.share.xml.NamespaceSupport$Context
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.share.xml.NamespaceSupport$Context.processName(String, boolean) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 607 | Low |
org.apache.myfaces.trinidadinternal.share.xml.ParseContextImpl$2
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.share.xml.ParseContextImpl$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 65-73 | Low |
org.apache.myfaces.trinidadinternal.share.xml.ParseContextWrapper$3
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.share.xml.ParseContextWrapper$3 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 70-78 | Low |
org.apache.myfaces.trinidadinternal.share.xml.ParserManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.share.xml.ParserManager._bindingParsers; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 184 | Medium |
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.share.xml.ParserManager._aliases; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 168 | Low |
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.share.xml.ParserManager._extensions; locked 80% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 120 | Low |
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.share.xml.ParserManager._factories; locked 80% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 80 | Low |
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.share.xml.ParserManager._functions; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 213 | Low |
org.apache.myfaces.trinidadinternal.share.xml.XMLUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.share.xml.XMLUtils.parseNameTokens(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 349 | Low |
| Redundant nullcheck of resolver, which is known to be non-null in org.apache.myfaces.trinidadinternal.share.xml.XMLUtils.parseInclude(ParseContext, String, Class) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 135 | Low |
org.apache.myfaces.trinidadinternal.share.xml.beans.BeanParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String parameter using == or != in org.apache.myfaces.trinidadinternal.share.xml.beans.BeanParser.startChildElement(ParseContext, String, String, Attributes) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 147 | High |
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.share.xml.beans.BeanParser.startElement(ParseContext, String, String, Attributes) | STYLE | REC_CATCH_EXCEPTION | 97 | Low |
org.apache.myfaces.trinidadinternal.share.xml.beans.IntrospectionBeanDef
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.share.xml.beans.IntrospectionBeanDef._defs; locked 80% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 208 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.share.xml.beans.IntrospectionBeanDef.loadProperties() | STYLE | REC_CATCH_EXCEPTION | 169 | Medium |
org.apache.myfaces.trinidadinternal.skin.SkinCSSDocumentHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.skin.SkinCSSDocumentHandler._getIntArray(List) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 442 | Low |
org.apache.myfaces.trinidadinternal.skin.SkinCSSDocumentHandler$CompleteSelectorNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.skin.SkinCSSDocumentHandler$CompleteSelectorNode._copyIntArray(int[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 619 | Low |
org.apache.myfaces.trinidadinternal.skin.SkinExtension
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidad.skin.Skin to org.apache.myfaces.trinidadinternal.skin.SkinImpl in new org.apache.myfaces.trinidadinternal.skin.SkinExtension(Skin, String, String, String, String) | STYLE | BC_UNCONFIRMED_CAST | 214 | Low |
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidad.skin.Skin to org.apache.myfaces.trinidadinternal.skin.SkinImpl in new org.apache.myfaces.trinidadinternal.skin.SkinExtension(Skin, String, String, String, String, String) | STYLE | BC_UNCONFIRMED_CAST | 97 | Low |
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidad.skin.Skin to org.apache.myfaces.trinidadinternal.skin.SkinImpl in new org.apache.myfaces.trinidadinternal.skin.SkinExtension(Skin, String, String, String, String, ValueExpression) | STYLE | BC_UNCONFIRMED_CAST | 157 | Low |
| Unchecked argument of type Object provided where type String is expected in org.apache.myfaces.trinidadinternal.skin.SkinExtension._stackContains(Stack, Object) | BAD_PRACTICE | GC_UNCHECKED_TYPE_IN_GENERIC_CALL | 642 | Low |
org.apache.myfaces.trinidadinternal.skin.SkinImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.skin.SkinImpl._getSkinAdditionsStyleSheets(StyleContext) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 626 | Low |
org.apache.myfaces.trinidadinternal.skin.SkinStyleSheetParserUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.skin.SkinStyleSheetParserUtils._addIconNode(String, String, String, List, List, Set, List) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 552 | Low |
| Method org.apache.myfaces.trinidadinternal.skin.SkinStyleSheetParserUtils._createStyleNode(String, List, List, List, Set, boolean) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 657 | Low |
| Method org.apache.myfaces.trinidadinternal.skin.SkinStyleSheetParserUtils._createStyleSheetDocument(ParseContext, List) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 826 | Low |
| Method org.apache.myfaces.trinidadinternal.skin.SkinStyleSheetParserUtils._createStyleSheetEntry(ParseContext, String, List) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 278 | Low |
org.apache.myfaces.trinidadinternal.skin.SkinUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of icon, which is known to be non-null in org.apache.myfaces.trinidadinternal.skin.SkinUtils._resolveReferenceIcon(Skin, ReferenceIcon, Stack) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 182 | Low |
org.apache.myfaces.trinidadinternal.skin.parse.SkinAdditionNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.skin.parse.SkinAdditionNode defines compareTo(SkinAdditionNode) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 93 | Medium |
org.apache.myfaces.trinidadinternal.style.CSSStyle
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.style.CSSStyle._inline; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 76 | Medium |
| The field org.apache.myfaces.trinidadinternal.style.CSSStyle._inline is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._document; locked 87% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 280 | Low |
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._shortStyleClassMap; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 204 | Low |
| Should org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getStyleContextResolvedStyles(StyleContext, StyleSheetDocument) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 592 | Low |
| Redundant nullcheck of contextName, which is known to be non-null in org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getTargetStyleSheetName(StyleContext, StyleSheetDocument) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 266 | Medium |
| Redundant nullcheck of contextName, which is known to be non-null in org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getTargetStyleSheetName(StyleContext, StyleSheetDocument) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 259 | Low |
| new org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache(String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 114 | Medium |
| org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._createStyleSheetFiles(StyleContext, StyleSheetDocument, StyleNode[], Map, String[], boolean, boolean) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 697 | Medium |
| org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getWriter(File) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 831 | Medium |
org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$StyleWriterFactoryImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$StyleWriterFactoryImpl.createWriter() ignores exceptional return value of java.io.File.setReadOnly() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1541 | Medium |
org.apache.myfaces.trinidadinternal.style.util.CSSGenerationUtils$PropertyNodeComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.myfaces.trinidadinternal.style.util.CSSGenerationUtils$PropertyNodeComparator.compare(PropertyNode, PropertyNode) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 1372 | Low |
| org.apache.myfaces.trinidadinternal.style.util.CSSGenerationUtils$PropertyNodeComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 1358-1385 | Low |
org.apache.myfaces.trinidadinternal.style.util.CSSUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 265 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 422 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 455 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 485 | Low |
| Should org.apache.myfaces.trinidadinternal.style.util.CSSUtils.parseFontFamilies(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 384 | Low |
org.apache.myfaces.trinidadinternal.style.util.FontProxy
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 165 | Low |
org.apache.myfaces.trinidadinternal.style.util.GraphicsUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 186 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 205 | Low |
org.apache.myfaces.trinidadinternal.style.util.GraphicsUtils$FontLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 371 | Low |
org.apache.myfaces.trinidadinternal.style.util.StyleUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.style.util.StyleUtils.convertToValidSelector(String) checks to see if result of String.indexOf is positive | STYLE | RV_CHECK_FOR_POSITIVE_INDEXOF | 48 | Low |
org.apache.myfaces.trinidadinternal.style.xml.StyleSheetDocumentUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.style.xml.StyleSheetDocumentUtils._sDefaultParserManager in org.apache.myfaces.trinidadinternal.style.xml.StyleSheetDocumentUtils._getDefaultParserManager() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 199-214 | Low |
org.apache.myfaces.trinidadinternal.style.xml.parse.ColorValidater
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.style.xml.parse.ColorValidater._sInstance in org.apache.myfaces.trinidadinternal.style.xml.parse.ColorValidater.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 32-33 | Low |
org.apache.myfaces.trinidadinternal.style.xml.parse.PropertyNodeParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 131 | Low |
org.apache.myfaces.trinidadinternal.style.xml.parse.StyleNodeParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.trinidadinternal.style.xml.parse.StyleNodeParser.addCompletedChild(ParseContext, String, String, Object), since all org.apache.myfaces.trinidadinternal.style.xml.parse.IncludePropertyNode are instances of org.apache.myfaces.trinidadinternal.style.xml.parse.IncludePropertyNode | STYLE | BC_VACUOUS_INSTANCEOF | 191 | Medium |
| instanceof will always return true in org.apache.myfaces.trinidadinternal.style.xml.parse.StyleNodeParser.addCompletedChild(ParseContext, String, String, Object), since all org.apache.myfaces.trinidadinternal.style.xml.parse.PropertyNode are instances of org.apache.myfaces.trinidadinternal.style.xml.parse.PropertyNode | STYLE | BC_VACUOUS_INSTANCEOF | 179 | Medium |
org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument$StyleSheetComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument$StyleSheetComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 1326-1389 | Low |
org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNode._copyLocaleArrayToSet(Locale[]) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 548-557 | Low |
org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNodeParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNodeParser._getIntegers(List) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 265 | Low |
| Should org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNodeParser._initPlatforms(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 212 | Low |
| Should org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNodeParser._initVersions(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 192 | Low |
org.apache.myfaces.trinidadinternal.taglib.ComponentRefTag$RelocatedFacet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field org.apache.myfaces.trinidadinternal.taglib.ComponentRefTag$RelocatedFacet._facet is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
org.apache.myfaces.trinidadinternal.taglib.ForEachTag$Constants
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.taglib.ForEachTag$Constants implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 372-418 | Low |
org.apache.myfaces.trinidadinternal.taglib.listener.FileDownloadActionListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 109 | Low |
org.apache.myfaces.trinidadinternal.taglib.listener.FileDownloadActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to application in org.apache.myfaces.trinidadinternal.taglib.listener.FileDownloadActionListenerTag.doStartTag() | STYLE | DLS_DEAD_LOCAL_STORE | 77 | Medium |
| Dead store to parentELContext in org.apache.myfaces.trinidadinternal.taglib.listener.FileDownloadActionListenerTag.doStartTag() | STYLE | DLS_DEAD_LOCAL_STORE | 74 | Medium |
org.apache.myfaces.trinidadinternal.taglib.listener.ReturnActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to application in org.apache.myfaces.trinidadinternal.taglib.listener.ReturnActionListenerTag.doStartTag() | STYLE | DLS_DEAD_LOCAL_STORE | 69 | Medium |
| Dead store to parentELContext in org.apache.myfaces.trinidadinternal.taglib.listener.ReturnActionListenerTag.doStartTag() | STYLE | DLS_DEAD_LOCAL_STORE | 66 | Medium |
org.apache.myfaces.trinidadinternal.taglib.listener.SetActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to application in org.apache.myfaces.trinidadinternal.taglib.listener.SetActionListenerTag.doStartTag() | STYLE | DLS_DEAD_LOCAL_STORE | 75 | Medium |
| Dead store to parentELContext in org.apache.myfaces.trinidadinternal.taglib.listener.SetActionListenerTag.doStartTag() | STYLE | DLS_DEAD_LOCAL_STORE | 72 | Medium |
| Nullcheck of SetActionListenerTag._to at line 86 of value previously dereferenced in org.apache.myfaces.trinidadinternal.taglib.listener.SetActionListenerTag.doStartTag() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 82 | Medium |
org.apache.myfaces.trinidadinternal.taglib.util.TagUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.trinidadinternal.taglib.util.TagUtils.getColor(String) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 294 | Medium |
| Should org.apache.myfaces.trinidadinternal.taglib.util.TagUtils._getTokensArray(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 323 | Low |
| Should org.apache.myfaces.trinidadinternal.taglib.util.TagUtils.getStringArray(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 166 | Low |
org.apache.myfaces.trinidadinternal.ui.AbstractTextNode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.ui.AbstractTextNode.getText(UIXRenderingContext) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 60 | Low |
org.apache.myfaces.trinidadinternal.ui.RendererManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.ui.RendererManager._factories; locked 80% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 139 | Low |
org.apache.myfaces.trinidadinternal.ui.RootRenderingContext$NullImageProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.ui.RootRenderingContext$NullImageProvider._sInstance in org.apache.myfaces.trinidadinternal.ui.RootRenderingContext$NullImageProvider.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 719-720 | Low |
org.apache.myfaces.trinidadinternal.ui.action.ActionUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.ui.action.ActionUtils.cloneParameterArray(Parameter[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 46 | Low |
| Should org.apache.myfaces.trinidadinternal.ui.action.ActionUtils.copyPartialTargets(String[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 99 | Low |
org.apache.myfaces.trinidadinternal.ui.action.ClientAction
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.ui.action.ClientAction.getParameters(UIXRenderingContext, UINode) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 190 | Low |
org.apache.myfaces.trinidadinternal.ui.action.FireAction
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of formName, which is known to be non-null in org.apache.myfaces.trinidadinternal.ui.action.FireAction.getSubmitScript(UIXRenderingContext, UINode, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 199 | Low |
| Redundant nullcheck of formName, which is known to be non-null in org.apache.myfaces.trinidadinternal.ui.action.FireAction.writeDependencies(UIXRenderingContext, UINode) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 138 | Low |
org.apache.myfaces.trinidadinternal.ui.action.FirePartialAction
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of formName, which is known to be non-null in org.apache.myfaces.trinidadinternal.ui.action.FirePartialAction.getSubmitScript(UIXRenderingContext, UINode, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 177 | Low |
org.apache.myfaces.trinidadinternal.ui.collection.ArrayAttributeMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.ui.collection.ArrayAttributeMap defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 135-147 | High |
org.apache.myfaces.trinidadinternal.ui.collection.MapContextMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked argument of type Object provided where type String is expected in org.apache.myfaces.trinidadinternal.ui.collection.MapContextMap.get(UIXRenderingContext, Object) | BAD_PRACTICE | GC_UNCHECKED_TYPE_IN_GENERIC_CALL | 56 | Low |
org.apache.myfaces.trinidadinternal.ui.data.ListDataObjectList
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked argument of type Object provided where type DataObject is expected in org.apache.myfaces.trinidadinternal.ui.data.ListDataObjectList.indexOf(Object) | BAD_PRACTICE | GC_UNCHECKED_TYPE_IN_GENERIC_CALL | 98 | Low |
org.apache.myfaces.trinidadinternal.ui.data.bean.BeanArrayDataObjectList
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.trinidadinternal.ui.data.bean.BeanArrayDataObjectList(Object[]) may expose internal representation by storing an externally mutable object into BeanArrayDataObjectList._array | MALICIOUS_CODE | EI_EXPOSE_REP2 | 54 | Medium |
org.apache.myfaces.trinidadinternal.ui.data.bean.IntrospectionAdapter$ClassInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked argument of type Object provided where type String is expected in org.apache.myfaces.trinidadinternal.ui.data.bean.IntrospectionAdapter$ClassInfo.selectValue(UIXRenderingContext, Object, Object) | BAD_PRACTICE | GC_UNCHECKED_TYPE_IN_GENERIC_CALL | 298 | Low |
| Unchecked argument of type Object provided where type String is expected in org.apache.myfaces.trinidadinternal.ui.data.bean.IntrospectionAdapter$ClassInfo.updateValue(UIXRenderingContext, Object, Object, Object) | BAD_PRACTICE | GC_UNCHECKED_TYPE_IN_GENERIC_CALL | 324 | Low |
org.apache.myfaces.trinidadinternal.ui.data.bind.AndBoundValue
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.trinidadinternal.ui.data.bind.AndBoundValue(BoundValue[]) may expose internal representation by storing an externally mutable object into AndBoundValue._values | MALICIOUS_CODE | EI_EXPOSE_REP2 | 63 | Medium |
org.apache.myfaces.trinidadinternal.ui.data.bind.ComparisonBoundValue
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Test for floating point equality in org.apache.myfaces.trinidadinternal.ui.data.bind.ComparisonBoundValue._equalsForDouble(double, Number, Class) | STYLE | FE_FLOATING_POINT_EQUALITY | 291 | Low |
org.apache.myfaces.trinidadinternal.ui.data.bind.ConcatBoundValue
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.trinidadinternal.ui.data.bind.ConcatBoundValue(BoundValue[]) may expose internal representation by storing an externally mutable object into ConcatBoundValue._values | MALICIOUS_CODE | EI_EXPOSE_REP2 | 45 | Medium |
org.apache.myfaces.trinidadinternal.ui.data.bind.OrBoundValue
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.trinidadinternal.ui.data.bind.OrBoundValue(BoundValue[]) may expose internal representation by storing an externally mutable object into OrBoundValue._values | MALICIOUS_CODE | EI_EXPOSE_REP2 | 64 | Medium |
org.apache.myfaces.trinidadinternal.ui.expl.ELUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to index in org.apache.myfaces.trinidadinternal.ui.expl.ELUtils.getFunctions(List, String, int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 52 | Low |
org.apache.myfaces.trinidadinternal.ui.expl.UIImplicitObject
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.ui.data.DataObject to org.apache.myfaces.trinidadinternal.ui.data.DataObjectList in org.apache.myfaces.trinidadinternal.ui.expl.UIImplicitObject.adapt(Object) | STYLE | BC_UNCONFIRMED_CAST | 132 | Low |
org.apache.myfaces.trinidadinternal.ui.html.HTMLWebBean
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 57 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.BaseLafUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String parameter using == or != in org.apache.myfaces.trinidadinternal.ui.laf.base.BaseLafUtils.getRenderedAncestorByName(UIXRenderingContext, UINode, String, String) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 173 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.BaseLafUtils$StyleStack
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless control flow in org.apache.myfaces.trinidadinternal.ui.laf.base.BaseLafUtils$StyleStack._resolveBackground(UIXRenderingContext, BaseLafUtils$StyleStack$Entry) | STYLE | UCF_USELESS_CONTROL_FLOW | 1045 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.BaseDesktopUtils$NoNetscapeScorer$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.BaseDesktopUtils$NoNetscapeScorer$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 103-107 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.BorderLayoutRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.BorderLayoutRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.BorderLayoutRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 30-44 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.BreadCrumbsRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.BreadCrumbsRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.BreadCrumbsRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 31-39 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.CellFormatRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.CellFormatRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.CellFormatRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 32-52 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.GeneratedImageRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of node, which is known to be non-null in org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.GeneratedImageRenderer.renderImage(UIXRenderingContext, UINode, ImageProviderResponse, boolean, String, Object, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 130 | Medium |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.HeaderRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.HeaderRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.HeaderRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 36-321 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.NavigationBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.NavigationBarRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationBarRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 32-60 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.NavigationPathRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.NavigationPathRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationPathRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 31-39 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.PageNavigationPathRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.PageNavigationPathRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.PageNavigationPathRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 31-39 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.ProcessChoiceBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.ProcessChoiceBarRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.ProcessChoiceBarRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 34-47 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TreeRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to nodeDepth in org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TreeRenderer._renderNode(UIXRenderingContext, UIXHierarchy, UINode, UINode, String, RowKeySet, Map, Boolean[], boolean, boolean, boolean, int) | STYLE | DLS_DEAD_LOCAL_STORE | 701 | Low |
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TreeRenderer._ICON in org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TreeRenderer.getIcon() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 841-844 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TreeRenderer$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TreeRenderer$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 858-863 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.BorderLayoutRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.BorderLayoutRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.BorderLayoutRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 29-43 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.CellFormatRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.CellFormatRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.CellFormatRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 32-57 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.GlobalButtonBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.GlobalButtonBarRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.GlobalButtonBarRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 33-58 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.HeaderRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.HeaderRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.HeaderRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 39-231 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.LinkRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.LinkRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.LinkRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 36-188 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.NavigationBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.NavigationBarRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationBarRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 33-81 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.PdaHtmlLafUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.ui.laf.base.pda.PdaHtmlLafUtils.getPartialTargets(UIXRenderingContext, UINode, Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 66 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.PdaHtmlLookAndFeel
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.ui.laf.base.pda.PdaHtmlLookAndFeel implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 41-154 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.ProcessChoiceBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.ProcessChoiceBarRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.ProcessChoiceBarRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 33-78 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.ResetButtonRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.ResetButtonRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.ResetButtonRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 35-65 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.SeparatorRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.SeparatorRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.SeparatorRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 35-48 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.SubmitButtonRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.SubmitButtonRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.SubmitButtonRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 35-70 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.pda.TreeRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.base.pda.TreeRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TreeRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 34-188 | High |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.AccentedLafIconProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of color which is known to be null in org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.AccentedLafIconProvider._getColor(UIXRenderingContext, String, Object, Color) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 281 | Low |
org.apache.myfaces.trinidadinternal.image.cache.FlippedIconKey
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.FlippedIconRequest doesn't override org.apache.myfaces.trinidadinternal.image.cache.FlippedIconKey.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 86-94 | Medium |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationBarRenderer._sEmptyRangeNode in org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationBarRenderer._getEmptyRangeNode() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 2342-2344 | Low |
| Redundant nullcheck of links, which is known to be non-null in org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationBarRenderer._renderSingleItemNavigator(UIXRenderingContext, UINode, String, String, String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 489 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationPathRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.apache.myfaces.trinidadinternal.ui.UIXRenderingContext to org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderingContext in org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.NavigationPathRenderer.renderStamp(UIXRenderingContext, UINode, UINode, boolean) | STYLE | BC_UNCONFIRMED_CAST | 239 | Medium |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.ProcessUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.ProcessUtils._createKeyValueArray(String, String, String, String, long, String, int, String, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 363-385 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.ScriptRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.ScriptRenderer implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 40-145 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.SubmitButtonRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.SubmitButtonRenderer.getNameValues(UIXRenderingContext, UINode) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 169 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.XhtmlLafConstants
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.XhtmlLafConstants.HEADER_ELEMENT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 114 | Medium |
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.XhtmlLafUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.XhtmlLafUtils.getPartialTargets(UIXRenderingContext, UINode, Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 833 | Low |
org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.ButtonRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.ButtonRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.ButtonRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 37-106 | High |
org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.GlobalButtonBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.GlobalButtonBarRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.GlobalButtonBarRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 50-113 | High |
org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.MessageBoxRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.MessageBoxRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.MessageBoxRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 41-446 | High |
| Redundant nullcheck of org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.MessageBoxRenderer$IconData.bottomEnd which is known to be null in org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.MessageBoxRenderer._getColumnCount(MessageBoxRenderer$IconData) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 293 | Low |
| Repeated conditional test in org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.MessageBoxRenderer._getColumnCount(MessageBoxRenderer$IconData) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 293 | High |
org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.ResetButtonRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.ResetButtonRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.ResetButtonRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 37-112 | High |
org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SideBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SideBarRenderer$IconData.bottomEnd which is known to be null in org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SideBarRenderer._getColumnCount(SideBarRenderer$IconData) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 330 | Low |
| Repeated conditional test in org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SideBarRenderer._getColumnCount(SideBarRenderer$IconData) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 330 | High |
org.apache.myfaces.trinidadinternal.image.cache.CompositeButtonKey
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SimpleButtonUtils$Key doesn't override org.apache.myfaces.trinidadinternal.image.cache.CompositeButtonKey.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 151-171 | Medium |
org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SubmitButtonRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SubmitButtonRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.SubmitButtonRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 37-106 | High |
org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.TabBarRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.TabBarRenderer shadows the simple name of the superclass org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.TabBarRenderer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 50-247 | High |
org.apache.myfaces.trinidadinternal.uinode.UINodePropertyKey
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 131 | Low |
org.apache.myfaces.trinidad.bean.PropertyKey
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.uinode.UINodePropertyKey doesn't override org.apache.myfaces.trinidad.bean.PropertyKey.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 280-306 | Medium |
org.apache.myfaces.trinidadinternal.uinode.UIXComponentUINode
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of renderer, which is known to be non-null in org.apache.myfaces.trinidadinternal.uinode.UIXComponentUINode.postrenderInternal(UIXRenderingContext, UINode) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 297 | Medium |
| Redundant nullcheck of renderer, which is known to be non-null in org.apache.myfaces.trinidadinternal.uinode.UIXComponentUINode.prerenderInternal(UIXRenderingContext, UINode) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 236 | Medium |
org.apache.myfaces.trinidadinternal.uinode.bind.MenuSelectedValueBoundValue
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXNavigationHierarchy in new org.apache.myfaces.trinidadinternal.uinode.bind.MenuSelectedValueBoundValue(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 42 | Low |
org.apache.myfaces.trinidadinternal.util.DateUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 65 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 43 | Low |
org.apache.myfaces.trinidadinternal.util.FormattedTextParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 61 | Low |
org.apache.myfaces.trinidadinternal.util.FormattedTextParser$ElementInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 587 | Low |
org.apache.myfaces.trinidadinternal.util.JavaIntrospector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.util.JavaIntrospector.getBeanInfoSearchPath() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 261 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.util.JavaIntrospector._findInformant(Class) | STYLE | REC_CATCH_EXCEPTION | 464 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.util.JavaIntrospector.__createMergedEventSetStub(EventSetDescriptor, MethodDescriptor[]) | STYLE | REC_CATCH_EXCEPTION | 1724 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.util.JavaIntrospector._findInformant(Class) | STYLE | REC_CATCH_EXCEPTION | 430 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.trinidadinternal.util.JavaIntrospector._instantiate(Class, String) | STYLE | REC_CATCH_EXCEPTION | 1549 | Low |
| org.apache.myfaces.trinidadinternal.util.JavaIntrospector.__getTargetEventInfo() checks to see if result of String.indexOf is positive | STYLE | RV_CHECK_FOR_POSITIVE_INDEXOF | 957 | Low |
org.apache.myfaces.trinidadinternal.util.SubKeyMap$Entry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of key, which is known to be non-null in org.apache.myfaces.trinidadinternal.util.SubKeyMap$Entry.hashCode() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 269 | Low |
org.apache.myfaces.trinidadinternal.util.TokenCache$LRU
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.trinidadinternal.util.TokenCache._removed; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 387 | Low |
org.apache.myfaces.trinidadinternal.util.TokenCache
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of remove which is known to be null in org.apache.myfaces.trinidadinternal.util.TokenCache.addNewEntry(Object, Map, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 242 | Medium |
| Class org.apache.myfaces.trinidadinternal.util.TokenCache defines non-transient non-serializable instance field _cache | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.trinidadinternal.util.TokenCache defines non-transient non-serializable instance field _pinned | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| The field org.apache.myfaces.trinidadinternal.util.TokenCache._owner is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
| The field org.apache.myfaces.trinidadinternal.util.TokenCache._removed is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.trinidadinternal.util.TokenCache$LRU
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.util.TokenCache$LRU is serializable and an inner class | BAD_PRACTICE | SE_INNER_CLASS | 377-388 | Low |
org.apache.myfaces.trinidadinternal.util.URLUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.trinidadinternal.util.URLUtils.getLastModified(URLConnection) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 79 | Low |
org.apache.myfaces.trinidadinternal.validator.ByteLengthValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 179 | Low |
| The class name org.apache.myfaces.trinidadinternal.validator.ByteLengthValidator shadows the simple name of the superclass org.apache.myfaces.trinidad.validator.ByteLengthValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 42-433 | High |
org.apache.myfaces.trinidadinternal.validator.DateRestrictionValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.validator.DateRestrictionValidator shadows the simple name of the superclass org.apache.myfaces.trinidad.validator.DateRestrictionValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 45-169 | High |
org.apache.myfaces.trinidadinternal.validator.DateTimeRangeValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.validator.DateTimeRangeValidator shadows the simple name of the superclass org.apache.myfaces.trinidad.validator.DateTimeRangeValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 44-177 | High |
org.apache.myfaces.trinidadinternal.validator.DoubleRangeValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Test for floating point equality in org.apache.myfaces.trinidadinternal.validator.DoubleRangeValidator.getClientValidation(FacesContext, UIComponent) | STYLE | FE_FLOATING_POINT_EQUALITY | 65 | Medium |
| The class name org.apache.myfaces.trinidadinternal.validator.DoubleRangeValidator shadows the simple name of the superclass org.apache.myfaces.trinidad.validator.DoubleRangeValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 37-129 | High |
org.apache.myfaces.trinidadinternal.validator.LengthValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.validator.LengthValidator shadows the simple name of the superclass org.apache.myfaces.trinidad.validator.LengthValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 38-165 | High |
org.apache.myfaces.trinidadinternal.validator.LongRangeValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.validator.LongRangeValidator shadows the simple name of the superclass org.apache.myfaces.trinidad.validator.LongRangeValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 38-130 | High |
org.apache.myfaces.trinidadinternal.validator.RegExpValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.trinidadinternal.validator.RegExpValidator shadows the simple name of the superclass org.apache.myfaces.trinidad.validator.RegExpValidator | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 40-120 | High |
org.apache.myfaces.trinidadinternal.webapp.ReplaceParametersRequestWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.trinidadinternal.webapp.ReplaceParametersRequestWrapper.getParameterValues(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 72 | Low |
org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl$LaunchData
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl$LaunchData defines non-transient non-serializable instance field _launchView | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl$LaunchData defines non-transient non-serializable instance field _launchParam | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |