FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
org.apache.myfaces.trinidaddemo.ActionBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.ActionBean.nothing() | CORRECTNESS | NP_ALWAYS_NULL | 29 | High |
org.apache.myfaces.trinidaddemo.AnimalsBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.AnimalsBean defines non-transient non-serializable instance field _names | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.AnimalsBean defines non-transient non-serializable instance field _namesInRange | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.AnimalsBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31 | Low |
org.apache.myfaces.trinidaddemo.AtomBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.AtomBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33 | Low |
org.apache.myfaces.trinidaddemo.CarBackingBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.myfaces.trinidaddemo.CarBackingBean.returnOptions(ReturnEvent) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 110 | Medium |
Method org.apache.myfaces.trinidaddemo.CarBackingBean.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 151 | Low |
org.apache.myfaces.trinidaddemo.ChartBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.ChartBean defines non-transient non-serializable instance field _editorBean | BAD_PRACTICE | SE_BAD_FIELD | High | |
org.apache.myfaces.trinidaddemo.ChartBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 46 | Low |
org.apache.myfaces.trinidaddemo.ChartBean$MyChartModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.ChartBean$MyChartModel._loadLargerValues(ArrayList, String) | CORRECTNESS | NP_ALWAYS_NULL | 235 | High |
org.apache.myfaces.trinidaddemo.ChartBean$MyChartModel._loadLargerValues(ArrayList, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 216 | Medium |
org.apache.myfaces.trinidaddemo.ChartBean$MyChartModel is serializable and an inner class | BAD_PRACTICE | SE_INNER_CLASS | 143 | Medium |
org.apache.myfaces.trinidaddemo.ChartBean$MyChartModel is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 143 | Low |
org.apache.myfaces.trinidaddemo.ClientValidationBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ClientValidationBean.getDate() may expose internal representation by returning ClientValidationBean._date | MALICIOUS_CODE | EI_EXPOSE_REP | 199 | Medium |
org.apache.myfaces.trinidaddemo.ClientValidationBean.setDate(Date) may expose internal representation by storing an externally mutable object into ClientValidationBean._date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 204 | Medium |
org.apache.myfaces.trinidaddemo.ClientValidationBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28 | Low |
org.apache.myfaces.trinidaddemo.ColorBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ColorBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30 | Low |
org.apache.myfaces.trinidaddemo.ComponentEditorHandler$PropertyOfComponent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ComponentEditorHandler$PropertyOfComponent defines compareTo(ComponentEditorHandler$PropertyOfComponent) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 171 | Medium |
org.apache.myfaces.trinidaddemo.ComponentTree
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.trinidad.component.UIXTree in org.apache.myfaces.trinidaddemo.ComponentTree.setTree(UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 92 | Low |
org.apache.myfaces.trinidaddemo.ComponentTree$Bean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ComponentTree$Bean defines compareTo(ComponentTree$Bean) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 219 | Medium |
Class org.apache.myfaces.trinidaddemo.ComponentTree$Bean defines non-transient non-serializable instance field _kids | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.ComponentTree$Bean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 188 | Low |
org.apache.myfaces.trinidaddemo.ConverterValidatorBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new org.apache.myfaces.trinidaddemo.ConverterValidatorBean() invokes inefficient Double.valueOf(double) constructor; use ConverterValidatorBean.java:[line 90] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 90 | Low |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.ConverterValidatorBean.valueChanged(ValueChangeEvent) | CORRECTNESS | NP_ALWAYS_NULL | 85 | High |
org.apache.myfaces.trinidaddemo.ConverterValidatorBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30 | Low |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.getDate1() may expose internal representation by returning CustomMessageConvertValidateBean._date1 | MALICIOUS_CODE | EI_EXPOSE_REP | 49 | Medium |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.getDate2() may expose internal representation by returning CustomMessageConvertValidateBean._date2 | MALICIOUS_CODE | EI_EXPOSE_REP | 59 | Medium |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.getMaxDate() may expose internal representation by returning CustomMessageConvertValidateBean._maxDate | MALICIOUS_CODE | EI_EXPOSE_REP | 84 | Medium |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.getMinDate() may expose internal representation by returning CustomMessageConvertValidateBean._minDate | MALICIOUS_CODE | EI_EXPOSE_REP | 74 | Medium |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.setDate1(Date) may expose internal representation by storing an externally mutable object into CustomMessageConvertValidateBean._date1 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 54 | Medium |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.setDate2(Date) may expose internal representation by storing an externally mutable object into CustomMessageConvertValidateBean._date2 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 64 | Medium |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.setMaxDate(Date) may expose internal representation by storing an externally mutable object into CustomMessageConvertValidateBean._maxDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 79 | Medium |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean.setMinDate(Date) may expose internal representation by storing an externally mutable object into CustomMessageConvertValidateBean._minDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 69 | Medium |
Class org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean defines non-transient non-serializable instance field _messages | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.CustomMessageConvertValidateBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31 | Low |
org.apache.myfaces.trinidaddemo.DataBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.DataBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 29 | Low |
org.apache.myfaces.trinidaddemo.DateBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.DateBean.getDate1() may expose internal representation by returning DateBean._date1 | MALICIOUS_CODE | EI_EXPOSE_REP | 64 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getDate2() may expose internal representation by returning DateBean._date2 | MALICIOUS_CODE | EI_EXPOSE_REP | 74 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getDate3() may expose internal representation by returning DateBean._date3 | MALICIOUS_CODE | EI_EXPOSE_REP | 84 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getDate4() may expose internal representation by returning DateBean._date4 | MALICIOUS_CODE | EI_EXPOSE_REP | 94 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getDate5() may expose internal representation by returning DateBean._date5 | MALICIOUS_CODE | EI_EXPOSE_REP | 104 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getMaxDate() may expose internal representation by returning DateBean._maxDate | MALICIOUS_CODE | EI_EXPOSE_REP | 129 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getMinDate() may expose internal representation by returning DateBean._minDate | MALICIOUS_CODE | EI_EXPOSE_REP | 119 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getTodayFromMidnight() may expose internal representation by returning DateBean._todayFromMidnight | MALICIOUS_CODE | EI_EXPOSE_REP | 144 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.getTonightNearMidnight() may expose internal representation by returning DateBean._tonightNearMidnight | MALICIOUS_CODE | EI_EXPOSE_REP | 155 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setDate1(Date) may expose internal representation by storing an externally mutable object into DateBean._date1 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 69 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setDate2(Date) may expose internal representation by storing an externally mutable object into DateBean._date2 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 79 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setDate3(Date) may expose internal representation by storing an externally mutable object into DateBean._date3 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 89 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setDate4(Date) may expose internal representation by storing an externally mutable object into DateBean._date4 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 99 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setDate5(Date) may expose internal representation by storing an externally mutable object into DateBean._date5 | MALICIOUS_CODE | EI_EXPOSE_REP2 | 109 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setMaxDate(Date) may expose internal representation by storing an externally mutable object into DateBean._maxDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 124 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setMinDate(Date) may expose internal representation by storing an externally mutable object into DateBean._minDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 114 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setTodayFromMidnight(Date) may expose internal representation by storing an externally mutable object into DateBean._todayFromMidnight | MALICIOUS_CODE | EI_EXPOSE_REP2 | 149 | Medium |
org.apache.myfaces.trinidaddemo.DateBean.setTonightNearMidnight(Date) may expose internal representation by storing an externally mutable object into DateBean._tonightNearMidnight | MALICIOUS_CODE | EI_EXPOSE_REP2 | 160 | Medium |
org.apache.myfaces.trinidaddemo.DateBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28 | Low |
org.apache.myfaces.trinidaddemo.DateRestrictionValidatorBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.DateRestrictionValidatorBean.getTestInvalidDays() may expose internal representation by returning DateRestrictionValidatorBean._testInvalidDays | MALICIOUS_CODE | EI_EXPOSE_REP | 46 | Medium |
org.apache.myfaces.trinidaddemo.DateRestrictionValidatorBean.getTestInvalidDaysOfWeek() may expose internal representation by returning DateRestrictionValidatorBean._testInvalidDaysOfWeek | MALICIOUS_CODE | EI_EXPOSE_REP | 54 | Medium |
org.apache.myfaces.trinidaddemo.DateRestrictionValidatorBean.getTestInvalidMonth() may expose internal representation by returning DateRestrictionValidatorBean._testInvalidMonth | MALICIOUS_CODE | EI_EXPOSE_REP | 62 | Medium |
org.apache.myfaces.trinidaddemo.DateRestrictionValidatorBean.setTestInvalidDays(Date) may expose internal representation by storing an externally mutable object into DateRestrictionValidatorBean._testInvalidDays | MALICIOUS_CODE | EI_EXPOSE_REP2 | 50 | Medium |
org.apache.myfaces.trinidaddemo.DateRestrictionValidatorBean.setTestInvalidDaysOfWeek(Date) may expose internal representation by storing an externally mutable object into DateRestrictionValidatorBean._testInvalidDaysOfWeek | MALICIOUS_CODE | EI_EXPOSE_REP2 | 58 | Medium |
org.apache.myfaces.trinidaddemo.DateRestrictionValidatorBean.setTestInvalidMonth(Date) may expose internal representation by storing an externally mutable object into DateRestrictionValidatorBean._testInvalidMonth | MALICIOUS_CODE | EI_EXPOSE_REP2 | 66 | Medium |
org.apache.myfaces.trinidaddemo.DemoCommandNavigationItemBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.myfaces.trinidaddemo.DemoCommandNavigationItemBean.navigationItemAction(ActionEvent) | CORRECTNESS | NP_ALWAYS_NULL | 50 | High |
org.apache.myfaces.trinidaddemo.DemoShowDetailDisclosureBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.DemoShowDetailDisclosureBean.setDisclosureKey(String) | CORRECTNESS | NP_ALWAYS_NULL | 64 | High |
org.apache.myfaces.trinidaddemo.DemoTreeData
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.DemoTreeData is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Low |
org.apache.myfaces.trinidaddemo.InfiniteTree
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.InfiniteTree is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27 | Low |
org.apache.myfaces.trinidaddemo.ListTestBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ListTestBean.getIntArray() may expose internal representation by returning ListTestBean._intArray | MALICIOUS_CODE | EI_EXPOSE_REP | 56 | Medium |
org.apache.myfaces.trinidaddemo.ListTestBean.getStringArray() may expose internal representation by returning ListTestBean._stringArray | MALICIOUS_CODE | EI_EXPOSE_REP | 76 | Medium |
org.apache.myfaces.trinidaddemo.ListTestBean.setIntArray(int[]) may expose internal representation by storing an externally mutable object into ListTestBean._intArray | MALICIOUS_CODE | EI_EXPOSE_REP2 | 61 | Medium |
org.apache.myfaces.trinidaddemo.ListTestBean.setStringArray(String[]) may expose internal representation by storing an externally mutable object into ListTestBean._stringArray | MALICIOUS_CODE | EI_EXPOSE_REP2 | 81 | Medium |
Method org.apache.myfaces.trinidaddemo.ListTestBean._toString(Object) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 177 | Medium |
Class org.apache.myfaces.trinidaddemo.ListTestBean defines non-transient non-serializable instance field _objectList | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.ListTestBean defines non-transient non-serializable instance field _selectedCars | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.ListTestBean defines non-transient non-serializable instance field _selectedCars2 | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.ListTestBean defines non-transient non-serializable instance field _selectedSelectItems | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.ListTestBean defines non-transient non-serializable instance field _stringList | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.ListTestBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31 | Low |
org.apache.myfaces.trinidaddemo.ListTestBean$Car
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ListTestBean$Car is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 210 | Low |
org.apache.myfaces.trinidaddemo.MessagesBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.MessagesBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 26 | Low |
org.apache.myfaces.trinidaddemo.PartialDemoStatusBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.PartialDemoStatusBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31 | Low |
org.apache.myfaces.trinidaddemo.PollBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.PollBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33 | Low |
Write to static field org.apache.myfaces.trinidaddemo.PollBean._POLL_COUNT from instance method new org.apache.myfaces.trinidaddemo.PollBean() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 34 | High |
Write to static field org.apache.myfaces.trinidaddemo.PollBean._POLL_COUNT from instance method org.apache.myfaces.trinidaddemo.PollBean.resetPoll(ActionEvent) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 49 | High |
org.apache.myfaces.trinidaddemo.ProgressBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ProgressBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36 | Low |
org.apache.myfaces.trinidaddemo.ProgressBean$ProcessThread
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ProgressBean$ProcessThread is serializable and an inner class | BAD_PRACTICE | SE_INNER_CLASS | 75 | Medium |
org.apache.myfaces.trinidaddemo.ProgressBean$ProcessThread is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 75 | Low |
org.apache.myfaces.trinidaddemo.ProgressStepsBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ProgressStepsBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 39 | Low |
org.apache.myfaces.trinidaddemo.SelectItemTestBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.SelectItemTestBean.getItemArray() may expose internal representation by returning SelectItemTestBean._itemArray | MALICIOUS_CODE | EI_EXPOSE_REP | 64 | Medium |
org.apache.myfaces.trinidaddemo.SkinDirtyPhaseListener
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.SkinDirtyPhaseListener.beforePhase(PhaseEvent) | CORRECTNESS | NP_ALWAYS_NULL | 52 | High |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.SkinDirtyPhaseListener.buttonAction(ActionEvent) | CORRECTNESS | NP_ALWAYS_NULL | 81 | High |
org.apache.myfaces.trinidaddemo.SubformBean$MyItem
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.SubformBean$MyItem.doSomething(ActionEvent) | CORRECTNESS | NP_ALWAYS_NULL | 119 | High |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.SubformBean$MyItem.setText(String) | CORRECTNESS | NP_ALWAYS_NULL | 113 | High |
org.apache.myfaces.trinidaddemo.ToggleBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.ToggleBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 23 | Low |
org.apache.myfaces.trinidaddemo.TreeModelAdapter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.TreeModelAdapter is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 35 | Medium |
org.apache.myfaces.trinidaddemo.TreeNodeImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.TreeNodeImpl defines non-transient non-serializable instance field _nodes | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.TreeNodeImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32 | Low |
org.apache.myfaces.trinidaddemo.UIBeanState
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.UIBeanState is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 24 | Low |
org.apache.myfaces.trinidaddemo.behaviors.render.InvokeFunctionBehaviorRenderer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.behavior.ClientBehavior to org.apache.myfaces.trinidaddemo.behaviors.InvokeFunctionBehavior in org.apache.myfaces.trinidaddemo.behaviors.render.InvokeFunctionBehaviorRenderer.getScript(ClientBehaviorContext, ClientBehavior) | STYLE | BC_UNCONFIRMED_CAST | 40 | Low |
org.apache.myfaces.trinidaddemo.change.ChangeBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.myfaces.trinidaddemo.change.ChangeBean._getRandIndex() uses the nextDouble method of Random to generate a random integer; using nextInt is more efficient | PERFORMANCE | DM_NEXTINT_VIA_NEXTDOUBLE | 384 | Medium |
org.apache.myfaces.trinidaddemo.composite.DateField
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.myfaces.trinidaddemo.composite.DateField._addChildren(FacesContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 185 | Medium |
org.apache.myfaces.trinidaddemo.composite.DateFieldAsRenderer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.trinidaddemo.composite.DateFieldAsRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 71 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.trinidaddemo.composite.DateFieldAsRenderer.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 108 | Low |
Method org.apache.myfaces.trinidaddemo.composite.DateFieldAsRenderer._addChildren(FacesContext, UIComponent) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 204 | Medium |
org.apache.myfaces.trinidaddemo.convertValidate.ConvertSSNTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.convertValidate.ConvertSSNTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33 | Low |
org.apache.myfaces.trinidaddemo.convertValidate.ValidatePasswordTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.convertValidate.ValidatePasswordTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32 | Low |
org.apache.myfaces.trinidaddemo.email.AccountData
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to smtp in org.apache.myfaces.trinidaddemo.email.AccountData._initializeFromProperties() | STYLE | DLS_DEAD_LOCAL_STORE | 351 | Medium |
org.apache.myfaces.trinidaddemo.email.AccountData.getRootFolders() may expose internal representation by returning AccountData._rootFolders | MALICIOUS_CODE | EI_EXPOSE_REP | 121 | Medium |
org.apache.myfaces.trinidaddemo.email.AccountData.setRootFolders(FolderData[]) may expose internal representation by storing an externally mutable object into AccountData._rootFolders | MALICIOUS_CODE | EI_EXPOSE_REP2 | 202 | Medium |
Inconsistent synchronization of org.apache.myfaces.trinidaddemo.email.AccountData._store; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 185 | Medium |
org.apache.myfaces.trinidaddemo.email.AccountData._initializeFromProperties() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 342 | Medium |
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidaddemo.email.AccountData.login() | STYLE | REC_CATCH_EXCEPTION | 257 | Low |
org.apache.myfaces.trinidaddemo.email.AccountData is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 55 | Medium |
org.apache.myfaces.trinidaddemo.email.FolderData
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.myfaces.trinidaddemo.email.FolderData.toFolderData(AccountData, Folder[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 211 | Low |
org.apache.myfaces.trinidaddemo.email.MessageData
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of org.apache.myfaces.trinidaddemo.email.MessageData._content; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 180 | Low |
Inconsistent synchronization of org.apache.myfaces.trinidaddemo.email.MessageData._contentType; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 158 | Low |
Inconsistent synchronization of org.apache.myfaces.trinidaddemo.email.MessageData._isRead; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 211 | Low |
Inconsistent synchronization of org.apache.myfaces.trinidaddemo.email.MessageData._lineCount; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 202 | Low |
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidaddemo.email.MessageData._tryInit() | STYLE | REC_CATCH_EXCEPTION | 341 | Medium |
org.apache.myfaces.trinidaddemo.email.MessageDataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on Throwable.getStackTrace() in org.apache.myfaces.trinidaddemo.email.MessageDataModel.pageInRowIndex(int) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 191 | Medium |
org.apache.myfaces.trinidaddemo.email.NewMessageBackingBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.myfaces.trinidaddemo.email.NewMessageBackingBean._getEmailList(String) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 373 | Low |
Method org.apache.myfaces.trinidaddemo.email.NewMessageBackingBean._setupMessage(Message) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 292 | Low |
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidaddemo.email.NewMessageBackingBean._setupMessage(Message) | STYLE | REC_CATCH_EXCEPTION | 342 | Low |
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidaddemo.email.NewMessageBackingBean.saveAsDraft() | STYLE | REC_CATCH_EXCEPTION | 261 | Low |
Exception is caught when Exception is not thrown in org.apache.myfaces.trinidaddemo.email.NewMessageBackingBean.send() | STYLE | REC_CATCH_EXCEPTION | 213 | Low |
org.apache.myfaces.trinidaddemo.email.PreferencesData
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.email.PreferencesData.REGULAR_BRANDING isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 40 | High |
org.apache.myfaces.trinidaddemo.email.PreferencesData.MEDIUM_BRANDING isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 47 | Low |
org.apache.myfaces.trinidaddemo.email.PreferencesData.SMALL_BRANDING isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 54 | Low |
org.apache.myfaces.trinidaddemo.email.resource.EmailDemoBundle
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.email.resource.EmailDemoBundle.getContents() may expose internal representation by returning EmailDemoBundle._CONTENTS | MALICIOUS_CODE | EI_EXPOSE_REP | 28 | Medium |
org.apache.myfaces.trinidaddemo.nav.DemoNavigationItem
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.nav.DemoNavigationItem defines non-transient non-serializable instance field _children | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.nav.DemoNavigationItem is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28 | Low |
org.apache.myfaces.trinidaddemo.nav.MenuModelAdapter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Check for oddness that won't work for negative numbers in org.apache.myfaces.trinidaddemo.nav.MenuModelAdapter.getModel() | STYLE | IM_BAD_CHECK_FOR_ODD | 58 | Medium |
Class org.apache.myfaces.trinidaddemo.nav.MenuModelAdapter defines non-transient non-serializable instance field _model | BAD_PRACTICE | SE_BAD_FIELD | High | |
Class org.apache.myfaces.trinidaddemo.nav.MenuModelAdapter defines non-transient non-serializable instance field _aliasList | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.nav.MenuModelAdapter is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32 | Low |
org.apache.myfaces.trinidaddemo.resource.SkinBundle
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.resource.SkinBundle.getContents() may expose internal representation by returning SkinBundle._CONTENTS | MALICIOUS_CODE | EI_EXPOSE_REP | 32 | Medium |
org.apache.myfaces.trinidaddemo.resource.SkinBundle_fr
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.resource.SkinBundle_fr.getContents() may expose internal representation by returning SkinBundle_fr._CONTENTS | MALICIOUS_CODE | EI_EXPOSE_REP | 28 | Medium |
org.apache.myfaces.trinidaddemo.survey.AnswerValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 42 | Low |
org.apache.myfaces.trinidaddemo.survey.AnswerValidatorTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.survey.AnswerValidatorTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28 | Low |
Unread field: org.apache.myfaces.trinidaddemo.survey.AnswerValidatorTag.ID; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 29 | Medium |
org.apache.myfaces.trinidaddemo.survey.CheckboxQuestionBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.survey.CheckboxQuestionBean.getCorrectAnswerMessage() | CORRECTNESS | NP_ALWAYS_NULL | 171 | High |
Method org.apache.myfaces.trinidaddemo.survey.CheckboxQuestionBean.getCorrectAnswerMessage() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 176 | Medium |
org.apache.myfaces.trinidaddemo.survey.CheckboxQuestionBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 57 | Low |
org.apache.myfaces.trinidaddemo.survey.MultChoiceQuestionBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.survey.MultChoiceQuestionBean defines non-transient non-serializable instance field _choices | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.survey.MultChoiceQuestionBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 42 | Low |
org.apache.myfaces.trinidaddemo.survey.SurveyBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 470 | Low |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.survey.SurveyBean.back() | CORRECTNESS | NP_ALWAYS_NULL | 236 | High |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.survey.SurveyBean.loadQuestions() | CORRECTNESS | NP_ALWAYS_NULL | 169 | High |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.survey.SurveyBean.next() | CORRECTNESS | NP_ALWAYS_NULL | 220 | High |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.survey.SurveyBean.storeCheckSelection(boolean, int, String) | CORRECTNESS | NP_ALWAYS_NULL | 418 | High |
Class org.apache.myfaces.trinidaddemo.survey.SurveyBean defines non-transient non-serializable instance field _pages | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.survey.SurveyBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40 | Low |
org.apache.myfaces.trinidaddemo.survey.SurveyPage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.survey.SurveyPage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 24 | Low |
org.apache.myfaces.trinidaddemo.survey.TextQuestionBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.survey.TextQuestionBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 44 | Low |
org.apache.myfaces.trinidaddemo.table.DynamicModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.myfaces.trinidaddemo.table.DynamicModel.getRowData() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 78 | Medium |
org.apache.myfaces.trinidaddemo.table.DynamicModel is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30 | Low |
org.apache.myfaces.trinidaddemo.table.SortableModelBean$FileInfo
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.table.SortableModelBean$FileInfo.getCreated() may expose internal representation by returning SortableModelBean$FileInfo._created | MALICIOUS_CODE | EI_EXPOSE_REP | 130 | Medium |
org.apache.myfaces.trinidaddemo.table.SortableModelBean$FileInfo.getModified() may expose internal representation by returning SortableModelBean$FileInfo._modified | MALICIOUS_CODE | EI_EXPOSE_REP | 125 | Medium |
org.apache.myfaces.trinidaddemo.table.SortableModelBean$SizeComparator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.table.SortableModelBean$SizeComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 140 | Medium |
org.apache.myfaces.trinidaddemo.table.TableBuilder
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.table.TableBuilder defines non-transient non-serializable instance field _data | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.table.TableBuilder defines non-transient non-serializable instance field _result | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.table.TableBuilder is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36 | Medium |
The field org.apache.myfaces.trinidaddemo.table.TableBuilder._beanProps is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
org.apache.myfaces.trinidaddemo.tableDemos.EmployeeBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.tableDemos.EmployeeBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34 | Low |
org.apache.myfaces.trinidaddemo.tableDemos.EmployeeTableBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.tableDemos.EmployeeTableBean defines non-transient non-serializable instance field _list | BAD_PRACTICE | SE_BAD_FIELD | Low | |
org.apache.myfaces.trinidaddemo.tableDemos.EmployeeTableBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32 | Low |
org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean defines non-transient non-serializable instance field _arrangeMap | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean defines non-transient non-serializable instance field _list | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean defines non-transient non-serializable instance field _map | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean defines non-transient non-serializable instance field _simpleList | BAD_PRACTICE | SE_BAD_FIELD | Low | |
Class org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean defines non-transient non-serializable instance field _updatableItemMap | BAD_PRACTICE | SE_BAD_FIELD | Low | |
The field org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean._felineFamily is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Low | |
The field org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean._model is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Low |
org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean$Genus
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean$Genus.getMembers() may expose internal representation by returning ForEachBean$Genus._members | MALICIOUS_CODE | EI_EXPOSE_REP | 166 | Medium |
org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean$SubFamily
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.tagDemos.ForEachBean$SubFamily.getMembers() may expose internal representation by returning ForEachBean$SubFamily._members | MALICIOUS_CODE | EI_EXPOSE_REP | 142 | Medium |
org.apache.myfaces.trinidaddemo.test.stateSaving.TestStateSavingBean
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.test.stateSaving.TestStateSavingBean.addComponent(ActionEvent) | CORRECTNESS | NP_ALWAYS_NULL | 62 | High |
Null pointer dereference of System.out in org.apache.myfaces.trinidaddemo.test.stateSaving.TestStateSavingBean.temporaryMoveComponent(ActionEvent) | CORRECTNESS | NP_ALWAYS_NULL | 73 | High |
org.apache.myfaces.trinidaddemo.webapp.RedirectFilter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.servlet.ServletResponse to javax.servlet.http.HttpServletResponse in org.apache.myfaces.trinidaddemo.webapp.RedirectFilter.doFilter(ServletRequest, ServletResponse, FilterChain) | STYLE | BC_UNCONFIRMED_CAST | 88 | Low |
HTTP parameter directly written to HTTP header output in org.apache.myfaces.trinidaddemo.webapp.RedirectFilter.doFilter(ServletRequest, ServletResponse, FilterChain) | SECURITY | HRS_REQUEST_PARAMETER_TO_HTTP_HEADER | 88 | Medium |
org.apache.myfaces.trinidaddemo.webapp.SourceCodeServlet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.trinidaddemo.webapp.SourceCodeServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34 | Low |