PMD Results
The following document contains the results of PMD 4.1.
Files
org/apache/myfaces/trinidadinternal/agent/AgentFactoryImpl.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'userAgent'. | 239 - 246 |
org/apache/myfaces/trinidadinternal/agent/CapabilityValue.java
Violation | Line |
---|---|
Avoid empty catch blocks | 54 - 56 |
org/apache/myfaces/trinidadinternal/agent/parse/CapabilitiesDocumentParser.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 81 |
An empty statement (semicolon) not part of a loop | 97 |
org/apache/myfaces/trinidadinternal/agent/parse/CapabilityDataDocumentParser.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 92 |
org/apache/myfaces/trinidadinternal/agent/parse/NameVersion.java
Violation | Line |
---|---|
These nested if statements could be combined | 365 - 366 |
org/apache/myfaces/trinidadinternal/application/ViewHandlerImpl.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.File' | 21 |
Avoid unused imports such as 'java.util.Locale' | 31 |
An empty statement (semicolon) not part of a loop | 171 |
org/apache/myfaces/trinidadinternal/config/CheckSerializationConfigurator.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.io.Serializable' | 21 |
Avoid unused imports such as 'java.util.Collections' | 23 |
org/apache/myfaces/trinidadinternal/config/ConfigParser.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 100 |
org/apache/myfaces/trinidadinternal/config/GlobalConfiguratorImpl.java
Violation | Line |
---|---|
Unnecessary final modifier in final class | 79 - 111 |
Unnecessary final modifier in final class | 136 - 155 |
org/apache/myfaces/trinidadinternal/config/LazyValueExpression.java
Violation | Line |
---|---|
Avoid unused private fields such as '_LOG'. | 224 |
org/apache/myfaces/trinidadinternal/config/dispatch/DispatchResponseConfiguratorImpl.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.Map' | 21 |
org/apache/myfaces/trinidadinternal/config/upload/FileUploadConfiguratorImpl.java
Violation | Line |
---|---|
Overriding method merely calls super | 195 - 199 |
org/apache/myfaces/trinidadinternal/context/PageFlowScopeMap.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'cache'. | 72 - 94 |
org/apache/myfaces/trinidadinternal/context/PartialVisitContext.java
Violation | Line |
---|---|
Avoid empty if statements | 314 - 316 |
org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java
Violation | Line |
---|---|
Avoid unused private fields such as '_facesContext'. | 934 |
org/apache/myfaces/trinidadinternal/context/external/NullEnumeration.java
Violation | Line |
---|---|
Unnecessary final modifier in final class | 30 - 33 |
org/apache/myfaces/trinidadinternal/context/external/ServletExternalContext.java
Violation | Line |
---|---|
These nested if statements could be combined | 193 - 197 |
Avoid unused private fields such as '_CHAR_ENCODING_CALLED'. | 693 |
org/apache/myfaces/trinidadinternal/convert/ByteConverter.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 122 - 139 |
Avoid unused method parameters such as 'context'. | 122 - 139 |
org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 212 - 268 |
org/apache/myfaces/trinidadinternal/convert/DateTimeConverter.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 384 |
Do not use if statements that are always true or always false | 405 |
Avoid unused method parameters such as 'context'. | 575 - 593 |
org/apache/myfaces/trinidadinternal/convert/DoubleConverter.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 95 - 100 |
Avoid unused method parameters such as 'context'. | 95 - 100 |
org/apache/myfaces/trinidadinternal/convert/FloatConverter.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 95 - 100 |
Avoid unused method parameters such as 'context'. | 95 - 100 |
org/apache/myfaces/trinidadinternal/convert/GenericConverterFactory.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.Collections' | 22 |
Avoid unused imports such as 'javax.faces.context.FacesContext' | 31 |
org/apache/myfaces/trinidadinternal/convert/IntegerConverter.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 129 - 146 |
Avoid unused method parameters such as 'context'. | 129 - 146 |
org/apache/myfaces/trinidadinternal/convert/LongConverter.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 126 - 143 |
Avoid unused method parameters such as 'context'. | 126 - 143 |
org/apache/myfaces/trinidadinternal/convert/NumberConverter.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 191 - 229 |
Avoid unused private fields such as '_LOG'. | 250 |
org/apache/myfaces/trinidadinternal/convert/ShortConverter.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 125 - 142 |
Avoid unused method parameters such as 'context'. | 125 - 142 |
org/apache/myfaces/trinidadinternal/el/OracleHelpProvider.java
Violation | Line |
---|---|
These nested if statements could be combined | 64 - 68 |
org/apache/myfaces/trinidadinternal/facelets/ReturnActionListenerTag.java
Violation | Line |
---|---|
Avoid unused imports such as 'com.sun.facelets.el.LegacyValueBinding' | 33 |
org/apache/myfaces/trinidadinternal/image/ImageTypeImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 80 - 85 |
org/apache/myfaces/trinidadinternal/image/cache/BaseColorizedIconKey.java
Violation | Line |
---|---|
Avoid unused constructor parameters such as 'context'. | 62 - 71 |
Avoid unused constructor parameters such as 'context'. | 79 - 87 |
org/apache/myfaces/trinidadinternal/image/cache/Cache.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 235 |
org/apache/myfaces/trinidadinternal/image/cache/FileSystemImageCache.java
Violation | Line |
---|---|
These nested if statements could be combined | 600 - 601 |
Avoid unused method parameters such as 'context'. | 998 - 1003 |
Avoid unused method parameters such as 'context'. | 1190 - 1201 |
An empty statement (semicolon) not part of a loop | 1677 |
These nested if statements could be combined | 1691 - 1700 |
org/apache/myfaces/trinidadinternal/image/encode/OctreeQuantizer.java
Violation | Line |
---|---|
These nested if statements could be combined | 241 - 246 |
org/apache/myfaces/trinidadinternal/image/encode/PNGEncoder.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.Iterator' | 29 |
Unnecessary final modifier in final class | 480 - 492 |
org/apache/myfaces/trinidadinternal/image/laf/browser/ButtonPainter.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 401 |
org/apache/myfaces/trinidadinternal/image/painter/AdjustableBorderPainter.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 167 |
org/apache/myfaces/trinidadinternal/image/painter/ImageUtils.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 275 |
An empty statement (semicolon) not part of a loop | 311 |
An empty statement (semicolon) not part of a loop | 322 |
org/apache/myfaces/trinidadinternal/image/xml/encode/AbstractXMLEncoder.java
Violation | Line |
---|---|
These nested if statements could be combined | 353 - 354 |
org/apache/myfaces/trinidadinternal/image/xml/parse/FontParser.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 153 |
org/apache/myfaces/trinidadinternal/image/xml/parse/ImageParseUtils.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 86 |
org/apache/myfaces/trinidadinternal/io/DebugHtmlResponseWriter.java
Violation | Line |
---|---|
These nested if statements could be combined | 80 - 81 |
org/apache/myfaces/trinidadinternal/io/HtmlResponseWriter.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.MimeTypes' | 31 |
org/apache/myfaces/trinidadinternal/io/IndentingResponseWriter.java
Violation | Line |
---|---|
These nested if statements could be combined | 71 - 74 |
org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java
Violation | Line |
---|---|
Avoid unused constructor parameters such as 'contentType'. | 46 - 56 |
org/apache/myfaces/trinidadinternal/menu/MenuContentHandlerImpl.java
Violation | Line |
---|---|
Avoid unused local variables such as 'npe'. | 305 |
org/apache/myfaces/trinidadinternal/renderkit/RenderKitBase.java
Violation | Line |
---|---|
These nested if statements could be combined | 132 - 133 |
org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java
Violation | Line |
---|---|
Avoid unused private fields such as '_BASIC_HTML_RENDERERS'. | 722 |
org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'context'. | 572 - 614 |
These nested if statements could be combined | 606 - 607 |
org/apache/myfaces/trinidadinternal/renderkit/core/DialogRequest.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SkinSelectors' | 33 |
org/apache/myfaces/trinidadinternal/renderkit/core/desktop/TrainRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'bean'. | 878 - 915 |
Avoid unused constructor parameters such as 'context'. | 919 - 949 |
org/apache/myfaces/trinidadinternal/renderkit/core/desktop/TreeTableRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 525 - 542 |
org/apache/myfaces/trinidadinternal/renderkit/core/pages/CalendarDialogJSP.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 154 |
org/apache/myfaces/trinidadinternal/renderkit/core/pages/JspUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 71 - 73 |
org/apache/myfaces/trinidadinternal/renderkit/core/pda/PdaCommandLinkRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.Collections' | 23 |
Avoid unused imports such as 'java.util.List' | 24 |
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SkinSelectors' | 35 |
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputUtils' | 36 |
org/apache/myfaces/trinidadinternal/renderkit/core/ppr/PPRResponseWriter.java
Violation | Line |
---|---|
These nested if statements could be combined | 380 - 388 |
org/apache/myfaces/trinidadinternal/renderkit/core/ppr/PartialPageContextImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 256 - 257 |
Avoid unused local variables such as 'clientId'. | 381 |
org/apache/myfaces/trinidadinternal/renderkit/core/skin/SimplePortletSkin.java
Violation | Line |
---|---|
No need to import a type that lives in the same package | 27 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/AutoSubmitUtils.java
Violation | Line |
---|---|
Avoid unused private fields such as '_START'. | 344 |
Avoid unused private fields such as '_START_RADIO'. | 345 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/BodyRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'arc'. | 413 - 427 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ChooseDateRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'isInline'. | 1523 - 1526 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/CoreFormData.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 328 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormElementRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 219 - 220 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 141 - 159 |
These nested if statements could be combined | 1195 - 1216 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 339 - 357 |
These nested if statements could be combined | 459 - 466 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MediaRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 606 - 613 |
These nested if statements could be combined | 609 - 612 |
These nested if statements could be combined | 1462 - 1466 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageBoxRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidad.skin.Icon' | 37 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/NavigationPaneRenderer.java
Violation | Line |
---|---|
Avoid duplicate imports such as 'org.apache.myfaces.trinidad.context.Agent' | 45 |
Avoid unused local variables such as 'styleAppender'. | 576 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/OutputLabelRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'javax.faces.component.EditableValueHolder' | 24 |
These nested if statements could be combined | 330 - 340 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/OutputUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 229 - 233 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelAccordionRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidad.context.Agent' | 34 |
Avoid unused method parameters such as 'component'. | 514 - 567 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelBorderLayoutRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 837 - 894 |
Avoid unused method parameters such as 'useLR'. | 837 - 894 |
Avoid unused method parameters such as 'isIE6'. | 907 - 932 |
Avoid unused method parameters such as 'bean'. | 907 - 932 |
Avoid unused method parameters such as 'bean'. | 934 - 980 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelFormLayoutRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 1063 - 1065 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelGroupLayoutRenderer.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 81 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelPartialRootRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'javax.faces.context.ExternalContext' | 25 |
These nested if statements could be combined | 144 - 148 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelPopupRenderer.java
Violation | Line |
---|---|
Avoid unused private fields such as '_LOG'. | 390 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PollRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'isPartial'. | 334 - 352 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SelectRangeChoiceBarRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 854 - 860 |
These nested if statements could be combined | 893 - 894 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ShowDetailRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'bean'. | 485 - 514 |
Avoid unused local variables such as 'linkId'. | 502 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 447 - 448 |
An empty statement (semicolon) not part of a loop | 789 |
An empty statement (semicolon) not part of a loop | 795 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectBooleanRadioRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 181 - 182 |
These nested if statements could be combined | 207 - 208 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectManyRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 627 - 630 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 127 - 129 |
These nested if statements could be combined | 584 - 585 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SingleStepButtonBarRenderer.java
Violation | Line |
---|---|
Avoid unused private fields such as '_SINGLE_CONTINUE_TEXT_KEY'. | 317 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/TreeRenderer.java
Violation | Line |
---|---|
Avoid unused local variables such as 'showLines'. | 317 |
Avoid empty catch blocks | 848 - 850 |
Avoid empty catch blocks | 851 - 853 |
Avoid empty catch blocks | 854 - 856 |
Avoid unused method parameters such as 'isFirstSibling'. | 935 - 977 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/XhtmlRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 370 - 374 |
Do not use if statements that are always true or always false | 937 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/jsLibs/DialogStyleScriptlet.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlUtils' | 29 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/ColumnData.java
Violation | Line |
---|---|
Avoid empty if statements | 418 |
An empty statement (semicolon) not part of a loop | 418 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/TableRenderingContext.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SkinSelectors' | 36 |
Avoid unused constructor parameters such as 'arc'. | 49 - 106 |
These nested if statements could be combined | 503 - 507 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/TableSelectOneRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidad.component.core.data.CoreTable' | 36 |
org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/TreeNodeColumnRenderer.java
Violation | Line |
---|---|
Avoid empty catch blocks | 224 - 226 |
Avoid empty catch blocks | 227 - 229 |
Avoid empty catch blocks | 230 - 232 |
org/apache/myfaces/trinidadinternal/renderkit/html/CellFormatRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.List' | 23 |
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.OutputUtils' | 35 |
These nested if statements could be combined | 96 - 99 |
org/apache/myfaces/trinidadinternal/renderkit/html/RowLayoutRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.List' | 23 |
org/apache/myfaces/trinidadinternal/renderkit/html/ScriptRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.List' | 23 |
org/apache/myfaces/trinidadinternal/renderkit/html/TableLayoutRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.List' | 23 |
org/apache/myfaces/trinidadinternal/renderkit/html/layout/CorePanelChoiceRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 298 - 315 |
org/apache/myfaces/trinidadinternal/renderkit/html/layout/CorePanelRadioRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 318 - 385 |
org/apache/myfaces/trinidadinternal/renderkit/html/layout/ShowOneListRendererBase.java
Violation | Line |
---|---|
These nested if statements could be combined | 578 - 584 |
org/apache/myfaces/trinidadinternal/share/data/ServletRequestParameters.java
Violation | Line |
---|---|
These nested if statements could be combined | 109 - 110 |
org/apache/myfaces/trinidadinternal/share/expl/Coercions.java
Violation | Line |
---|---|
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 308 |
An empty statement (semicolon) not part of a loop | 539 |
org/apache/myfaces/trinidadinternal/share/io/CachingNameResolver.java
Violation | Line |
---|---|
These nested if statements could be combined | 139 - 143 |
org/apache/myfaces/trinidadinternal/share/io/DefaultNameResolver.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 86 |
org/apache/myfaces/trinidadinternal/share/nls/ImmutableDateFormatContext.java
Violation | Line |
---|---|
Overriding method merely calls super | 47 - 50 |
org/apache/myfaces/trinidadinternal/share/nls/ImmutableDecimalFormatContext.java
Violation | Line |
---|---|
Overriding method merely calls super | 60 - 63 |
org/apache/myfaces/trinidadinternal/share/nls/MutableLocaleContext.java
Violation | Line |
---|---|
Overriding method merely calls super | 103 - 108 |
Overriding method merely calls super | 116 - 121 |
Unnecessary final modifier in final class | 129 - 136 |
Unnecessary final modifier in final class | 145 - 154 |
org/apache/myfaces/trinidadinternal/share/url/EncoderUtils.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 650 |
org/apache/myfaces/trinidadinternal/share/util/CaboHttpUtils.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 139 |
org/apache/myfaces/trinidadinternal/share/util/MultipartFormHandler.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 674 |
org/apache/myfaces/trinidadinternal/share/xml/ParseContextWrapper.java
Violation | Line |
---|---|
Unnecessary final modifier in final class | 142 - 145 |
org/apache/myfaces/trinidadinternal/share/xml/beans/BeanParser.java
Violation | Line |
---|---|
These nested if statements could be combined | 86 - 94 |
org/apache/myfaces/trinidadinternal/skin/SkinCSSParser.java
Violation | Line |
---|---|
These nested if statements could be combined | 77 - 80 |
org/apache/myfaces/trinidadinternal/skin/SkinExtension.java
Violation | Line |
---|---|
These nested if statements could be combined | 453 - 463 |
These nested if statements could be combined | 479 - 487 |
org/apache/myfaces/trinidadinternal/skin/SkinImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 218 - 222 |
An empty statement (semicolon) not part of a loop | 968 |
org/apache/myfaces/trinidadinternal/skin/SkinUtils.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 268 |
These nested if statements could be combined | 576 - 577 |
org/apache/myfaces/trinidadinternal/skin/StyleSheetEntry.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.List' | 23 |
org/apache/myfaces/trinidadinternal/skin/StyleSheetNameResolver.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 197 |
org/apache/myfaces/trinidadinternal/skin/icon/BaseImageIcon.java
Violation | Line |
---|---|
These nested if statements could be combined | 217 - 218 |
org/apache/myfaces/trinidadinternal/style/cache/FileSystemStyleCache.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 271 |
These nested if statements could be combined | 1083 - 1084 |
Avoid unused private fields such as '_outputDirectory'. | 1499 |
org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 425 - 432 |
Avoid empty if statements | 575 - 577 |
Avoid unnecessary return statements | 584 |
These nested if statements could be combined | 697 - 704 |
Avoid unused method parameters such as 'selector'. | 853 - 886 |
Avoid unused private fields such as '_SPACE_PATTERN'. | 1396 |
org/apache/myfaces/trinidadinternal/style/util/CSSUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 80 - 85 |
An empty statement (semicolon) not part of a loop | 506 |
These nested if statements could be combined | 808 - 813 |
org/apache/myfaces/trinidadinternal/style/xml/parse/ColorNodeParser.java
Violation | Line |
---|---|
These nested if statements could be combined | 63 - 64 |
org/apache/myfaces/trinidadinternal/style/xml/parse/ColorValidater.java
Violation | Line |
---|---|
These nested if statements could be combined | 47 - 48 |
org/apache/myfaces/trinidadinternal/style/xml/parse/SkinPropertyNode.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidad.logging.TrinidadLogger' | 21 |
org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.NoSuchElementException' | 33 |
An empty statement (semicolon) not part of a loop | 1228 |
An empty statement (semicolon) not part of a loop | 1253 |
org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocumentParser.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.net.URLConnection' | 25 |
These nested if statements could be combined | 156 - 162 |
org/apache/myfaces/trinidadinternal/taglib/ComponentDefTag.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.taglib.util.TagUtils' | 28 |
org/apache/myfaces/trinidadinternal/taglib/ForEachTag.java
Violation | Line |
---|---|
These nested if statements could be combined | 348 - 352 |
org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListenerTag.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.taglib.util.TagUtils' | 21 |
Avoid unused imports such as 'java.io.OutputStream' | 23 |
Avoid unused local variables such as 'parentELContext'. | 80 |
Avoid unused local variables such as 'application'. | 83 |
org/apache/myfaces/trinidadinternal/taglib/listener/ResetActionListenerTag.java
Violation | Line |
---|---|
Overriding method merely calls super | 63 - 66 |
org/apache/myfaces/trinidadinternal/taglib/listener/ReturnActionListenerTag.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.taglib.util.TagUtils' | 21 |
Avoid unused local variables such as 'parentELContext'. | 70 |
Avoid unused local variables such as 'application'. | 73 |
org/apache/myfaces/trinidadinternal/taglib/listener/SetActionListenerTag.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.taglib.util.TagUtils' | 21 |
Avoid unused local variables such as 'parentELContext'. | 76 |
Avoid unused local variables such as 'application'. | 79 |
org/apache/myfaces/trinidadinternal/taglib/util/TagUtils.java
Violation | Line |
---|---|
Avoid unused imports such as 'javax.faces.application.Application' | 34 |
Avoid unused imports such as 'javax.faces.context.FacesContext' | 35 |
Unnecessary final modifier in final class | 334 - 345 |
org/apache/myfaces/trinidadinternal/ui/BaseRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 87 - 88 |
org/apache/myfaces/trinidadinternal/ui/RootRenderingContext.java
Violation | Line |
---|---|
These nested if statements could be combined | 345 - 357 |
These nested if statements could be combined | 347 - 356 |
org/apache/myfaces/trinidadinternal/ui/beans/BaseWebBean.java
Violation | Line |
---|---|
Overriding method merely calls super | 330 - 336 |
Overriding method merely calls super | 344 - 348 |
org/apache/myfaces/trinidadinternal/ui/collection/FlaggedAttributeMap.java
Violation | Line |
---|---|
These nested if statements could be combined | 75 - 78 |
org/apache/myfaces/trinidadinternal/ui/laf/base/BaseLafRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 571 - 575 |
org/apache/myfaces/trinidadinternal/ui/laf/base/BaseLafUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 144 - 145 |
An empty statement (semicolon) not part of a loop | 1081 |
org/apache/myfaces/trinidadinternal/ui/laf/base/desktop/GlobalButtonRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 149 - 155 |
org/apache/myfaces/trinidadinternal/ui/laf/base/desktop/MessageWrapper.java
Violation | Line |
---|---|
Avoid unused imports such as 'javax.faces.el.ValueBinding' | 23 |
org/apache/myfaces/trinidadinternal/ui/laf/base/pda/LinkRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.ui.laf.base.BaseLafUtils' | 27 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/AccentedLafIconProvider.java
Violation | Line |
---|---|
These nested if statements could be combined | 133 - 134 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/BreadCrumbsRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'isLastChild'. | 375 - 392 |
Avoid unused constructor parameters such as 'breadCrumbs'. | 443 - 455 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ChoiceRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 84 - 95 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/CommandItemRenderer.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidad.component.UIXCommand' | 26 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/FormElementRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 125 - 130 |
These nested if statements could be combined | 154 - 158 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/HiddenLabelUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 101 - 111 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ImageRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 350 - 353 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/LinkRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 104 - 105 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/NavigationBarRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 1338 - 1342 |
These nested if statements could be combined | 2448 - 2451 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/NavigationPathRenderer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'isLastChild'. | 311 - 328 |
Avoid unused constructor parameters such as 'breadCrumbs'. | 379 - 391 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ProcessChoiceBarRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 677 - 680 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ProcessUtils.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlUtils' | 31 |
Avoid unused private methods such as '_createKeyValueArray(String,String,String,String,long,String,int,String,String)'. | 351 - 361 |
org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/XhtmlLafRenderer.java
Violation | Line |
---|---|
These nested if statements could be combined | 330 - 343 |
These nested if statements could be combined | 1436 - 1447 |
These nested if statements could be combined | 1477 - 1478 |
These nested if statements could be combined | 1848 - 1852 |
These nested if statements could be combined | 2162 - 2172 |
These nested if statements could be combined | 2207 - 2208 |
org/apache/myfaces/trinidadinternal/ui/laf/simple/desktop/SimpleButtonUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 116 - 121 |
Avoid unused constructor parameters such as 'arc'. | 191 - 225 |
Avoid unused constructor parameters such as 'fContext'. | 191 - 225 |
org/apache/myfaces/trinidadinternal/uinode/UINodeFacesBean.java
Violation | Line |
---|---|
These nested if statements could be combined | 215 - 220 |
These nested if statements could be combined | 238 - 239 |
org/apache/myfaces/trinidadinternal/util/DateUtils.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.config.ConfigParser' | 25 |
org/apache/myfaces/trinidadinternal/util/JavaIntrospector.java
Violation | Line |
---|---|
An empty statement (semicolon) not part of a loop | 433 |
An empty statement (semicolon) not part of a loop | 447 |
An empty statement (semicolon) not part of a loop | 467 |
These nested if statements could be combined | 660 - 674 |
An empty statement (semicolon) not part of a loop | 1344 |
An empty statement (semicolon) not part of a loop | 1552 |
An empty statement (semicolon) not part of a loop | 2076 |
An empty statement (semicolon) not part of a loop | 2149 |
An empty statement (semicolon) not part of a loop | 2204 |
An empty statement (semicolon) not part of a loop | 2243 |
org/apache/myfaces/trinidadinternal/util/MessageUtils.java
Violation | Line |
---|---|
Avoid unused imports such as 'javax.faces.application.FacesMessage.Severity' | 24 |
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.MessageWrapper' | 35 |
org/apache/myfaces/trinidadinternal/util/MimeUtility.java
Violation | Line |
---|---|
Avoid empty catch blocks | 72 - 75 |
An empty statement (semicolon) not part of a loop | 192 |
org/apache/myfaces/trinidadinternal/util/URLUtils.java
Violation | Line |
---|---|
Avoid empty catch blocks | 79 - 82 |
org/apache/myfaces/trinidadinternal/validator/ByteLengthValidator.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'maxLength'. | 141 - 166 |
Avoid unused method parameters such as 'context'. | 141 - 166 |
org/apache/myfaces/trinidadinternal/validator/DateRestrictionValidator.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 135 - 166 |
Avoid unused method parameters such as 'context'. | 135 - 166 |
org/apache/myfaces/trinidadinternal/validator/DateTimeRangeValidator.java
Violation | Line |
---|---|
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.convert.DateTimeConverter' | 36 |
Avoid unused method parameters such as 'component'. | 131 - 162 |
Avoid unused method parameters such as 'context'. | 131 - 162 |
org/apache/myfaces/trinidadinternal/validator/DoubleRangeValidator.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 96 - 127 |
Avoid unused method parameters such as 'context'. | 96 - 127 |
org/apache/myfaces/trinidadinternal/validator/LengthValidator.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 129 - 163 |
Avoid unused method parameters such as 'context'. | 129 - 163 |
org/apache/myfaces/trinidadinternal/validator/LongRangeValidator.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'component'. | 97 - 128 |
Avoid unused method parameters such as 'context'. | 97 - 128 |
org/apache/myfaces/trinidadinternal/validator/RegExpValidator.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'context'. | 82 - 107 |
org/apache/myfaces/trinidadinternal/webapp/wrappers/BasicHTMLBrowserRequestWrapper.java
Violation | Line |
---|---|
Avoid unused imports such as 'java.util.Iterator' | 25 |
Avoid unused imports such as 'java.util.Set' | 27 |