FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.8
Threshold is Low
Effort is Max
Summary
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 220 | 20 | 0 | 0 |
Files
org.apache.myfaces.tobago.example.addressbook.Address
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.tobago.example.addressbook.Address.pcCopyKeyFieldsFromObjectId(Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Not available | Medium |
| Method org.apache.myfaces.tobago.example.addressbook.Address.pcCopyKeyFieldsFromObjectId(FieldConsumer, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Not available | Medium |
| Private method org.apache.myfaces.tobago.example.addressbook.Address.load() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 125-134 | Low |
| Private method org.apache.myfaces.tobago.example.addressbook.Address.pcGetrevision(Address) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | Not available | Low |
| Private method org.apache.myfaces.tobago.example.addressbook.Address.pcSetrevision(Address, Integer) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | Not available | Low |
| Private method org.apache.myfaces.tobago.example.addressbook.Address.store() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 111-121 | Low |
org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener.contextDestroyed(ServletContextEvent) may fail to close Connection | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 42 | Medium |
org.apache.myfaces.tobago.example.addressbook.Picture
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.tobago.example.addressbook.Picture.pcCopyKeyFieldsFromObjectId(Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Not available | Medium |
| Method org.apache.myfaces.tobago.example.addressbook.Picture.pcCopyKeyFieldsFromObjectId(FieldConsumer, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | Not available | Medium |
| new org.apache.myfaces.tobago.example.addressbook.Picture(String, byte[]) may expose internal representation by storing an externally mutable object into Picture.content | MALICIOUS_CODE | EI_EXPOSE_REP2 | 50 | Medium |
| org.apache.myfaces.tobago.example.addressbook.Picture.pcIsDetached() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | Not available | Medium |
| Private method org.apache.myfaces.tobago.example.addressbook.Picture.pcSetcontent(Picture, byte[]) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | Not available | Low |
| Private method org.apache.myfaces.tobago.example.addressbook.Picture.pcSetcontentType(Picture, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | Not available | Low |
| Private method org.apache.myfaces.tobago.example.addressbook.Picture.pcSetid(Picture, Integer) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | Not available | Low |
| Unwritten field: org.apache.myfaces.tobago.example.addressbook.Picture.pcPCSuperclass | CORRECTNESS | UWF_UNWRITTEN_FIELD | Not available | Medium |
| Unwritten field: org.apache.myfaces.tobago.example.addressbook.Picture.pcInheritedFieldCount | CORRECTNESS | UWF_UNWRITTEN_FIELD | Not available | Low |
org.apache.myfaces.tobago.example.addressbook.web.Countries
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.example.addressbook.web.Countries is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-42 | Low |
org.apache.myfaces.tobago.example.addressbook.web.LoggingController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.tobago.example.addressbook.web.LoggingController.downloadLogFile() may fail to clean up stream or resource of type java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 112 | Medium |
org.apache.myfaces.tobago.example.addressbook.web.LoggingController$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.tobago.example.addressbook.web.LoggingController$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 93-96 | Low |
org.apache.myfaces.tobago.example.addressbook.web.PictureServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.example.addressbook.web.PictureServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34-57 | Low |