PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/application/ApplicationImpl.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'PROJECT_STAGE_PARAM_NAME'. | 148 |
| Avoid empty catch blocks | 792 - 795 |
| Avoid empty catch blocks | 796 - 805 |
| These nested if statements could be combined | 1748 - 1751 |
| These nested if statements could be combined | 2076 - 2079 |
| These nested if statements could be combined | 2225 - 2228 |
| These nested if statements could be combined | 2450 - 2453 |
org/apache/myfaces/application/NavigationHandlerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 179 - 185 |
| Avoid empty catch blocks | 411 - 417 |
| These nested if statements could be combined | 587 - 607 |
| These nested if statements could be combined | 616 - 625 |
| Avoid unused method parameters such as 'facesContext'. | 690 - 746 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 769 |
org/apache/myfaces/application/ResourceHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 524 - 527 |
org/apache/myfaces/application/StateManagerImpl.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'externalContext'. | 227 |
org/apache/myfaces/application/jsp/JspStateManagerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 720 - 727 |
| Avoid empty while statements | 970 |
org/apache/myfaces/application/jsp/JspViewHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'renderKit'. | 457 - 474 |
| Avoid unused method parameters such as 'externalContext'. | 457 - 474 |
org/apache/myfaces/component/visit/PartialVisitContext.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 310 - 312 |
org/apache/myfaces/config/ConfigFilesXmlValidationUtils.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 274 - 277 |
| Avoid empty catch blocks | 283 - 286 |
| Avoid empty catch blocks | 297 - 299 |
| Avoid empty catch blocks | 433 - 436 |
| Avoid empty catch blocks | 441 - 444 |
| Avoid empty catch blocks | 455 - 457 |
org/apache/myfaces/config/DefaultFacesConfigurationMerger.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 124 - 129 |
| These nested if statements could be combined | 183 - 189 |
| These nested if statements could be combined | 352 - 356 |
org/apache/myfaces/config/annotation/AnnotationConfigurator.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'rkFactory'. | 83 |
| These nested if statements could be combined | 390 - 393 |
| These nested if statements could be combined | 420 - 423 |
org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'context'. | 346 - 432 |
| Avoid empty catch blocks | 402 - 405 |
| An empty statement (semicolon) not part of a loop | 418 |
| An empty statement (semicolon) not part of a loop | 422 |
| Avoid empty catch blocks | 538 - 541 |
| An empty statement (semicolon) not part of a loop | 558 |
| An empty statement (semicolon) not part of a loop | 562 |
org/apache/myfaces/config/annotation/DefaultLifecycleProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 205 - 208 |
| Avoid empty catch blocks | 209 - 212 |
org/apache/myfaces/config/annotation/Tomcat7AnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'externalContext'. | 46 - 49 |
| Avoid empty catch blocks | 111 - 114 |
org/apache/myfaces/config/annotation/TomcatAnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 79 - 82 |
org/apache/myfaces/config/annotation/_ClassByteCodeAnnotationFilter.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'minorVersion'. | 102 |
org/apache/myfaces/config/impl/digester/DigesterFacesConfigDispenserImpl.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'faceletCacheFactories'. | 67 |
org/apache/myfaces/config/util/Vertex.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_seen'. | 41 |
org/apache/myfaces/context/FacesContextFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 90 - 94 |
org/apache/myfaces/context/PartialResponseWriterImpl.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'elem'. | 194 |
| Overriding method merely calls super | 351 - 354 |
org/apache/myfaces/context/servlet/ServletExternalContextImplBase.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 108 - 112 |
org/apache/myfaces/el/unified/resolver/CompositeComponentELResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 104 - 114 |
| These nested if statements could be combined | 119 - 123 |
org/apache/myfaces/el/unified/resolver/ManagedBeanResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 191 - 194 |
| These nested if statements could be combined | 211 - 214 |
org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 482 - 485 |
org/apache/myfaces/renderkit/ErrorPageWriter.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 289 - 292 |
| These nested if statements could be combined | 831 - 838 |
| Avoid empty catch blocks | 1003 - 1006 |
| These nested if statements could be combined | 1195 - 1204 |
| Avoid empty catch blocks | 1299 - 1302 |
| Avoid empty catch blocks | 1319 - 1322 |
org/apache/myfaces/renderkit/RenderKitFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 63 - 66 |
org/apache/myfaces/renderkit/ServerSideStateCacheImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 230 - 236 |
| These nested if statements could be combined | 284 - 291 |
| These nested if statements could be combined | 590 - 593 |
| Avoid empty while statements | 597 - 599 |
| Avoid empty while statements | 621 - 623 |
org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 297 - 323 |
org/apache/myfaces/renderkit/html/HtmlCompositeFacetRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 39 |
org/apache/myfaces/renderkit/html/HtmlRenderKitImpl.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'checkNull(Object,String)'. | 335 |
org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 138 - 140 |
org/apache/myfaces/shared_impl/webapp/webxml/FilterMapping.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 41 - 44 |
org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 254 - 256 |
| Avoid empty if statements | 322 - 324 |
| Avoid empty if statements | 358 - 360 |
org/apache/myfaces/spi/impl/DefaultAnnotationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 94 - 97 |
| Avoid empty catch blocks | 98 - 101 |
org/apache/myfaces/spi/impl/DefaultFaceletConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 80 - 83 |
| Avoid empty catch blocks | 84 - 87 |
org/apache/myfaces/spi/impl/DefaultFacesConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 80 - 83 |
| Avoid empty catch blocks | 84 - 87 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationMergerFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 81 - 84 |
| Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 86 - 89 |
| Avoid empty catch blocks | 90 - 93 |
org/apache/myfaces/spi/impl/DefaultServiceProviderFinder.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 141 - 144 |
org/apache/myfaces/spi/impl/DefaultWebConfigProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 84 - 87 |
| Avoid empty catch blocks | 88 - 91 |
org/apache/myfaces/taglib/core/AttributeTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 123 - 133 |
org/apache/myfaces/taglib/core/DelegateValueChangeListener.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 111 - 115 |
| Avoid empty catch blocks | 139 - 143 |
org/apache/myfaces/taglib/core/GenericMinMaxValidatorTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 84 - 87 |
org/apache/myfaces/taglib/core/ValidateRequiredTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 90 - 93 |
org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 50 - 54 |
org/apache/myfaces/util/ContainerUtils.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 58 |
org/apache/myfaces/view/ViewDeclarationLanguageFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 162 - 167 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementHelper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 213 - 220 |
| Avoid empty while statements | 448 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'CHECK_ID_PRODUCTION_MODE_FALSE'. | 159 |
| Avoid unused local variables such as 'viewParameters'. | 230 |
| These nested if statements could be combined | 355 - 374 |
| Avoid unused local variables such as 'externalContext'. | 506 |
| These nested if statements could be combined | 613 - 625 |
| Avoid unused private methods such as 'checkIds(FacesContext,UIComponent,Set)'. | 1034 |
| Avoid unused local variables such as 'children'. | 1037 |
org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as '_publishPreRemoveFromViewEvent(FacesContext,UIComponent)'. | 501 |
| These nested if statements could be combined | 975 - 980 |
| Avoid unused local variables such as 'request'. | 1980 |
org/apache/myfaces/view/facelets/FaceletViewHandler.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'developmentMode'. | 131 |
org/apache/myfaces/view/facelets/compiler/Compiler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 190 - 193 |
org/apache/myfaces/view/facelets/compiler/NamespaceManager.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 95 - 108 |
org/apache/myfaces/view/facelets/compiler/SAXCompiler.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 128 - 131 |
| Overriding method merely calls super | 315 - 318 |
| Overriding method merely calls super | 503 - 506 |
| These nested if statements could be combined | 521 - 527 |
| These nested if statements could be combined | 627 - 633 |
| Unnecessary final modifier in final class | 769 - 795 |
| Unnecessary final modifier in final class | 797 - 823 |
| These nested if statements could be combined | 811 - 814 |
| Unnecessary final modifier in final class | 825 - 839 |
org/apache/myfaces/view/facelets/compiler/TagLibraryConfig.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 323 |
| Unnecessary final modifier in final class | 705 - 731 |
org/apache/myfaces/view/facelets/compiler/TextUnit.java
| Violation | Line |
|---|---|
| Do not use if statements that are always true or always false | 280 |
| Unnecessary final modifier in final class | 368 - 392 |
org/apache/myfaces/view/facelets/compiler/_ComponentUtils.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'separatorChar'. | 239 - 261 |
| Avoid unused private methods such as 'dynamicIdIsEqual(String,String)'. | 263 |
org/apache/myfaces/view/facelets/el/ContextAwareTagMethodExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 123 - 126 |
org/apache/myfaces/view/facelets/el/ContextAwareTagValueExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 118 - 121 |
org/apache/myfaces/view/facelets/el/DefaultVariableMapper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 85 - 93 |
| These nested if statements could be combined | 98 - 106 |
org/apache/myfaces/view/facelets/el/ELText.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 467 - 490 |
| These nested if statements could be combined | 469 - 489 |
org/apache/myfaces/view/facelets/impl/DefaultFacelet.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 207 - 267 |
| Unnecessary final modifier in final class | 269 - 293 |
org/apache/myfaces/view/facelets/tag/MetaRulesetImpl.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 238 - 267 |
org/apache/myfaces/view/facelets/tag/composite/AttributeHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 307 - 390 |
| Avoid empty catch blocks | 333 - 336 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentDefinitionTagHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'ctx'. | 194 - 200 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentResourceTagHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 532 - 559 |
org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 65 - 69 |
| These nested if statements could be combined | 78 - 88 |
| These nested if statements could be combined | 104 - 125 |
org/apache/myfaces/view/facelets/tag/composite/FacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 288 - 324 |
org/apache/myfaces/view/facelets/tag/composite/InsertFacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'parentCompositeComponent'. | 153 |
| Avoid unused method parameters such as 'parent'. | 162 - 185 |
org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 629 - 699 |
| These nested if statements could be combined | 673 - 677 |
| These nested if statements could be combined | 685 - 694 |
| Avoid unused method parameters such as 'ctx'. | 701 - 748 |
| Avoid unused method parameters such as 'facesContext'. | 764 - 802 |
| Avoid unused method parameters such as 'mctx'. | 764 - 802 |
| These nested if statements could be combined | 787 - 797 |
org/apache/myfaces/view/facelets/tag/jsf/core/SelectItemsHandler.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getNoSelectionValue()'. | 53 |
org/apache/myfaces/view/facelets/tag/jstl/core/ChooseHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 107 - 145 |
| These nested if statements could be combined | 159 - 165 |
| These nested if statements could be combined | 179 - 185 |
org/apache/myfaces/view/facelets/tag/jstl/core/ForEachHandler.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 292 - 299 |
| Unnecessary final modifier in final class | 301 - 308 |
| Unnecessary final modifier in final class | 310 - 317 |
| Unnecessary final modifier in final class | 319 - 326 |
| Unnecessary final modifier in final class | 328 - 335 |
| Unnecessary final modifier in final class | 337 - 352 |
| Unnecessary final modifier in final class | 354 - 361 |
| Unnecessary final modifier in final class | 363 - 370 |
| Unnecessary final modifier in final class | 372 - 394 |
org/apache/myfaces/view/facelets/tag/jstl/core/IfHandler.java
| Violation | Line |
|---|---|
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 110 |
org/apache/myfaces/view/facelets/tag/jstl/core/SetHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 140 - 143 |
org/apache/myfaces/view/facelets/tag/jstl/fn/JstlFunction.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 109 - 111 |
org/apache/myfaces/view/facelets/tag/ui/ParamHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 97 - 101 |
org/apache/myfaces/view/facelets/tag/ui/RepeatHandler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 90 - 93 |
org/apache/myfaces/view/facelets/util/Classpath.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 193 - 195 |
| Avoid empty catch blocks | 307 - 310 |
| Avoid empty catch blocks | 330 - 333 |
org/apache/myfaces/view/facelets/util/FastWriter.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 58 - 66 |
org/apache/myfaces/view/facelets/util/ParameterCheck.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 34 |
org/apache/myfaces/view/facelets/util/Path.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 67 |
| Unnecessary final modifier in final class | 69 - 95 |
| Unnecessary final modifier in final class | 97 - 105 |
org/apache/myfaces/view/facelets/util/Resource.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 78 - 81 |
| Avoid empty catch blocks | 107 - 111 |
org/apache/myfaces/webapp/AbstractFacesInitializer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'servletContext'. | 277 - 282 |
| Avoid empty catch blocks | 331 - 334 |
org/apache/myfaces/webapp/Jsp21FacesInitializer.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 88 |