PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/application/ApplicationImpl.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'PROJECT_STAGE_PARAM_NAME'. | 149 |
| Avoid empty catch blocks | 804 - 807 |
| Avoid empty catch blocks | 808 - 817 |
| These nested if statements could be combined | 1799 - 1802 |
| These nested if statements could be combined | 2196 - 2199 |
| These nested if statements could be combined | 2345 - 2348 |
| These nested if statements could be combined | 2575 - 2578 |
org/apache/myfaces/application/NavigationHandlerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 184 - 190 |
| Avoid empty catch blocks | 464 - 470 |
| These nested if statements could be combined | 648 - 668 |
| These nested if statements could be combined | 677 - 686 |
| Avoid unused method parameters such as 'facesContext'. | 770 - 826 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 849 |
org/apache/myfaces/application/ResourceHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 530 - 533 |
org/apache/myfaces/application/StateManagerImpl.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'externalContext'. | 231 |
org/apache/myfaces/application/jsp/JspStateManagerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 720 - 727 |
| Avoid empty while statements | 970 |
org/apache/myfaces/application/jsp/JspViewHandlerImpl.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'renderKit'. | 471 - 488 |
| Avoid unused method parameters such as 'externalContext'. | 471 - 488 |
org/apache/myfaces/application/viewstate/RandomKeyFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 101 - 107 |
org/apache/myfaces/application/viewstate/SecureRandomKeyFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 123 - 129 |
org/apache/myfaces/application/viewstate/SerializedViewCollection.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 76 - 91 |
| Avoid empty while statements | 96 - 98 |
| Avoid empty while statements | 121 - 123 |
org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 288 - 294 |
| These nested if statements could be combined | 321 - 330 |
org/apache/myfaces/application/viewstate/SessionIdGenerator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 280 - 284 |
org/apache/myfaces/component/visit/PartialVisitContext.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 310 - 312 |
org/apache/myfaces/config/ConfigFilesXmlValidationUtils.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 164 - 167 |
| Avoid empty catch blocks | 270 - 273 |
| Avoid empty catch blocks | 279 - 282 |
| Avoid empty catch blocks | 293 - 295 |
| Avoid empty catch blocks | 429 - 432 |
| Avoid empty catch blocks | 437 - 440 |
| Avoid empty catch blocks | 451 - 453 |
org/apache/myfaces/config/DefaultFacesConfigurationMerger.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 124 - 129 |
| These nested if statements could be combined | 183 - 189 |
| These nested if statements could be combined | 352 - 356 |
org/apache/myfaces/config/annotation/AnnotationConfigurator.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'rkFactory'. | 83 |
| These nested if statements could be combined | 391 - 394 |
| These nested if statements could be combined | 421 - 424 |
org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'STANDARD_FACES_CONFIG_RESOURCE'. | 95 |
| Avoid unused method parameters such as 'context'. | 440 - 528 |
| Avoid empty catch blocks | 497 - 500 |
| Avoid empty catch blocks | 512 - 515 |
| Avoid empty catch blocks | 516 - 519 |
| Avoid empty catch blocks | 635 - 638 |
| Avoid empty catch blocks | 654 - 657 |
| Avoid empty catch blocks | 658 - 661 |
org/apache/myfaces/config/annotation/DefaultLifecycleProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 205 - 208 |
| Avoid empty catch blocks | 209 - 212 |
org/apache/myfaces/config/annotation/Tomcat7AnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'externalContext'. | 46 - 49 |
| Avoid empty catch blocks | 111 - 114 |
org/apache/myfaces/config/annotation/TomcatAnnotationLifecycleProvider.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 79 - 82 |
org/apache/myfaces/config/annotation/_ClassByteCodeAnnotationFilter.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'minorVersion'. | 107 |
org/apache/myfaces/config/impl/digester/DigesterFacesConfigDispenserImpl.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'faceletCacheFactories'. | 67 |
org/apache/myfaces/config/util/Vertex.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_seen'. | 41 |
org/apache/myfaces/context/FacesContextFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 90 - 94 |
org/apache/myfaces/context/PartialResponseWriterImpl.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'elem'. | 194 |
| Overriding method merely calls super | 351 - 354 |
org/apache/myfaces/context/servlet/ServletExternalContextImplBase.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 108 - 112 |
org/apache/myfaces/el/unified/resolver/CompositeComponentELResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 105 - 115 |
| These nested if statements could be combined | 120 - 124 |
org/apache/myfaces/el/unified/resolver/ManagedBeanResolver.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 191 - 194 |
| These nested if statements could be combined | 211 - 214 |
org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 514 - 517 |
org/apache/myfaces/renderkit/ErrorPageWriter.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 289 - 292 |
| These nested if statements could be combined | 831 - 838 |
| Avoid empty catch blocks | 1005 - 1008 |
| These nested if statements could be combined | 1198 - 1207 |
| Avoid empty catch blocks | 1332 - 1335 |
| Avoid empty catch blocks | 1352 - 1355 |
org/apache/myfaces/renderkit/RenderKitFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 63 - 66 |
org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 297 - 323 |
org/apache/myfaces/renderkit/html/HtmlCompositeFacetRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 39 |
org/apache/myfaces/renderkit/html/HtmlRenderKitImpl.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'checkNull(Object,String)'. | 359 |
org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 163 - 165 |
org/apache/myfaces/shared_impl/webapp/webxml/FilterMapping.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 41 - 44 |
org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 254 - 256 |
| Avoid empty if statements | 322 - 324 |
| Avoid empty if statements | 358 - 360 |
org/apache/myfaces/spi/impl/DefaultAnnotationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 94 - 97 |
| Avoid empty catch blocks | 98 - 101 |
org/apache/myfaces/spi/impl/DefaultFaceletConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 80 - 83 |
| Avoid empty catch blocks | 84 - 87 |
org/apache/myfaces/spi/impl/DefaultFacesConfigResourceProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 80 - 83 |
| Avoid empty catch blocks | 84 - 87 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationMergerFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 81 - 84 |
| Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 86 - 89 |
| Avoid empty catch blocks | 90 - 93 |
org/apache/myfaces/spi/impl/DefaultServiceProviderFinder.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 141 - 144 |
org/apache/myfaces/spi/impl/DefaultWebConfigProviderFactory.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 84 - 87 |
| Avoid empty catch blocks | 88 - 91 |
org/apache/myfaces/taglib/core/AttributeTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 123 - 133 |
org/apache/myfaces/taglib/core/DelegateValueChangeListener.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 111 - 115 |
| Avoid empty catch blocks | 139 - 143 |
org/apache/myfaces/taglib/core/GenericMinMaxValidatorTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 84 - 87 |
org/apache/myfaces/taglib/core/ValidateRequiredTag.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 90 - 93 |
org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 50 - 54 |
org/apache/myfaces/util/ContainerUtils.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 58 |
org/apache/myfaces/view/ViewDeclarationLanguageFactoryImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 167 - 172 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementHelper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 213 - 220 |
| Avoid empty while statements | 448 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'CHECK_ID_PRODUCTION_MODE_FALSE'. | 160 |
| Avoid unused local variables such as 'viewParameters'. | 240 |
| Avoid unused local variables such as 'externalContext'. | 624 |
| These nested if statements could be combined | 735 - 747 |
| Avoid unused private methods such as 'checkIds(FacesContext,UIComponent,Set)'. | 1172 |
| Avoid unused local variables such as 'children'. | 1175 |
org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as '_publishPreRemoveFromViewEvent(FacesContext,UIComponent)'. | 512 |
| These nested if statements could be combined | 995 - 1000 |
| Avoid unused local variables such as 'request'. | 2049 |
org/apache/myfaces/view/facelets/FaceletViewHandler.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'developmentMode'. | 131 |
org/apache/myfaces/view/facelets/compiler/Compiler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 190 - 193 |
org/apache/myfaces/view/facelets/compiler/NamespaceManager.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 95 - 108 |
org/apache/myfaces/view/facelets/compiler/SAXCompiler.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 131 - 134 |
| Overriding method merely calls super | 318 - 321 |
| Overriding method merely calls super | 520 - 523 |
| These nested if statements could be combined | 538 - 544 |
| These nested if statements could be combined | 644 - 650 |
| Unnecessary final modifier in final class | 817 - 843 |
| Unnecessary final modifier in final class | 845 - 871 |
| These nested if statements could be combined | 859 - 862 |
| Unnecessary final modifier in final class | 873 - 887 |
org/apache/myfaces/view/facelets/compiler/TagLibraryConfig.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 321 - 323 |
| Avoid empty if statements | 366 - 368 |
| Avoid empty if statements | 370 - 372 |
| Avoid empty if statements | 374 - 376 |
| Unnecessary final modifier in final class | 724 - 750 |
org/apache/myfaces/view/facelets/compiler/TextUnit.java
| Violation | Line |
|---|---|
| Do not use if statements that are always true or always false | 280 |
| Unnecessary final modifier in final class | 368 - 392 |
org/apache/myfaces/view/facelets/compiler/_ComponentUtils.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'separatorChar'. | 239 - 261 |
| Avoid unused private methods such as 'dynamicIdIsEqual(String,String)'. | 263 |
org/apache/myfaces/view/facelets/el/ContextAwareTagMethodExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 123 - 126 |
org/apache/myfaces/view/facelets/el/ContextAwareTagValueExpression.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 118 - 121 |
org/apache/myfaces/view/facelets/el/DefaultVariableMapper.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 85 - 93 |
| These nested if statements could be combined | 98 - 106 |
org/apache/myfaces/view/facelets/el/ELText.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 482 - 505 |
| These nested if statements could be combined | 484 - 504 |
org/apache/myfaces/view/facelets/impl/DefaultFacelet.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 231 - 291 |
| Unnecessary final modifier in final class | 293 - 317 |
org/apache/myfaces/view/facelets/impl/FaceletCompositionContextImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 841 - 852 |
org/apache/myfaces/view/facelets/tag/MetaRulesetImpl.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 238 - 267 |
org/apache/myfaces/view/facelets/tag/composite/AttributeHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 307 - 390 |
| Avoid empty catch blocks | 333 - 336 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentDefinitionTagHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 121 - 125 |
| Avoid unused method parameters such as 'ctx'. | 223 - 229 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentResourceTagHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 535 - 562 |
org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 65 - 69 |
| These nested if statements could be combined | 78 - 88 |
| These nested if statements could be combined | 104 - 125 |
org/apache/myfaces/view/facelets/tag/composite/FacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'parent'. | 288 - 324 |
org/apache/myfaces/view/facelets/tag/composite/InsertFacetHandler.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'parentCompositeComponent'. | 153 |
| Avoid unused method parameters such as 'parent'. | 162 - 185 |
org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 678 - 748 |
| These nested if statements could be combined | 722 - 726 |
| These nested if statements could be combined | 734 - 743 |
| Avoid unused method parameters such as 'ctx'. | 750 - 797 |
| Avoid unused method parameters such as 'facesContext'. | 813 - 851 |
| Avoid unused method parameters such as 'mctx'. | 813 - 851 |
| These nested if statements could be combined | 836 - 846 |
org/apache/myfaces/view/facelets/tag/jsf/core/SelectItemsHandler.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getNoSelectionValue()'. | 53 |
org/apache/myfaces/view/facelets/tag/jstl/core/ChooseHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 107 - 145 |
| These nested if statements could be combined | 159 - 165 |
| These nested if statements could be combined | 179 - 185 |
org/apache/myfaces/view/facelets/tag/jstl/core/ForEachHandler.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 321 - 328 |
| Unnecessary final modifier in final class | 330 - 337 |
| Unnecessary final modifier in final class | 339 - 346 |
| Unnecessary final modifier in final class | 348 - 355 |
| Unnecessary final modifier in final class | 357 - 364 |
| Unnecessary final modifier in final class | 366 - 381 |
| Unnecessary final modifier in final class | 383 - 390 |
| Unnecessary final modifier in final class | 392 - 399 |
| Unnecessary final modifier in final class | 401 - 423 |
org/apache/myfaces/view/facelets/tag/jstl/core/IfHandler.java
| Violation | Line |
|---|---|
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 110 |
org/apache/myfaces/view/facelets/tag/jstl/core/SetHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 140 - 143 |
org/apache/myfaces/view/facelets/tag/jstl/fn/JstlFunction.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 109 - 111 |
org/apache/myfaces/view/facelets/tag/ui/ParamHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 97 - 101 |
org/apache/myfaces/view/facelets/tag/ui/RepeatHandler.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 90 - 93 |
org/apache/myfaces/view/facelets/util/Classpath.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 218 - 220 |
| Avoid empty catch blocks | 351 - 354 |
| Avoid empty catch blocks | 381 - 385 |
org/apache/myfaces/view/facelets/util/FastWriter.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 58 - 66 |
org/apache/myfaces/view/facelets/util/ParameterCheck.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 34 |
org/apache/myfaces/view/facelets/util/Path.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 28 - 67 |
| Unnecessary final modifier in final class | 69 - 95 |
| Unnecessary final modifier in final class | 97 - 105 |
org/apache/myfaces/view/facelets/util/Resource.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 78 - 81 |
| Avoid empty catch blocks | 107 - 111 |
org/apache/myfaces/webapp/AbstractFacesInitializer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'servletContext'. | 282 - 287 |
org/apache/myfaces/webapp/Jsp21FacesInitializer.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 88 |