FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
javax.faces.FactoryFinder
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in javax.faces.FactoryFinder.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | 125 | Low |
Exception is caught when Exception is not thrown in javax.faces.FactoryFinder.getClassLoader() | STYLE | REC_CATCH_EXCEPTION | 544 | Low |
javax.faces._FactoryFinderProviderFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in javax.faces._FactoryFinderProviderFactory.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | 72 | Medium |
javax.faces.application.FacesMessage$Severity
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.application.FacesMessage$Severity defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 281 | Medium |
javax.faces.application.NavigationCase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.application.NavigationCase.getCondition(FacesContext) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 112 | Medium |
javax.faces.application.StateManager$SerializedView
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.application.StateManager$SerializedView be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 301-319 | Medium |
javax.faces.component.UICommand
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method call in javax.faces.component.UICommand.queueEvent(FacesEvent) passes null for nonnull parameter of UIComponentBase.queueEvent(FacesEvent) | CORRECTNESS | NP_NULL_PARAM_DEREF | 143 | Medium |
javax.faces.component.UIComponent$BundleMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of java.util.ResourceBundle.getObject(String), which is known to be non-null in javax.faces.component.UIComponent$BundleMap.containsKey(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1160 | Low |
javax.faces.component.UIComponentBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Questionable cast from java.util.Collection to java.util.ArrayList in javax.faces.component.UIComponentBase.saveAttachedState(FacesContext, Object) | STYLE | BC_BAD_CAST_TO_CONCRETE_COLLECTION | 1777 | High |
Load of known null value in javax.faces.component.UIComponentBase.setParent(UIComponent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 200 | Medium |
Method call in javax.faces.component.UIComponentBase.encodeEnd(FacesContext) passes null for nonnull parameter of UIComponent.popComponentFromEL(FacesContext) | CORRECTNESS | NP_NULL_PARAM_DEREF | 673 | Medium |
javax.faces.component.UIData
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in javax.faces.component.UIData.process(FacesContext, UIComponent, int) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1369-1372 | Low |
javax.faces.component.UIData$EditableValueHolderState
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.component.UIData$EditableValueHolderState be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 280-293 | Medium |
javax.faces.component.UIInput
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 524 | Low |
javax.faces.component.UIViewParameter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method javax.faces.component.UIViewParameter.releaseRenderer() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 275-297 | Low |
javax.faces.component.UIViewRoot
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in javax.faces.component.UIViewRoot.getLocale(), since all java.util.Locale are instances of java.util.Locale | STYLE | BC_VACUOUS_INSTANCEOF | 665 | Medium |
Exception is caught when Exception is not thrown in javax.faces.component.UIViewRoot._broadcastAll(FacesContext, List, Collection) | STYLE | REC_CATCH_EXCEPTION | 1053 | Low |
javax.faces.component.UIViewRoot$Events
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.component.UIViewRoot$Events be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1655-1673 | Medium |
javax.faces.component._AttachedCollectionStateWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._AttachedCollectionStateWrapper defines non-transient non-serializable instance field _wrappedStateList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._AttachedListStateWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._AttachedListStateWrapper defines non-transient non-serializable instance field _wrappedStateList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ComponentAttributesMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentAttributesMap defines non-transient non-serializable instance field _ccBeanInfo | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentAttributesMap defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.component._ComponentChildrenList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentChildrenList defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentChildrenList defines non-transient non-serializable instance field _list | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ComponentFacetMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _entrySet | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _keySet | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _map | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _valueCollection | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ArrayMap stored into non-transient field _ComponentFacetMap._map | BAD_PRACTICE | SE_BAD_FIELD_STORE | 37 | High |
javax.faces.component._ComponentFacetMap$ComponentFacetEntrySet stored into non-transient field _ComponentFacetMap._entrySet | BAD_PRACTICE | SE_BAD_FIELD_STORE | 102 | Medium |
javax.faces.component._ComponentFacetMap$ComponentFacetKeySet stored into non-transient field _ComponentFacetMap._keySet | BAD_PRACTICE | SE_BAD_FIELD_STORE | 111 | Medium |
javax.faces.component._ComponentFacetMap$ComponentFacetValueCollection stored into non-transient field _ComponentFacetMap._valueCollection | BAD_PRACTICE | SE_BAD_FIELD_STORE | 85 | Medium |
javax.faces.component._ComponentUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method javax.faces.component._ComponentUtils.dynamicIdIsEqual(String, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 252 | Low |
javax.faces.component._DeltaStateHelper$InternalDeltaListMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._DeltaStateHelper$InternalDeltaListMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 791-807 | Low |
javax.faces.component._DeltaStateHelper$InternalList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._DeltaStateHelper$InternalList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 814-865 | Low |
javax.faces.component._DeltaStateHelper$InternalMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._DeltaStateHelper$InternalMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 720-779 | Low |
javax.faces.component._ExternalSpecifications
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Incorrect lazy initialization and update of static field javax.faces.component._ExternalSpecifications.beanValidationAvailable in javax.faces.component._ExternalSpecifications.isBeanValidationAvailable() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 51-57 | Medium |
javax.faces.component._LabeledFacesMessage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._LabeledFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 37-76 | Low |
javax.faces.component._MethodBindingToMethodExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._MethodBindingToMethodExpression defines non-transient non-serializable instance field methodBinding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._MethodBindingToMethodExpression is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40-240 | Medium |
javax.faces.component._PrimitiveArrayIterator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._PrimitiveArrayIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 48 | Medium |
javax.faces.component._SharedRendererUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in javax.faces.component._SharedRendererUtils.getConvertedUISelectManyValue(FacesContext, UISelectMany, String[], boolean) | STYLE | REC_CATCH_EXCEPTION | 249 | Low |
javax.faces.component._ValueBindingToValueExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ValueBindingToValueExpression defines non-transient non-serializable instance field _valueBinding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.component._ViewAttributeMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ViewAttributeMap defines non-transient non-serializable instance field _root | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class javax.faces.component._ViewAttributeMap defines non-transient non-serializable instance field _delegate | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalDeltaListMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalDeltaListMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 528-541 | Low |
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 546-586 | Low |
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._AjaxBehaviorDeltaStateHelper$InternalMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 471-518 | Low |
javax.faces.component.behavior._AttachedListStateWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component.behavior._AttachedListStateWrapper defines non-transient non-serializable instance field _wrappedStateList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component.behavior._DeltaStateHelper$InternalDeltaListMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._DeltaStateHelper$InternalDeltaListMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 749-765 | Low |
javax.faces.component.behavior._DeltaStateHelper$InternalList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._DeltaStateHelper$InternalList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 772-823 | Low |
javax.faces.component.behavior._DeltaStateHelper$InternalMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.behavior._DeltaStateHelper$InternalMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 678-737 | Low |
javax.faces.component.visit.VisitContext$AllIdsCollection
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component.visit.VisitContext$AllIdsCollection is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 62-126 | Low |
javax.faces.context.PartialResponseWriter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method javax.faces.context.PartialResponseWriter.startExtension(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 211 | Medium |
Method javax.faces.context.PartialResponseWriter.updateAttributes(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 255 | Medium |
javax.faces.convert.NumberConverter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in javax.faces.convert.NumberConverter.checkJavaVersion14() where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 565-568 | Medium |
Switch statement found in javax.faces.convert.NumberConverter.checkJavaVersion14() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 570-574 | Low |
javax.faces.convert._LabeledFacesMessage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.convert._LabeledFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 37-77 | Low |
javax.faces.event.ActionEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.ActionListener in javax.faces.event.ActionEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 51 | Low |
javax.faces.event.AjaxBehaviorEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.AjaxBehaviorListener in javax.faces.event.AjaxBehaviorEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 57 | Low |
javax.faces.event.AjaxBehaviorEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 39-58 | Low |
javax.faces.event.ExceptionQueuedEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.ExceptionQueuedEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 34-39 | Low |
javax.faces.event.MethodExpressionActionListener
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of cause, which is known to be non-null in javax.faces.event.MethodExpressionActionListener.processAction(ActionEvent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 102 | Low |
javax.faces.event.MethodExpressionValueChangeListener
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of cause, which is known to be non-null in javax.faces.event.MethodExpressionValueChangeListener.processValueChange(ValueChangeEvent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 102 | Low |
javax.faces.event.PhaseEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.event.PhaseEvent defines non-transient non-serializable instance field _facesContext | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.event.PhaseEvent defines non-transient non-serializable instance field _phaseId | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.event.PhaseId
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PhaseId defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 78 | Medium |
javax.faces.event.PostAddToViewEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostAddToViewEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-45 | Low |
javax.faces.event.PostAddToViewNonPDLEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostAddToViewNonPDLEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-37 | Low |
javax.faces.event.PostConstructApplicationEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostConstructApplicationEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-44 | Low |
javax.faces.event.PostConstructCustomScopeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostConstructCustomScopeEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-40 | Low |
javax.faces.event.PostConstructViewMapEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostConstructViewMapEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-37 | Low |
javax.faces.event.PostRestoreStateEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostRestoreStateEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-42 | Low |
javax.faces.event.PostValidateEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PostValidateEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-37 | Low |
javax.faces.event.PreDestroyApplicationEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreDestroyApplicationEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-44 | Low |
javax.faces.event.PreDestroyCustomScopeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreDestroyCustomScopeEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31-38 | Low |
javax.faces.event.PreDestroyViewMapEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreDestroyViewMapEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-37 | Low |
javax.faces.event.PreRemoveFromViewEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreRemoveFromViewEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-45 | Low |
javax.faces.event.PreRenderComponentEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreRenderComponentEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-37 | Low |
javax.faces.event.PreRenderViewEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreRenderViewEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-37 | Low |
javax.faces.event.PreValidateEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PreValidateEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-37 | Low |
javax.faces.event.SystemEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.SystemEventListener in javax.faces.event.SystemEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 43 | Low |
javax.faces.event.ValueChangeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.FacesListener to javax.faces.event.ValueChangeListener in javax.faces.event.ValueChangeEvent.processListener(FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 66 | Low |
javax.faces.model.ArrayDataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.ArrayDataModel.getWrappedData() may expose internal representation by returning ArrayDataModel._data | MALICIOUS_CODE | EI_EXPOSE_REP | 80 | Medium |
javax.faces.model.ArrayDataModel.setWrappedData(Object) may expose internal representation by storing an externally mutable object into ArrayDataModel._data | MALICIOUS_CODE | EI_EXPOSE_REP2 | 120 | Medium |
javax.faces.model.DataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.DataModel.getDataModelListeners() may expose internal representation by returning DataModel._cachedListenersArray | MALICIOUS_CODE | EI_EXPOSE_REP | 82 | Medium |
javax.faces.model.ResultDataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.model.ResultDataModel.getRows() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 118 | Low |
javax.faces.model.ResultSetDataModel$WrapResultSetMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.ResultSetDataModel$WrapResultSetMap is serializable but also an inner class of a non-serializable class | BAD_PRACTICE | SE_BAD_FIELD_INNER_CLASS | 242-384 | Low |
javax.faces.model.SelectItemGroup
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.SelectItemGroup.getSelectItems() may expose internal representation by returning SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP | 59 | Medium |
new javax.faces.model.SelectItemGroup(String, String, boolean, SelectItem[]) may expose internal representation by storing an externally mutable object into SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP2 | 53 | Medium |
javax.faces.model.SelectItemGroup.setSelectItems(SelectItem[]) may expose internal representation by storing an externally mutable object into SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP2 | 65 | Medium |
javax.faces.validator.BeanValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.BeanValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 447 | Medium |
Redundant nullcheck of reference, which is known to be non-null in javax.faces.validator.BeanValidator.validate(FacesContext, UIComponent, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 157 | Low |
Redundant nullcheck of valueBaseClass, which is known to be non-null in javax.faces.validator.BeanValidator.validate(FacesContext, UIComponent, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 168 | Low |
Private method javax.faces.validator.BeanValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 453 | Low |
Private method javax.faces.validator.BeanValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 447 | Low |
javax.faces.validator.BeanValidator$1
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class javax.faces.validator.BeanValidator$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 340-343 | Low |
javax.faces.validator.DoubleRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new javax.faces.validator.DoubleRangeValidator(double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 74] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 74 | Low |
Method new javax.faces.validator.DoubleRangeValidator(double, double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 80] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 80 | Low |
Method javax.faces.validator.DoubleRangeValidator.setMaximum(double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 160] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 160 | Low |
Method javax.faces.validator.DoubleRangeValidator.setMinimum(double) invokes inefficient Double.valueOf(double) constructor; use DoubleRangeValidator.java:[line 176] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 176 | Low |
javax.faces.validator.DoubleRangeValidator defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 219-227 | High |
javax.faces.validator.DoubleRangeValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 250 | Medium |
Private method javax.faces.validator.DoubleRangeValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 256 | Low |
Private method javax.faces.validator.DoubleRangeValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 250 | Low |
javax.faces.validator.LengthValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.LengthValidator defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 191-199 | High |
javax.faces.validator.LengthValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 222 | Medium |
Private method javax.faces.validator.LengthValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 228 | Low |
Private method javax.faces.validator.LengthValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 222 | Low |
javax.faces.validator.LongRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method javax.faces.validator.LongRangeValidator.setMinimum(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 176 | Medium |
javax.faces.validator.LongRangeValidator defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 218-226 | High |
javax.faces.validator.LongRangeValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 249 | Medium |
Private method javax.faces.validator.LongRangeValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 255 | Low |
Private method javax.faces.validator.LongRangeValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 249 | Low |
javax.faces.validator.MethodExpressionValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of cause, which is known to be non-null in javax.faces.validator.MethodExpressionValidator.validate(FacesContext, UIComponent, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 72 | Low |
javax.faces.validator.RegexValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.RegexValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 238 | Medium |
Private method javax.faces.validator.RegexValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 244 | Low |
Private method javax.faces.validator.RegexValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 238 | Low |
javax.faces.validator.RequiredValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.RequiredValidator.isDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 91 | Medium |
Private method javax.faces.validator.RequiredValidator.getFor() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 97 | Low |
Private method javax.faces.validator.RequiredValidator.isDisabled() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 91 | Low |
javax.faces.validator._ExternalSpecifications
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Incorrect lazy initialization and update of static field javax.faces.validator._ExternalSpecifications.beanValidationAvailable in javax.faces.validator._ExternalSpecifications.isBeanValidationAvailable() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 55-61 | Medium |
javax.faces.validator._LabeledFacesMessage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator._LabeledFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 37-78 | Low |
javax.faces.validator._ValueReferenceResolver
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
_ValueReferenceResolver.lastObject not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
javax.faces.view.facelets.CompositeFaceletHandler
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.view.facelets.CompositeFaceletHandler.getHandlers() may expose internal representation by returning CompositeFaceletHandler.children | MALICIOUS_CODE | EI_EXPOSE_REP | 57 | Medium |
new javax.faces.view.facelets.CompositeFaceletHandler(FaceletHandler[]) may expose internal representation by storing an externally mutable object into CompositeFaceletHandler.children | MALICIOUS_CODE | EI_EXPOSE_REP2 | 40 | Medium |
javax.faces.webapp.FacesServlet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.webapp.FacesServlet._facesContextFactory is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 235 | Low |
javax.faces.webapp.FacesServlet._lifecycle is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 189 | Low |
javax.faces.webapp.FacesServlet._servletConfig is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 101 | Low |
javax.faces.webapp.PreJsf2ExceptionHandlerFactory$PreJsf2ExceptionHandlerImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.event.SystemEvent to javax.faces.event.ExceptionQueuedEvent in javax.faces.webapp.PreJsf2ExceptionHandlerFactory$PreJsf2ExceptionHandlerImpl.processEvent(SystemEvent) | STYLE | BC_UNCONFIRMED_CAST | 337 | Low |
javax.faces.webapp.UIComponentTagBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.webapp.UIComponentTagBase.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 37 | High |