View Javadoc
1   /*
2    * Licensed to the Apache Software Foundation (ASF) under one
3    * or more contributor license agreements.  See the NOTICE file
4    * distributed with this work for additional information
5    * regarding copyright ownership.  The ASF licenses this file
6    * to you under the Apache License, Version 2.0 (the
7    * "License"); you may not use this file except in compliance
8    * with the License.  You may obtain a copy of the License at
9    *
10   *   http://www.apache.org/licenses/LICENSE-2.0
11   *
12   * Unless required by applicable law or agreed to in writing,
13   * software distributed under the License is distributed on an
14   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15   * KIND, either express or implied.  See the License for the
16   * specific language governing permissions and limitations
17   * under the License.
18   */
19  package org.apache.maven.project;
20  
21  import java.io.File;
22  import java.nio.charset.StandardCharsets;
23  import java.nio.file.Files;
24  import java.nio.file.Path;
25  import java.util.ArrayList;
26  import java.util.Collections;
27  import java.util.List;
28  import java.util.Properties;
29  import java.util.concurrent.atomic.AtomicInteger;
30  
31  import org.apache.commons.io.FileUtils;
32  import org.apache.maven.AbstractCoreMavenComponentTestCase;
33  import org.apache.maven.execution.MavenSession;
34  import org.apache.maven.model.Dependency;
35  import org.apache.maven.model.InputLocation;
36  import org.apache.maven.model.Plugin;
37  import org.apache.maven.model.building.FileModelSource;
38  import org.apache.maven.model.building.ModelBuildingRequest;
39  import org.apache.maven.model.building.ModelProblem;
40  import org.apache.maven.model.building.ModelSource;
41  import org.junit.jupiter.api.Test;
42  import org.junit.jupiter.api.io.TempDir;
43  
44  import static org.apache.maven.project.ProjectBuildingResultWithLocationMatcher.projectBuildingResultWithLocation;
45  import static org.apache.maven.project.ProjectBuildingResultWithProblemMessageMatcher.projectBuildingResultWithProblemMessage;
46  import static org.hamcrest.MatcherAssert.assertThat;
47  import static org.hamcrest.Matchers.contains;
48  import static org.hamcrest.Matchers.containsString;
49  import static org.hamcrest.Matchers.empty;
50  import static org.hamcrest.Matchers.greaterThan;
51  import static org.hamcrest.Matchers.hasKey;
52  import static org.hamcrest.Matchers.is;
53  import static org.junit.jupiter.api.Assertions.assertEquals;
54  import static org.junit.jupiter.api.Assertions.assertNotNull;
55  import static org.junit.jupiter.api.Assertions.assertThrows;
56  import static org.junit.jupiter.api.Assertions.assertTrue;
57  
58  class ProjectBuilderTest extends AbstractCoreMavenComponentTestCase {
59      @Override
60      protected String getProjectsDirectory() {
61          return "src/test/projects/project-builder";
62      }
63  
64      @Test
65      void testSystemScopeDependencyIsPresentInTheCompileClasspathElements() throws Exception {
66          File pom = getProject("it0063");
67  
68          Properties eps = new Properties();
69          eps.setProperty("jre.home", new File(pom.getParentFile(), "jdk/jre").getPath());
70  
71          MavenSession session = createMavenSession(pom, eps);
72          MavenProject project = session.getCurrentProject();
73  
74          // Here we will actually not have any artifacts because the ProjectDependenciesResolver is not involved here. So
75          // right now it's not valid to ask for artifacts unless plugins require the artifacts.
76  
77          project.getCompileClasspathElements();
78      }
79  
80      @Test
81      void testBuildFromModelSource() throws Exception {
82          File pomFile = new File("src/test/resources/projects/modelsource/module01/pom.xml");
83          MavenSession mavenSession = createMavenSession(pomFile);
84          ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
85          configuration.setRepositorySession(mavenSession.getRepositorySession());
86          ModelSource modelSource = new FileModelSource(pomFile);
87          ProjectBuildingResult result = getContainer()
88                  .lookup(org.apache.maven.project.ProjectBuilder.class)
89                  .build(modelSource, configuration);
90  
91          assertNotNull(result.getProject().getParentFile());
92      }
93  
94      @Test
95      void testVersionlessManagedDependency() throws Exception {
96          File pomFile = new File("src/test/resources/projects/versionless-managed-dependency.xml");
97          MavenSession mavenSession = createMavenSession(null);
98          ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
99          configuration.setRepositorySession(mavenSession.getRepositorySession());
100 
101         ProjectBuildingException e = assertThrows(ProjectBuildingException.class, () -> getContainer()
102                 .lookup(org.apache.maven.project.ProjectBuilder.class)
103                 .build(pomFile, configuration));
104         assertThat(
105                 e.getResults(),
106                 contains(projectBuildingResultWithProblemMessage(
107                         "'dependencies.dependency.version' for org.apache.maven.its:a:jar is missing")));
108         assertThat(e.getResults(), contains(projectBuildingResultWithLocation(5, 9)));
109     }
110 
111     @Test
112     void testResolveDependencies() throws Exception {
113         File pomFile = new File("src/test/resources/projects/basic-resolveDependencies.xml");
114         MavenSession mavenSession = createMavenSession(null);
115         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
116         configuration.setRepositorySession(mavenSession.getRepositorySession());
117         configuration.setResolveDependencies(true);
118 
119         // single project build entry point
120         ProjectBuildingResult result = getContainer()
121                 .lookup(org.apache.maven.project.ProjectBuilder.class)
122                 .build(pomFile, configuration);
123         assertEquals(1, result.getProject().getArtifacts().size());
124         // multi projects build entry point
125         List<ProjectBuildingResult> results = getContainer()
126                 .lookup(org.apache.maven.project.ProjectBuilder.class)
127                 .build(Collections.singletonList(pomFile), false, configuration);
128         assertEquals(1, results.size());
129         MavenProject mavenProject = results.get(0).getProject();
130         assertEquals(1, mavenProject.getArtifacts().size());
131 
132         final MavenProject project = mavenProject;
133         final AtomicInteger artifactsResultInAnotherThread = new AtomicInteger();
134         Thread t = new Thread(new Runnable() {
135             @Override
136             public void run() {
137                 artifactsResultInAnotherThread.set(project.getArtifacts().size());
138             }
139         });
140         t.start();
141         t.join();
142         assertEquals(project.getArtifacts().size(), artifactsResultInAnotherThread.get());
143     }
144 
145     @Test
146     void testDontResolveDependencies() throws Exception {
147         File pomFile = new File("src/test/resources/projects/basic-resolveDependencies.xml");
148         MavenSession mavenSession = createMavenSession(null);
149         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
150         configuration.setRepositorySession(mavenSession.getRepositorySession());
151         configuration.setResolveDependencies(false);
152 
153         // single project build entry point
154         ProjectBuildingResult result = getContainer()
155                 .lookup(org.apache.maven.project.ProjectBuilder.class)
156                 .build(pomFile, configuration);
157         assertEquals(0, result.getProject().getArtifacts().size());
158         // multi projects build entry point
159         List<ProjectBuildingResult> results = getContainer()
160                 .lookup(org.apache.maven.project.ProjectBuilder.class)
161                 .build(Collections.singletonList(pomFile), false, configuration);
162         assertEquals(1, results.size());
163         MavenProject mavenProject = results.get(0).getProject();
164         assertEquals(0, mavenProject.getArtifacts().size());
165     }
166 
167     @Test
168     void testReadModifiedPoms(@TempDir Path tempDir) throws Exception {
169         // TODO a similar test should be created to test the dependency management (basically all usages
170         // of DefaultModelBuilder.getCache() are affected by MNG-6530
171 
172         FileUtils.copyDirectory(new File("src/test/resources/projects/grandchild-check"), tempDir.toFile());
173         MavenSession mavenSession = createMavenSession(null);
174         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
175         configuration.setRepositorySession(mavenSession.getRepositorySession());
176         org.apache.maven.project.ProjectBuilder projectBuilder =
177                 getContainer().lookup(org.apache.maven.project.ProjectBuilder.class);
178         File child = new File(tempDir.toFile(), "child/pom.xml");
179         // build project once
180         projectBuilder.build(child, configuration);
181         // modify parent
182         File parent = new File(tempDir.toFile(), "pom.xml");
183         String parentContent = new String(Files.readAllBytes(parent.toPath()), StandardCharsets.UTF_8);
184         parentContent = parentContent.replace(
185                 "<packaging>pom</packaging>",
186                 "<packaging>pom</packaging><properties><addedProperty>addedValue</addedProperty></properties>");
187         Files.write(parent.toPath(), parentContent.getBytes(StandardCharsets.UTF_8));
188         // re-build pom with modified parent
189         ProjectBuildingResult result = projectBuilder.build(child, configuration);
190         assertThat(result.getProject().getProperties(), hasKey((Object) "addedProperty"));
191     }
192 
193     @Test
194     void testReadErroneousMavenProjectContainsReference() throws Exception {
195         File pomFile = new File("src/test/resources/projects/artifactMissingVersion/pom.xml").getAbsoluteFile();
196         MavenSession mavenSession = createMavenSession(null);
197         mavenSession.getRequest().setRootDirectory(pomFile.getParentFile().toPath());
198         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
199         configuration.setValidationLevel(ModelBuildingRequest.VALIDATION_LEVEL_MINIMAL);
200         configuration.setRepositorySession(mavenSession.getRepositorySession());
201         org.apache.maven.project.ProjectBuilder projectBuilder =
202                 getContainer().lookup(org.apache.maven.project.ProjectBuilder.class);
203 
204         // single project build entry point
205         ProjectBuildingException ex1 =
206                 assertThrows(ProjectBuildingException.class, () -> projectBuilder.build(pomFile, configuration));
207 
208         assertEquals(1, ex1.getResults().size());
209         MavenProject project1 = ex1.getResults().get(0).getProject();
210         assertNotNull(project1);
211         assertEquals("testArtifactMissingVersion", project1.getArtifactId());
212         assertEquals(pomFile, project1.getFile());
213 
214         // multi projects build entry point
215         ProjectBuildingException ex2 = assertThrows(
216                 ProjectBuildingException.class,
217                 () -> projectBuilder.build(Collections.singletonList(pomFile), false, configuration));
218 
219         assertEquals(1, ex2.getResults().size());
220         MavenProject project2 = ex2.getResults().get(0).getProject();
221         assertNotNull(project2);
222         assertEquals("testArtifactMissingVersion", project2.getArtifactId());
223         assertEquals(pomFile, project2.getFile());
224     }
225 
226     @Test
227     void testReadInvalidPom() throws Exception {
228         File pomFile = new File("src/test/resources/projects/badPom.xml").getAbsoluteFile();
229         MavenSession mavenSession = createMavenSession(null);
230         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
231         configuration.setValidationLevel(ModelBuildingRequest.VALIDATION_LEVEL_STRICT);
232         configuration.setRepositorySession(mavenSession.getRepositorySession());
233         org.apache.maven.project.ProjectBuilder projectBuilder =
234                 getContainer().lookup(org.apache.maven.project.ProjectBuilder.class);
235 
236         // single project build entry point
237         Exception ex = assertThrows(Exception.class, () -> projectBuilder.build(pomFile, configuration));
238         assertThat(ex.getMessage(), containsString("Received non-all-whitespace CHARACTERS or CDATA event"));
239 
240         // multi projects build entry point
241         ProjectBuildingException pex = assertThrows(
242                 ProjectBuildingException.class,
243                 () -> projectBuilder.build(Collections.singletonList(pomFile), false, configuration));
244         assertEquals(1, pex.getResults().size());
245         assertNotNull(pex.getResults().get(0).getPomFile());
246         assertThat(pex.getResults().get(0).getProblems().size(), greaterThan(0));
247         assertThat(
248                 pex.getResults(),
249                 contains(projectBuildingResultWithProblemMessage(
250                         "Received non-all-whitespace CHARACTERS or CDATA event in nextTag()")));
251     }
252 
253     @Test
254     void testReadParentAndChildWithRegularVersionSetParentFile() throws Exception {
255         List<File> toRead = new ArrayList<>(2);
256         File parentPom = getProject("MNG-6723");
257         toRead.add(parentPom);
258         toRead.add(new File(parentPom.getParentFile(), "child/pom.xml"));
259         MavenSession mavenSession = createMavenSession(null);
260         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
261         configuration.setValidationLevel(ModelBuildingRequest.VALIDATION_LEVEL_MINIMAL);
262         configuration.setRepositorySession(mavenSession.getRepositorySession());
263         org.apache.maven.project.ProjectBuilder projectBuilder =
264                 getContainer().lookup(org.apache.maven.project.ProjectBuilder.class);
265 
266         // read poms separately
267         boolean parentFileWasFoundOnChild = false;
268         for (File file : toRead) {
269             List<ProjectBuildingResult> results =
270                     projectBuilder.build(Collections.singletonList(file), false, configuration);
271             assertResultShowNoError(results);
272             MavenProject project = findChildProject(results);
273             if (project != null) {
274                 assertEquals(parentPom, project.getParentFile());
275                 parentFileWasFoundOnChild = true;
276             }
277         }
278         assertTrue(parentFileWasFoundOnChild);
279 
280         // read projects together
281         List<ProjectBuildingResult> results = projectBuilder.build(toRead, false, configuration);
282         assertResultShowNoError(results);
283         assertEquals(parentPom, findChildProject(results).getParentFile());
284         Collections.reverse(toRead);
285         results = projectBuilder.build(toRead, false, configuration);
286         assertResultShowNoError(results);
287         assertEquals(parentPom, findChildProject(results).getParentFile());
288     }
289 
290     private MavenProject findChildProject(List<ProjectBuildingResult> results) {
291         for (ProjectBuildingResult result : results) {
292             if (result.getPomFile().getParentFile().getName().equals("child")) {
293                 return result.getProject();
294             }
295         }
296         return null;
297     }
298 
299     private void assertResultShowNoError(List<ProjectBuildingResult> results) {
300         for (ProjectBuildingResult result : results) {
301             assertThat(result.getProblems(), is(empty()));
302             assertNotNull(result.getProject());
303         }
304     }
305 
306     @Test
307     void testBuildProperties() throws Exception {
308         File file = new File(getProject("MNG-6716").getParentFile(), "project/pom.xml");
309         MavenSession mavenSession = createMavenSession(null);
310         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
311         configuration.setRepositorySession(mavenSession.getRepositorySession());
312         configuration.setResolveDependencies(true);
313         List<ProjectBuildingResult> result = projectBuilder.build(Collections.singletonList(file), true, configuration);
314         MavenProject project = result.get(0).getProject();
315         // verify a few typical parameters are not duplicated
316         assertEquals(1, project.getTestCompileSourceRoots().size());
317         assertEquals(1, project.getCompileSourceRoots().size());
318         assertEquals(1, project.getMailingLists().size());
319         assertEquals(1, project.getResources().size());
320     }
321 
322     @Test
323     void testPropertyInPluginManagementGroupId() throws Exception {
324         File pom = getProject("MNG-6983");
325 
326         MavenSession session = createMavenSession(pom);
327         MavenProject project = session.getCurrentProject();
328 
329         for (Plugin buildPlugin : project.getBuildPlugins()) {
330             assertNotNull(buildPlugin.getVersion(), "Missing version for build plugin " + buildPlugin.getKey());
331         }
332     }
333 
334     @Test
335     void testBuildFromModelSourceResolvesBasedir() throws Exception {
336         File pomFile = new File("src/test/resources/projects/modelsourcebasedir/pom.xml");
337         MavenSession mavenSession = createMavenSession(null);
338         ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
339         configuration.setRepositorySession(mavenSession.getRepositorySession());
340         ModelSource modelSource = new FileModelSource(pomFile);
341         ProjectBuildingResult result = getContainer()
342                 .lookup(org.apache.maven.project.ProjectBuilder.class)
343                 .build(modelSource, configuration);
344 
345         assertEquals(
346                 pomFile.getAbsoluteFile(),
347                 result.getProject().getModel().getPomFile().getAbsoluteFile());
348         int errors = 0;
349         for (ModelProblem p : result.getProblems()) {
350             if (p.getSeverity() == ModelProblem.Severity.ERROR) {
351                 errors++;
352             }
353         }
354         assertEquals(0, errors);
355     }
356 
357     @Test
358     void testLocationTrackingResolution() throws Exception {
359         File pom = getProject("MNG-7648");
360 
361         MavenSession session = createMavenSession(pom);
362         MavenProject project = session.getCurrentProject();
363 
364         InputLocation dependencyLocation = null;
365         for (Dependency dependency : project.getDependencies()) {
366             if (dependency.getManagementKey().equals("org.apache.maven.its:a:jar")) {
367                 dependencyLocation = dependency.getLocation("version");
368             }
369         }
370         assertNotNull(dependencyLocation, "missing dependency");
371         assertEquals(
372                 "org.apache.maven.its:bom:0.1", dependencyLocation.getSource().getModelId());
373 
374         InputLocation pluginLocation = null;
375         for (Plugin plugin : project.getBuildPlugins()) {
376             if (plugin.getKey().equals("org.apache.maven.plugins:maven-clean-plugin")) {
377                 pluginLocation = plugin.getLocation("version");
378             }
379         }
380         assertNotNull(pluginLocation, "missing build plugin");
381         assertEquals(
382                 "org.apache.maven.its:parent:0.1", pluginLocation.getSource().getModelId());
383     }
384 }