Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

FilesInfos InfosWarnings WarningsErrors Errors
30322788

Files

FilesI InfosW WarningsE Errors
org/apache/archiva/configuration/MockRepoAdmin.java0263
org/apache/archiva/configuration/TestConfiguration.java084
org/apache/archiva/dependency/tree/maven2/ArchivaRepositoryConnectorFactory.java022
org/apache/archiva/dependency/tree/maven2/DependencyTreeBuilder.java021
org/apache/archiva/dependency/tree/maven2/DependencyTreeBuilderException.java011
org/apache/archiva/dependency/tree/maven2/DependencyTreeBuilderTestMaven3.java032
org/apache/archiva/dependency/tree/maven2/Maven3DependencyTreeBuilder.java056
org/apache/archiva/dependency/tree/maven2/TreeDependencyNodeVisitor.java031
org/apache/archiva/metadata/repository/TestMetadataRepository.java0321
org/apache/archiva/metadata/repository/TestMetadataResolver.java071
org/apache/archiva/metadata/repository/TestRepositorySessionFactory.java022
org/apache/archiva/metadata/repository/storage/maven2/ArtifactMappingProvider.java021
org/apache/archiva/metadata/repository/storage/maven2/ArtifactMetadataVersionComparator.java113
org/apache/archiva/metadata/repository/storage/maven2/DefaultArtifactMappingProvider.java030
org/apache/archiva/metadata/repository/storage/maven2/DummyLifecycleBindingsInjector.java011
org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverMRM1411RepoGroupTest.java066
org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverMRM1411Test.java053
org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverManagedReleaseTest.java006
org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverManagedSnapshotTest.java004
org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverTest.java0188
org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryPathTranslator.java0140
org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryStorage.java01014
org/apache/archiva/metadata/repository/storage/maven2/MavenArtifactFacet.java1132
org/apache/archiva/metadata/repository/storage/maven2/MavenArtifactFacetFactory.java022
org/apache/archiva/metadata/repository/storage/maven2/MavenProjectFacet.java1133
org/apache/archiva/metadata/repository/storage/maven2/MavenProjectFacetFactory.java020
org/apache/archiva/metadata/repository/storage/maven2/MavenProjectParent.java061
org/apache/archiva/metadata/repository/storage/maven2/MavenRepositoryMetadataReaderTest.java040
org/apache/archiva/metadata/repository/storage/maven2/MockWagon.java0293
org/apache/archiva/metadata/repository/storage/maven2/RepositoryModelResolver.java077

Rules

RulesViolationsSeverity
FileLength0Errors Error
RegexpHeader
  • headerFile: "target/checkstyle-header.txt"
9Errors Error
FileTabCharacter
  • eachLine: "true"
0Errors Error
LeftCurly
  • option: "nl"
0Errors Error
RightCurly
  • option: "alone"
0Errors Error
LineLength
  • max: "120"
  • ignorePattern: "@version|@see|@todo|TODO"
20Errors Error
MemberName0Errors Error
JavadocMethod
  • scope: "protected"
223Warnings Warning
JavadocType
  • allowUnknownTags: "true"
  • scope: "protected"
17Errors Error
JavadocVariable
  • scope: "protected"
3Infos Info
ConstantName2Errors Error
LocalFinalVariableName0Errors Error
LocalVariableName0Errors Error
MethodName0Errors Error
PackageName0Errors Error
ParameterName0Errors Error
StaticVariableName1Errors Error
TypeName0Errors Error
AvoidStarImport0Errors Error
IllegalImport0Errors Error
RedundantImport0Errors Error
UnusedImports4Errors Error
MethodLength1Errors Error
ParameterNumber3Errors Error
EmptyForIteratorPad
  • option: "space"
0Errors Error
OperatorWrap2Errors Error
ParenPad
  • option: "space"
13Errors Error
WhitespaceAfter4Errors Error
WhitespaceAround2Errors Error
ModifierOrder1Errors Error
RedundantModifier0Errors Error
AvoidNestedBlocks0Errors Error
EmptyBlock
  • option: "text"
2Errors Error
NeedBraces0Errors Error
DoubleCheckedLocking0Errors Error
EmptyStatement0Errors Error
EqualsHashCode1Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
4Warnings Warning
IllegalInstantiation0Errors Error
InnerAssignment0Errors Error
MagicNumber
  • ignoreNumbers: "-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 32, 64, 100, 128, 256, 512, 1000, 1024"
3Errors Error
MissingSwitchDefault0Errors Error
RedundantThrows2Errors Error
SimplifyBooleanExpression0Errors Error
SimplifyBooleanReturn0Errors Error
InterfaceIsType0Errors Error
VisibilityModifier
  • packageAllowed: "true"
  • protectedAllowed: "true"
1Errors Error
UpperEll0Errors Error

Details

org/apache/archiva/configuration/MockRepoAdmin.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.57
ErrorsLine is longer than 120 characters.62
WarningsMissing a Javadoc comment.83
WarningsMissing a Javadoc comment.96
WarningsMissing a Javadoc comment.102
WarningsMissing a Javadoc comment.108
WarningsMissing a Javadoc comment.114
WarningsMissing a Javadoc comment.120
WarningsMissing a Javadoc comment.126
WarningsMissing a Javadoc comment.132
WarningsMissing a Javadoc comment.138
ErrorsLine is longer than 120 characters.141
WarningsMissing a Javadoc comment.156
WarningsMissing a Javadoc comment.163
WarningsMissing a Javadoc comment.170
WarningsMissing a Javadoc comment.177
WarningsMissing a Javadoc comment.183
WarningsMissing a Javadoc comment.197
WarningsMissing a Javadoc comment.203
WarningsMissing a Javadoc comment.209
WarningsMissing a Javadoc comment.215
WarningsMissing a Javadoc comment.221
WarningsMissing a Javadoc comment.247
WarningsMissing a Javadoc comment.253
WarningsMissing a Javadoc comment.259
WarningsMissing a Javadoc comment.265
WarningsMissing a Javadoc comment.271
WarningsMissing a Javadoc comment.277

org/apache/archiva/configuration/TestConfiguration.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^/\*\s*$'.3
ErrorsMissing a Javadoc comment.26
Errors'(' is not followed by whitespace.26
Errors')' is not preceded with whitespace.26
WarningsMissing a Javadoc comment.32
WarningsMissing a Javadoc comment.37
Warnings'configuration' hides a field.37
WarningsMissing a Javadoc comment.43
WarningsMissing a Javadoc comment.48
WarningsMissing a Javadoc comment.53
WarningsMissing a Javadoc comment.58
WarningsMissing a Javadoc comment.63

org/apache/archiva/dependency/tree/maven2/ArchivaRepositoryConnectorFactory.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.42
WarningsMissing a Javadoc comment.47
ErrorsEmpty catch block.55

org/apache/archiva/dependency/tree/maven2/DependencyTreeBuilder.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.31
WarningsMissing a Javadoc comment.35

org/apache/archiva/dependency/tree/maven2/DependencyTreeBuilderException.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.28

org/apache/archiva/dependency/tree/maven2/DependencyTreeBuilderTestMaven3.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.42
WarningsMissing a Javadoc comment.67
WarningsMissing a Javadoc comment.94
ErrorsMissing a Javadoc comment.111
WarningsMissing a Javadoc comment.116

org/apache/archiva/dependency/tree/maven2/Maven3DependencyTreeBuilder.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.114
WarningsMissing a Javadoc comment.125
ErrorsUnable to get class information for DependencyTreeBuilderException.127
ErrorsLine is longer than 120 characters.161
WarningsMissing a Javadoc comment.183
ErrorsUnable to get class information for DependencyTreeBuilderException.185
WarningsMissing a Javadoc comment.233
Errors';' is not followed by whitespace.237
WarningsMissing a Javadoc comment.247
Errors';' is not followed by whitespace.256

org/apache/archiva/dependency/tree/maven2/TreeDependencyNodeVisitor.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.43
WarningsMissing a Javadoc comment.49
WarningsMissing a Javadoc comment.69

org/apache/archiva/metadata/repository/TestMetadataRepository.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.36
WarningsMissing a Javadoc comment.42
WarningsMissing a Javadoc comment.47
WarningsMissing a Javadoc comment.53
WarningsMissing a Javadoc comment.59
WarningsMissing a Javadoc comment.64
WarningsMissing a Javadoc comment.69
WarningsMissing a Javadoc comment.74
WarningsMissing a Javadoc comment.79
WarningsMissing a Javadoc comment.84
WarningsMissing a Javadoc comment.89
WarningsMissing a Javadoc comment.94
WarningsMissing a Javadoc comment.99
WarningsMissing a Javadoc comment.104
WarningsMissing a Javadoc comment.109
WarningsMissing a Javadoc comment.114
WarningsMissing a Javadoc comment.119
WarningsMissing a Javadoc comment.125
WarningsMissing a Javadoc comment.132
WarningsMissing a Javadoc comment.139
WarningsMissing a Javadoc comment.146
WarningsMissing a Javadoc comment.152
WarningsMissing a Javadoc comment.158
WarningsMissing a Javadoc comment.164
WarningsMissing a Javadoc comment.170
WarningsMissing a Javadoc comment.177
WarningsMissing a Javadoc comment.182
WarningsMissing a Javadoc comment.187
WarningsMissing a Javadoc comment.192
WarningsMissing a Javadoc comment.197
WarningsMissing a Javadoc comment.202
WarningsMissing a Javadoc comment.209
WarningsMissing a Javadoc comment.215

org/apache/archiva/metadata/repository/TestMetadataResolver.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.30
WarningsMissing a Javadoc comment.34
WarningsMissing a Javadoc comment.41
WarningsMissing a Javadoc comment.49
WarningsMissing a Javadoc comment.55
WarningsMissing a Javadoc comment.61
WarningsMissing a Javadoc comment.67
WarningsMissing a Javadoc comment.74

org/apache/archiva/metadata/repository/TestRepositorySessionFactory.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^/\*\s*$'.3
ErrorsMissing a Javadoc comment.23
WarningsMissing a Javadoc comment.31
WarningsMissing a Javadoc comment.36

org/apache/archiva/metadata/repository/storage/maven2/ArtifactMappingProvider.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.22
WarningsMissing a Javadoc comment.24
WarningsMissing a Javadoc comment.26

org/apache/archiva/metadata/repository/storage/maven2/ArtifactMetadataVersionComparator.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
InfosMissing a Javadoc comment.33
ErrorsName 'INSTANCE' must match pattern '^[a-z][a-zA-Z0-9]*$'.33
ErrorsVariable 'INSTANCE' must be private and have accessor methods.33
WarningsMissing a Javadoc comment.35

org/apache/archiva/metadata/repository/storage/maven2/DefaultArtifactMappingProvider.java

ViolationMessageLine
WarningsMissing a Javadoc comment.38
WarningsMissing a Javadoc comment.71
WarningsMissing a Javadoc comment.84

org/apache/archiva/metadata/repository/storage/maven2/DummyLifecycleBindingsInjector.java

ViolationMessageLine
ErrorsLine is longer than 120 characters.35
WarningsMissing a Javadoc comment.35

org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverMRM1411RepoGroupTest.java

ViolationMessageLine
ErrorsUnused import - org.apache.archiva.admin.model.beans.RepositoryGroup.30
ErrorsUnused import - org.apache.archiva.metadata.repository.storage.RepositoryStorageRuntimeException.45
ErrorsMissing a Javadoc comment.57
WarningsMissing a Javadoc comment.172
WarningsMissing a Javadoc comment.215
WarningsMissing a Javadoc comment.247
WarningsMissing a Javadoc comment.273
ErrorsLine is longer than 120 characters.282
WarningsMissing a Javadoc comment.315
ErrorsLine is longer than 120 characters.323
WarningsMissing a Javadoc comment.357
ErrorsMore than 7 parameters.429

org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverMRM1411Test.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.55
WarningsMissing a Javadoc comment.139
WarningsMissing a Javadoc comment.182
WarningsMissing a Javadoc comment.214
WarningsMissing a Javadoc comment.240
WarningsMissing a Javadoc comment.282
ErrorsEmpty catch block.300
ErrorsMore than 7 parameters.340

org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverManagedReleaseTest.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.37
Errors')' is not preceded with whitespace.101
ErrorsLine is longer than 120 characters.106
Errors')' is not preceded with whitespace.109
Errors')' is not preceded with whitespace.118
Errors')' is not preceded with whitespace.127

org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverManagedSnapshotTest.java

ViolationMessageLine
ErrorsUnused import - org.apache.archiva.metadata.repository.storage.RepositoryStorageMetadataInvalidException.28
ErrorsUnused import - org.apache.archiva.metadata.repository.storage.RepositoryStorageMetadataNotFoundException.29
ErrorsMissing a Javadoc comment.38
Errors')' is not preceded with whitespace.89

org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryMetadataResolverTest.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.62
WarningsMissing a Javadoc comment.145
WarningsMissing a Javadoc comment.155
ErrorsLine is longer than 120 characters.174
WarningsMissing a Javadoc comment.210
WarningsMissing a Javadoc comment.252
WarningsMissing a Javadoc comment.335
ErrorsLine is longer than 120 characters.351
ErrorsLine is longer than 120 characters.352
ErrorsLine is longer than 120 characters.353
ErrorsLine is longer than 120 characters.354
WarningsMissing a Javadoc comment.373
WarningsMissing a Javadoc comment.388
WarningsMissing a Javadoc comment.404
WarningsMissing a Javadoc comment.420
WarningsMissing a Javadoc comment.435
WarningsMissing a Javadoc comment.450
WarningsMissing a Javadoc comment.465
WarningsMissing a Javadoc comment.472
WarningsMissing a Javadoc comment.497
WarningsMissing a Javadoc comment.519
WarningsMissing a Javadoc comment.550
Errors'7407' is a magic number.567
WarningsMissing a Javadoc comment.571
WarningsMissing a Javadoc comment.592
ErrorsMore than 7 parameters.621

org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryPathTranslator.java

ViolationMessageLine
WarningsMissing a Javadoc comment.60
WarningsMissing a Javadoc comment.65
WarningsMissing a Javadoc comment.74
WarningsMissing a Javadoc comment.79
WarningsMissing a Javadoc comment.84
WarningsMissing a Javadoc comment.89
WarningsMissing a Javadoc comment.107
WarningsMissing a Javadoc comment.116
WarningsMissing a Javadoc comment.125
WarningsMissing a Javadoc comment.145
WarningsMissing a Javadoc comment.150
WarningsMissing a Javadoc comment.160
WarningsMissing a Javadoc comment.185
WarningsMissing a Javadoc comment.332

org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryStorage.java

ViolationMessageLine
ErrorsLine is longer than 120 characters.87
Errors'static' modifier out of order with the JLS suggestions.128
ErrorsName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.128
WarningsMissing a Javadoc comment.135
WarningsMissing a Javadoc comment.143
ErrorsMethod length is 210 lines (max allowed is 150).149
WarningsMissing a Javadoc comment.149
ErrorsLine is longer than 120 characters.159
ErrorsLine is longer than 120 characters.163
Errors'(' is not followed by whitespace.163
Errors')' is not preceded with whitespace.163
ErrorsLine is longer than 120 characters.170
Errors'(' is not followed by whitespace.170
Errors')' is not preceded with whitespace.170
ErrorsLine is longer than 120 characters.267
Errors'&&' should be on a new line.269
Errors'+' should be on a new line.272
WarningsMissing a Javadoc comment.364
WarningsMissing a Javadoc comment.471
WarningsMissing a Javadoc comment.510
WarningsMissing a Javadoc comment.532
WarningsMissing a Javadoc comment.554
WarningsMissing a Javadoc comment.564
WarningsMissing a Javadoc comment.585

org/apache/archiva/metadata/repository/storage/maven2/MavenArtifactFacet.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.28
InfosMissing a Javadoc comment.39
WarningsMissing a Javadoc comment.41
WarningsMissing a Javadoc comment.46
WarningsMissing a Javadoc comment.51
WarningsMissing a Javadoc comment.56
WarningsMissing a Javadoc comment.61
WarningsMissing a Javadoc comment.66
WarningsMissing a Javadoc comment.71
WarningsMissing a Javadoc comment.76
WarningsMissing a Javadoc comment.81
WarningsMissing a Javadoc comment.86
WarningsMissing a Javadoc comment.92
WarningsMissing a Javadoc comment.111
Warnings'buildNumber' hides a field.116
ErrorsDefinition of 'equals()' without corresponding definition of 'hashCode()'.123

org/apache/archiva/metadata/repository/storage/maven2/MavenArtifactFacetFactory.java

ViolationMessageLine
Errors'(' is not followed by whitespace.29
Errors')' is not preceded with whitespace.29
WarningsMissing a Javadoc comment.33
WarningsMissing a Javadoc comment.38

org/apache/archiva/metadata/repository/storage/maven2/MavenProjectFacet.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.27
InfosMissing a Javadoc comment.38
WarningsMissing a Javadoc comment.40
WarningsMissing a Javadoc comment.45
WarningsMissing a Javadoc comment.50
WarningsMissing a Javadoc comment.55
WarningsMissing a Javadoc comment.60
WarningsMissing a Javadoc comment.65
WarningsMissing a Javadoc comment.70
WarningsMissing a Javadoc comment.75
WarningsMissing a Javadoc comment.80
WarningsMissing a Javadoc comment.85
WarningsMissing a Javadoc comment.91
WarningsMissing a Javadoc comment.106
Warnings'parent' hides a field.114
Errors'31' is a magic number.156
Errors'31' is a magic number.157

org/apache/archiva/metadata/repository/storage/maven2/MavenProjectFacetFactory.java

ViolationMessageLine
WarningsMissing a Javadoc comment.33
WarningsMissing a Javadoc comment.38

org/apache/archiva/metadata/repository/storage/maven2/MavenProjectParent.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.22
WarningsMissing a Javadoc comment.30
WarningsMissing a Javadoc comment.35
WarningsMissing a Javadoc comment.40
WarningsMissing a Javadoc comment.45
WarningsMissing a Javadoc comment.50
WarningsMissing a Javadoc comment.55

org/apache/archiva/metadata/repository/storage/maven2/MavenRepositoryMetadataReaderTest.java

ViolationMessageLine
WarningsMissing a Javadoc comment.46
WarningsMissing a Javadoc comment.81
WarningsMissing a Javadoc comment.99
WarningsMissing a Javadoc comment.119

org/apache/archiva/metadata/repository/storage/maven2/MockWagon.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.40
WarningsMissing a Javadoc comment.43
Errors'assert' is not followed by whitespace.51
Errors'catch' is not followed by whitespace.53
WarningsMissing a Javadoc comment.59
WarningsMissing a Javadoc comment.65
WarningsMissing a Javadoc comment.71
WarningsMissing a Javadoc comment.77
WarningsMissing a Javadoc comment.83
WarningsMissing a Javadoc comment.89
WarningsMissing a Javadoc comment.94
WarningsMissing a Javadoc comment.99
WarningsMissing a Javadoc comment.105
WarningsMissing a Javadoc comment.111
WarningsMissing a Javadoc comment.117
WarningsMissing a Javadoc comment.123
WarningsMissing a Javadoc comment.129
WarningsMissing a Javadoc comment.136
WarningsMissing a Javadoc comment.142
WarningsMissing a Javadoc comment.148
WarningsMissing a Javadoc comment.153
WarningsMissing a Javadoc comment.158
WarningsMissing a Javadoc comment.163
WarningsMissing a Javadoc comment.168
WarningsMissing a Javadoc comment.173
WarningsMissing a Javadoc comment.178
WarningsMissing a Javadoc comment.183
WarningsMissing a Javadoc comment.188
WarningsMissing a Javadoc comment.193
WarningsMissing a Javadoc comment.198
WarningsMissing a Javadoc comment.203
WarningsMissing a Javadoc comment.208

org/apache/archiva/metadata/repository/storage/maven2/RepositoryModelResolver.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.58
ErrorsName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.71
WarningsMissing a Javadoc comment.80
WarningsMissing a Javadoc comment.87
WarningsMissing a Javadoc comment.104
ErrorsLine is longer than 120 characters.143
ErrorsLine is longer than 120 characters.148
WarningsMissing a Javadoc comment.159
WarningsMissing a Javadoc comment.201
WarningsMissing a Javadoc comment.209
ErrorsLine is longer than 120 characters.214
Errors',' is not followed by whitespace.404
Errors',' is not followed by whitespace.409
Warnings'targetRepository' hides a field.438