Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

FilesInfos InfosWarnings WarningsErrors Errors
161015276

Files

FilesI InfosW WarningsE Errors
org/apache/archiva/AbstractDownloadTest.java41612
org/apache/archiva/DownloadArtifactsTest.java5610
org/apache/archiva/DownloadMergedIndexTest.java058
org/apache/archiva/security/UserRepositoriesStub.java0102
org/apache/archiva/web/rss/RoleManagerStub.java0143
org/apache/archiva/web/rss/RssFeedServlet.java123
org/apache/archiva/web/rss/RssFeedServletTest.java0105
org/apache/archiva/web/rss/SecuritySystemStub.java0133
org/apache/archiva/web/runtime/ArchivaRuntimeInfo.java091
org/apache/archiva/web/spring/RepositoryListenerFactoryBean.java043
org/apache/archiva/web/startup/ArchivaStartup.java020
org/apache/archiva/web/startup/Banner.java0518
org/apache/archiva/web/startup/SecuritySynchronization.java052
org/apache/archiva/webtest/memory/TestMetadataRepository.java0332
org/apache/archiva/webtest/memory/TestMetadataResolver.java0161
org/apache/archiva/webtest/memory/TestRepositorySessionFactory.java023

Rules

RulesViolationsSeverity
FileLength0Errors Error
RegexpHeader
  • headerFile: "target/checkstyle-header.txt"
5Errors Error
FileTabCharacter
  • eachLine: "true"
0Errors Error
LeftCurly
  • option: "nl"
0Errors Error
RightCurly
  • option: "alone"
0Errors Error
LineLength
  • max: "120"
  • ignorePattern: "@version|@see|@todo|TODO"
6Errors Error
MemberName0Errors Error
JavadocMethod
  • scope: "protected"
146Warnings Warning
JavadocType
  • allowUnknownTags: "true"
  • scope: "protected"
6Errors Error
JavadocVariable
  • scope: "protected"
10Infos Info
ConstantName1Errors Error
LocalFinalVariableName0Errors Error
LocalVariableName0Errors Error
MethodName3Errors Error
PackageName0Errors Error
ParameterName0Errors Error
StaticVariableName1Errors Error
TypeName0Errors Error
AvoidStarImport0Errors Error
IllegalImport0Errors Error
RedundantImport0Errors Error
UnusedImports0Errors Error
MethodLength3Errors Error
ParameterNumber0Errors Error
EmptyForIteratorPad
  • option: "space"
0Errors Error
OperatorWrap6Errors Error
ParenPad
  • option: "space"
12Errors Error
WhitespaceAfter0Errors Error
WhitespaceAround0Errors Error
ModifierOrder0Errors Error
RedundantModifier0Errors Error
AvoidNestedBlocks0Errors Error
EmptyBlock
  • option: "text"
2Errors Error
NeedBraces0Errors Error
DoubleCheckedLocking0Errors Error
EmptyStatement0Errors Error
EqualsHashCode0Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
6Warnings Warning
IllegalInstantiation0Errors Error
InnerAssignment2Errors Error
MagicNumber
  • ignoreNumbers: "-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 32, 64, 100, 128, 256, 512, 1000, 1024"
19Errors Error
MissingSwitchDefault0Errors Error
RedundantThrows3Errors Error
SimplifyBooleanExpression0Errors Error
SimplifyBooleanReturn0Errors Error
InterfaceIsType0Errors Error
VisibilityModifier
  • packageAllowed: "true"
  • protectedAllowed: "true"
7Errors Error
UpperEll0Errors Error

Details

org/apache/archiva/AbstractDownloadTest.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
InfosMissing a Javadoc comment.63
InfosMissing a Javadoc comment.67
ErrorsVariable 'authorizationHeader' must be private and have accessor methods.67
InfosMissing a Javadoc comment.69
ErrorsVariable 'server' must be private and have accessor methods.69
InfosMissing a Javadoc comment.71
ErrorsVariable 'port' must be private and have accessor methods.71
WarningsMissing a Javadoc comment.73
WarningsMissing a Javadoc comment.78
WarningsMissing a Javadoc comment.89
WarningsMissing a Javadoc comment.92
WarningsMissing a Javadoc comment.98
WarningsMissing a Javadoc comment.145
WarningsMissing a Javadoc comment.158
Errors'300000L' is a magic number.166
WarningsMissing a Javadoc comment.170
Errors'300000L' is a magic number.178
WarningsMissing a Javadoc comment.182
Errors'300000L' is a magic number.190
WarningsMissing a Javadoc comment.195
Errors'300000L' is a magic number.203
WarningsMissing a Javadoc comment.207
Errors'300000L' is a magic number.215
WarningsMissing a Javadoc comment.219
Errors'300000L' is a magic number.227
WarningsMissing a Javadoc comment.231
WarningsMissing a Javadoc comment.238
Errors'3000000L' is a magic number.246
WarningsMissing a Javadoc comment.255
Errors'3000000L' is a magic number.262
WarningsMissing a Javadoc comment.271

org/apache/archiva/DownloadArtifactsTest.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
InfosMissing a Javadoc comment.63
InfosMissing a Javadoc comment.65
ErrorsVariable 'redirectServer' must be private and have accessor methods.65
InfosMissing a Javadoc comment.67
ErrorsVariable 'redirectPort' must be private and have accessor methods.67
InfosMissing a Javadoc comment.69
ErrorsVariable 'repoServer' must be private and have accessor methods.69
InfosMissing a Javadoc comment.71
ErrorsVariable 'repoServerPort' must be private and have accessor methods.71
WarningsMissing a Javadoc comment.73
WarningsMissing a Javadoc comment.81
WarningsMissing a Javadoc comment.87
ErrorsLine is longer than 120 characters.89
WarningsMissing a Javadoc comment.92
WarningsMissing a Javadoc comment.131
WarningsMissing a Javadoc comment.142
ErrorsMissing a Javadoc comment.206
Errors'302' is a magic number.215
ErrorsLine is longer than 120 characters.218
ErrorsMissing a Javadoc comment.226

org/apache/archiva/DownloadMergedIndexTest.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.54
WarningsMissing a Javadoc comment.61
WarningsMissing a Javadoc comment.67
ErrorsLine is longer than 120 characters.69
WarningsMissing a Javadoc comment.72
WarningsMissing a Javadoc comment.85
Errors'20000' is a magic number.115
Errors'500' is a magic number.118
Errors'500' is a magic number.119
Errors'20000' is a magic number.166
Errors'500' is a magic number.169
Errors'500' is a magic number.170

org/apache/archiva/security/UserRepositoriesStub.java

ViolationMessageLine
WarningsMissing a Javadoc comment.37
WarningsMissing a Javadoc comment.42
WarningsMissing a Javadoc comment.48
Warnings'repoIds' hides a field.48
WarningsMissing a Javadoc comment.53
WarningsMissing a Javadoc comment.59
WarningsMissing a Javadoc comment.64
WarningsMissing a Javadoc comment.70
WarningsMissing a Javadoc comment.75
WarningsMissing a Javadoc comment.80
ErrorsRedundant throws: 'AccessDeniedException' is subclass of 'ArchivaSecurityException'.81
ErrorsRedundant throws: 'PrincipalNotFoundException' is subclass of 'ArchivaSecurityException'.81

org/apache/archiva/web/rss/RoleManagerStub.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
Errors'(' is not followed by whitespace.31
Errors')' is not preceded with whitespace.31
WarningsMissing a Javadoc comment.35
WarningsMissing a Javadoc comment.41
WarningsMissing a Javadoc comment.47
WarningsMissing a Javadoc comment.53
WarningsMissing a Javadoc comment.59
WarningsMissing a Javadoc comment.65
WarningsMissing a Javadoc comment.71
WarningsMissing a Javadoc comment.77
WarningsMissing a Javadoc comment.83
WarningsMissing a Javadoc comment.89
WarningsMissing a Javadoc comment.95
WarningsMissing a Javadoc comment.101
WarningsMissing a Javadoc comment.107
WarningsMissing a Javadoc comment.112

org/apache/archiva/web/rss/RssFeedServlet.java

ViolationMessageLine
InfosMissing a Javadoc comment.70
WarningsMissing a Javadoc comment.92
WarningsMissing a Javadoc comment.104
ErrorsLine is longer than 120 characters.295
ErrorsEmpty catch block.301
ErrorsEmpty catch block.305

org/apache/archiva/web/rss/RssFeedServletTest.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.43
ErrorsName 'PREVIOUS_ARCHIVA_PATH' must match pattern '^[a-z][a-zA-Z0-9]*$'.51
WarningsMissing a Javadoc comment.53
WarningsMissing a Javadoc comment.62
WarningsMissing a Javadoc comment.69
WarningsMissing a Javadoc comment.77
WarningsMissing a Javadoc comment.94
WarningsMissing a Javadoc comment.104
WarningsMissing a Javadoc comment.126
WarningsMissing a Javadoc comment.147
ErrorsName 'XXX_testInvalidRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'.148
WarningsMissing a Javadoc comment.167
ErrorsName 'XXX_testInvalidAuthenticationRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'.168
WarningsMissing a Javadoc comment.194
ErrorsName 'XXX_testUnauthorizedRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'.195

org/apache/archiva/web/rss/SecuritySystemStub.java

ViolationMessageLine
WarningsMissing a Javadoc comment.58
WarningsMissing a Javadoc comment.67
WarningsMissing a Javadoc comment.91
WarningsMissing a Javadoc comment.97
WarningsMissing a Javadoc comment.105
WarningsMissing a Javadoc comment.110
WarningsMissing a Javadoc comment.115
WarningsMissing a Javadoc comment.120
WarningsMissing a Javadoc comment.125
ErrorsMethod length is 433 lines (max allowed is 150).130
WarningsMissing a Javadoc comment.130
ErrorsMethod length is 154 lines (max allowed is 150).159
ErrorsMethod length is 154 lines (max allowed is 150).347
WarningsMissing a Javadoc comment.565
WarningsMissing a Javadoc comment.571
WarningsMissing a Javadoc comment.577

org/apache/archiva/web/runtime/ArchivaRuntimeInfo.java

ViolationMessageLine
ErrorsLine does not match expected header line of '^\s*$'.2
WarningsMissing a Javadoc comment.46
WarningsMissing a Javadoc comment.63
WarningsMissing a Javadoc comment.68
WarningsMissing a Javadoc comment.73
WarningsMissing a Javadoc comment.78
WarningsMissing a Javadoc comment.83
WarningsMissing a Javadoc comment.88
WarningsMissing a Javadoc comment.93
WarningsMissing a Javadoc comment.98

org/apache/archiva/web/spring/RepositoryListenerFactoryBean.java

ViolationMessageLine
WarningsMissing a Javadoc comment.40
ErrorsRedundant throws: 'BeansException' is unchecked exception.41
WarningsMissing a Javadoc comment.46
WarningsMissing a Javadoc comment.52
Errors'(' is not followed by whitespace.52
Errors')' is not preceded with whitespace.52
WarningsMissing a Javadoc comment.58

org/apache/archiva/web/startup/ArchivaStartup.java

ViolationMessageLine
WarningsMissing a Javadoc comment.61
WarningsMissing a Javadoc comment.99

org/apache/archiva/web/startup/Banner.java

ViolationMessageLine
ErrorsName 'eol' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.35
Errors'(' is not followed by whitespace.35
Errors')' is not preceded with whitespace.35
WarningsMissing a Javadoc comment.37
Errors'(' is not followed by whitespace.40
Errors')' is not preceded with whitespace.40
Errors'(' is not followed by whitespace.40
Errors')' is not preceded with whitespace.40
WarningsMissing a Javadoc comment.110
ErrorsInner assignments should be avoided.169
Errors'26' is a magic number.172
ErrorsInner assignments should be avoided.178
Errors'26' is a magic number.181
WarningsMissing a Javadoc comment.191
WarningsMissing a Javadoc comment.211
Errors'+' should be on a new line.213
Errors'+' should be on a new line.214
Errors'+' should be on a new line.215
Errors'+' should be on a new line.216
Errors'+' should be on a new line.217
Errors'+' should be on a new line.218
WarningsMissing a Javadoc comment.224
Errors'25' is a magic number.227

org/apache/archiva/web/startup/SecuritySynchronization.java

ViolationMessageLine
WarningsMissing a Javadoc comment.77
WarningsMissing a Javadoc comment.83
ErrorsLine is longer than 120 characters.100
WarningsMissing a Javadoc comment.100
ErrorsLine is longer than 120 characters.111
WarningsMissing a Javadoc comment.111
WarningsMissing a Javadoc comment.156

org/apache/archiva/webtest/memory/TestMetadataRepository.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.36
WarningsMissing a Javadoc comment.47
Errors'123456789' is a magic number.49
WarningsMissing a Javadoc comment.77
WarningsMissing a Javadoc comment.82
WarningsMissing a Javadoc comment.88
WarningsMissing a Javadoc comment.94
WarningsMissing a Javadoc comment.100
WarningsMissing a Javadoc comment.105
WarningsMissing a Javadoc comment.110
WarningsMissing a Javadoc comment.115
WarningsMissing a Javadoc comment.120
WarningsMissing a Javadoc comment.125
WarningsMissing a Javadoc comment.131
WarningsMissing a Javadoc comment.137
WarningsMissing a Javadoc comment.142
WarningsMissing a Javadoc comment.147
WarningsMissing a Javadoc comment.152
WarningsMissing a Javadoc comment.157
WarningsMissing a Javadoc comment.162
WarningsMissing a Javadoc comment.167
WarningsMissing a Javadoc comment.172
WarningsMissing a Javadoc comment.177
WarningsMissing a Javadoc comment.182
WarningsMissing a Javadoc comment.187
WarningsMissing a Javadoc comment.194
WarningsMissing a Javadoc comment.199
WarningsMissing a Javadoc comment.205
WarningsMissing a Javadoc comment.209
WarningsMissing a Javadoc comment.213
WarningsMissing a Javadoc comment.218
WarningsMissing a Javadoc comment.223
WarningsMissing a Javadoc comment.228
WarningsMissing a Javadoc comment.233
WarningsMissing a Javadoc comment.239

org/apache/archiva/webtest/memory/TestMetadataResolver.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.36
WarningsMissing a Javadoc comment.52
WarningsMissing a Javadoc comment.58
WarningsMissing a Javadoc comment.67
WarningsMissing a Javadoc comment.72
Warnings'namespaces' hides a field.75
WarningsMissing a Javadoc comment.95
WarningsMissing a Javadoc comment.101
WarningsMissing a Javadoc comment.108
Warnings'artifacts' hides a field.111
WarningsMissing a Javadoc comment.116
WarningsMissing a Javadoc comment.139
Warnings'artifacts' hides a field.140
WarningsMissing a Javadoc comment.150
Warnings'references' hides a field.151
WarningsMissing a Javadoc comment.156
Warnings'namespaces' hides a field.156

org/apache/archiva/webtest/memory/TestRepositorySessionFactory.java

ViolationMessageLine
ErrorsMissing a Javadoc comment.26
Errors'(' is not followed by whitespace.26
Errors')' is not preceded with whitespace.26
WarningsMissing a Javadoc comment.32
WarningsMissing a Javadoc comment.37