PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/trinidad/bean/AttachedObjects.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.Collection' | 26 |
| These nested if statements could be combined | 80 - 84 |
org/apache/myfaces/trinidad/bean/FacesBeanFactory.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 144 - 145 |
org/apache/myfaces/trinidad/bean/FacesBeanImpl.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.HashMap' | 25 |
| Avoid unused imports such as 'java.util.Map' | 28 |
| Avoid unused imports such as 'javax.faces.component.PartialStateHolder' | 33 |
| Avoid unused imports such as 'javax.faces.component.StateHolder' | 34 |
| Avoid unused imports such as 'javax.faces.component.behavior.ClientBehavior' | 35 |
| Avoid unused imports such as 'org.apache.myfaces.trinidad.bean.util.StateUtils' | 40 |
| These nested if statements could be combined | 502 - 505 |
org/apache/myfaces/trinidad/bean/util/FlaggedPropertyMap.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 65 - 68 |
org/apache/myfaces/trinidad/change/ChangeUtils.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 188 - 196 |
org/apache/myfaces/trinidad/change/RemoveChildComponentChange.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 119 - 123 |
org/apache/myfaces/trinidad/change/SessionChangeManager.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 565 - 575 |
| Avoid unused method parameters such as 'in'. | 978 - 982 |
org/apache/myfaces/trinidad/component/ChildLoop.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.faces.event.AbortProcessingException' | 28 |
org/apache/myfaces/trinidad/component/FacesBeanWrapper.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.List' | 22 |
| Avoid unused imports such as 'java.util.Map' | 23 |
| Avoid unused imports such as 'javax.faces.component.behavior.ClientBehavior' | 28 |
org/apache/myfaces/trinidad/component/StampState.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as '_EMPTY_ARRAY'. | 533 |
org/apache/myfaces/trinidad/component/TreeState.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 111 - 112 |
| These nested if statements could be combined | 138 - 139 |
org/apache/myfaces/trinidad/component/UIXCollection.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 130 - 134 |
| These nested if statements could be combined | 1530 - 1545 |
| These nested if statements could be combined | 2276 - 2284 |
| These nested if statements could be combined | 2308 - 2314 |
| Avoid unused private fields such as '_collectionModel'. | 2602 |
org/apache/myfaces/trinidad/component/UIXComponent.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 1688 |
org/apache/myfaces/trinidad/component/UIXComponentBase.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as '_getAncestorPath()'. | 587 |
| An empty statement (semicolon) not part of a loop | 954 |
| An empty statement (semicolon) not part of a loop | 978 |
| These nested if statements could be combined | 1521 - 1522 |
| These nested if statements could be combined | 1555 - 1556 |
| These nested if statements could be combined | 1590 - 1591 |
| An empty statement (semicolon) not part of a loop | 2536 |
org/apache/myfaces/trinidad/component/UIXHierarchy.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 392 - 416 |
org/apache/myfaces/trinidad/context/ComponentContextManagerImpl.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as '_suspendedStack'. | 201 |
org/apache/myfaces/trinidad/context/RequestContext.java
| Violation | Line |
|---|---|
| Avoid unnecessary return statements | 982 |
| Avoid unnecessary return statements | 994 |
org/apache/myfaces/trinidad/convert/DateTimeConverter.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 590 |
| An empty statement (semicolon) not part of a loop | 1242 |
| Avoid unused method parameters such as 'pattern'. | 1863 - 1871 |
| Avoid unused method parameters such as 'locale'. | 1863 - 1871 |
| Avoid unused method parameters such as 'tZone'. | 1863 - 1871 |
| Avoid unused method parameters such as 'pattern'. | 1874 - 1885 |
| Avoid unused method parameters such as 'locale'. | 1874 - 1885 |
| Avoid unused method parameters such as 'tZone'. | 1874 - 1885 |
| Avoid unused method parameters such as 'format'. | 1874 - 1885 |
org/apache/myfaces/trinidad/menu/ImmutableGroupNode.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'accessKey'. | 185 |
| Avoid unused local variables such as 'label'. | 300 |
org/apache/myfaces/trinidad/menu/ImmutableItemNode.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'accessKey'. | 228 |
| Avoid unused local variables such as 'label'. | 382 |
| Avoid unused local variables such as 'labelAndAcessKeyEval'. | 461 |
org/apache/myfaces/trinidad/model/CollectionModel.java
| Violation | Line |
|---|---|
| Avoid unnecessary return statements | 527 |
org/apache/myfaces/trinidad/model/ModelUtils.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 135 - 136 |
org/apache/myfaces/trinidad/model/RowKeySetImpl.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 248 - 257 |
org/apache/myfaces/trinidad/model/RowKeySetTreeImpl.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as '_containsDefaultNodes()'. | 556 |
| Avoid unused private methods such as '_dumpFlags()'. | 574 |
| Avoid unused constructor parameters such as 'noop'. | 715 - 717 |
| Avoid unused private fields such as '_LOG'. | 872 |
org/apache/myfaces/trinidad/model/XMLMenuModel.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.Serializable' | 22 |
org/apache/myfaces/trinidad/resource/CachingResourceLoader.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as '_contentLength'. | 341 |
org/apache/myfaces/trinidad/resource/DirectoryResourceLoader.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as '_LOG'. | 125 |
org/apache/myfaces/trinidad/skin/SkinVersion.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 75 - 86 |
| Unnecessary final modifier in final class | 89 - 96 |
org/apache/myfaces/trinidad/util/ClassLoaderUtils.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 126 |
org/apache/myfaces/trinidad/util/CollectionUtils.java
| Violation | Line |
|---|---|
| Ensure you override both equals() and hashCode() | 1213 |
| These nested if statements could be combined | 1854 - 1858 |
org/apache/myfaces/trinidad/util/ComponentReference.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'stream'. | 417 - 421 |
org/apache/myfaces/trinidad/util/ExternalContextURLEncoder.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.Collections' | 21 |
| Avoid unused imports such as 'javax.faces.context.FacesContext' | 27 |
org/apache/myfaces/trinidad/util/ExternalContextUtils.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 58 - 76 |
| Unnecessary final modifier in final class | 93 - 111 |
| Unnecessary final modifier in final class | 121 - 160 |
| These nested if statements could be combined | 129 - 156 |
| Unnecessary final modifier in final class | 490 - 493 |
| Unnecessary final modifier in final class | 510 - 513 |
org/apache/myfaces/trinidad/util/FastMessageFormat.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 92 - 105 |
| Avoid unused private fields such as '_LOG'. | 116 |
org/apache/myfaces/trinidad/util/LabeledFacesMessage.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.IOException' | 23 |
org/apache/myfaces/trinidad/util/RequestStateMap.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 105 - 107 |
org/apache/myfaces/trinidad/util/URLEncoder.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.Serializable' | 21 |
| Avoid unused imports such as 'java.io.UnsupportedEncodingException' | 23 |
| Avoid unused imports such as 'java.util.Collections' | 25 |
| Avoid unused imports such as 'javax.faces.context.FacesContext' | 30 |
org/apache/myfaces/trinidad/util/URLUtils.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.servlet.http.HttpServletResponse' | 39 |
| Avoid empty catch blocks | 91 - 94 |
org/apache/myfaces/trinidad/validator/DoubleRangeValidator.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.myfaces.trinidad.util.IntegerUtils' | 35 |
| These nested if statements could be combined | 345 - 349 |
| These nested if statements could be combined | 354 - 358 |
| These nested if statements could be combined | 363 - 367 |
org/apache/myfaces/trinidad/validator/LengthValidator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 405 - 409 |
| These nested if statements could be combined | 414 - 418 |
| These nested if statements could be combined | 423 - 427 |
org/apache/myfaces/trinidad/validator/LongRangeValidator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 347 - 351 |
| These nested if statements could be combined | 356 - 360 |
| These nested if statements could be combined | 365 - 369 |
org/apache/myfaces/trinidad/webapp/ChainedUploadedFileProcessor.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.IOException' | 21 |
org/apache/myfaces/trinidad/webapp/ResourceServlet.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 397 - 401 |
| Avoid empty catch blocks | 662 - 665 |
org/apache/myfaces/trinidad/webapp/TagUtils.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 41 - 49 |
| Unnecessary final modifier in final class | 52 - 100 |
| Unnecessary final modifier in final class | 103 - 111 |
org/apache/myfaces/trinidad/webapp/TrinidadBodyTagSupport.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 84 - 87 |
org/apache/myfaces/trinidad/webapp/TrinidadConverterELTag.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.apache.myfaces.trinidad.convert.ColorConverter' | 31 |
| Avoid unused imports such as 'org.apache.myfaces.trinidad.convert.DateTimeConverter' | 32 |
| Avoid unused imports such as 'org.apache.myfaces.trinidad.convert.NumberConverter' | 33 |
| An empty statement (semicolon) not part of a loop | 95 |
org/apache/myfaces/trinidad/webapp/UIXComponentELTag.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'reqMap'. | 83 |