PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/component/html/ext/AbstractHtmlDataTable.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_SORTABLE'. | 88 |
| Avoid unused private fields such as 'DEFAULT_EMBEDDED'. | 89 |
| Avoid unused private fields such as 'DEFAULT_DETAILSTAMP_EXPANDED'. | 90 |
| Avoid unused private fields such as 'DEFAULT_NEWSPAPER_COLUMNS'. | 93 |
| Avoid unused private fields such as 'DEFAULT_NEWSPAPER_ORIENTATION'. | 94 |
| Avoid unused private fields such as 'DEFAULT_DETAILSTAMP_LOCATION'. | 95 |
| Avoid unnecessary temporaries when converting primitives to Strings | 1703 |
| These nested if statements could be combined | 1738 - 1741 |
| Avoid unused private fields such as 'DEFAULT_RENDEREDIFEMPTY'. | 1752 |
org/apache/myfaces/component/html/ext/AbstractHtmlSelectManyCheckbox.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'booleanFromObject(Object,boolean)'. | 99 |
org/apache/myfaces/component/html/ext/HtmlDataTableHack.java
| Violation | Line |
|---|---|
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 608 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 629 |
| Avoid unused private methods such as 'booleanFromObject(Object,boolean)'. | 654 |
org/apache/myfaces/component/html/ext/_SerializableResultSetDataModel.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'resultSet'. | 33 - 36 |
| Avoid unused constructor parameters such as 'first'. | 33 - 36 |
| Avoid unused constructor parameters such as 'rows'. | 33 - 36 |
org/apache/myfaces/component/html/ext/_SubIdConverter.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 58 - 60 |
| Avoid empty if statements | 118 - 120 |
org/apache/myfaces/component/html/util/HtmlComponentUtils.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 83 - 97 |
org/apache/myfaces/component/html/util/StreamingAddResource.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'REQUEST_ID_COUNTER'. | 135 |
| Avoid unused private fields such as 'RESOURCE_VIRTUAL_PATH'. | 157 |
| Avoid unused method parameters such as 'position'. | 525 - 543 |
| Avoid unused local variables such as 'manager'. | 603 |
| These nested if statements could be combined | 1072 - 1079 |
org/apache/myfaces/custom/buffer/AbstractBuffer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 79 |
org/apache/myfaces/custom/calendar/AbstractHtmlInputCalendar.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 90 |
org/apache/myfaces/custom/calendar/DefaultDateBusinessConverter.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 46 - 49 |
org/apache/myfaces/custom/calendar/HtmlCalendarRenderer.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 479 - 481 |
| Avoid empty if statements | 498 - 500 |
org/apache/myfaces/custom/calendar/HtmlInputCalendarTagHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 114 - 120 |
org/apache/myfaces/custom/checkbox/AbstractHtmlCheckbox.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 53 |
org/apache/myfaces/custom/collapsiblepanel/AbstractHtmlCollapsiblePanel.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 58 |
| Overriding method merely calls super | 155 - 158 |
| Overriding method merely calls super | 215 - 218 |
| Overriding method merely calls super | 262 - 264 |
| Overriding method merely calls super | 269 - 272 |
| Overriding method merely calls super | 277 - 280 |
| Overriding method merely calls super | 285 - 288 |
org/apache/myfaces/custom/datalist/AbstractHtmlDataList.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 51 |
org/apache/myfaces/custom/datascroller/AbstractHtmlDataScroller.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 74 |
| Avoid unused private fields such as 'DEFAULT_IMMEDIATE'. | 75 |
org/apache/myfaces/custom/datascroller/HtmlDataScrollerRenderer.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 493 - 496 |
org/apache/myfaces/custom/date/AbstractHtmlInputDate.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 61 |
| Avoid unused method parameters such as 'type'. | 236 - 241 |
| Overriding method merely calls super | 433 - 436 |
org/apache/myfaces/custom/date/HtmlInputDateTagHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 115 - 121 |
org/apache/myfaces/custom/div/AbstractDiv.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 41 |
org/apache/myfaces/custom/dojo/DojoUtils.java
| Violation | Line |
|---|---|
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 185 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 186 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 187 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 422 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 423 |
| These nested if statements could be combined | 552 - 554 |
org/apache/myfaces/custom/fieldset/AbstractFieldset.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 40 |
org/apache/myfaces/custom/fileupload/AbstractHtmlInputFileUpload.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 122 - 125 |
org/apache/myfaces/custom/fileupload/HtmlFileUploadRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 59 |
| These nested if statements could be combined | 75 - 78 |
org/apache/myfaces/custom/htmlTag/AbstractHtmlTag.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 59 |
org/apache/myfaces/custom/jslistener/AbstractJsValueChangeListener.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 53 |
org/apache/myfaces/custom/jslistener/JsValueChangeListenerRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'context'. | 124 - 170 |
| Avoid empty if statements | 149 - 154 |
org/apache/myfaces/custom/jsvalueset/AbstractHtmlJsValueSet.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 49 |
| Overriding method merely calls super | 71 - 74 |
org/apache/myfaces/custom/layout/AbstractHtmlPanelLayout.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 53 |
| Avoid unused private fields such as 'DEFAULT_BORDER'. | 55 |
| Avoid unused private fields such as 'DEFAULT_LAYOUT'. | 56 |
org/apache/myfaces/custom/navigation/AbstractHtmlCommandNavigation.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 61 |
| These nested if statements could be combined | 97 - 100 |
org/apache/myfaces/custom/navigation/AbstractHtmlPanelNavigation.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 63 |
| Avoid unused private fields such as 'DEFAULT_BORDER'. | 65 |
| Avoid empty if statements | 90 - 93 |
org/apache/myfaces/custom/navmenu/AbstractUINavigationMenuItem.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_IMMEDIATE'. | 57 |
org/apache/myfaces/custom/navmenu/htmlnavmenu/AbstractHtmlCommandNavigationItem.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 62 |
| These nested if statements could be combined | 154 - 156 |
org/apache/myfaces/custom/navmenu/htmlnavmenu/AbstractHtmlPanelNavigationMenu.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 66 |
| Avoid unused private fields such as 'DEFAULT_BORDER'. | 69 |
| Avoid empty if statements | 96 - 99 |
org/apache/myfaces/custom/navmenu/htmlnavmenu/HtmlNavigationMenuRenderer.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 564 |
org/apache/myfaces/custom/navmenu/jscookmenu/AbstractHtmlCommandJSCookMenu.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 59 |
org/apache/myfaces/custom/navmenu/jscookmenu/HtmlJSCookMenuRenderer.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 229 - 231 |
org/apache/myfaces/custom/newspaper/AbstractHtmlNewspaperTable.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_NEWSPAPER_COLUMNS'. | 58 |
org/apache/myfaces/custom/panelstack/AbstractHtmlPanelStack.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 46 |
org/apache/myfaces/custom/panelstack/HtmlPanelStackRenderer.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 73 - 75 |
org/apache/myfaces/custom/picklist/HtmlPicklistRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'uiComponent'. | 257 - 264 |
| Avoid unused method parameters such as 'facesContext'. | 378 - 385 |
| Avoid unused method parameters such as 'converter'. | 378 - 385 |
| Avoid unused method parameters such as 'uiComponent'. | 378 - 385 |
org/apache/myfaces/custom/popup/AbstractHtmlPopup.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 49 |
org/apache/myfaces/custom/popup/HtmlPopupRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LAYOUT_SPAN'. | 53 |
| Avoid empty if statements | 115 - 116 |
org/apache/myfaces/custom/radio/AbstractHtmlRadio.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 66 |
org/apache/myfaces/custom/schedule/AbstractHtmlSchedule.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 62 |
org/apache/myfaces/custom/selectOneLanguage/AbstractSelectOneLanguage.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as '_maxLength'. | 59 |
| Avoid unused private fields such as '_emptySelection'. | 61 |
org/apache/myfaces/custom/stylesheet/AbstractStylesheet.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 43 |
org/apache/myfaces/custom/subform/AbstractSubForm.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 281 - 284 |
org/apache/myfaces/custom/subform/SubFormRenderer.java
| Violation | Line |
|---|---|
| Invoke equals() on the object you've already ensured is not null | 78 |
org/apache/myfaces/custom/swapimage/AbstractHtmlSwapImage.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 44 |
| Avoid unused private fields such as 'DEFAULT_ISMAP'. | 45 |
org/apache/myfaces/custom/tabbedpane/AbstractHtmlPanelTab.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 50 |
| Avoid unused private fields such as 'DEFAULT_DISABLED'. | 51 |
org/apache/myfaces/custom/tabbedpane/AbstractHtmlPanelTabbedPane.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 66 |
| Avoid unused private fields such as 'DEFAULT_SELECTEDINDEX'. | 67 |
| Avoid unused private fields such as 'DEFAULT_SERVER_SIDE_TAB_SWITCH'. | 68 |
| Avoid unused private fields such as 'DEFAULT_BORDER'. | 71 |
| Overriding method merely calls super | 73 - 76 |
org/apache/myfaces/custom/toggle/ToggleGroupRenderer.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'toggleGroup'. | 43 |
org/apache/myfaces/custom/toggle/ToggleLinkRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 182 - 189 |
org/apache/myfaces/custom/tree/AbstractHtmlTreeCheckbox.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 56 |
org/apache/myfaces/custom/tree/AbstractHtmlTreeImageCommandLink.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 39 |
org/apache/myfaces/custom/tree/HtmlTree.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 75 |
| Avoid empty if statements | 764 - 767 |
| Overriding method merely calls super | 774 - 777 |
org/apache/myfaces/custom/tree/renderkit/html/HtmlTreeCheckboxRenderer.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 123 - 125 |
org/apache/myfaces/custom/tree2/AbstractHtmlTree.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'DEFAULT_RENDERER_TYPE'. | 57 |
org/apache/myfaces/custom/tree2/HtmlTreeRenderer.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 116 - 119 |
org/apache/myfaces/custom/tree2/TreeWalkerBase.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 105 - 111 |
org/apache/myfaces/custom/updateactionlistener/UpdateActionListener.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 181 |
| An empty statement (semicolon) not part of a loop | 182 |
org/apache/myfaces/dateformat/SimpleDateFormatter.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 1084 - 1086 |
org/apache/myfaces/renderkit/html/ext/HtmlCheckboxRenderer.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 522 - 524 |
org/apache/myfaces/renderkit/html/ext/HtmlMessageRenderer.java
| Violation | Line |
|---|---|
| Avoid empty while statements | 170 |
org/apache/myfaces/renderkit/html/ext/HtmlRadioRenderer.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 270 - 272 |
org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'facesContext'. | 312 - 464 |
| These nested if statements could be combined | 691 - 693 |
| Avoid unnecessary temporaries when converting primitives to Strings | 704 |
| These nested if statements could be combined | 722 - 724 |
org/apache/myfaces/renderkit/html/util/AddResourceFactory.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 347 - 350 |
org/apache/myfaces/renderkit/html/util/DefaultAddResource.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 650 - 657 |
org/apache/myfaces/renderkit/html/util/ExtensionsPhaseListener.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 133 - 143 |
org/apache/myfaces/renderkit/html/util/MyFacesResourceLoader.java
| Violation | Line |
|---|---|
| Avoid empty finally blocks | 221 - 224 |
org/apache/myfaces/renderkit/html/util/NonBufferingAddResource.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 557 - 561 |
org/apache/myfaces/tomahawk/util/ExternalContextUtils.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 61 - 80 |
| Unnecessary final modifier in final class | 89 - 109 |
| Unnecessary final modifier in final class | 118 - 157 |
| These nested if statements could be combined | 126 - 153 |
| Unnecessary final modifier in final class | 171 - 211 |
| These nested if statements could be combined | 180 - 207 |
org/apache/myfaces/validator/_ValidatorRule.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 63 - 69 |
org/apache/myfaces/webapp/filter/TomahawkFacesContextWrapper.java
| Violation | Line |
|---|---|
| An empty statement (semicolon) not part of a loop | 223 |
| Avoid unused local variables such as 'oldResponse'. | 348 |
org/apache/myfaces/webapp/filter/WelcomeFileFilter.java
| Violation | Line |
|---|---|
| Avoid unnecessary return statements | 169 |