FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is min
Files
org.apache.myfaces.shared.application.DefaultViewHandlerSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateActionURL(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 242 | High |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateAndCheckViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 170 | Medium |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateAndCheckViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 184 | Medium |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 113 | Medium |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateActionURL(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 215 | Low |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateAndCheckViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 139 | Low |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateAndCheckViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 155 | Low |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 84 | Low |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 104 | Low |
org.apache.myfaces.shared.application.FacesServletMappingUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.application.FacesServletMappingUtils.createMappingFromServletRegistration(FacesContext, ServletContext, String, String, boolean) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 299 | Low |
| Load of known null value in org.apache.myfaces.shared.application.FacesServletMappingUtils.calculateFacesServletMapping(FacesContext, String, String, boolean) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 232 | Medium |
| Redundant nullcheck of servletRegistrations, which is known to be non-null in org.apache.myfaces.shared.application.FacesServletMappingUtils.createMappingFromServletRegistration(FacesContext, ServletContext, String, String, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 251 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.application.FacesServletMappingUtils.createMappingFromServletRegistration(FacesContext, ServletContext, String, String, boolean) | STYLE | REC_CATCH_EXCEPTION | 299 | Low |
org.apache.myfaces.shared.application.FacesServletMappingUtils$ServletRegistrationInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.application.FacesServletMappingUtils$ServletRegistrationInfo.getMappings() may expose internal representation by returning FacesServletMappingUtils$ServletRegistrationInfo.mappings | MALICIOUS_CODE | EI_EXPOSE_REP | 75 | Medium |
org.apache.myfaces.shared.context.AjaxExceptionHandlerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.SystemEvent to javax.faces.event.ExceptionQueuedEvent in org.apache.myfaces.shared.context.AjaxExceptionHandlerImpl.processEvent(SystemEvent) | STYLE | BC_UNCONFIRMED_CAST | 306 | Low |
org.apache.myfaces.shared.context.ExceptionHandlerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.SystemEvent to javax.faces.event.ExceptionQueuedEvent in org.apache.myfaces.shared.context.ExceptionHandlerImpl.processEvent(SystemEvent) | STYLE | BC_UNCONFIRMED_CAST | 216 | Low |
org.apache.myfaces.shared.context.flash.ClientWindowFlashTokenLRUMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.shared.context.flash.ClientWindowFlashTokenLRUMap implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 36-69 | Low |
| org.apache.myfaces.shared.context.flash.ClientWindowFlashTokenLRUMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-69 | Low |
org.apache.myfaces.shared.context.flash.FlashClientWindowTokenCollection
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.context.flash.FlashClientWindowTokenCollection is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31-56 | Low |
org.apache.myfaces.shared.renderkit.ContentTypeUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.renderkit.ContentTypeUtils.AJAX_XHTML_ALLOWED_CONTENT_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 42 | Low |
| org.apache.myfaces.shared.renderkit.ContentTypeUtils.HTML_ALLOWED_CONTENT_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 32 | Low |
| org.apache.myfaces.shared.renderkit.ContentTypeUtils.XHTML_ALLOWED_CONTENT_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 39 | Low |
org.apache.myfaces.shared.renderkit.RendererUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.myfaces.shared.renderkit.RendererUtils.loadResourceFile(FacesContext, String): java.io.ByteArrayOutputStream.toString() | I18N | DM_DEFAULT_ENCODING | 1405 | High |
| Test for floating point equality in org.apache.myfaces.shared.renderkit.RendererUtils.isDefaultAttributeValue(Object) | STYLE | FE_FLOATING_POINT_EQUALITY | 513 | Medium |
org.apache.myfaces.shared.renderkit._SharedRendererUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.renderkit._SharedRendererUtils.getConvertedUISelectManyValue(FacesContext, UISelectMany, String[], boolean) | STYLE | REC_CATCH_EXCEPTION | 251 | Low |
org.apache.myfaces.shared.renderkit.html.CommonEventConstants
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.renderkit.html.CommonEventConstants.COMMON_EVENTS_KEY_BY_NAME is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 48 | Medium |
org.apache.myfaces.shared.renderkit.html.CommonPropertyConstants
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.renderkit.html.CommonPropertyConstants.COMMON_PROPERTIES_KEY_BY_NAME is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 106 | Medium |
org.apache.myfaces.shared.renderkit.html.HTML
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 213 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_ATTRIBUTES_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 250 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 227 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 256 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_DISABLED_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 261 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 242 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 237 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_STYLE_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 246 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 531 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 543 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 554 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 558 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 372 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 386 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 138 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 81 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONFOCUS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 89 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONSELECT_AND_ONCHANGE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 96 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 166 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 195 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 186 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 181 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 171 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 199 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 150 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 158 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 162 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 191 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 154 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 74 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 50 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 62 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.FORM_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 270 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.FORM_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 280 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.FORM_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 284 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 297 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 311 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 319 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 328 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_FILE_UPLOAD_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 472 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 337 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 351 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 341 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 356 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 396 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 403 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.MESSAGE_PASSTHROUGH_ATTRIBUTES_WITHOUT_TITLE_STYLE_AND_STYLE_CLASS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 493 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.SELECT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 419 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.SELECT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 421 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.SELECT_TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 499 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TABLE_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 431 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 443 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TABLE_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 447 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TEXTAREA_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 455 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TEXTAREA_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 463 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TEXTAREA_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 467 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 503 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 126 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 111 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES_WITHOUT_STYLE_AND_TITLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 119 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 232 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 378 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 382 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 144 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 176 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 315 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_FILE_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 477 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_FILE_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 481 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 346 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 408 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 412 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.UL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 508 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.UL_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 512 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 285 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 62 | Low |
| StringBuilder is incompatible with expected argument type String in org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase.decode(FacesContext, UIComponent) | CORRECTNESS | GC_UNRELATED_TYPES | 291 | High |
org.apache.myfaces.shared.renderkit.html.HtmlGroupRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.html.HtmlPanelGroup in org.apache.myfaces.shared.renderkit.html.HtmlGroupRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 72 | Low |
| Possible null pointer dereference of behaviors in org.apache.myfaces.shared.renderkit.html.HtmlGroupRendererBase.encodeEnd(FacesContext, UIComponent) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 87 | Medium |
org.apache.myfaces.shared.renderkit.html.HtmlInputFileRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIInput in org.apache.myfaces.shared.renderkit.html.HtmlInputFileRendererBase.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 65 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlMessagesRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.shared.renderkit.html.HtmlMessagesRendererBase.renderMessages(FacesContext, UIComponent, boolean, boolean) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 102 | Medium |
org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 72 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 558 | Low |
| Comparison of String objects using == or != in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, String, Integer) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 309 | Low |
| Load of known null value in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, String, Integer) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 309 | Medium |
| Redundant nullcheck of selectItemList, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 115 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase$GetSelectItemListCallback
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of selectItemList, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase$GetSelectItemListCallback.visit(VisitContext, UIComponent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 603 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.findUIOutputConverterFailSafe(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 617 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.findUISelectManyConverterFailsafe(FacesContext, UIComponent, boolean) | STYLE | BC_UNCONFIRMED_CAST | 599 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) | STYLE | BC_UNCONFIRMED_CAST | 553 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) | STYLE | BC_UNCONFIRMED_CAST | 564 | Low |
| Public static org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.getSupportedContentTypes() may expose internal representation by returning HtmlRendererUtils.SUPPORTED_CONTENT_TYPES | MALICIOUS_CODE | MS_EXPOSE_REP | 1813 | Medium |
| Null passed for non-null parameter of renderSelectOptionsAsText(FacesContext, UIComponent, Converter, Set, List, boolean) in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.renderDisplayValueOnlyForSelects(FacesContext, UIComponent, boolean) | CORRECTNESS | NP_NULL_PARAM_DEREF | 1129 | Medium |
| Redundant nullcheck of behaviorCode, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.buildBehaviorChain(FacesContext, UIComponent, String, String, Collection, String, Collection, Map, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 2130 | Low |
| Redundant nullcheck of behaviorCode2, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.buildBehaviorChain(FacesContext, UIComponent, String, String, Collection, String, Collection, Map, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 2135 | Low |
| Redundant nullcheck of behaviorCode, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.buildBehaviorChain(FacesContext, UIComponent, String, String, Collection, Map, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 2037 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlResponseWriterImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in new org.apache.myfaces.shared.renderkit.html.HtmlResponseWriterImpl(Writer, String, String, boolean, String) | I18N | DM_CONVERT_CASE | 246 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.renderkit.html.HtmlResponseWriterImpl.encodeAndWriteURIAttribute(String, Object) | I18N | DM_CONVERT_CASE | 893 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlSecretRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlSecretRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 231 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.encodeChildren(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 200 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 921 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.encodeInnerHtml(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 350 | Low |
| Redundant nullcheck of elemName, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.renderFacet(FacesContext, ResponseWriter, UIComponent, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1017 | Medium |
| Redundant nullcheck of elemName, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.renderFacet(FacesContext, ResponseWriter, UIComponent, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 989 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlTextRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlTextRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 378 | Low |
| Check for sign of bitwise operation in org.apache.myfaces.shared.renderkit.html.HtmlTextRendererBase.renderOutput(FacesContext, UIComponent) | BAD_PRACTICE | BIT_SIGNED_CHECK | 110 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlTextareaRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlTextareaRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 225 | Low |
org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder.encodeURIAttribute(Writer, String, String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 1099 | Low |
| Redundant nullcheck of app which is known to be null in org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder.encodeURIAttribute(Writer, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 1099 | Medium |
org.apache.myfaces.shared.renderkit.html.util.JavascriptUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.renderkit.html.util.JavascriptUtils.getValidJavascriptName(String, boolean) | I18N | DM_CONVERT_CASE | 153 | Low |
org.apache.myfaces.shared.renderkit.html.util.SelectItemsUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of selectItemInfo at line 84 of value previously dereferenced in org.apache.myfaces.shared.renderkit.html.util.SelectItemsUtils.renderSelectOptions(FacesContext, UIComponent, Converter, Set, List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 84 | Medium |
org.apache.myfaces.shared.resource.BaseResourceHandlerSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.resource.BaseResourceHandlerSupport.calculateResourceBasePath(FacesContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 85 | Medium |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.resource.BaseResourceHandlerSupport.getMapping() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 147 | Medium |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.resource.BaseResourceHandlerSupport.isExtensionMapping() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 133 | Low |
org.apache.myfaces.shared.resource.ClassLoaderResourceLoader$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.shared.resource.ClassLoaderResourceLoader$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 78-81 | Low |
org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$FileDepthIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$FileDepthIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 296-330 | Low |
| Possible null pointer dereference in new org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$FileDepthIterator(File, String, int, ResourceVisitOption[]) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 251 | Medium |
| Possible null pointer dereference in org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$FileDepthIterator.hasNext() due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 271 | Medium |
| Possible null pointer dereference in org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$FileDepthIterator.next() due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 307 | Medium |
| Unread field: org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$FileDepthIterator.basePath | PERFORMANCE | URF_UNREAD_FIELD | 246 | Medium |
| Unread field: org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$FileDepthIterator.options | PERFORMANCE | URF_UNREAD_FIELD | 248 | Medium |
org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$JarDepthIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$JarDepthIterator(URL, String, int, ResourceVisitOption[]) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 195 | Low |
| Unread field: org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$JarDepthIterator.basePath | PERFORMANCE | URF_UNREAD_FIELD | 132 | Medium |
| Unread field: org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$JarDepthIterator.directory | PERFORMANCE | URF_UNREAD_FIELD | 131 | Medium |
| Unread field: org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$JarDepthIterator.maxDepth | PERFORMANCE | URF_UNREAD_FIELD | 133 | Medium |
| Unread field: org.apache.myfaces.shared.resource.ClassLoaderResourceLoaderIterator$JarDepthIterator.options | PERFORMANCE | URF_UNREAD_FIELD | 134 | Medium |
org.apache.myfaces.shared.resource.ExternalContextResourceLoaderIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.resource.ExternalContextResourceLoaderIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 130-163 | Low |
| Unread field: org.apache.myfaces.shared.resource.ExternalContextResourceLoaderIterator.options | PERFORMANCE | URF_UNREAD_FIELD | 46 | Medium |
org.apache.myfaces.shared.resource.ResourceHandlerCache
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.resource.ResourceHandlerCache.libraryExists(String) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 315 | Medium |
org.apache.myfaces.shared.resource.ResourceLoader$VersionComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive org.apache.myfaces.shared.resource.ResourceLoader$VersionComparator.compare(String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 132 | High |
| org.apache.myfaces.shared.resource.ResourceLoader$VersionComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 110-171 | Medium |
org.apache.myfaces.shared.resource.ResourceLoaderUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.resource.ResourceLoaderUtils.getResourceLastModified(URLConnection) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 113 | Low |
org.apache.myfaces.shared.resource.ResourceValidationUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless condition: it's always c < 65536 (0x10000) because variable type is char | STYLE | UC_USELESS_CONDITION_TYPE | 102 | High |
| Useless condition: it's always c < 65536 (0x10000) because variable type is char | STYLE | UC_USELESS_CONDITION_TYPE | 180 | High |
org.apache.myfaces.shared.test.ClassElementHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of string, which is known to be non-null in org.apache.myfaces.shared.test.ClassElementHandler.characters(char[], int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 62 | Low |
| ClassElementHandler.buffer not initialized in constructor and dereferenced in org.apache.myfaces.shared.test.ClassElementHandler.characters(char[], int, int) | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 64 | Low |
| ClassElementHandler.buffer not initialized in constructor and dereferenced in org.apache.myfaces.shared.test.ClassElementHandler.endElement(String, String, String) | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 89 | Low |
org.apache.myfaces.shared.trace.TracingIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.trace.TracingIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 66 | Low |
org.apache.myfaces.shared.util.BiLevelCacheMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Synchronization on BiLevelCacheMap._cacheL1 in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 262 | High |
| Synchronization on BiLevelCacheMap._cacheL1 in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 209 | High |
org.apache.myfaces.shared.util.ConcurrentLRUCache
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to newNewestEntry in org.apache.myfaces.shared.util.ConcurrentLRUCache.markAndSweep() | STYLE | DLS_DEAD_LOCAL_STORE | 350 | Low |
| Integral division result cast to double or float in new org.apache.myfaces.shared.util.ConcurrentLRUCache(int, int) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 92 | Medium |
| Self assignment of field ConcurrentLRUCache.oldestEntry in org.apache.myfaces.shared.util.ConcurrentLRUCache.markAndSweep() | CORRECTNESS | SA_FIELD_SELF_ASSIGNMENT | 222 | High |
| new org.apache.myfaces.shared.util.ConcurrentLRUCache(int, int, int, int, boolean, boolean, ConcurrentLRUCache$EvictionListener) invokes org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 86 | Low |
org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.stop; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 779 | Medium |
| Naked notify in org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.wakeThread() | MT_CORRECTNESS | NN_NAKED_NOTIFY | 796 | Medium |
| Using notify rather than notifyAll in org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.stopThread() | MT_CORRECTNESS | NO_NOTIFY_NOT_NOTIFYALL | 805 | Low |
| Using notify rather than notifyAll in org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.wakeThread() | MT_CORRECTNESS | NO_NOTIFY_NOT_NOTIFYALL | 796 | Low |
org.apache.myfaces.shared.util.ExceptionUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.ExceptionUtils.getExceptions(Throwable) | STYLE | REC_CATCH_EXCEPTION | 58 | Low |
org.apache.myfaces.shared.util.LRULinkedHashMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.util.LRULinkedHashMap is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-40 | Low |
org.apache.myfaces.shared.util.StateUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in org.apache.myfaces.shared.util.StateUtils.getMacSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey | STYLE | BC_VACUOUS_INSTANCEOF | 999 | Medium |
| instanceof will always return true for all non-null values in org.apache.myfaces.shared.util.StateUtils.getSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey | STYLE | BC_VACUOUS_INSTANCEOF | 844 | Medium |
| Dead store of null to baos in org.apache.myfaces.shared.util.StateUtils.compress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 370 | Low |
| Dead store of null to gzip in org.apache.myfaces.shared.util.StateUtils.compress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 369 | Low |
| Dead store of null to bais in org.apache.myfaces.shared.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 449 | Low |
| Dead store of null to baos in org.apache.myfaces.shared.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 448 | Low |
| Dead store of null to gis in org.apache.myfaces.shared.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 450 | Low |
| Dead store of null to outputStream in org.apache.myfaces.shared.util.StateUtils.getAsByteArray(Object, ExternalContext) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 296 | Low |
| Dead store of null to writer in org.apache.myfaces.shared.util.StateUtils.getAsByteArray(Object, ExternalContext) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 295 | Low |
| Random object created and used only once in org.apache.myfaces.shared.util.StateUtils.findMacSecret(String, String) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 1054 | High |
| Random object created and used only once in org.apache.myfaces.shared.util.StateUtils.findSecret(String, String) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 899 | High |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findAlgorithm(ExternalContext) | I18N | DM_CONVERT_CASE | 709 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findAlgorithm(ServletContext) | I18N | DM_CONVERT_CASE | 722 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findAlgorithmParams(ExternalContext) | I18N | DM_CONVERT_CASE | 686 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findInitializationVector(ExternalContext) | I18N | DM_CONVERT_CASE | 668 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findMacAlgorithm(ExternalContext) | I18N | DM_CONVERT_CASE | 922 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findMacAlgorithm(ServletContext) | I18N | DM_CONVERT_CASE | 936 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findMacSecret(ExternalContext, String) | I18N | DM_CONVERT_CASE | 1015 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findMacSecret(ServletContext, String) | I18N | DM_CONVERT_CASE | 1027 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findSecret(ExternalContext, String) | I18N | DM_CONVERT_CASE | 860 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.findSecret(ServletContext, String) | I18N | DM_CONVERT_CASE | 872 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.getMacSecret(ExternalContext) | I18N | DM_CONVERT_CASE | 970 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.getSecret(ExternalContext) | I18N | DM_CONVERT_CASE | 815 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.initSecret(ServletContext) | I18N | DM_CONVERT_CASE | 773 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.shared.util.StateUtils.testConfiguration(ExternalContext) | I18N | DM_CONVERT_CASE | 198 | Low |
| Found reliance on default encoding in org.apache.myfaces.shared.util.StateUtils.findInitializationVector(ExternalContext): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 673 | High |
| Found reliance on default encoding in org.apache.myfaces.shared.util.StateUtils.findMacSecret(String, String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 1064 | High |
| Found reliance on default encoding in org.apache.myfaces.shared.util.StateUtils.findSecret(String, String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 909 | High |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StateUtils.decrypt(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 524 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StateUtils.encrypt(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 352 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StateUtils.getAsObject(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 589 | Low |
org.apache.myfaces.shared.util.StreamCharBuffer$StreamCharBufferSubChunkReader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.myfaces.shared.util.StreamCharBuffer$StreamCharBufferSubChunkReader.parent | PERFORMANCE | URF_UNREAD_FIELD | 1908 | Medium |
org.apache.myfaces.shared.util.StringCharArrayAccessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.util.StringCharArrayAccessor.createString(char[]) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 195 | Medium |
| Invocation of reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block, in org.apache.myfaces.shared.util.StringCharArrayAccessor.<static initializer for StringCharArrayAccessor>() | MALICIOUS_CODE | DP_DO_INSIDE_DO_PRIVILEGED | 65 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StringCharArrayAccessor.<static initializer for StringCharArrayAccessor>() | STYLE | REC_CATCH_EXCEPTION | 73 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StringCharArrayAccessor.createString(char[]) | STYLE | REC_CATCH_EXCEPTION | 216 | Low |
org.apache.myfaces.shared.util.SubKeyMap$Entry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of key, which is known to be non-null in org.apache.myfaces.shared.util.SubKeyMap$Entry.hashCode() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 294 | Medium |
org.apache.myfaces.shared.util.servlet.SourceCodeServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.util.servlet.SourceCodeServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32-72 | Low |
org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to response in org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.getResponseSwitch(Object) | STYLE | DLS_DEAD_LOCAL_STORE | 425 | High |
org.apache.myfaces.shared.webapp.webxml.WebXmlParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.webapp.webxml.WebXmlParser.parse() | STYLE | REC_CATCH_EXCEPTION | 110 | Low |