PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/application/ActionListenerImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 110 - 124 |
org/apache/myfaces/application/ApplicationImpl.java
Violation | Line |
---|---|
Avoid unused private fields such as 'PROJECT_STAGE_PARAM_NAME'. | 151 |
Avoid empty catch blocks | 813 - 816 |
Avoid empty catch blocks | 817 - 826 |
org/apache/myfaces/application/NavigationHandlerImpl.java
Violation | Line |
---|---|
Avoid empty catch blocks | 1094 - 1100 |
org/apache/myfaces/application/ResourceHandlerImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 747 - 750 |
Avoid empty catch blocks | 753 - 756 |
org/apache/myfaces/application/viewstate/RandomKeyFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 101 - 105 |
org/apache/myfaces/application/viewstate/SecureRandomKeyFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 123 - 127 |
org/apache/myfaces/application/viewstate/SerializedViewCollection.java
Violation | Line |
---|---|
Avoid unused private fields such as 'log'. | 37 |
Avoid empty while statements | 92 - 94 |
These nested if statements could be combined | 102 - 117 |
Avoid empty while statements | 138 - 140 |
Avoid empty while statements | 163 - 165 |
org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 342 - 351 |
These nested if statements could be combined | 399 - 405 |
org/apache/myfaces/application/viewstate/SessionIdGenerator.java
Violation | Line |
---|---|
These nested if statements could be combined | 277 - 281 |
org/apache/myfaces/cdi/impl/CDIManagedBeanHandlerImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 109 - 119 |
These nested if statements could be combined | 141 - 144 |
org/apache/myfaces/cdi/util/AbstractContext.java
Violation | Line |
---|---|
These nested if statements could be combined | 93 - 97 |
org/apache/myfaces/config/ConfigFilesXmlValidationUtils.java
Violation | Line |
---|---|
These nested if statements could be combined | 167 - 171 |
Avoid empty catch blocks | 278 - 281 |
Avoid empty catch blocks | 287 - 290 |
Avoid empty catch blocks | 301 - 303 |
Avoid empty catch blocks | 452 - 455 |
Avoid empty catch blocks | 460 - 463 |
Avoid empty catch blocks | 474 - 476 |
org/apache/myfaces/config/DefaultFacesConfigurationMerger.java
Violation | Line |
---|---|
These nested if statements could be combined | 143 - 148 |
These nested if statements could be combined | 205 - 211 |
org/apache/myfaces/config/DefaultFacesConfigurationProvider.java
Violation | Line |
---|---|
Avoid empty catch blocks | 620 - 622 |
Avoid empty catch blocks | 646 - 648 |
Avoid empty catch blocks | 764 - 767 |
org/apache/myfaces/config/FacesConfigurator.java
Violation | Line |
---|---|
Avoid empty catch blocks | 358 - 361 |
Avoid empty catch blocks | 574 - 578 |
org/apache/myfaces/config/annotation/AnnotationConfigurator.java
Violation | Line |
---|---|
Avoid empty if statements | 136 - 138 |
These nested if statements could be combined | 456 - 460 |
These nested if statements could be combined | 488 - 493 |
org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java
Violation | Line |
---|---|
Avoid empty catch blocks | 510 - 513 |
Avoid empty catch blocks | 525 - 528 |
Avoid empty catch blocks | 529 - 532 |
Avoid empty catch blocks | 648 - 651 |
Avoid empty catch blocks | 667 - 670 |
Avoid empty catch blocks | 671 - 674 |
org/apache/myfaces/config/annotation/DefaultLifecycleProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 218 - 221 |
Avoid empty catch blocks | 222 - 225 |
org/apache/myfaces/config/annotation/Tomcat7AnnotationLifecycleProvider.java
Violation | Line |
---|---|
Avoid unused constructor parameters such as 'externalContext'. | 46 - 49 |
Avoid empty catch blocks | 111 - 114 |
org/apache/myfaces/config/annotation/TomcatAnnotationLifecycleProvider.java
Violation | Line |
---|---|
Avoid empty catch blocks | 79 - 82 |
org/apache/myfaces/config/annotation/_ClassByteCodeAnnotationFilter.java
Violation | Line |
---|---|
Avoid unused local variables such as 'minorVersion'. | 107 |
org/apache/myfaces/config/impl/digester/DigesterFacesConfigUnmarshallerImpl.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'externalContext'. | 348 - 369 |
Avoid unused method parameters such as 'systemId'. | 461 - 493 |
org/apache/myfaces/config/util/Vertex.java
Violation | Line |
---|---|
Avoid unused private fields such as 'm_seen'. | 41 |
org/apache/myfaces/context/FacesContextFactoryImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 89 - 93 |
org/apache/myfaces/context/PartialResponseWriterImpl.java
Violation | Line |
---|---|
Overriding method merely calls super | 352 - 355 |
org/apache/myfaces/context/RequestViewContext.java
Violation | Line |
---|---|
Avoid unused constructor parameters such as 'rvm'. | 63 - 66 |
org/apache/myfaces/context/RequestViewMetadata.java
Violation | Line |
---|---|
These nested if statements could be combined | 82 - 85 |
These nested if statements could be combined | 107 - 110 |
org/apache/myfaces/context/servlet/FacesContextImplBase.java
Violation | Line |
---|---|
These nested if statements could be combined | 293 - 301 |
org/apache/myfaces/context/servlet/PartialViewContextImpl.java
Violation | Line |
---|---|
Avoid unused private fields such as 'JAVAX_FACES_REQUEST'. | 68 |
org/apache/myfaces/el/unified/ResolverBuilderForFaces.java
Violation | Line |
---|---|
Avoid empty catch blocks | 69 - 72 |
Avoid empty catch blocks | 73 - 76 |
Avoid empty catch blocks | 77 - 80 |
Avoid empty catch blocks | 123 - 125 |
Avoid empty catch blocks | 126 - 128 |
Avoid empty catch blocks | 129 - 131 |
Avoid empty catch blocks | 132 - 134 |
org/apache/myfaces/el/unified/resolver/CompositeComponentELResolver.java
Violation | Line |
---|---|
These nested if statements could be combined | 105 - 115 |
These nested if statements could be combined | 120 - 124 |
org/apache/myfaces/el/unified/resolver/ImportHandlerResolver.java
Violation | Line |
---|---|
Avoid empty catch blocks | 61 - 64 |
Avoid empty catch blocks | 65 - 68 |
Avoid empty catch blocks | 69 - 72 |
Avoid empty catch blocks | 113 - 116 |
Avoid empty catch blocks | 117 - 120 |
Avoid empty catch blocks | 121 - 124 |
Avoid empty catch blocks | 125 - 128 |
Avoid empty catch blocks | 129 - 132 |
org/apache/myfaces/el/unified/resolver/ManagedBeanResolver.java
Violation | Line |
---|---|
These nested if statements could be combined | 192 - 195 |
These nested if statements could be combined | 212 - 215 |
org/apache/myfaces/flow/FlowHandlerImpl.java
Violation | Line |
---|---|
Avoid empty if statements | 143 - 145 |
Avoid unused method parameters such as 'flow'. | 359 - 375 |
org/apache/myfaces/flow/builder/NavigationCaseBuilderImpl.java
Violation | Line |
---|---|
Avoid unused private fields such as '_flowBuilder'. | 37 |
org/apache/myfaces/flow/builder/SwitchCaseBuilderImpl.java
Violation | Line |
---|---|
Avoid unused private fields such as '_facesFlow'. | 36 |
Avoid unused private fields such as '_switchBuilderImpl'. | 37 |
org/apache/myfaces/lifecycle/CODIClientSideWindow.java
Violation | Line |
---|---|
These nested if statements could be combined | 124 - 127 |
Avoid empty catch blocks | 274 - 277 |
Avoid unused local variables such as 'existingParameters'. | 334 |
Avoid unused local variables such as 'urlContainsWindowId'. | 335 |
org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
Violation | Line |
---|---|
Avoid empty catch blocks | 567 - 570 |
org/apache/myfaces/lifecycle/RestoreViewExecutor.java
Violation | Line |
---|---|
Avoid empty if statements | 431 - 433 |
Avoid empty if statements | 443 - 447 |
Avoid empty if statements | 505 - 507 |
org/apache/myfaces/renderkit/ErrorPageWriter.java
Violation | Line |
---|---|
Avoid empty catch blocks | 290 - 293 |
These nested if statements could be combined | 836 - 843 |
Avoid empty catch blocks | 1010 - 1013 |
These nested if statements could be combined | 1203 - 1212 |
Avoid empty catch blocks | 1339 - 1342 |
Avoid empty catch blocks | 1360 - 1363 |
org/apache/myfaces/renderkit/RenderKitFactoryImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 67 - 70 |
org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java
Violation | Line |
---|---|
Avoid empty catch blocks | 253 - 256 |
org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
Violation | Line |
---|---|
Avoid unused private fields such as 'log'. | 49 |
org/apache/myfaces/resource/TempDirFileCacheContractResourceLoader.java
Violation | Line |
---|---|
Overriding method merely calls super | 173 - 176 |
Avoid empty catch blocks | 249 - 252 |
org/apache/myfaces/resource/TempDirFileCacheResourceLoader.java
Violation | Line |
---|---|
Overriding method merely calls super | 213 - 216 |
Avoid empty catch blocks | 305 - 308 |
org/apache/myfaces/shared_impl/webapp/webxml/FilterMapping.java
Violation | Line |
---|---|
These nested if statements could be combined | 41 - 44 |
org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
Violation | Line |
---|---|
Avoid empty if statements | 263 - 265 |
Avoid empty if statements | 345 - 347 |
Avoid empty if statements | 388 - 390 |
org/apache/myfaces/spi/impl/CDIAnnotationDelegateInjectionProvider.java
Violation | Line |
---|---|
Avoid empty catch blocks | 46 - 49 |
org/apache/myfaces/spi/impl/DefaultAnnotationProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 96 - 99 |
Avoid empty catch blocks | 100 - 103 |
org/apache/myfaces/spi/impl/DefaultFaceletConfigResourceProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 82 - 85 |
Avoid empty catch blocks | 86 - 89 |
org/apache/myfaces/spi/impl/DefaultFacesConfigResourceProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 81 - 84 |
Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationMergerFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 81 - 84 |
Avoid empty catch blocks | 85 - 88 |
org/apache/myfaces/spi/impl/DefaultFacesConfigurationProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 90 - 93 |
Avoid empty catch blocks | 94 - 97 |
org/apache/myfaces/spi/impl/DefaultInjectionProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 222 - 225 |
Avoid empty catch blocks | 226 - 229 |
Avoid unused method parameters such as 'externalContext'. | 269 - 328 |
org/apache/myfaces/spi/impl/DefaultResourceLibraryContractsProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 83 - 86 |
Avoid empty catch blocks | 87 - 90 |
org/apache/myfaces/spi/impl/DefaultServiceProviderFinder.java
Violation | Line |
---|---|
Avoid empty catch blocks | 156 - 159 |
org/apache/myfaces/spi/impl/DefaultWebConfigProviderFactory.java
Violation | Line |
---|---|
Avoid empty catch blocks | 85 - 88 |
Avoid empty catch blocks | 89 - 92 |
org/apache/myfaces/spi/impl/Tomcat7AnnotationInjectionProvider.java
Violation | Line |
---|---|
Avoid unused constructor parameters such as 'externalContext'. | 43 - 46 |
Avoid empty catch blocks | 158 - 161 |
org/apache/myfaces/spi/impl/TomcatAnnotationInjectionProvider.java
Violation | Line |
---|---|
Avoid empty catch blocks | 96 - 99 |
org/apache/myfaces/taglib/core/AttributeTag.java
Violation | Line |
---|---|
These nested if statements could be combined | 123 - 133 |
org/apache/myfaces/taglib/core/DelegateValueChangeListener.java
Violation | Line |
---|---|
Avoid empty catch blocks | 111 - 115 |
Avoid empty catch blocks | 139 - 143 |
org/apache/myfaces/taglib/core/GenericMinMaxValidatorTag.java
Violation | Line |
---|---|
These nested if statements could be combined | 84 - 87 |
org/apache/myfaces/taglib/core/ValidateRequiredTag.java
Violation | Line |
---|---|
These nested if statements could be combined | 90 - 93 |
org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
Violation | Line |
---|---|
These nested if statements could be combined | 50 - 54 |
org/apache/myfaces/view/ViewDeclarationLanguageFactoryImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 153 - 158 |
org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java
Violation | Line |
---|---|
Avoid unused private fields such as '_config'. | 187 |
org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
Violation | Line |
---|---|
Avoid unused private fields such as '_config'. | 292 |
Avoid empty if statements | 362 - 364 |
These nested if statements could be combined | 599 - 602 |
These nested if statements could be combined | 1153 - 1158 |
Avoid unused method parameters such as 'attributeName'. | 1429 - 1457 |
Avoid unused method parameters such as 'targetAttributeName'. | 1429 - 1457 |
Avoid unused method parameters such as 'mctx'. | 1429 - 1457 |
Avoid unused method parameters such as 'topLevelComponent'. | 1429 - 1457 |
Avoid unused method parameters such as 'attributeName'. | 1459 - 1507 |
Avoid unused method parameters such as 'topLevelComponent'. | 1459 - 1507 |
Avoid unused method parameters such as 'attributeName'. | 1509 - 1551 |
Avoid unused method parameters such as 'topLevelComponent'. | 1509 - 1551 |
Avoid unused method parameters such as 'attributeName'. | 1553 - 1602 |
Avoid unused method parameters such as 'topLevelComponent'. | 1553 - 1602 |
Avoid unused local variables such as 'state'. | 1993 |
These nested if statements could be combined | 2406 - 2413 |
org/apache/myfaces/view/facelets/ViewPoolProcessor.java
Violation | Line |
---|---|
These nested if statements could be combined | 601 - 611 |
Avoid empty if statements | 637 - 640 |
Avoid unused local variables such as 'state'. | 1046 |
org/apache/myfaces/view/facelets/compiler/Compiler.java
Violation | Line |
---|---|
Avoid empty catch blocks | 162 - 165 |
org/apache/myfaces/view/facelets/compiler/SAXCompiler.java
Violation | Line |
---|---|
These nested if statements could be combined | 378 - 381 |
These nested if statements could be combined | 478 - 481 |
These nested if statements could be combined | 602 - 608 |
These nested if statements could be combined | 717 - 723 |
org/apache/myfaces/view/facelets/compiler/TagLibraryConfigUnmarshallerImpl.java
Violation | Line |
---|---|
Avoid empty if statements | 194 - 196 |
Avoid empty if statements | 236 - 238 |
Avoid empty if statements | 240 - 242 |
Avoid empty if statements | 244 - 246 |
org/apache/myfaces/view/facelets/compiler/TextUnit.java
Violation | Line |
---|---|
Unnecessary final modifier in final class | 438 - 462 |
Unnecessary final modifier in final class | 464 - 550 |
These nested if statements could be combined | 481 - 484 |
Unnecessary final modifier in final class | 561 - 712 |
These nested if statements could be combined | 614 - 617 |
org/apache/myfaces/view/facelets/el/ContextAwareTagMethodExpression.java
Violation | Line |
---|---|
Avoid empty catch blocks | 125 - 128 |
org/apache/myfaces/view/facelets/el/ContextAwareTagValueExpression.java
Violation | Line |
---|---|
Avoid empty catch blocks | 120 - 123 |
org/apache/myfaces/view/facelets/el/DefaultVariableMapper.java
Violation | Line |
---|---|
These nested if statements could be combined | 85 - 104 |
These nested if statements could be combined | 130 - 133 |
org/apache/myfaces/view/facelets/el/ELText.java
Violation | Line |
---|---|
These nested if statements could be combined | 530 - 553 |
These nested if statements could be combined | 532 - 552 |
These nested if statements could be combined | 615 - 638 |
These nested if statements could be combined | 617 - 637 |
These nested if statements could be combined | 690 - 698 |
These nested if statements could be combined | 692 - 697 |
org/apache/myfaces/view/facelets/impl/DefaultFacelet.java
Violation | Line |
---|---|
Avoid empty if statements | 476 - 479 |
org/apache/myfaces/view/facelets/impl/DefaultFaceletFactory.java
Violation | Line |
---|---|
Avoid empty if statements | 230 - 233 |
Avoid empty catch blocks | 364 - 367 |
Avoid empty if statements | 492 - 495 |
Avoid empty if statements | 546 - 549 |
org/apache/myfaces/view/facelets/impl/FaceletCacheImpl.java
Violation | Line |
---|---|
Avoid empty catch blocks | 183 - 186 |
org/apache/myfaces/view/facelets/impl/FaceletCompositionContextImpl.java
Violation | Line |
---|---|
These nested if statements could be combined | 884 - 895 |
org/apache/myfaces/view/facelets/pool/impl/ViewPoolImpl.java
Violation | Line |
---|---|
Avoid empty catch blocks | 316 - 319 |
org/apache/myfaces/view/facelets/tag/LegacyUserTagHandler.java
Violation | Line |
---|---|
Avoid unused local variables such as 'actx'. | 155 |
Avoid empty finally blocks | 161 - 164 |
Avoid unused local variables such as 'actx'. | 174 |
Avoid empty finally blocks | 180 - 183 |
org/apache/myfaces/view/facelets/tag/composite/AttributeHandler.java
Violation | Line |
---|---|
Avoid empty catch blocks | 340 - 343 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentDefinitionTagHandler.java
Violation | Line |
---|---|
These nested if statements could be combined | 125 - 129 |
org/apache/myfaces/view/facelets/tag/composite/CompositeComponentResourceTagHandler.java
Violation | Line |
---|---|
Avoid empty if statements | 206 - 208 |
These nested if statements could be combined | 616 - 683 |
These nested if statements could be combined | 813 - 820 |
org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java
Violation | Line |
---|---|
These nested if statements could be combined | 196 - 200 |
These nested if statements could be combined | 209 - 227 |
These nested if statements could be combined | 243 - 273 |
org/apache/myfaces/view/facelets/tag/jsf/ComponentSupport.java
Violation | Line |
---|---|
Avoid empty catch blocks | 861 - 863 |
Avoid empty catch blocks | 864 - 866 |
Avoid empty catch blocks | 867 - 869 |
org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java
Violation | Line |
---|---|
These nested if statements could be combined | 523 - 535 |
Avoid empty catch blocks | 531 - 534 |
These nested if statements could be combined | 838 - 842 |
These nested if statements could be combined | 850 - 859 |
org/apache/myfaces/view/facelets/tag/jsf/core/SelectItemsHandler.java
Violation | Line |
---|---|
Avoid unused private methods such as 'getNoSelectionValue()'. | 53 |
org/apache/myfaces/view/facelets/tag/jsf/html/DefaultTagDecorator.java
Violation | Line |
---|---|
Avoid unused private methods such as 'isReservedJSFAttribute(String)'. | 396 |
org/apache/myfaces/view/facelets/tag/jstl/core/ChooseHandler.java
Violation | Line |
---|---|
These nested if statements could be combined | 113 - 152 |
These nested if statements could be combined | 172 - 178 |
These nested if statements could be combined | 198 - 204 |
org/apache/myfaces/view/facelets/tag/jstl/core/ForEachHandler.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'i'. | 730 - 746 |
org/apache/myfaces/view/facelets/tag/jstl/core/LegacyForEachHandler.java
Violation | Line |
---|---|
Unnecessary final modifier in final class | 335 - 342 |
Unnecessary final modifier in final class | 344 - 351 |
Unnecessary final modifier in final class | 353 - 360 |
Unnecessary final modifier in final class | 362 - 369 |
Unnecessary final modifier in final class | 371 - 378 |
Unnecessary final modifier in final class | 380 - 395 |
Unnecessary final modifier in final class | 397 - 404 |
Unnecessary final modifier in final class | 406 - 413 |
Unnecessary final modifier in final class | 415 - 438 |
org/apache/myfaces/view/facelets/tag/jstl/core/SetHandler.java
Violation | Line |
---|---|
These nested if statements could be combined | 161 - 164 |
org/apache/myfaces/view/facelets/tag/jstl/fn/JstlFunction.java
Violation | Line |
---|---|
Avoid empty if statements | 109 - 111 |
org/apache/myfaces/view/facelets/tag/ui/LegacyIncludeHandler.java
Violation | Line |
---|---|
Avoid empty if statements | 215 - 217 |
org/apache/myfaces/view/facelets/tag/ui/ParamHandler.java
Violation | Line |
---|---|
These nested if statements could be combined | 102 - 106 |
These nested if statements could be combined | 137 - 141 |
org/apache/myfaces/view/facelets/tag/ui/RepeatHandler.java
Violation | Line |
---|---|
Avoid empty catch blocks | 91 - 94 |
org/apache/myfaces/view/facelets/util/Classpath.java
Violation | Line |
---|---|
Avoid empty catch blocks | 227 - 229 |
Avoid empty catch blocks | 360 - 363 |
Avoid empty catch blocks | 390 - 394 |
org/apache/myfaces/view/facelets/util/Resource.java
Violation | Line |
---|---|
These nested if statements could be combined | 78 - 81 |
Avoid empty catch blocks | 107 - 111 |
org/apache/myfaces/webapp/AbstractFacesInitializer.java
Violation | Line |
---|---|
Avoid unused method parameters such as 'servletContext'. | 340 - 345 |
Avoid empty catch blocks | 634 - 637 |
Avoid empty catch blocks | 673 - 676 |
Avoid empty catch blocks | 686 - 689 |
Avoid empty catch blocks | 690 - 695 |
Avoid empty catch blocks | 705 - 708 |
Avoid empty catch blocks | 709 - 714 |