FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
javax.faces.application.FacesMessage$Severity
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.application.FacesMessage$Severity defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 177-181 | Medium |
javax.faces.application.StateManager$SerializedView
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.application.StateManager$SerializedView be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 142-154 | Medium |
javax.faces.component.UICommand
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method call in javax.faces.component.UICommand.queueEvent(FacesEvent) passes null for nonnull parameter of UIComponentBase.queueEvent(FacesEvent) | CORRECTNESS | NP_NULL_PARAM_DEREF | 169 | Medium |
javax.faces.component.UIData
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in javax.faces.component.UIData.process(FacesContext, UIComponent, int) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 797-800 | Low |
javax.faces.component.UIData$EditableValueHolderState
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.component.UIData$EditableValueHolderState be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1014-1027 | Medium |
javax.faces.component.UISelectMany
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of previous, which is known to be non-null in javax.faces.component.UISelectMany.compareValues(Object, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 125 | Medium |
javax.faces.component.UIViewRoot
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in javax.faces.component.UIViewRoot.getLocale(String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 291-294 | Low |
javax.faces.component._AttachedListStateWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._AttachedListStateWrapper defines non-transient non-serializable instance field _wrappedStateList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ComponentAttributesMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentAttributesMap defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentAttributesMap defines non-transient non-serializable instance field _attributes | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ComponentChildrenList
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of child in javax.faces.component._ComponentChildrenList.resetParent(UIComponent) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 101 | Medium |
Class javax.faces.component._ComponentChildrenList defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentChildrenList defines non-transient non-serializable instance field _idIndexedMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class javax.faces.component._ComponentChildrenList defines non-transient non-serializable instance field _list | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._ComponentFacetMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _component | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.component._ComponentFacetMap defines non-transient non-serializable instance field _map | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
javax.faces.component._MessageUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in javax.faces.component._MessageUtils.getCause(Throwable) | STYLE | REC_CATCH_EXCEPTION | 102 | Low |
javax.faces.component._PrimitiveArrayIterator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.component._PrimitiveArrayIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 48 | Medium |
javax.faces.component._SelectItemsIterator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of component, which is known to be non-null in javax.faces.component._SelectItemsIterator.getPathToComponent(UIComponent, StringBuffer) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 251 | Low |
javax.faces.convert.NumberConverter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in javax.faces.convert.NumberConverter.checkJavaVersion14() where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 508-511 | Medium |
Switch statement found in javax.faces.convert.NumberConverter.checkJavaVersion14() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 513-517 | Low |
javax.faces.event.PhaseEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class javax.faces.event.PhaseEvent defines non-transient non-serializable instance field _facesContext | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class javax.faces.event.PhaseEvent defines non-transient non-serializable instance field _phaseId | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
javax.faces.event.PhaseId
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.event.PhaseId defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 78 | Medium |
javax.faces.model.ArrayDataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.ArrayDataModel.getWrappedData() may expose internal representation by returning ArrayDataModel._data | MALICIOUS_CODE | EI_EXPOSE_REP | 75 | Medium |
javax.faces.model.ArrayDataModel.setWrappedData(Object) may expose internal representation by storing an externally mutable object into ArrayDataModel._data | MALICIOUS_CODE | EI_EXPOSE_REP2 | 109 | Medium |
javax.faces.model.ResultDataModel
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should javax.faces.model.ResultDataModel.getRows() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 113 | Low |
javax.faces.model.ResultSetDataModel$WrapResultSetMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.ResultSetDataModel$WrapResultSetMap is serializable but also an inner class of a non-serializable class | BAD_PRACTICE | SE_BAD_FIELD_INNER_CLASS | 245-375 | Low |
javax.faces.model.SelectItemGroup
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.model.SelectItemGroup.getSelectItems() may expose internal representation by returning SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP | 59 | Medium |
new javax.faces.model.SelectItemGroup(String, String, boolean, SelectItem[]) may expose internal representation by storing an externally mutable object into SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP2 | 53 | Medium |
javax.faces.model.SelectItemGroup.setSelectItems(SelectItem[]) may expose internal representation by storing an externally mutable object into SelectItemGroup._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP2 | 65 | Medium |
javax.faces.validator.DoubleRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.DoubleRangeValidator defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 202-210 | High |
javax.faces.validator.LengthValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.LengthValidator defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 173-181 | High |
javax.faces.validator.LongRangeValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.validator.LongRangeValidator defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 200-208 | High |
javax.faces.webapp.FacesServlet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
javax.faces.webapp.FacesServlet._facesContextFactory is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 73 | Low |
javax.faces.webapp.FacesServlet._lifecycle is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 74 | Low |
javax.faces.webapp.FacesServlet._servletConfig is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 80 | Low |
javax.faces.webapp._ErrorPageWriter
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Incorrect lazy initialization of static field javax.faces.webapp._ErrorPageWriter.DEBUG_PARTS in javax.faces.webapp._ErrorPageWriter.init(FacesContext) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 107-108 | Low |
Incorrect lazy initialization of static field javax.faces.webapp._ErrorPageWriter.ERROR_PARTS in javax.faces.webapp._ErrorPageWriter.init(FacesContext) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 103-104 | Low |
Exception is caught when Exception is not thrown in javax.faces.webapp._ErrorPageWriter.writeAttributes(Writer, UIComponent) | STYLE | REC_CATCH_EXCEPTION | 436 | High |
Exception is caught when Exception is not thrown in javax.faces.webapp._ErrorPageWriter.initCauseIfAvailable(Throwable, Throwable) | STYLE | REC_CATCH_EXCEPTION | 607 | Medium |
Exception is caught when Exception is not thrown in javax.faces.webapp._ErrorPageWriter.writeAttributes(Writer, UIComponent) | STYLE | REC_CATCH_EXCEPTION | 424 | Medium |
Exception is caught when Exception is not thrown in javax.faces.webapp._ErrorPageWriter.getCause(Throwable) | STYLE | REC_CATCH_EXCEPTION | 553 | Low |
Exception is caught when Exception is not thrown in javax.faces.webapp._ErrorPageWriter.initCausePerReflection(Throwable, String) | STYLE | REC_CATCH_EXCEPTION | 563 | Low |
Exception is caught when Exception is not thrown in javax.faces.webapp._ErrorPageWriter.writeAttributes(Writer, UIComponent) | STYLE | REC_CATCH_EXCEPTION | 424 | Low |