FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
org.apache.myfaces.commons.exporter.ExporterActionListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.commons.exporter.ExporterActionListener.processAction(ActionEvent), since all javax.faces.component.html.HtmlDataTable are instances of javax.faces.component.html.HtmlDataTable | STYLE | BC_VACUOUS_INSTANCEOF | 88 | Medium |
| Method org.apache.myfaces.commons.exporter.ExporterActionListener.processAction(ActionEvent) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 88 | Low |
org.apache.myfaces.commons.exporter.FaceletsExporterActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ActionSource in org.apache.myfaces.commons.exporter.FaceletsExporterActionListenerTag.apply(FaceletContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 69 | Medium |
org.apache.myfaces.commons.exporter.util.ExcelExporterUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.commons.exporter.util.ExcelExporterUtil.generateTableContent(FacesContext, HSSFSheet, List, HtmlDataTable) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 145 | Medium |
org.apache.myfaces.commons.exporter.util.PDFExporterUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.commons.exporter.util.PDFExporterUtil.generateTableContent(FacesContext, PdfPTable, List, HtmlDataTable) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 114 | Medium |
org.apache.myfaces.commons.renderOne.UIRenderOne
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of vb, which is known to be non-null in org.apache.myfaces.commons.renderOne.UIRenderOne.getValue() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 83 | Medium |