/[Apache-SVN]
ViewVC logotype

Revision 1346365


Jump to revision: Previous Next
Author: kkolinko
Date: Tue Jun 5 12:13:07 2012 UTC (7 years, 4 months ago)
Changed paths: 1
Log Message:
For https://issues.apache.org/bugzilla/show_bug.cgi?id=53119
Port r1344253 to AjpNioProcessor

Prevent possible overflow exception with buffer in AjpNioProcessor.output() if it is called again after the previous write failed with IOException.

This is based on review of the issue fixed by r1344253. I see several reasons why it is hard to observe in Nio, but it is easy to prevent this issue. An overflow exception is bad because it is RuntimeException and is generally unexpected. This change:
- avoids writing to the buffer if att == null
- always clears the buffer. Note that Buffer.clear() method is rather lightweight one.

Changed paths

Path Details
Directorytomcat/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26