PMD Results

The following document contains the results of PMD 5.1.2.

Files

org/apache/turbine/Turbine.java

Violation Line
Useless parentheses. 316
These nested if statements could be combined 518–521
Avoid using a branching statement as the last in a loop. 560
Avoid empty catch blocks 932–935
Avoid empty catch blocks 942–945
Avoid empty catch blocks 968–971

org/apache/turbine/annotation/AnnotationProcessor.java

Violation Line
Avoid unused private methods such as 'injectTurbineLoader(Object,AssemblerBrokerService,Field,TurbineLoader)'. 144
Avoid unused private methods such as 'injectTurbineConfiguration(Object,Configuration,Field,TurbineConfiguration)'. 180
Avoid unused private methods such as 'injectTurbineService(Object,ServiceManager,Field,TurbineService)'. 339

org/apache/turbine/modules/ActionEvent.java

Violation Line
These nested if statements could be combined 216–220
Useless parentheses. 296

org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java

Violation Line
These nested if statements could be combined 98–117

org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java

Violation Line
Avoid unused imports such as 'org.apache.turbine.annotation.TurbineService' 28
Avoid unused imports such as 'org.apache.turbine.services.security.SecurityService' 31

org/apache/turbine/modules/pages/JspPage.java

Violation Line
Avoid empty catch blocks 62–66

org/apache/turbine/modules/screens/TemplateScreen.java

Violation Line
Avoid empty catch blocks 148–151

org/apache/turbine/om/security/DefaultUserImpl.java

Violation Line
An empty statement (semicolon) not part of a loop 70
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 420
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 436
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 649
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 651
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 651
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 660
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 671
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 673
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 682
Useless parentheses. 696
Useless parentheses. 723
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 735

org/apache/turbine/om/security/TurbineUserDelegate.java

Violation Line
Avoid modifiers which are implied by the context 36
Avoid modifiers which are implied by the context 43

org/apache/turbine/pipeline/CleanUpValve.java

Violation Line
Avoid empty catch blocks 91–95

org/apache/turbine/pipeline/PipelineData.java

Violation Line
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 67

org/apache/turbine/pipeline/Valve.java

Violation Line
Avoid modifiers which are implied by the context 92–93
Avoid modifiers which are implied by the context 99–100

org/apache/turbine/pipeline/ValveContext.java

Violation Line
Avoid modifiers which are implied by the context 67–68

org/apache/turbine/services/BaseServiceBroker.java

Violation Line
Useless parentheses. 261
Useless parentheses. 262
Useless parentheses. 263
Useless parentheses. 322

org/apache/turbine/services/TurbineServiceProvider.java

Violation Line
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 57

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Violation Line
Useless parentheses. 231
Useless parentheses. 287

org/apache/turbine/services/jsonrpc/JsonRpcService.java

Violation Line
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 50–51
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 68
Avoid modifiers which are implied by the context 76
Avoid modifiers which are implied by the context 83

org/apache/turbine/services/jsp/TurbineJspService.java

Violation Line
Avoid empty catch blocks 183–186

org/apache/turbine/services/jsp/util/JspNavigation.java

Violation Line
Avoid empty catch blocks 88–91

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Violation Line
Avoid empty catch blocks 95–98

org/apache/turbine/services/pull/PipelineDataApplicationTool.java

Violation Line
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 65

org/apache/turbine/services/pull/RunDataApplicationTool.java

Violation Line
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 66

org/apache/turbine/services/pull/TurbinePullService.java

Violation Line
These nested if statements could be combined 411–415
These nested if statements could be combined 462–466

org/apache/turbine/services/rundata/DefaultTurbineRunData.java

Violation Line
Useless parentheses. 358
Useless parentheses. 359
Useless parentheses. 379
Useless parentheses. 380
Useless parentheses. 475–476
Useless parentheses. 819

org/apache/turbine/services/rundata/TurbineRunDataService.java

Violation Line
Useless parentheses. 133
Useless parentheses. 224
Useless parentheses. 225
Useless parentheses. 226

org/apache/turbine/services/schedule/JobQueue.java

Violation Line
Useless parentheses. 191

org/apache/turbine/services/servlet/TurbineServletService.java

Violation Line
Avoid empty catch blocks 116–119

org/apache/turbine/services/session/SessionListener.java

Violation Line
Avoid unused private methods such as 'getSessionService()'. 81

org/apache/turbine/services/session/SessionService.java

Violation Line
Avoid modifiers which are implied by the context 46

org/apache/turbine/services/template/TemplateService.java

Violation Line
Avoid modifiers which are implied by the context 46

org/apache/turbine/services/template/TurbineTemplateService.java

Violation Line
Useless parentheses. 343
Useless parentheses. 437
Useless parentheses. 451
Useless parentheses. 465
Useless parentheses. 479
Useless parentheses. 493
Useless parentheses. 540
Useless parentheses. 555
Useless parentheses. 570
Useless parentheses. 586
Useless parentheses. 601
Useless parentheses. 617
Useless parentheses. 810
Useless parentheses. 810
Useless parentheses. 815
Useless parentheses. 815

org/apache/turbine/services/template/mapper/BaseMapper.java

Violation Line
Useless parentheses. 173

org/apache/turbine/services/template/mapper/ClassMapper.java

Violation Line
Useless parentheses. 122
Useless parentheses. 142
Avoid empty catch blocks 157–160

org/apache/turbine/services/template/mapper/DirectMapper.java

Violation Line
Useless parentheses. 66

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Violation Line
Useless parentheses. 123

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Violation Line
Useless parentheses. 118

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Violation Line
Useless parentheses. 79

org/apache/turbine/services/ui/UIService.java

Violation Line
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 87
Avoid modifiers which are implied by the context 101
Avoid modifiers which are implied by the context 117
Avoid modifiers which are implied by the context 127
Avoid modifiers which are implied by the context 143
Avoid modifiers which are implied by the context 153
Avoid modifiers which are implied by the context 169–170
Avoid modifiers which are implied by the context 180

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Violation Line
Useless parentheses. 135

org/apache/turbine/services/velocity/TurbineVelocityService.java

Violation Line
Avoid empty catch blocks 306–309
Avoid empty catch blocks 352–355
Avoid empty catch blocks 393–396
Useless parentheses. 438
Useless parentheses. 438
Useless parentheses. 443
Useless parentheses. 457
Useless parentheses. 457
Useless parentheses. 579
Useless parentheses. 582

org/apache/turbine/util/DateSelector.java

Violation Line
Useless parentheses. 205
Useless parentheses. 228
Useless parentheses. 234
Useless parentheses. 245
Useless parentheses. 270
Useless parentheses. 282
Useless parentheses. 296
Useless parentheses. 329
Useless parentheses. 376
Useless parentheses. 399
Useless parentheses. 451

org/apache/turbine/util/GenerateUniqueId.java

Violation Line
Unnecessary use of fully qualified name 'java.util.Random' due to existing import 'java.util.Random' 52
Useless parentheses. 103

org/apache/turbine/util/ObjectUtils.java

Violation Line
Avoid empty catch blocks 115–118
Avoid empty catch blocks 129–132

org/apache/turbine/util/SecurityCheck.java

Violation Line
Useless parentheses. 155
Useless parentheses. 249

org/apache/turbine/util/ServerData.java

Violation Line
Useless parentheses. 260–261
Useless parentheses. 263–264

org/apache/turbine/util/ServletUtils.java

Violation Line
Useless parentheses. 77

org/apache/turbine/util/TimeSelector.java

Violation Line
Useless parentheses. 284
Useless parentheses. 296–297
Useless parentheses. 319
Useless parentheses. 327
Useless parentheses. 338
Useless parentheses. 350
Useless parentheses. 380
Useless parentheses. 391
Useless parentheses. 403
Useless parentheses. 443
Useless parentheses. 443
Useless parentheses. 444
Useless parentheses. 458
Useless parentheses. 458
Useless parentheses. 459
Useless parentheses. 474
Useless parentheses. 487
Useless parentheses. 520
Useless parentheses. 549
Useless parentheses. 579
Useless parentheses. 646

org/apache/turbine/util/template/TemplateInfo.java

Violation Line
Avoid empty catch blocks 120–125

org/apache/turbine/util/uri/BaseURI.java

Violation Line
Useless parentheses. 461–462
Useless parentheses. 463–464

org/apache/turbine/util/uri/TurbineURI.java

Violation Line
Avoid unused private methods such as 'doEncode(StringBuilder,Collection,char,char)'. 775

org/apache/turbine/util/uri/URIParam.java

Violation Line
Useless parentheses. 63