The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$LeastFailureComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 261-268 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$PrioritizedTestComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 239-246 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$RunCountComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 141-153 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$TestRuntimeComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 250-257 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.surefire.booter.SurefireReflector$ClassLoaderProxy be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 143-151 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.surefire.report.AbstractReporter.deleteIfExisting(File) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 206 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.maven.surefire.report.AsynchRunListener(RunListener, String) invokes Thread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.maven.surefire.report.TestSetStatistics.completedCount; locked 88% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 91 | Medium |
| Inconsistent synchronization of org.apache.maven.surefire.report.TestSetStatistics.errors; locked 88% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 92 | Medium |
| Inconsistent synchronization of org.apache.maven.surefire.report.TestSetStatistics.failures; locked 88% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 93 | Medium |
| Inconsistent synchronization of org.apache.maven.surefire.report.TestSetStatistics.skipped; locked 77% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 94 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.surefire.report.XMLReporter.testSetCompleted(ReportEntry) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 125 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.surefire.testset.DirectoryScannerParameters.getRunOrder() may expose internal representation by returning DirectoryScannerParameters.runOrder | MALICIOUS_CODE | EI_EXPOSE_REP | 100 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.surefire.testset.RunOrderParameters.getRunOrder() may expose internal representation by returning RunOrderParameters.runOrder | MALICIOUS_CODE | EI_EXPOSE_REP | 58 | Medium |
| new org.apache.maven.surefire.testset.RunOrderParameters(RunOrder[], File) may expose internal representation by storing an externally mutable object into RunOrderParameters.runOrder | MALICIOUS_CODE | EI_EXPOSE_REP2 | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.surefire.util.RunOrder.DEFAULT is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 47 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.surefire.util.internal.ByteBuffer.getData() may expose internal representation by returning ByteBuffer.data | MALICIOUS_CODE | EI_EXPOSE_REP | 98 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.maven.surefire.util.internal.FunkyTwoThreadBlockingQueue.chunkSize; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.surefire.util.internal.FunkyTwoThreadBlockingQueue$Chunk be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 93-95 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Wait not in loop in org.apache.maven.surefire.util.internal.Java13BlockingQueue.take() | MT_CORRECTNESS | WA_NOT_IN_LOOP | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of str at line 531 of value previously dereferenced in org.apache.maven.surefire.util.internal.StringUtils.escapeJavaStyleString(PrintStream, byte[], int, int) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 530 | Medium |
| Nullcheck of str at line 437 of value previously dereferenced in org.apache.maven.surefire.util.internal.StringUtils.escapeJavaStyleString(ByteBuffer, byte[], int, int) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 436 | Medium |
| Nullcheck of str at line 625 of value previously dereferenced in org.apache.maven.surefire.util.internal.StringUtils.escapeJavaStyleString(byte[], int, byte[], int, int) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 624 | Medium |