Maven SCM Git Executable - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
27	4	77	43

Files

Files	I	W	E
org/apache/maven/scm/provider/git/gitexe/command/AbstractFileCheckingConsumer.java	3	6	0
org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java	0	4	0
org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java	0	1	0
org/apache/maven/scm/provider/git/gitexe/command/blame/GitBlameCommand.java	0	1	0
org/apache/maven/scm/provider/git/gitexe/command/blame/GitBlameConsumer.java	0	3	8
org/apache/maven/scm/provider/git/gitexe/command/branch/GitBranchCommand.java	0	7	3
org/apache/maven/scm/provider/git/gitexe/command/branch/GitCurrentBranchConsumer.java	0	2	1
org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java	0	10	6
org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumer.java	0	3	3
org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java	0	2	3
org/apache/maven/scm/provider/git/gitexe/command/checkout/GitCheckOutCommand.java	0	1	0
org/apache/maven/scm/provider/git/gitexe/command/diff/GitDiffCommand.java	0	7	1
org/apache/maven/scm/provider/git/gitexe/command/diff/GitDiffRawConsumer.java	0	2	2
org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoCommand.java	1	1	2
org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoConsumer.java	0	3	0
org/apache/maven/scm/provider/git/gitexe/command/list/GitListCommand.java	0	1	0
org/apache/maven/scm/provider/git/gitexe/command/list/GitListConsumer.java	0	3	0
org/apache/maven/scm/provider/git/gitexe/command/remoteinfo/GitRemoteInfoCommand.java	0	1	0
org/apache/maven/scm/provider/git/gitexe/command/remoteinfo/GitRemoteInfoConsumer.java	0	2	1
org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveCommand.java	0	1	0
org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveConsumer.java	0	2	1
org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusCommand.java	0	1	0
org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumer.java	0	2	1
org/apache/maven/scm/provider/git/gitexe/command/tag/GitTagCommand.java	0	3	5
org/apache/maven/scm/provider/git/gitexe/command/update/GitLatestRevisionCommandConsumer.java	0	2	1
org/apache/maven/scm/provider/git/gitexe/command/update/GitUpdateCommand.java	0	6	5

Rules

Rules	Violations	Severity
FileLength	0	Error
RegexpHeader headerFile: `"target/checkstyle-header.txt"`	0	Error
FileTabCharacter eachLine: `"true"`	0	Error
LeftCurly option: `"nl"`	0	Error
RightCurly option: `"alone"`	0	Error
LineLength max: `"120"` ignorePattern: `"@version\|@see\|@todo\|TODO"`	22	Error
MemberName	0	Error
JavadocMethod scope: `"protected"`	77	Warning
JavadocType allowUnknownTags: `"true"` scope: `"protected"`	0	Error
JavadocVariable scope: `"protected"`	4	Info
ConstantName	0	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
AvoidStarImport	1	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
MethodLength	0	Error
ParameterNumber	3	Error
EmptyForIteratorPad option: `"space"`	0	Error
OperatorWrap	2	Error
ParenPad option: `"space"`	7	Error
WhitespaceAfter	0	Error
WhitespaceAround	3	Error
ModifierOrder	5	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock option: `"text"`	0	Error
NeedBraces	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	0	Warning
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber ignoreNumbers: `"-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 32, 64, 100, 128, 256, 512, 1000, 1024"`	0	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
InterfaceIsType	0	Error
VisibilityModifier packageAllowed: `"true"` protectedAllowed: `"true"`	0	Error
UpperEll	0	Error

Details

org/apache/maven/scm/provider/git/gitexe/command/AbstractFileCheckingConsumer.java

Violation	Message	Line
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	103
	Missing a Javadoc comment.	108

org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java

Violation	Message	Line
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	105
	Missing a Javadoc comment.	128

org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	107

org/apache/maven/scm/provider/git/gitexe/command/blame/GitBlameCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	79

org/apache/maven/scm/provider/git/gitexe/command/blame/GitBlameConsumer.java

Violation	Message	Line
	Using the '.' form of import should be avoided - java.util..	28
	'static' modifier out of order with the JLS suggestions.	45
	'static' modifier out of order with the JLS suggestions.	46
	'static' modifier out of order with the JLS suggestions.	47
	'static' modifier out of order with the JLS suggestions.	48
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	75
	'(' is not followed by whitespace.	82
	')' is not preceded with whitespace.	82
	')' is not preceded with whitespace.	87
	Missing a Javadoc comment.	148

org/apache/maven/scm/provider/git/gitexe/command/branch/GitBranchCommand.java

Violation	Message	Line
	Line is longer than 120 characters.	50
	'if' is not followed by whitespace.	77
	Line is longer than 120 characters.	85
	Missing a Javadoc comment.	108
	Missing a Javadoc comment.	118
	Expected an @return tag.	133
	Expected @param tag for 'logger'.	133
	Expected @param tag for 'repository'.	133
	Expected @param tag for 'fileSet'.	133
	Expected @throws tag for 'ScmException'.	134

org/apache/maven/scm/provider/git/gitexe/command/branch/GitCurrentBranchConsumer.java

Violation	Message	Line
	'static' modifier out of order with the JLS suggestions.	35
	Expected @param tag for 'logger'.	42
	Missing a Javadoc comment.	47

org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	72
	More than 7 parameters.	72
	Line is longer than 120 characters.	78
	Missing a Javadoc comment.	94
	More than 7 parameters.	94
	Expected an @return tag.	130
	Expected @param tag for 'repository'.	130
	Expected @param tag for 'workingDirectory'.	130
	Expected @param tag for 'branch'.	131
	Expected @param tag for 'startDate'.	131
	Expected @param tag for 'endDate'.	131
	Expected @param tag for 'startVersion'.	132
	Expected @param tag for 'endVersion'.	132
	Line is longer than 120 characters.	134
	More than 7 parameters.	137
	Line is longer than 120 characters.	160

org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumer.java

Violation	Message	Line
	Expected @param tag for 'logger'.	207
	Expected @param tag for 'userDateFormat'.	207
	Line is longer than 120 characters.	227
	Missing a Javadoc comment.	232
	Line is longer than 120 characters.	351
	Line is longer than 120 characters.	375

org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java

Violation	Message	Line
	'+' should be on a new line.	111
	'if' is not followed by whitespace.	130
	Line is longer than 120 characters.	137
	Missing a Javadoc comment.	186
	Missing a Javadoc comment.	206

org/apache/maven/scm/provider/git/gitexe/command/checkout/GitCheckOutCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	149

org/apache/maven/scm/provider/git/gitexe/command/diff/GitDiffCommand.java

Violation	Message	Line
	Line is longer than 120 characters.	68
	Expected an @return tag.	82
	Expected @param tag for 'workingDirectory'.	82
	Expected @param tag for 'startVersion'.	82
	Expected @param tag for 'endVersion'.	82
	Expected an @return tag.	111
	Expected @param tag for 'workingDirectory'.	111
	Expected @param tag for 'sha1'.	111

org/apache/maven/scm/provider/git/gitexe/command/diff/GitDiffRawConsumer.java

Violation	Message	Line
	Missing a Javadoc comment.	46
	'(' is not followed by whitespace.	46
	')' is not preceded with whitespace.	46
	Missing a Javadoc comment.	103

org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	65
	Line is longer than 120 characters.	73
	Line is longer than 120 characters.	86

org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoConsumer.java

Violation	Message	Line
	Missing a Javadoc comment.	45
	Expected @param tag for 'line'.	54
	Missing a Javadoc comment.	74

org/apache/maven/scm/provider/git/gitexe/command/list/GitListCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	79

org/apache/maven/scm/provider/git/gitexe/command/list/GitListConsumer.java

Violation	Message	Line
	Expected @param tag for 'logger'.	45
	Expected @param tag for 'workingDirectory'.	45
	Missing a Javadoc comment.	64

org/apache/maven/scm/provider/git/gitexe/command/remoteinfo/GitRemoteInfoCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	68

org/apache/maven/scm/provider/git/gitexe/command/remoteinfo/GitRemoteInfoConsumer.java

Violation	Message	Line
	Missing a Javadoc comment.	59
	Line is longer than 120 characters.	73
	Missing a Javadoc comment.	102

org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	74

org/apache/maven/scm/provider/git/gitexe/command/remove/GitRemoveConsumer.java

Violation	Message	Line
	Missing a Javadoc comment.	58
	Line is longer than 120 characters.	68
	Missing a Javadoc comment.	103

org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	70

org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumer.java

Violation	Message	Line
	Missing a Javadoc comment.	81
	Line is longer than 120 characters.	95
	Missing a Javadoc comment.	165

org/apache/maven/scm/provider/git/gitexe/command/tag/GitTagCommand.java

Violation	Message	Line
	Missing a Javadoc comment.	53
	Line is longer than 120 characters.	60
	'if' is not followed by whitespace.	102
	Line is longer than 120 characters.	110
	Line is longer than 120 characters.	115
	Missing a Javadoc comment.	146
	Line is longer than 120 characters.	160
	Missing a Javadoc comment.	160

org/apache/maven/scm/provider/git/gitexe/command/update/GitLatestRevisionCommandConsumer.java

Violation	Message	Line
	Missing a Javadoc comment.	48
	Line is longer than 120 characters.	58
	Missing a Javadoc comment.	80

org/apache/maven/scm/provider/git/gitexe/command/update/GitUpdateCommand.java

Violation	Message	Line
	Expected an @return tag.	125
	Line is longer than 120 characters.	125
	Expected @param tag for 'repository'.	125
	Expected @param tag for 'workingDirectory'.	125
	Expected @param tag for 'scmVersion'.	125
	Line is longer than 120 characters.	148
	'(' is not followed by whitespace.	148
	Expected @param tag for 'repository'.	148
	Expected @param tag for 'workingDirectory'.	148
	')' is not preceded with whitespace.	149
	'&&' should be on a new line.	159