FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
753500

org.apache.maven.archetype.DefaultArchetypeManager

BugCategoryDetailsLinePriority
org.apache.maven.archetype.DefaultArchetypeManager.zip(File, File) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE93Medium

org.apache.maven.archetype.common.DefaultArchetypeArtifactManager

BugCategoryDetailsLinePriority
org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.getArchetypeJarLoader(File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged blockBAD_PRACTICEDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED108Medium

org.apache.maven.archetype.common.DefaultArchetypeFilesResolver

BugCategoryDetailsLinePriority
Method org.apache.maven.archetype.common.DefaultArchetypeFilesResolver.resolveFiles(File, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION308Medium

org.apache.maven.archetype.common.DefaultPomManager

BugCategoryDetailsLinePriority
Method org.apache.maven.archetype.common.DefaultPomManager.mergeModelBase(ModelBase, ModelBase) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR446Medium
Method org.apache.maven.archetype.common.DefaultPomManager.mergeReportPlugins(Model, Model) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR479Medium

org.apache.maven.archetype.common.MavenJDOMWriter

BugCategoryDetailsLinePriority
Method org.apache.maven.archetype.common.MavenJDOMWriter.findAndReplaceProperties(MavenJDOMWriter$Counter, Element, String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR198Medium

org.apache.maven.archetype.common.MavenJDOMWriter$Counter

BugCategoryDetailsLinePriority
Should org.apache.maven.archetype.common.MavenJDOMWriter$Counter be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC2304-2346Medium

org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy

BugCategoryDetailsLinePriority
new org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy(Format, String) might ignore java.lang.ExceptionBAD_PRACTICEDE_MIGHT_IGNORE500Medium
Exception is caught when Exception is not thrown in new org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy(Format, String)STYLEREC_CATCH_EXCEPTION500Medium
Exception is caught when Exception is not thrown in org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy.shouldEscape(char)STYLEREC_CATCH_EXCEPTION529Medium
Should org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC470-536Medium

org.apache.maven.archetype.common.util.ListScanner

BugCategoryDetailsLinePriority
org.apache.maven.archetype.common.util.ListScanner.DEFAULTEXCLUDES is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY118High

org.apache.maven.archetype.common.util.XMLOutputter$NamespaceStack

BugCategoryDetailsLinePriority
Should org.apache.maven.archetype.common.util.XMLOutputter$NamespaceStack be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1790Medium

org.apache.maven.archetype.creator.FilesetArchetypeCreator

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetype(ArchetypeCreationRequest, ArchetypeCreationResult)STYLEREC_CATCH_EXCEPTION249Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.copyFiles(File, File, String, List, boolean, String) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE816Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetype(ArchetypeCreationRequest, ArchetypeCreationResult) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE132Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeBasicIt(ArchetypeDescriptor, File) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE270Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE892Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE880Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeProjectPom(MavenProject, ArtifactRepository, Properties, File) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE417Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModule(Properties, String, String, String, File, File, List, List, String, boolean, boolean) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE1010Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE1115Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE1103Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.processFileSet(File, File, String, List, boolean, String, Properties, String) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE1326Medium
Method org.apache.maven.archetype.creator.FilesetArchetypeCreator.createFileSets(List, int, boolean, String, boolean, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR985Medium

org.apache.maven.archetype.generator.DefaultArchetypeGenerator

BugCategoryDetailsLinePriority
Possible null pointer dereference of request in org.apache.maven.archetype.generator.DefaultArchetypeGenerator.getArchetypeFile(ArchetypeGenerationRequest, ArtifactRepository)CORRECTNESSNP_NULL_ON_SOME_PATH81Medium

org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator

BugCategoryDetailsLinePriority
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.copyFile(File, String, boolean, ZipFile) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE271Medium
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processFilesetModule(String, String, List, File, ZipFile, String, File, File, String, AbstractArchetypeDescriptor, Context) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE557Medium
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplate(File, Context, String, String, boolean) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE717Medium
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplates(String, File, Context, AbstractArchetypeDescriptor, List, ZipFile, String, boolean) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE777Medium

org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader

BugCategoryDetailsLinePriority
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD153Medium
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getDateValue(String, String, XmlPullParser) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD241Medium

org.apache.maven.archetype.old.DefaultOldArchetype

BugCategoryDetailsLinePriority
org.apache.maven.archetype.old.DefaultOldArchetype.createArchetype(ArchetypeGenerationRequest, File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged blockBAD_PRACTICEDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED178Medium
org.apache.maven.archetype.old.DefaultOldArchetype.processTemplate(String, Context, String, TemplateDescriptor, boolean, String, String) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE835Medium

org.apache.maven.archetype.source.RemoteCatalogArchetypeDataSource

BugCategoryDetailsLinePriority
org.apache.maven.archetype.source.RemoteCatalogArchetypeDataSource.downloadCatalog(String, String) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE126Medium