The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.DefaultArchetypeManager.zip(File, File) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 93 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.getArchetypeJarLoader(File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 108 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.maven.archetype.common.DefaultArchetypeFilesResolver.resolveFiles(File, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 308 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.maven.archetype.common.DefaultPomManager.mergeModelBase(ModelBase, ModelBase) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 446 | Medium |
Method org.apache.maven.archetype.common.DefaultPomManager.mergeReportPlugins(Model, Model) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 479 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.maven.archetype.common.MavenJDOMWriter.findAndReplaceProperties(MavenJDOMWriter$Counter, Element, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 198 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.maven.archetype.common.MavenJDOMWriter$Counter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 2304-2346 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy(Format, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 500 | Medium |
Exception is caught when Exception is not thrown in new org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy(Format, String) | STYLE | REC_CATCH_EXCEPTION | 500 | Medium |
Exception is caught when Exception is not thrown in org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy.shouldEscape(char) | STYLE | REC_CATCH_EXCEPTION | 529 | Medium |
Should org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 470-536 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.common.util.ListScanner.DEFAULTEXCLUDES is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 118 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.maven.archetype.common.util.XMLOutputter$NamespaceStack be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1790 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetype(ArchetypeCreationRequest, ArchetypeCreationResult) | STYLE | REC_CATCH_EXCEPTION | 249 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.copyFiles(File, File, String, List, boolean, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 816 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetype(ArchetypeCreationRequest, ArchetypeCreationResult) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 132 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeBasicIt(ArchetypeDescriptor, File) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 270 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 892 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 880 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeProjectPom(MavenProject, ArtifactRepository, Properties, File) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 417 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModule(Properties, String, String, String, File, File, List, List, String, boolean, boolean) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1010 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1115 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1103 | Medium |
org.apache.maven.archetype.creator.FilesetArchetypeCreator.processFileSet(File, File, String, List, boolean, String, Properties, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1326 | Medium |
Method org.apache.maven.archetype.creator.FilesetArchetypeCreator.createFileSets(List, int, boolean, String, boolean, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 985 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of request in org.apache.maven.archetype.generator.DefaultArchetypeGenerator.getArchetypeFile(ArchetypeGenerationRequest, ArtifactRepository) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.copyFile(File, String, boolean, ZipFile) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 271 | Medium |
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processFilesetModule(String, String, List, File, ZipFile, String, File, File, String, AbstractArchetypeDescriptor, Context) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 557 | Medium |
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplate(File, Context, String, String, boolean) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 717 | Medium |
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplates(String, File, Context, AbstractArchetypeDescriptor, List, ZipFile, String, boolean) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 777 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 153 | Medium |
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getDateValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 241 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.old.DefaultOldArchetype.createArchetype(ArchetypeGenerationRequest, File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 178 | Medium |
org.apache.maven.archetype.old.DefaultOldArchetype.processTemplate(String, Context, String, TemplateDescriptor, boolean, String, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 835 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.archetype.source.RemoteCatalogArchetypeDataSource.downloadCatalog(String, String) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 126 | Medium |