The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
Tag Class | Total number of occurrences | Tag strings used by tag class |
---|---|---|
@todo | 8 | @todo |
TODO | 72 | TODO |
Each tag is detailed below:
Number of occurrences found in the code: 8
org.apache.maven.DefaultArtifactFilterManager | Line |
---|---|
this should probably be a component with some dynamic control of filtering | 38 |
org.apache.maven.artifact.DependencyResolutionRequiredException | Line |
it may be better for artifact.getFile() to throw it - perhaps it is a runtime exception? | 26 |
org.apache.maven.artifact.repository.MavenArtifactRepository | Line |
need to URL decode for spaces? | 237 |
org.apache.maven.artifact.repository.metadata.RepositoryMetadata | Line |
not happy about the store method - they use "this" | 29 |
org.apache.maven.artifact.resolver.filter.ExcludesArtifactFilter | Line |
I think this is equiv. to exclusion set filter in maven-core | 30 |
org.apache.maven.project.DuplicateArtifactAttachmentException | Line |
Make this a checked exception, and modify the API of MavenProjectHelper. Currently, this modification would create compatibility problems for existing plugins. | 30 |
org.apache.maven.project.MavenProject | Line |
I would like to get rid of this. jvz. | 222 |
org.apache.maven.project.artifact.ActiveProjectArtifact | Line |
I think this exposes a design flaw in that the immutable and mutable parts of an artifact are in one class and should be split. ie scope, file, etc depend on the context of use, whereas everything else is immutable. | 41 |
Number of occurrences found in the code: 72
org.apache.maven.AbstractMavenLifecycleParticipant | Line |
---|---|
This is too early for build extensions, so maybe just remove it? | 56 |
org.apache.maven.DefaultArtifactFilterManager | Line |
configure this from bootstrap or scan lib | 110 |
org.apache.maven.artifact.repository.MavenArtifactRepository | Line |
completely separate local and remote artifact repositories | 31 |
org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata | Line |
not sure that it should assume this, maybe the calls to addMetadata should pre-merge, then artifact replaces? | 207 |
not sure that it should assume this, maybe the calls to addMetadata should pre-merge, then artifact replaces? | 214 |
org.apache.maven.artifact.resolver.ResolutionListener | Line |
Use the following two instead of manageArtifact | 85 |
Remove ResolutionListenerDM interface | 86 |
org.apache.maven.artifact.resolver.ResolutionNode | Line |
if it was null, we really need to go find them now... or is this taken care of by the ordering? | 201 |
org.apache.maven.artifact.resolver.filter.IncludesArtifactFilter | Line |
what about wildcards? Just specifying groups? versions? | 52 |
org.apache.maven.execution.DefaultMavenExecutionRequest | Line |
this does not belong here. | 983 |
org.apache.maven.lifecycle.DefaultLifecycleExecutor | Line |
This whole method could probably removed by injecting lifeCyclePluginAnalyzer straight into client site. | 100 |
But for some reason the whole plexus appcontext refuses to start when I try this. | 101 |
org.apache.maven.lifecycle.DefaultLifecycles | Line |
The configuration for the lifecycle needs to be externalized so that I can use the annotations properly for the wiring and reference and external source for the lifecycle configuration. | 43 |
org.apache.maven.lifecycle.MavenExecutionPlan | Line |
lifecycles being executed | 37 |
what runs in each phase | 38 |
plugins that need downloading | 39 |
project dependencies that need downloading | 40 |
unfortunately the plugins need to be downloaded in order to get the plugin.xml file. need to externalize this from the plugin archive. | 41 |
this will be the class that people get in IDEs to modify | 43 |
org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator | Line |
take repo mans into account as one may be aggregating prefixes of many | 579 |
collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue | 580 |
org.apache.maven.lifecycle.internal.DependencyContext | Line |
From a concurrency perspective, this class is not good. The combination of mutable/immutable state is not nice | 38 |
org.apache.maven.lifecycle.internal.GoalTask | Line |
From a concurrecy perspective, this class is not good. The combination of mutable/immutable state is not nice | 25 |
org.apache.maven.lifecycle.internal.MojoDescriptorCreator | Line |
take repo mans into account as one may be aggregating prefixes of many | 237 |
collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue | 238 |
org.apache.maven.lifecycle.internal.ProjectBuildList | Line |
Optimize; or maybe just rewrite the whole way aggregating mojos are being run. | 54 |
org.apache.maven.lifecycle.internal.TaskSegment | Line |
Consider throwing UnsupprtedSomething on hashCode/equals | 72 |
org.apache.maven.plugin.DefaultBuildPluginManager | Line |
the antrun plugin has its own configurator, the only plugin that does. might need to think about how that works | 40 |
remove the coreArtifactFilterManager | 41 |
pluginDescriptor classRealm and artifacts are set as a side effect of this call, which is not nice. | 216 |
org.apache.maven.plugin.PluginManagerTest | Line |
These two tests display a lack of symmetry with respect to the input which is a free form string and the mojo descriptor which comes back. All the free form parsing needs to be done somewhere else, this is really the function of the CLI, and then the pre-processing of that output still needs to be fed into a hinting process which helps flesh out the full specification of the plugin. The plugin manager should only deal in concrete terms -- all version finding mumbo jumbo is a customization to base functionality the plugin manager provides. | 105 |
turn an equivalent back on when the RR plugin is released. | 115 |
this will be the basis of the customizable lifecycle execution so need to figure this out quickly. | 140 |
org.apache.maven.plugin.PluginParameterExpressionEvaluator | Line |
used by the Enforcer plugin | 78 |
don't catch exception | 214 |
don't catch exception | 254 |
don't catch exception | 286 |
don't catch exception | 343 |
without #, this could just be an evaluate call... | 398 |
Copied from the DefaultInterpolator. We likely want to resurrect the PathTranslator or at least a similar component for re-usage | 442 |
org.apache.maven.plugin.PluginParameterExpressionEvaluatorTest | Line |
Auto-generated method stub | 443 |
org.apache.maven.plugin.internal.DefaultMavenPluginManager | Line |
could the configuration be passed to lookup and the configurator known to plexus via the descriptor so that this method could entirely be handled by a plexus lookup? | 563 |
org.apache.maven.project.MavenProject | Line |
let the scope handler deal with this | 350 |
this checking for file == null happens because the resolver has been confused about the root artifact or not. things like the stupid dummy artifact coming from surefire. | 362 |
let the scope handler deal with this | 406 |
this should not be allowed to be null. | 468 |
classpath check doesn't belong here - that's the other method | 1569 |
let the scope handler deal with this | 1572 |
let the scope handler deal with this | 1597 |
classpath check doesn't belong here - that's the other method | 1623 |
let the scope handler deal with this | 1674 |
classpath check doesn't belong here - that's the other method | 1699 |
let the scope handler deal with this | 1701 |
let the scope handler deal with this | 1726 |
classpath check doesn't belong here - that's the other method | 1743 |
let the scope handler deal with this | 1746 |
let the scope handler deal with this | 1770 |
org.apache.maven.project.ProjectSorter | Line |
!![jc; 28-jul-2005] check this; if we're using '-r' and there are aggregator tasks, this will result in weirdness. | 236 |
org.apache.maven.project.artifact.MavenMetadataSource | Line |
This prevents a cycle in the composition which shows us another problem we need to deal with. | 96 |
Not even sure this is really required as the project will be cached in the builder, we'll see this is currently the biggest hotspot | 178 |
shouldn't the versions be merged across relocations? | 661 |
org.apache.maven.project.artifact.MavenMetadataSourceTest | Line |
restore these if it makes sense | 93 |
org.apache.maven.repository.TestRepositoryConnector | Line |
Auto-generated method stub | 119 |
org.apache.maven.repository.TestRepositorySystem | Line |
Auto-generated method stub | 193 |
Auto-generated method stub | 313 |
org.apache.maven.settings.DefaultMavenSettingsBuilder | Line |
This replacing shouldn't be necessary as user.home should be in the context of the container and thus the value would be interpolated by Plexus | 130 |
org.apache.maven.settings.SettingsUtilsTest | Line |
deep compare the lists | 121 |
deep compare the lists | 123 |
org.apache.maven.toolchain.DefaultToolchainManager | Line |
why is this using the context | 90 |
org.apache.maven.toolchain.RequirementMatcherFactory | Line |
error reporting | 90 |
org.apache.maven.toolchain.ToolchainFactory | Line |
keep around?? */ | 39 |
org.apache.maven.toolchain.java.DefaultJavaToolchainFactory | Line |
possibly move at least parts to a utility method or abstract implementation. | 78 |