The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.plugin.announcement.AnnouncementMailMojo.readAnnouncement(File): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 325 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.announcement.AnnouncementMojo.processTemplate(Context, File, String, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 602 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugin.announcement.mailsender.ProjectJavamailMailSender.userProperties | CORRECTNESS | UWF_UNWRITTEN_FIELD | 107 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.changes.AbstractChangesReport.execute() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 182 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.maven.plugin.changes.ChangesCheckMojo.releaseUtils | PERFORMANCE | URF_UNREAD_FIELD | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.changes.ChangesMojo.getChangesFromFile(File, MavenProject, Properties) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 365 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.changes.ChangesReportGenerator.constructDueTo(Sink, Action, ResourceBundle, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 333 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.maven.plugin.changes.ChangesXML(File, Log) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 65 | Medium |
| Redundant nullcheck of org.apache.maven.plugin.changes.ChangesXML.changesDocument, which is known to be non-null in new org.apache.maven.plugin.changes.ChangesXML(File, Log) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugin.changes.HelpMojo.goal | CORRECTNESS | UWF_UNWRITTEN_FIELD | 129 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.github.GitHubMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.issues.Issue.getCreated() may expose internal representation by returning Issue.created | MALICIOUS_CODE | EI_EXPOSE_REP | 113 | Medium |
| org.apache.maven.plugin.issues.Issue.getUpdated() may expose internal representation by returning Issue.updated | MALICIOUS_CODE | EI_EXPOSE_REP | 237 | Medium |
| org.apache.maven.plugin.issues.Issue.setCreated(Date) may expose internal representation by storing an externally mutable object into Issue.created | MALICIOUS_CODE | EI_EXPOSE_REP2 | 118 | Medium |
| org.apache.maven.plugin.issues.Issue.setUpdated(Date) may expose internal representation by storing an externally mutable object into Issue.updated | MALICIOUS_CODE | EI_EXPOSE_REP2 | 242 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.maven.plugin.issues.IssuesReportGenerator(int[]) may expose internal representation by storing an externally mutable object into IssuesReportGenerator.columns | MALICIOUS_CODE | EI_EXPOSE_REP2 | 55 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.jira.AbstractJiraDownloader.download(HttpClient, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 554 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.jira.JiraHelper.validateNonProxyHosts(ProxyInfo, String) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.jira.JiraMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 59 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.trac.TracDownloader.getIssueList() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 121 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.trac.TracMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 62 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.addDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueTo | STYLE | BC_VACUOUS_INSTANCEOF | 142 | Medium |
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.addFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssue | STYLE | BC_VACUOUS_INSTANCEOF | 156 | Medium |
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.removeDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueTo | STYLE | BC_VACUOUS_INSTANCEOF | 309 | Medium |
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.removeFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssue | STYLE | BC_VACUOUS_INSTANCEOF | 323 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Body.addRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.Release | STYLE | BC_VACUOUS_INSTANCEOF | 40 | Medium |
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Body.removeRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.Release | STYLE | BC_VACUOUS_INSTANCEOF | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Component.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 56 | Medium |
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Component.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 105 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Release.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 65 | Medium |
| instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Release.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 126 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseBody(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 577 | High |
| Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseDueTo(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 737 | High |
| Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseFixedIssue(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 771 | High |
| Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseRelease(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 854 | High |
| Redundant nullcheck of dueTos, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseAction(String, XmlPullParser, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 498 | Medium |
| Redundant nullcheck of fixedIssues, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseAction(String, XmlPullParser, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 488 | Medium |
| Redundant nullcheck of releases, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseBody(String, XmlPullParser, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 583 | Medium |
| Redundant nullcheck of actions, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseRelease(String, XmlPullParser, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 860 | Medium |
| Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 109 | Medium |
| Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getDateValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 197 | Medium |