The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unwritten field: org.apache.maven.plugin.announcement.AnnouncementMailMojo.mailContentType | CORRECTNESS | UWF_UNWRITTEN_FIELD | 283 | Medium |
Unwritten field: org.apache.maven.plugin.announcement.AnnouncementMailMojo.senderString | CORRECTNESS | UWF_UNWRITTEN_FIELD | 366 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.plugin.announcement.AnnouncementMojo.processTemplate(Context, File, String, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 630 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unwritten field: org.apache.maven.plugin.announcement.mailsender.ProjectJavamailMailSender.userProperties | CORRECTNESS | UWF_UNWRITTEN_FIELD | 107 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.plugin.changes.AbstractChangesReport.execute() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 189 | Medium |
Unwritten field: org.apache.maven.plugin.changes.AbstractChangesReport.outputDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 184 | Medium |
Unwritten field: org.apache.maven.plugin.changes.AbstractChangesReport.outputEncoding | CORRECTNESS | UWF_UNWRITTEN_FIELD | 236 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Read of unwritten field version in org.apache.maven.plugin.changes.ChangesCheckMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 85 | Medium |
Read of unwritten field xmlPath in org.apache.maven.plugin.changes.ChangesCheckMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 89 | Medium |
Unread field: org.apache.maven.plugin.changes.ChangesCheckMojo.releaseUtils | PERFORMANCE | URF_UNREAD_FIELD | 75 | Medium |
Unwritten field: org.apache.maven.plugin.changes.ChangesCheckMojo.releaseDateFormat | CORRECTNESS | UWF_UNWRITTEN_FIELD | 96 | Medium |
Unwritten field: org.apache.maven.plugin.changes.ChangesCheckMojo.version | CORRECTNESS | UWF_UNWRITTEN_FIELD | 85 | Medium |
Unwritten field: org.apache.maven.plugin.changes.ChangesCheckMojo.xmlPath | CORRECTNESS | UWF_UNWRITTEN_FIELD | 89 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.plugin.changes.ChangesMojo.getChangesFromFile(File, MavenProject, Properties) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 369 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.maven.plugin.changes.ChangesReportGenerator.constructDueTo(Sink, Action, ResourceBundle, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 333 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Read of unwritten field changesSchemaValidator in org.apache.maven.plugin.changes.ChangesValidatorMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 89 | Medium |
Read of unwritten field xmlPath in org.apache.maven.plugin.changes.ChangesValidatorMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 81 | Medium |
Read of unwritten field xmlPath in org.apache.maven.plugin.changes.ChangesValidatorMojo.logSchemaValidation(List) | CORRECTNESS | NP_UNWRITTEN_FIELD | 118 | Medium |
Unwritten field: org.apache.maven.plugin.changes.ChangesValidatorMojo.changesSchemaValidator | CORRECTNESS | UWF_UNWRITTEN_FIELD | 89 | Medium |
Unwritten field: org.apache.maven.plugin.changes.ChangesValidatorMojo.changesXsdVersion | CORRECTNESS | UWF_UNWRITTEN_FIELD | 89 | Medium |
Unwritten field: org.apache.maven.plugin.changes.ChangesValidatorMojo.xmlPath | CORRECTNESS | UWF_UNWRITTEN_FIELD | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new org.apache.maven.plugin.changes.ChangesXML(File, Log) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 65 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unwritten field: org.apache.maven.plugin.changes.HelpMojo.goal | CORRECTNESS | UWF_UNWRITTEN_FIELD | 76 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.plugin.issues.Issue.getCreated() may expose internal representation by returning Issue.created | MALICIOUS_CODE | EI_EXPOSE_REP | 113 | Medium |
org.apache.maven.plugin.issues.Issue.getUpdated() may expose internal representation by returning Issue.updated | MALICIOUS_CODE | EI_EXPOSE_REP | 237 | Medium |
org.apache.maven.plugin.issues.Issue.setCreated(Date) may expose internal representation by storing an externally mutable object into Issue.created | MALICIOUS_CODE | EI_EXPOSE_REP2 | 118 | Medium |
org.apache.maven.plugin.issues.Issue.setUpdated(Date) may expose internal representation by storing an externally mutable object into Issue.updated | MALICIOUS_CODE | EI_EXPOSE_REP2 | 242 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.apache.maven.plugin.issues.IssuesReportGenerator(int[]) may expose internal representation by storing an externally mutable object into IssuesReportGenerator.columns | MALICIOUS_CODE | EI_EXPOSE_REP2 | 55 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.plugin.jira.AbstractJiraDownloader.download(HttpClient, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 701 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.plugin.jira.JiraHelper.validateNonProxyHosts(ProxyInfo, String) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 163 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.maven.plugin.jira.JiraMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 57 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.plugin.trac.TracDownloader.getIssueList() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 121 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.maven.plugin.trac.TracMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 61 | Medium |
Unwritten field: org.apache.maven.plugin.trac.TracMojo.columnNames | CORRECTNESS | UWF_UNWRITTEN_FIELD | 144 | Medium |
Unwritten field: org.apache.maven.plugin.trac.TracMojo.query | CORRECTNESS | UWF_UNWRITTEN_FIELD | 218 | Medium |
Unwritten field: org.apache.maven.plugin.trac.TracMojo.tracPassword | CORRECTNESS | UWF_UNWRITTEN_FIELD | 220 | Medium |
Unwritten field: org.apache.maven.plugin.trac.TracMojo.tracUser | CORRECTNESS | UWF_UNWRITTEN_FIELD | 222 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.maven.plugins.changes.model.Action.addDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueTo | STYLE | BC_VACUOUS_INSTANCEOF | 142 | Medium |
instanceof will always return true in org.apache.maven.plugins.changes.model.Action.addFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssue | STYLE | BC_VACUOUS_INSTANCEOF | 156 | Medium |
instanceof will always return true in org.apache.maven.plugins.changes.model.Action.removeDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueTo | STYLE | BC_VACUOUS_INSTANCEOF | 309 | Medium |
instanceof will always return true in org.apache.maven.plugins.changes.model.Action.removeFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssue | STYLE | BC_VACUOUS_INSTANCEOF | 323 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.maven.plugins.changes.model.Body.addRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.Release | STYLE | BC_VACUOUS_INSTANCEOF | 40 | Medium |
instanceof will always return true in org.apache.maven.plugins.changes.model.Body.removeRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.Release | STYLE | BC_VACUOUS_INSTANCEOF | 69 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.maven.plugins.changes.model.Component.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 56 | Medium |
instanceof will always return true in org.apache.maven.plugins.changes.model.Component.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 105 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.maven.plugins.changes.model.Release.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 65 | Medium |
instanceof will always return true in org.apache.maven.plugins.changes.model.Release.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action | STYLE | BC_VACUOUS_INSTANCEOF | 126 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseBody(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 577 | High |
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseDueTo(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 737 | High |
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseFixedIssue(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 771 | High |
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseRelease(String, XmlPullParser, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 854 | High |
Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 109 | Medium |
Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getDateValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 197 | Medium |