FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.2

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
61 35 0 0

Files

Class Bugs
org.apache.maven.plugin.announcement.AnnouncementMojo 1
org.apache.maven.plugin.announcement.mailsender.ProjectJavamailMailSender 1
org.apache.maven.plugin.changes.AbstractChangesReport 1
org.apache.maven.plugin.changes.ChangesCheckMojo 1
org.apache.maven.plugin.changes.ChangesMojo 2
org.apache.maven.plugin.changes.ChangesReportGenerator 1
org.apache.maven.plugin.changes.ChangesXML 1
org.apache.maven.plugin.changes.HelpMojo 1
org.apache.maven.plugin.issues.Issue 4
org.apache.maven.plugin.issues.IssuesReportGenerator 1
org.apache.maven.plugin.jira.ClassicJiraDownloader 1
org.apache.maven.plugins.changes.model.Action 4
org.apache.maven.plugins.changes.model.Body 2
org.apache.maven.plugins.changes.model.Component 2
org.apache.maven.plugins.changes.model.Release 2
org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader 10

org.apache.maven.plugin.announcement.AnnouncementMojo

Bug Category Details Line Priority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.announcement.AnnouncementMojo.processTemplate(Context, File, String, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 693 Medium

org.apache.maven.plugin.announcement.mailsender.ProjectJavamailMailSender

Bug Category Details Line Priority
Unwritten field: org.apache.maven.plugin.announcement.mailsender.ProjectJavamailMailSender.userProperties CORRECTNESS UWF_UNWRITTEN_FIELD 112 Medium

org.apache.maven.plugin.changes.AbstractChangesReport

Bug Category Details Line Priority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.changes.AbstractChangesReport.execute() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 209 Medium

org.apache.maven.plugin.changes.ChangesCheckMojo

Bug Category Details Line Priority
Unread field: org.apache.maven.plugin.changes.ChangesCheckMojo.releaseUtils PERFORMANCE URF_UNREAD_FIELD 81 Medium

org.apache.maven.plugin.changes.ChangesMojo

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.plugin.changes.ChangesMojo.generateFeed(ChangesXML, Locale): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 532 High
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.changes.ChangesMojo.getChangesFromFile(File, MavenProject, Properties) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 404 Medium

org.apache.maven.plugin.changes.ChangesReportGenerator

Bug Category Details Line Priority
org.apache.maven.plugin.changes.ChangesReportGenerator.constructDueTo(Sink, Action, ResourceBundle, List) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 348 Medium

org.apache.maven.plugin.changes.ChangesXML

Bug Category Details Line Priority
Redundant nullcheck of org.apache.maven.plugin.changes.ChangesXML.changesDocument, which is known to be non-null in new org.apache.maven.plugin.changes.ChangesXML(File, Log) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 71 Medium

org.apache.maven.plugin.changes.HelpMojo

Bug Category Details Line Priority
org.apache.maven.plugin.changes.HelpMojo.build() may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 68 Medium

org.apache.maven.plugin.issues.Issue

Bug Category Details Line Priority
org.apache.maven.plugin.issues.Issue.getCreated() may expose internal representation by returning Issue.created MALICIOUS_CODE EI_EXPOSE_REP 113 Medium
org.apache.maven.plugin.issues.Issue.getUpdated() may expose internal representation by returning Issue.updated MALICIOUS_CODE EI_EXPOSE_REP 237 Medium
org.apache.maven.plugin.issues.Issue.setCreated(Date) may expose internal representation by storing an externally mutable object into Issue.created MALICIOUS_CODE EI_EXPOSE_REP2 118 Medium
org.apache.maven.plugin.issues.Issue.setUpdated(Date) may expose internal representation by storing an externally mutable object into Issue.updated MALICIOUS_CODE EI_EXPOSE_REP2 242 Medium

org.apache.maven.plugin.issues.IssuesReportGenerator

Bug Category Details Line Priority
new org.apache.maven.plugin.issues.IssuesReportGenerator(int[]) may expose internal representation by storing an externally mutable object into IssuesReportGenerator.columns MALICIOUS_CODE EI_EXPOSE_REP2 55 Medium

org.apache.maven.plugin.jira.ClassicJiraDownloader

Bug Category Details Line Priority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.jira.ClassicJiraDownloader.download(HttpClient, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 404 Medium

org.apache.maven.plugins.changes.model.Action

Bug Category Details Line Priority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.addDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueTo STYLE BC_VACUOUS_INSTANCEOF 141 Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.addFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssue STYLE BC_VACUOUS_INSTANCEOF 155 Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.removeDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueTo STYLE BC_VACUOUS_INSTANCEOF 308 Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.removeFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssue STYLE BC_VACUOUS_INSTANCEOF 322 Medium

org.apache.maven.plugins.changes.model.Body

Bug Category Details Line Priority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Body.addRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.Release STYLE BC_VACUOUS_INSTANCEOF 40 Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Body.removeRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.Release STYLE BC_VACUOUS_INSTANCEOF 69 Medium

org.apache.maven.plugins.changes.model.Component

Bug Category Details Line Priority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Component.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action STYLE BC_VACUOUS_INSTANCEOF 56 Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Component.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action STYLE BC_VACUOUS_INSTANCEOF 105 Medium

org.apache.maven.plugins.changes.model.Release

Bug Category Details Line Priority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Release.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action STYLE BC_VACUOUS_INSTANCEOF 66 Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Release.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.Action STYLE BC_VACUOUS_INSTANCEOF 128 Medium

org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader

Bug Category Details Line Priority
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseBody(String, XmlPullParser, boolean) STYLE DLS_DEAD_LOCAL_STORE 577 High
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseDueTo(String, XmlPullParser, boolean) STYLE DLS_DEAD_LOCAL_STORE 737 High
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseFixedIssue(String, XmlPullParser, boolean) STYLE DLS_DEAD_LOCAL_STORE 771 High
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseRelease(String, XmlPullParser, boolean) STYLE DLS_DEAD_LOCAL_STORE 854 High
Redundant nullcheck of dueTos, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseAction(String, XmlPullParser, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 498 Medium
Redundant nullcheck of fixedIssues, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseAction(String, XmlPullParser, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 488 Medium
Redundant nullcheck of releases, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseBody(String, XmlPullParser, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 583 Medium
Redundant nullcheck of actions, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseRelease(String, XmlPullParser, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 860 Medium
Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 109 Medium
Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getDateValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 197 Medium