The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.apache.maven.shared.release.DefaultReleaseManager.scmRepositoryConfigurator | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.shared.release.ReleaseResult.getStackTrace(Exception): java.io.ByteArrayOutputStream.toString() | I18N | DM_DEFAULT_ENCODING | 133 | High |
| Found reliance on default encoding in org.apache.maven.shared.release.ReleaseResult.getStackTrace(Exception): new java.io.PrintStream(OutputStream) | I18N | DM_DEFAULT_ENCODING | 127 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field secDispatcher in org.apache.maven.shared.release.config.PropertiesReleaseDescriptorStore.encryptAndDecorate(String) | CORRECTNESS | NP_UNWRITTEN_FIELD | 343 | Medium |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.config.PropertiesReleaseDescriptorStore.delete(ReleaseDescriptor) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 125 | Medium |
| Unwritten field: org.apache.maven.shared.release.config.PropertiesReleaseDescriptorStore.secDispatcher | CORRECTNESS | UWF_UNWRITTEN_FIELD | 343 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of ReleaseDescriptor.resolvedSnapshotDependencies in org.apache.maven.shared.release.config.ReleaseDescriptor.getDependencyDevelopmentVersion(String) | CORRECTNESS | NP_ALWAYS_NULL | 1741 | High |
| Null pointer dereference of ReleaseDescriptor.resolvedSnapshotDependencies in org.apache.maven.shared.release.config.ReleaseDescriptor.getDependencyReleaseVersion(String) | CORRECTNESS | NP_ALWAYS_NULL | 1755 | High |
| Possible null pointer dereference of that on branch that might be infeasible in org.apache.maven.shared.release.config.ReleaseDescriptor.compareScmCollections(Map) | STYLE | NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE | 1958 | Medium |
| Redundant nullcheck of org.apache.maven.shared.release.config.ReleaseDescriptor.checkModificationExcludes, which is known to be non-null in org.apache.maven.shared.release.config.ReleaseDescriptor.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1831 | Medium |
| Redundant nullcheck of org.apache.maven.shared.release.config.ReleaseDescriptor.developmentVersions, which is known to be non-null in org.apache.maven.shared.release.config.ReleaseDescriptor.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1844 | Medium |
| Redundant nullcheck of org.apache.maven.shared.release.config.ReleaseDescriptor.originalScmInfo, which is known to be non-null in org.apache.maven.shared.release.config.ReleaseDescriptor.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1857 | Medium |
| Redundant nullcheck of org.apache.maven.shared.release.config.ReleaseDescriptor.releaseVersions, which is known to be non-null in org.apache.maven.shared.release.config.ReleaseDescriptor.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1869 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to versionMap in org.apache.maven.shared.release.config.ReleaseUtils.loadResolvedDependencies(Properties, ReleaseDescriptor) | STYLE | DLS_DEAD_LOCAL_STORE | 243 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 151 | Medium |
| Private method org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Reader.getDateValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 239 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.shared.release.exec.AbstractMavenExecutor.cipher | CORRECTNESS | UWF_UNWRITTEN_FIELD | 238 | Medium |
| Unwritten field: org.apache.maven.shared.release.exec.AbstractMavenExecutor.secDispatcher | CORRECTNESS | UWF_UNWRITTEN_FIELD | 209 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.shared.release.exec.ForkedMavenExecutor.executeGoals(File, List, ReleaseEnvironment, boolean, String, String, ReleaseResult): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 84 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.shared.release.exec.InvokerMavenExecutor.executeGoals(File, List, ReleaseEnvironment, boolean, String, String, ReleaseResult): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 357 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in new org.apache.maven.shared.release.exec.TeeOutputStream(OutputStream, String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 42 | High |
| Found reliance on default encoding in org.apache.maven.shared.release.exec.TeeOutputStream.getContent(): java.io.ByteArrayOutputStream.toString() | I18N | DM_DEFAULT_ENCODING | 85 | High |
| Found reliance on default encoding in org.apache.maven.shared.release.exec.TeeOutputStream.toString(): java.io.ByteArrayOutputStream.toString() | I18N | DM_DEFAULT_ENCODING | 80 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.phase.AbstractBackupPomsPhase.deletePomBackup(MavenProject) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 55 | Medium |
| Unread field: org.apache.maven.shared.release.phase.AbstractBackupPomsPhase.backupSuffix; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 33 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.clean(List) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 722 | Medium |
| Unwritten field: org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.pomSuffix | CORRECTNESS | UWF_UNWRITTEN_FIELD | 236 | Medium |
| Unwritten field: org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.scmTranslators | CORRECTNESS | UWF_UNWRITTEN_FIELD | 95 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: org.apache.maven.shared.release.phase.AbstractScmCommitPhase.afterBranchOrTag | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 58 | Medium |
| Unread public/protected field: org.apache.maven.shared.release.phase.AbstractScmCommitPhase.beforeBranchOrTag | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 56 | Medium |
| Unwritten public or protected field: org.apache.maven.shared.release.phase.AbstractScmCommitPhase.messageFormat | STYLE | UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD | 191 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.apache.maven.shared.release.phase.CheckDependencySnapshotsPhase.resolveSnapshots(Set, Set, Set, Set, ReleaseDescriptor) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 377-404 | Medium |
| Unwritten field: org.apache.maven.shared.release.phase.CheckDependencySnapshotsPhase.artifactFactory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 136 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.release.phase.CheckoutProjectFromScm.performCheckout(ReleaseDescriptor, ReleaseEnvironment, List) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 210 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field pathTranslator in org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel(MavenProject, ReleaseDescriptor, ReleaseEnvironment, List, ReleaseResult) | CORRECTNESS | NP_UNWRITTEN_FIELD | 294 | Medium |
| Read of unwritten field scmTranslators in org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.getScmTranslator(ScmRepository) | CORRECTNESS | NP_UNWRITTEN_FIELD | 353 | Medium |
| Unwritten field: org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.pathTranslator | CORRECTNESS | UWF_UNWRITTEN_FIELD | 294 | Medium |
| Unwritten field: org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.scmTranslators | CORRECTNESS | UWF_UNWRITTEN_FIELD | 353 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.phase.RemoveReleasePomsPhase.removeReleasePomsFromFilesystem(boolean, ReleaseResult, List) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 117 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field scmTranslators in org.apache.maven.shared.release.phase.ScmCheckModificationsPhase.execute(ReleaseDescriptor, ReleaseEnvironment, List) | CORRECTNESS | NP_UNWRITTEN_FIELD | 144 | Medium |
| Unwritten field: org.apache.maven.shared.release.phase.ScmCheckModificationsPhase.scmTranslators | CORRECTNESS | UWF_UNWRITTEN_FIELD | 144 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.shared.release.phase.ScmCommitDevelopmentPhase.rollbackMessageFormat | CORRECTNESS | UWF_UNWRITTEN_FIELD | 98 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.shared.release.phase.ScmCommitPreparationPhase.rollbackMessageFormat | CORRECTNESS | UWF_UNWRITTEN_FIELD | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field secDispatcher in org.apache.maven.shared.release.scm.DefaultScmRepositoryConfigurator.decrypt(String, String) | CORRECTNESS | NP_UNWRITTEN_FIELD | 182 | Medium |
| Unwritten field: org.apache.maven.shared.release.scm.DefaultScmRepositoryConfigurator.secDispatcher | CORRECTNESS | UWF_UNWRITTEN_FIELD | 182 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.shared.release.versions.DefaultVersionInfo defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 254-259 | High |