XBean :: Telnet - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
19	0	0	353

Rules

Rules	Violations	Severity
PackageHtml	3	Error
NewlineAtEndOfFile	14	Error
Translation	0	Error
JavadocMethod	78	Error
JavadocType	15	Error
JavadocVariable	43	Error
JavadocStyle	3	Error
ConstantName	33	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	1	Error
MethodName	1	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	1	Error
TypeName	0	Error
Header headerFile: `"c:\java\geronimo\xbean\tags\xbean-2.6\xbean-telnet\target\checkstyle-header.txt"`	16	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
FileLength	0	Error
LineLength max: `"120"`	1	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	0	Error
ParenPad	4	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	0	Error
WhitespaceAround	10	Error
ModifierOrder	0	Error
RedundantModifier	17	Error
AvoidNestedBlocks	0	Error
EmptyBlock	10	Error
LeftCurly	0	Error
NeedBraces	8	Error
RightCurly	0	Error
AvoidInlineConditionals	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	1	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	2	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	7	Error
MissingSwitchDefault	1	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	2	Error
InterfaceIsType	1	Error
VisibilityModifier	0	Error
ArrayTypeStyle	1	Error
FinalParameters	67	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	7	Error
TodoComment	6	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/xbean/command/CommandShell.java	0	0	78
org/apache/xbean/command/Test.java	0	0	9
org/apache/xbean/terminal/telnet/TelnetDaemon.java	0	0	22
org/apache/xbean/command/CommandRegistry.java	0	0	24
org/apache/xbean/terminal/console/Main.java	0	0	6
org/apache/xbean/terminal/telnet/TelnetPrintStream.java	0	0	27
org/apache/xbean/command/Command.java	0	0	10
org/apache/xbean/command/GroovySh.java	0	0	8
org/apache/xbean/terminal/telnet/TelnetShell.java	0	0	15
org/apache/xbean/terminal/telnet/TelnetCodes.java	0	0	29
org/apache/xbean/terminal/telnet/TelnetInputStream.java	0	0	50
org/apache/xbean/command/package.html	0	0	1
org/apache/xbean/command/Lookup.java	0	0	22
org/apache/xbean/terminal/telnet/TelnetOption.java	0	0	22
org/apache/xbean/terminal/telnet/package.html	0	0	1
org/apache/xbean/command/Exit.java	0	0	9
org/apache/xbean/terminal/console/package.html	0	0	1
org/apache/xbean/command/Version.java	0	0	10
org/apache/xbean/command/Help.java	0	0	9

Details

org/apache/xbean/command/CommandShell.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	31
	Parameter serverName should be final.	31
	'+' is not preceded with whitespace.	33
	'+' is not followed by whitespace.	33
	'+' is not preceded with whitespace.	33
	'+' is not followed by whitespace.	33
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Name 'TTY_Reset' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	40
	Missing a Javadoc comment.	41
	Name 'TTY_Bright' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	41
	Missing a Javadoc comment.	42
	Name 'TTY_Dim' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	42
	Missing a Javadoc comment.	43
	Name 'TTY_Underscore' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	43
	Missing a Javadoc comment.	44
	Name 'TTY_Blink' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	44
	Missing a Javadoc comment.	45
	Name 'TTY_Reverse' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	45
	Missing a Javadoc comment.	46
	Name 'TTY_Hidden' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	46
	Missing a Javadoc comment.	48
	Name 'TTY_FG_Black' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	48
	Missing a Javadoc comment.	49
	Name 'TTY_FG_Red' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	49
	Missing a Javadoc comment.	50
	Name 'TTY_FG_Green' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	50
	Missing a Javadoc comment.	51
	Name 'TTY_FG_Yellow' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	51
	Missing a Javadoc comment.	52
	Name 'TTY_FG_Blue' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	52
	Missing a Javadoc comment.	53
	Name 'TTY_FG_Magenta' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	53
	Missing a Javadoc comment.	54
	Name 'TTY_FG_Cyan' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	54
	Missing a Javadoc comment.	55
	Name 'TTY_FG_White' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	55
	Missing a Javadoc comment.	57
	Name 'TTY_BG_Black' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	57
	Missing a Javadoc comment.	58
	Name 'TTY_BG_Red' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	58
	Missing a Javadoc comment.	59
	Name 'TTY_BG_Green' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	59
	Missing a Javadoc comment.	60
	Name 'TTY_BG_Yellow' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	60
	Missing a Javadoc comment.	61
	Name 'TTY_BG_Blue' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	61
	Missing a Javadoc comment.	62
	Name 'TTY_BG_Magenta' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	62
	Missing a Javadoc comment.	63
	Name 'TTY_BG_Cyan' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	63
	Missing a Javadoc comment.	64
	Name 'TTY_BG_White' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	64
	Missing a Javadoc comment.	66
	Parameter args should be final.	66
	Parameter input should be final.	66
	Parameter out should be final.	66
	Missing a Javadoc comment.	75
	Parameter in should be final.	75
	Parameter out should be final.	75
	'if' is not followed by whitespace.	81
	'(' is followed by whitespace.	81
	')' is preceded with whitespace.	81
	'(' is followed by whitespace.	97
	')' is preceded with whitespace.	97
	'=' is not preceded with whitespace.	112
	'=' is not followed by whitespace.	112
	'=' is not preceded with whitespace.	116
	'=' is not followed by whitespace.	116
	Missing a Javadoc comment.	121
	Parameter in should be final.	121
	Parameter out should be final.	121

org/apache/xbean/command/Test.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	27
	Missing a Javadoc comment.	28
	Name '_DONT_register' must match pattern '^[a-z][a-zA-Z0-9]*$'.	28
	Missing a Javadoc comment.	32
	Parameter args should be final.	32
	Parameter in should be final.	32
	Parameter out should be final.	32

org/apache/xbean/terminal/telnet/TelnetDaemon.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	35
	Parameter serverName should be final.	35
	Parameter port should be final.	35
	Missing a Javadoc comment.	40
	'if' construct must use '{}'s.	43
	'20' is a magic number.	50
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	75
	Must have at least one statement.	80
	Must have at least one statement.	81
	'if' construct must use '{}'s.	84
	Must have at least one statement.	86
	Missing a Javadoc comment.	95
	'if' construct must use '{}'s.	103
	Must have at least one statement.	104
	Must have at least one statement.	105

org/apache/xbean/command/CommandRegistry.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	23
	Utility classes should not have a public or default constructor.	23
	Line has trailing spaces.	24
	Missing a Javadoc comment.	25
	Name 'commands' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	25
	Missing a Javadoc comment.	31
	Name 'unknownCommand' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	31
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	43
	Parameter name should be final.	43
	Parameter cmd should be final.	43
	Missing a Javadoc comment.	47
	Parameter name should be final.	47
	Parameter cmd should be final.	47
	Missing a Javadoc comment.	51
	Parameter name should be final.	51
	Missing a Javadoc comment.	62
	Parameter commandClass should be final.	62
	Must have at least one statement.	66
	Line is longer than 120 characters.	67
	First sentence should end with a period.	72
	Comment matches to-do format 'TODO:'.	73

org/apache/xbean/terminal/console/Main.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	21
	Utility classes should not have a public or default constructor.	21
	Missing a Javadoc comment.	23
	Parameter args should be final.	23

org/apache/xbean/terminal/telnet/TelnetPrintStream.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	23
	Name 'CRLF' must match pattern '^[a-z][a-zA-Z0-9]*$'.	23
	Missing a Javadoc comment.	25
	Parameter out should be final.	25
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	33
	Parameter x should be final.	33
	Missing a Javadoc comment.	40
	Parameter x should be final.	40
	Missing a Javadoc comment.	47
	Parameter x should be final.	47
	Missing a Javadoc comment.	54
	Parameter x should be final.	54
	Missing a Javadoc comment.	61
	Parameter x should be final.	61
	Missing a Javadoc comment.	68
	Parameter x should be final.	68
	Missing a Javadoc comment.	75
	Parameter x should be final.	75
	Missing a Javadoc comment.	82
	Parameter x should be final.	82
	Array brackets at illegal position.	82
	Missing a Javadoc comment.	89
	Must have at least one statement.	92

org/apache/xbean/command/Command.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	22
	Line has trailing spaces.	26
	Line has trailing spaces.	28
	Expected an @return tag.	34
	Redundant 'public' modifier.	34
	Expected @param tag for 'args'.	34
	Expected @param tag for 'in'.	34
	Expected @param tag for 'out'.	34

org/apache/xbean/command/GroovySh.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	33
	Parameter args should be final.	33
	Parameter in should be final.	33
	Parameter out should be final.	33

org/apache/xbean/terminal/telnet/TelnetShell.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	31
	Parameter serverName should be final.	31
	Missing a Javadoc comment.	35
	Parameter socket should be final.	35
	'if' construct must use '{}'s.	42
	Missing a Javadoc comment.	46
	Parameter in should be final.	46
	Parameter out should be final.	46
	Comment matches to-do format 'TODO:'.	56
	Must have at least one statement.	62
	Comment matches to-do format 'TODO:'.	63
	'{' is not preceded with whitespace.	65

org/apache/xbean/terminal/telnet/TelnetCodes.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	19
	interfaces should describe a type and hence have methods.	19
	Redundant 'public' modifier.	26
	Redundant 'public' modifier.	33
	Redundant 'public' modifier.	42
	Name 'Data_Mark' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	42
	Redundant 'public' modifier.	49
	Name 'Break' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	49
	Redundant 'public' modifier.	56
	Name 'Interrupt_Process' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	56
	Redundant 'public' modifier.	63
	Name 'Abort_output' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	63
	Redundant 'public' modifier.	70
	Name 'Are_You_There' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	70
	Redundant 'public' modifier.	77
	Name 'Erase_character' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	77
	Redundant 'public' modifier.	84
	Name 'Erase_Line' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	84
	Redundant 'public' modifier.	91
	Name 'Go_ahead' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	91
	Redundant 'public' modifier.	100
	Redundant 'public' modifier.	110
	Redundant 'public' modifier.	119
	Redundant 'public' modifier.	130
	Redundant 'public' modifier.	141
	First sentence should end with a period.	142
	Redundant 'public' modifier.	149

org/apache/xbean/terminal/telnet/TelnetInputStream.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	26
	'256' is a magic number.	26
	Missing a Javadoc comment.	27
	Parameter in should be final.	38
	Expected @param tag for 'in'.	38
	Parameter out should be final.	38
	Expected @param tag for 'out'.	38
	Expected @throws tag for 'IOException'.	38
	'6' is a magic number.	42
	'24' is a magic number.	43
	'33' is a magic number.	44
	'34' is a magic number.	45
	Missing a Javadoc comment.	48
	Expected @throws tag for 'IOException'.	69
	Missing a Javadoc comment.	92
	Parameter command should be final.	92
	Parameter optionID should be final.	105
	Expected @param tag for 'optionID'.	105
	Expected @throws tag for 'IOException'.	105
	'if' construct must use '{}'s.	109
	Parameter optionID should be final.	132
	Expected @param tag for 'optionID'.	132
	Expected @throws tag for 'IOException'.	132
	'if' construct must use '{}'s.	136
	Parameter optionID should be final.	160
	Expected @param tag for 'optionID'.	160
	Expected @throws tag for 'IOException'.	160
	'if' construct must use '{}'s.	163
	Parameter optionID should be final.	181
	Expected @param tag for 'optionID'.	181
	Expected @throws tag for 'IOException'.	181
	'if' construct must use '{}'s.	185
	Comment matches to-do format 'TODO:'.	192
	Missing a Javadoc comment.	193
	Parameter s should be final.	193
	Comment matches to-do format 'TODO:'.	197
	Missing a Javadoc comment.	198
	Parameter s should be final.	198
	First sentence should end with a period.	202
	Parameter negotiate should be final.	209
	Expected @param tag for 'negotiate'.	209
	Parameter optionID should be final.	209
	Expected @param tag for 'optionID'.	209
	Expected @throws tag for 'IOException'.	210
	switch without "default" clause.	214
	Missing a Javadoc comment.	237
	Parameter optionID should be final.	237

org/apache/xbean/command/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/xbean/command/Lookup.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	36
	Parameter ctx should be final.	36
	Missing a Javadoc comment.	40
	Must have at least one statement.	44
	Missing a Javadoc comment.	48
	Name 'PWD' must match pattern '^[a-z][a-zA-Z0-9]*$'.	48
	Missing a Javadoc comment.	51
	Parameter args should be final.	51
	Parameter in should be final.	51
	Parameter out should be final.	51
	Comment matches to-do format 'TODO:'.	76
	Line has trailing spaces.	79
	'-2' is a magic number.	82
	Missing a Javadoc comment.	86
	Parameter name should be final.	86
	Parameter in should be final.	86
	Parameter out should be final.	86

org/apache/xbean/terminal/telnet/TelnetOption.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	27
	Parameter optionCode should be final.	27
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Parameter inNegotiation should be final.	57
	'inNegotiation' hides a field.	57
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	65
	Parameter negotiated should be final.	65
	'negotiated' hides a field.	65

org/apache/xbean/terminal/telnet/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/xbean/command/Exit.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	22
	Line has trailing spaces.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	28
	Parameter args should be final.	28
	Parameter in should be final.	28
	Parameter out should be final.	28

org/apache/xbean/terminal/console/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/xbean/command/Version.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	24
	Line has trailing spaces.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	30
	Parameter args should be final.	30
	Parameter in should be final.	30
	Parameter out should be final.	30
	Must have at least one statement.	37

org/apache/xbean/command/Help.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	30
	Parameter args should be final.	30
	Parameter in should be final.	30
	Parameter out should be final.	30
	Empty statement.	31

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/xbean/command/CommandShell.java

org/apache/xbean/command/Test.java

org/apache/xbean/terminal/telnet/TelnetDaemon.java

org/apache/xbean/command/CommandRegistry.java

org/apache/xbean/terminal/console/Main.java

org/apache/xbean/terminal/telnet/TelnetPrintStream.java

org/apache/xbean/command/Command.java

org/apache/xbean/command/GroovySh.java

org/apache/xbean/terminal/telnet/TelnetShell.java

org/apache/xbean/terminal/telnet/TelnetCodes.java

org/apache/xbean/terminal/telnet/TelnetInputStream.java

org/apache/xbean/command/package.html

org/apache/xbean/command/Lookup.java

org/apache/xbean/terminal/telnet/TelnetOption.java

org/apache/xbean/terminal/telnet/package.html

org/apache/xbean/command/Exit.java

org/apache/xbean/terminal/console/package.html

org/apache/xbean/command/Version.java

org/apache/xbean/command/Help.java