Geronimo :: Tomcat - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
50	0	0	1809

Rules

Rules	Violations	Severity
PackageHtml	8	Error
NewlineAtEndOfFile	1	Error
Translation	0	Error
JavadocMethod	452	Error
JavadocType	26	Error
JavadocVariable	174	Error
JavadocStyle	9	Error
ConstantName	26	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-tomcat/target/checkstyle-header.txt"`	42	Error
AvoidStarImport	2	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	8	Error
FileLength	0	Error
LineLength max: `"120"`	46	Error
MethodLength	0	Error
ParameterNumber	5	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	9	Error
NoWhitespaceBefore	0	Error
OperatorWrap	11	Error
ParenPad	17	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	52	Error
WhitespaceAround	218	Error
ModifierOrder	21	Error
RedundantModifier	80	Error
AvoidNestedBlocks	0	Error
EmptyBlock	2	Error
LeftCurly	10	Error
NeedBraces	49	Error
RightCurly	1	Error
AvoidInlineConditionals	29	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	6	Error
IllegalInstantiation	0	Error
InnerAssignment	2	Error
MagicNumber	20	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	0	Error
InterfaceIsType	0	Error
VisibilityModifier	6	Error
ArrayTypeStyle	4	Error
FinalParameters	319	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	142	Error
TodoComment	12	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/tomcat/RealmGBean.java	0	0	20
org/apache/geronimo/tomcat/interceptor/InstanceContextBeforeAfter.java	0	0	24
org/apache/geronimo/tomcat/cluster/ReceiverGBean.java	0	0	19
org/apache/geronimo/tomcat/valve/package.html	0	0	1
org/apache/geronimo/tomcat/interceptor/package.html	0	0	1
org/apache/geronimo/tomcat/TomcatContainer.java	0	0	80
org/apache/geronimo/tomcat/TomcatLogManager.java	0	0	1
org/apache/geronimo/tomcat/TomcatManagerImpl.java	0	0	72
org/apache/geronimo/tomcat/util/SecurityHolder.java	0	0	39
org/apache/geronimo/tomcat/listener/package.html	0	0	1
org/apache/geronimo/tomcat/ConnectorGBean.java	0	0	226
org/apache/geronimo/tomcat/package.html	0	0	1
org/apache/geronimo/tomcat/ManagerGBean.java	0	0	36
org/apache/geronimo/tomcat/cluster/MembershipServiceGBean.java	0	0	22
org/apache/geronimo/tomcat/valve/GeronimoBeforeAfterValve.java	0	0	20
org/apache/geronimo/tomcat/connector/HTTPConnector.java	0	0	13
org/apache/geronimo/tomcat/EngineGBean.java	0	0	68
org/apache/geronimo/tomcat/cluster/ClusterDeployerGBean.java	0	0	31
org/apache/geronimo/tomcat/ObjectRetriever.java	0	0	4
org/apache/geronimo/tomcat/interceptor/PolicyContextBeforeAfter.java	0	0	22
org/apache/geronimo/tomcat/cluster/FarmWarDeployerGBean.java	0	0	26
org/apache/geronimo/tomcat/GeronimoStandardContext.java	0	0	39
org/apache/geronimo/tomcat/realm/TomcatEJBWSGeronimoRealm.java	0	0	11
org/apache/geronimo/tomcat/cluster/SenderGBean.java	0	0	20
org/apache/geronimo/tomcat/ValveGBean.java	0	0	39
org/apache/geronimo/tomcat/TomcatEJBWebServiceContext.java	0	0	80
org/apache/geronimo/tomcat/JAASTomcatPrincipal.java	0	0	13
org/apache/geronimo/tomcat/BaseGBean.java	0	0	15
org/apache/geronimo/tomcat/realm/TomcatGeronimoRealm.java	0	0	58
org/apache/geronimo/tomcat/HttpsConnectorGBean.java	0	0	59
org/apache/geronimo/tomcat/connector/package.html	0	0	1
org/apache/geronimo/tomcat/cluster/package.html	0	0	1
org/apache/geronimo/tomcat/TomcatGeronimoEmbedded.java	0	0	38
org/apache/geronimo/tomcat/realm/TomcatJAASRealm.java	0	0	40
org/apache/geronimo/tomcat/TomcatSecureConnector.java	0	0	15
org/apache/geronimo/tomcat/HostGBean.java	0	0	61
org/apache/geronimo/tomcat/interceptor/ComponentContextBeforeAfter.java	0	0	18
org/apache/geronimo/tomcat/util/package.html	0	0	1
org/apache/geronimo/tomcat/valve/DefaultSubjectValve.java	0	0	7
org/apache/geronimo/tomcat/TomcatContext.java	0	0	41
org/apache/geronimo/tomcat/cluster/CatalinaClusterGBean.java	0	0	62
org/apache/geronimo/tomcat/listener/DispatchListener.java	0	0	20
org/apache/geronimo/tomcat/TomcatWebAppContext.java	0	0	141
org/apache/geronimo/tomcat/TomcatWebConnector.java	0	0	105
org/apache/geronimo/tomcat/TomcatLogManagerImpl.java	0	0	138
org/apache/geronimo/tomcat/realm/package.html	0	0	1
org/apache/geronimo/tomcat/interceptor/BeforeAfter.java	0	0	5
org/apache/geronimo/tomcat/TomcatEngine.java	0	0	10
org/apache/geronimo/tomcat/cluster/MessageListenerGBean.java	0	0	42
org/apache/geronimo/tomcat/TomcatWebContainer.java	0	0	1

Details

org/apache/geronimo/tomcat/RealmGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26
	Line has trailing spaces.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	30
	Parameter className should be final.	30
	Parameter initParams should be final.	30
	Comment matches to-do format 'TODO:'.	31
	Line has trailing spaces.	32
	Line has trailing spaces.	34
	'cast' is not followed by whitespace.	35
	Line has trailing spaces.	36
	Line has trailing spaces.	38
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	54
	'{' is followed by whitespace.	62
	Missing a Javadoc comment.	66

org/apache/geronimo/tomcat/interceptor/InstanceContextBeforeAfter.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	'{' is not preceded with whitespace.	29
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Line is longer than 120 characters.	37
	Missing a Javadoc comment.	37
	Parameter next should be final.	37
	Parameter index should be final.	37
	Parameter unshareableResources should be final.	37
	Parameter applicationManagedSecurityResources should be final.	37
	Parameter trackedConnectionAssociator should be final.	37
	Missing a Javadoc comment.	45
	Parameter context should be final.	45
	Parameter httpRequest should be final.	45
	Parameter httpResponse should be final.	45
	Line is longer than 120 characters.	47
	Missing a Javadoc comment.	56
	Parameter context should be final.	56
	Parameter httpRequest should be final.	56
	Parameter httpResponse should be final.	56

org/apache/geronimo/tomcat/cluster/ReceiverGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	33
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	33
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Line has trailing spaces.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44
	Parameter className should be final.	44
	Parameter initParams should be final.	44
	Comment matches to-do format 'TODO:'.	46
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	'{' is followed by whitespace.	85
	Missing a Javadoc comment.	89

org/apache/geronimo/tomcat/valve/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/interceptor/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/TomcatContainer.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - javax.management.ObjectName.	26
	Unused import - org.apache.geronimo.kernel.ObjectNameUtil.	40
	First sentence should end with a period.	52
	Missing a Javadoc comment.	61
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	61
	First sentence should end with a period.	63
	First sentence should end with a period.	73
	First sentence should end with a period.	78
	Missing a Javadoc comment.	83
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	85
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	89
	First sentence should end with a period.	95
	Line is longer than 120 characters.	98
	Parameter classLoader should be final.	98
	Expected @param tag for 'classLoader'.	98
	Parameter catalinaHome should be final.	98
	Expected @param tag for 'catalinaHome'.	98
	Parameter engineGBean should be final.	98
	Expected @param tag for 'engineGBean'.	98
	Parameter serverInfo should be final.	98
	Expected @param tag for 'serverInfo'.	98
	Parameter objectName should be final.	98
	Expected @param tag for 'objectName'.	98
	Parameter manager should be final.	98
	Expected @param tag for 'manager'.	98
	'if' construct must use '{}'s.	117
	Missing a Javadoc comment.	138
	Missing a Javadoc comment.	142
	Missing a Javadoc comment.	146
	Missing a Javadoc comment.	150
	Missing a Javadoc comment.	154
	Missing a Javadoc comment.	158
	Parameter protocol should be final.	158
	Missing a Javadoc comment.	162
	Must have at least one statement.	165
	First sentence should end with a period.	169
	Comment matches to-do format 'TODO:'.	172
	Expected @throws tag for 'Exception'.	174
	Missing a Javadoc comment.	229
	First sentence should end with a period.	237
	Parameter ctx should be final.	246
	Expected @throws tag for 'Exception'.	246
	Line is longer than 120 characters.	263
	'if' construct must use '{}'s.	269
	'+' should be on a new line.	306
	Line is longer than 120 characters.	307
	'+' should be on a new line.	307
	'+' should be on a new line.	308
	Line is longer than 120 characters.	311
	Line is longer than 120 characters.	312
	Missing a Javadoc comment.	328
	Parameter ctx should be final.	328
	Missing a Javadoc comment.	348
	Parameter catalinaHome should be final.	348
	Missing a Javadoc comment.	352
	Parameter connector should be final.	352
	Missing a Javadoc comment.	356
	Parameter connector should be final.	356
	Line is longer than 120 characters.	360
	Missing a Javadoc comment.	360
	More than 7 parameters.	360
	Parameter contextPath should be final.	360
	Parameter virtualHosts should be final.	360
	Parameter webServiceContainer should be final.	360
	Parameter securityRealmName should be final.	360
	Parameter realmName should be final.	360
	Parameter transportGuarantee should be final.	360
	Parameter authMethod should be final.	360
	Parameter classLoader should be final.	360
	'classLoader' hides a field.	360
	Line is longer than 120 characters.	361
	Line is longer than 120 characters.	372
	Missing a Javadoc comment.	379
	Parameter contextPath should be final.	379
	Missing a Javadoc comment.	391
	Line is longer than 120 characters.	396
	Missing a Javadoc comment.	421

org/apache/geronimo/tomcat/TomcatLogManager.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1

org/apache/geronimo/tomcat/TomcatManagerImpl.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	52
	'static' modifier out of order with the JLS suggestions.	52
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	52
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	55
	Parameter kernel should be final.	55
	Missing a Javadoc comment.	59
	Expected an @return tag.	75
	Line is longer than 120 characters.	75
	Parameter container should be final.	75
	Parameter uniqueName should be final.	75
	Parameter protocol should be final.	75
	Parameter host should be final.	75
	Parameter port should be final.	75
	Line is longer than 120 characters.	77
	'if' is not followed by whitespace.	79
	'if' is not followed by whitespace.	81
	'cast' is not followed by whitespace.	85
	'if' is not followed by whitespace.	87
	'+' is not preceded with whitespace.	90
	'+' is not followed by whitespace.	90
	'+' is not preceded with whitespace.	90
	'+' is not followed by whitespace.	90
	'50' is a magic number.	95
	'100' is a magic number.	96
	'if' is not followed by whitespace.	100
	Line is longer than 120 characters.	103
	Expected an @return tag.	119
	'=' is not preceded with whitespace.	124
	'=' is not followed by whitespace.	124
	Expected an @return tag.	135
	Parameter connectorName should be final.	144
	Expected @param tag for 'connectorName'.	144
	'if' is not followed by whitespace.	159
	Expected an @return tag.	182
	Parameter protocol should be final.	182
	'if' is not followed by whitespace.	183
	Missing a Javadoc comment.	203
	Parameter container should be final.	203
	'if' is not followed by whitespace.	206
	'if' is not followed by whitespace.	208
	Line is longer than 120 characters.	211
	'cast' is not followed by whitespace.	211
	Expected an @return tag.	217
	'=' is not preceded with whitespace.	222
	'=' is not followed by whitespace.	222
	Expected an @return tag.	235
	Parameter container should be final.	235
	Expected @param tag for 'container'.	235
	Parameter protocol should be final.	235
	'if' is not followed by whitespace.	236
	'if' is not followed by whitespace.	249
	'if' is not followed by whitespace.	252
	'+' is not preceded with whitespace.	256
	'+' is not followed by whitespace.	256
	'+' is not preceded with whitespace.	256
	'+' is not followed by whitespace.	256
	',' is not followed by whitespace.	256
	Line is longer than 120 characters.	263
	'cast' is not followed by whitespace.	263
	'+' is not preceded with whitespace.	263
	'+' is not followed by whitespace.	263
	'+' is not followed by whitespace.	263
	Expected an @return tag.	270
	Parameter container should be final.	270
	Expected @param tag for 'container'.	270
	Line is longer than 120 characters.	287
	'+' is not preceded with whitespace.	287
	'+' is not followed by whitespace.	287
	Missing a Javadoc comment.	291
	Missing a Javadoc comment.	301

org/apache/geronimo/tomcat/util/SecurityHolder.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	23
	'{' should be on the previous line.	24
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35
	'{' should be on the previous line.	36
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	49
	Parameter securityRealm should be final.	49
	Missing a Javadoc comment.	53
	'{' should be on the previous line.	54
	Missing a Javadoc comment.	58
	Parameter checked should be final.	58
	'{' should be on the previous line.	59
	Missing a Javadoc comment.	63
	'{' should be on the previous line.	64
	Missing a Javadoc comment.	68
	Parameter defaultPrincipal should be final.	68
	'{' should be on the previous line.	69
	Missing a Javadoc comment.	73
	'{' should be on the previous line.	74
	Missing a Javadoc comment.	78
	Parameter excluded should be final.	78
	'{' should be on the previous line.	79
	Missing a Javadoc comment.	83
	'{' should be on the previous line.	84
	Missing a Javadoc comment.	88
	Parameter policyContextID should be final.	88
	'{' should be on the previous line.	89
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	Parameter security should be final.	97
	Line has trailing spaces.	100

org/apache/geronimo/tomcat/listener/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/ConnectorGBean.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	40
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	40
	Missing a Javadoc comment.	41
	'static' modifier out of order with the JLS suggestions.	41
	Missing a Javadoc comment.	43
	Variable 'connector' must be private and have accessor methods.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Line is longer than 120 characters.	48
	Missing a Javadoc comment.	48
	Parameter name should be final.	48
	Parameter protocol should be final.	48
	Parameter host should be final.	48
	Parameter port should be final.	48
	Parameter container should be final.	48
	Comment matches to-do format 'TODO:'.	49
	Line has trailing spaces.	54
	'{' is not preceded with whitespace.	56
	Line has trailing spaces.	59
	'{' is not preceded with whitespace.	61
	'if' is not followed by whitespace.	71
	'{' is not preceded with whitespace.	77
	'{' is not preceded with whitespace.	81
	Line has trailing spaces.	84
	Line has trailing spaces.	94
	Parameter protocol should be final.	104
	Parameter params should be final.	104
	'{' is not followed by whitespace.	104
	'}' is not preceded with whitespace.	104
	Parameter protocol should be final.	110
	Expected @param tag for 'protocol'.	110
	'if' is not followed by whitespace.	111
	'if' is not followed by whitespace.	114
	'if' is not followed by whitespace.	116
	Line is longer than 120 characters.	117
	'+' is not preceded with whitespace.	117
	'+' is not followed by whitespace.	117
	'+' is not preceded with whitespace.	117
	'+' is not followed by whitespace.	117
	Missing a Javadoc comment.	121
	Missing a Javadoc comment.	125
	Missing a Javadoc comment.	129
	Missing a Javadoc comment.	135
	'try' is not followed by whitespace.	136
	'{' is not preceded with whitespace.	136
	'{' is not preceded with whitespace.	138
	Missing a Javadoc comment.	145
	Missing a Javadoc comment.	150
	Avoid inline conditionals.	151
	':' should be on a new line.	151
	Avoid inline conditionals.	152
	'80' is a magic number.	152
	':' should be on a new line.	152
	Avoid inline conditionals.	153
	'443' is a magic number.	153
	Missing a Javadoc comment.	156
	'if' is not followed by whitespace.	157
	'if' is not followed by whitespace.	159
	'if' is not followed by whitespace.	166
	'if' is not followed by whitespace.	168
	'+' is not preceded with whitespace.	175
	'+' is not followed by whitespace.	175
	'+' is not preceded with whitespace.	175
	'+' is not followed by whitespace.	175
	'+' is not preceded with whitespace.	175
	'+' is not followed by whitespace.	175
	Avoid inline conditionals.	175
	'+' is not preceded with whitespace.	175
	'+' is not followed by whitespace.	175
	Missing a Javadoc comment.	178
	'{' is not preceded with whitespace.	178
	Line has trailing spaces.	181
	Missing a Javadoc comment.	182
	Parameter emptySessionPath should be final.	182
	'{' is not preceded with whitespace.	182
	Line has trailing spaces.	183
	Expected an @return tag.	189
	'if' is not followed by whitespace.	191
	'if' is not followed by whitespace.	193
	'if' is not followed by whitespace.	195
	'+' is not preceded with whitespace.	198
	'+' is not followed by whitespace.	198
	'+' is not preceded with whitespace.	198
	'+' is not followed by whitespace.	198
	'+' is not preceded with whitespace.	198
	'+' is not followed by whitespace.	198
	'+' is not preceded with whitespace.	198
	'+' is not followed by whitespace.	198
	Expected an @return tag.	204
	Parameter port should be final.	211
	Expected @param tag for 'port'.	211
	Expected an @return tag.	218
	'if' is not followed by whitespace.	220
	'if' is not followed by whitespace.	222
	'cast' is not followed by whitespace.	223
	'else' construct must use '{}'s.	224
	Parameter host should be final.	234
	Expected @param tag for 'host'.	234
	Expected @throws tag for 'UnknownHostException'.	234
	Expected an @return tag.	244
	Expected an @return tag.	252
	Avoid inline conditionals.	254
	'2048' is a magic number.	254
	Parameter bytes should be final.	261
	Expected @param tag for 'bytes'.	261
	Expected an @return tag.	269
	Avoid inline conditionals.	271
	'200' is a magic number.	271
	Parameter threads should be final.	278
	Expected @param tag for 'threads'.	278
	Expected an @return tag.	287
	Avoid inline conditionals.	289
	'10' is a magic number.	289
	Parameter size should be final.	297
	Expected @param tag for 'size'.	297
	Expected an @return tag.	305
	Avoid inline conditionals.	307
	Parameter millis should be final.	314
	Expected @param tag for 'millis'.	314
	Expected an @return tag.	323
	Avoid inline conditionals.	325
	Parameter enable should be final.	333
	Expected @param tag for 'enable'.	333
	Expected an @return tag.	343
	Parameter port should be final.	354
	Expected @param tag for 'port'.	354
	Missing a Javadoc comment.	358
	Avoid inline conditionals.	360
	'4' is a magic number.	360
	Missing a Javadoc comment.	363
	Parameter threads should be final.	363
	Missing a Javadoc comment.	367
	Avoid inline conditionals.	369
	'50' is a magic number.	369
	Missing a Javadoc comment.	372
	Parameter threads should be final.	372
	Missing a Javadoc comment.	376
	Avoid inline conditionals.	378
	'4096' is a magic number.	378
	Missing a Javadoc comment.	381
	Parameter bytes should be final.	381
	Missing a Javadoc comment.	385
	Missing a Javadoc comment.	389
	Parameter enabled should be final.	389
	Missing a Javadoc comment.	393
	Avoid inline conditionals.	395
	'60000' is a magic number.	395
	Missing a Javadoc comment.	398
	Parameter millis should be final.	398
	Missing a Javadoc comment.	402
	Avoid inline conditionals.	404
	Missing a Javadoc comment.	407
	Parameter enabled should be final.	407
	Missing a Javadoc comment.	411
	Avoid inline conditionals.	413
	'2097152' is a magic number.	413
	Missing a Javadoc comment.	416
	Parameter bytes should be final.	416
	Missing a Javadoc comment.	420
	Avoid inline conditionals.	422
	'4096' is a magic number.	422
	Missing a Javadoc comment.	425
	Parameter kbytes should be final.	425
	Missing a Javadoc comment.	429
	Avoid inline conditionals.	431
	'100' is a magic number.	431
	Missing a Javadoc comment.	434
	Parameter maxKeepAliveRequests should be final.	434
	Missing a Javadoc comment.	438
	Avoid inline conditionals.	440
	'9000' is a magic number.	440
	Missing a Javadoc comment.	443
	Parameter kbytes should be final.	443
	Missing a Javadoc comment.	447
	Missing a Javadoc comment.	451
	Parameter enabled should be final.	451
	Missing a Javadoc comment.	455
	Parameter allow should be final.	455
	Missing a Javadoc comment.	459
	Missing a Javadoc comment.	463
	Parameter proxyName should be final.	463
	Missing a Javadoc comment.	467
	Missing a Javadoc comment.	471
	Parameter port should be final.	471
	Missing a Javadoc comment.	475
	Missing a Javadoc comment.	479
	Parameter scheme should be final.	479
	Missing a Javadoc comment.	483
	Missing a Javadoc comment.	487
	Parameter encoding should be final.	487
	Missing a Javadoc comment.	491
	Missing a Javadoc comment.	495
	Parameter useIPVHosts should be final.	495
	Missing a Javadoc comment.	499
	Missing a Javadoc comment.	503
	Parameter xpoweredBy should be final.	503
	Missing a Javadoc comment.	507
	Missing a Javadoc comment.	511
	Parameter compressableMimeType should be final.	511
	Missing a Javadoc comment.	515
	Missing a Javadoc comment.	519
	Parameter compression should be final.	519
	Missing a Javadoc comment.	523
	Missing a Javadoc comment.	527
	Parameter noCompressionUserAgents should be final.	527
	Missing a Javadoc comment.	531
	Missing a Javadoc comment.	535
	Parameter restrictedUserAgents should be final.	535
	Missing a Javadoc comment.	539
	Missing a Javadoc comment.	543
	Parameter threadPriority should be final.	543
	Missing a Javadoc comment.	547
	Avoid inline conditionals.	549
	'5' is a magic number.	549
	':' is not followed by whitespace.	549
	Missing a Javadoc comment.	552
	Parameter server should be final.	552
	Missing a Javadoc comment.	556
	Missing a Javadoc comment.	560
	Parameter strategy should be final.	560
	Missing a Javadoc comment.	564
	Missing a Javadoc comment.	568
	'{' is followed by whitespace.	621
	Missing a Javadoc comment.	625

org/apache/geronimo/tomcat/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/ManagerGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	28
	'{' is not preceded with whitespace.	28
	Missing a Javadoc comment.	30
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	30
	Line has trailing spaces.	31
	Missing a Javadoc comment.	32
	Line has trailing spaces.	33
	Missing a Javadoc comment.	34
	Variable 'manager' must be private and have accessor methods.	34
	Missing a Javadoc comment.	36
	Parameter className should be final.	36
	'{' is not preceded with whitespace.	36
	Line has trailing spaces.	37
	'cast' is not followed by whitespace.	38
	Line has trailing spaces.	40
	Line has trailing spaces.	41
	Missing a Javadoc comment.	41
	Parameter className should be final.	41
	Parameter initParams should be final.	42
	Comment matches to-do format 'TODO:'.	43
	'{' is not preceded with whitespace.	45
	Line has trailing spaces.	48
	'cast' is not followed by whitespace.	50
	Line has trailing spaces.	51
	Line has trailing spaces.	54
	Line has trailing spaces.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	66
	Line has trailing spaces.	70
	Missing a Javadoc comment.	71
	Line has trailing spaces.	78
	Line has trailing spaces.	79
	Missing a Javadoc comment.	84

org/apache/geronimo/tomcat/cluster/MembershipServiceGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	33
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	33
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	'=' is not preceded with whitespace.	41
	'=' is not followed by whitespace.	41
	Line has trailing spaces.	43
	Missing a Javadoc comment.	44
	Parameter className should be final.	44
	Parameter initParams should be final.	44
	Comment matches to-do format 'TODO:'.	46
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	Line is longer than 120 characters.	81
	'{' is followed by whitespace.	85
	Missing a Javadoc comment.	89

org/apache/geronimo/tomcat/valve/GeronimoBeforeAfterValve.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - org.apache.catalina.Valve.	7
	Missing a Javadoc comment.	13
	'{' is not preceded with whitespace.	13
	Line has trailing spaces.	14
	Missing a Javadoc comment.	15
	Missing a Javadoc comment.	16
	Missing a Javadoc comment.	18
	Parameter beforeAfter should be final.	18
	Parameter contextIndexCount should be final.	18
	Missing a Javadoc comment.	23
	Parameter request should be final.	23
	Parameter response should be final.	23
	Array brackets at illegal position.	24
	Line has trailing spaces.	25
	'{' is not preceded with whitespace.	26
	Line has trailing spaces.	29
	Line has trailing spaces.	32
	'{' is not preceded with whitespace.	33
	Line has trailing spaces.	36

org/apache/geronimo/tomcat/connector/HTTPConnector.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	28
	Line has trailing spaces.	30
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Parameter container should be final.	36
	Comment matches to-do format 'TODO:'.	37
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54
	'{' is followed by whitespace.	60
	Missing a Javadoc comment.	64

org/apache/geronimo/tomcat/EngineGBean.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	45
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	45
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	52
	More than 7 parameters.	52
	Parameter className should be final.	52
	Parameter initParams should be final.	53
	Parameter defaultHost should be final.	54
	Parameter hosts should be final.	55
	Parameter realmGBean should be final.	56
	Parameter tomcatValveChain should be final.	57
	Parameter clusterGBean should be final.	58
	Parameter manager should be final.	59
	Comment matches to-do format 'TODO:'.	60
	'{' is not preceded with whitespace.	62
	'{' is not preceded with whitespace.	66
	Line has trailing spaces.	69
	'{' is not preceded with whitespace.	71
	'{' is not preceded with whitespace.	76
	Line has trailing spaces.	79
	'{' is not preceded with whitespace.	81
	'cast' is not followed by whitespace.	86
	Line has trailing spaces.	90
	'{' is not preceded with whitespace.	92
	'cast' is not followed by whitespace.	93
	Line has trailing spaces.	95
	'cast' is not followed by whitespace.	97
	'if' construct must use '{}'s.	101
	'cast' is not followed by whitespace.	102
	'{' is not preceded with whitespace.	105
	'{' is not preceded with whitespace.	106
	'while' is not followed by whitespace.	108
	'{' is not preceded with whitespace.	108
	'cast' is not followed by whitespace.	109
	'cast' is not followed by whitespace.	109
	'cast' is not followed by whitespace.	117
	Parameter event should be final.	120
	'cast' is not followed by whitespace.	123
	'if' construct must use '{}'s.	124
	Parameter event should be final.	128
	'cast' is not followed by whitespace.	131
	'if' construct must use '{}'s.	132
	'{' is not preceded with whitespace.	137
	'cast' is not followed by whitespace.	138
	'cast' is not followed by whitespace.	139
	'if' construct must use '{}'s.	140
	'{' is not preceded with whitespace.	147
	'cast' is not followed by whitespace.	148
	Missing a Javadoc comment.	152
	Parameter objRetriever should be final.	152
	'cast' is not followed by whitespace.	153
	Missing a Javadoc comment.	157
	Parameter objRetriever should be final.	157
	'cast' is not followed by whitespace.	158
	Missing a Javadoc comment.	167
	Missing a Javadoc comment.	171
	Missing a Javadoc comment.	175
	Missing a Javadoc comment.	179
	Missing a Javadoc comment.	183
	Line has trailing spaces.	196
	Line has trailing spaces.	197
	Line has trailing spaces.	198
	Line has trailing spaces.	200
	Line has trailing spaces.	201
	Missing a Javadoc comment.	208

org/apache/geronimo/tomcat/cluster/ClusterDeployerGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	32
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Variable 'deployer' must be private and have accessor methods.	37
	Missing a Javadoc comment.	39
	Line has trailing spaces.	40
	Line has trailing spaces.	42
	Missing a Javadoc comment.	43
	Parameter className should be final.	43
	'{' is not preceded with whitespace.	43
	Line has trailing spaces.	44
	'cast' is not followed by whitespace.	45
	Line has trailing spaces.	47
	Missing a Javadoc comment.	48
	Parameter className should be final.	48
	Parameter initParams should be final.	48
	Comment matches to-do format 'TODO:'.	50
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	'+' is not preceded with whitespace.	71
	Missing a Javadoc comment.	74
	'+' is not preceded with whitespace.	75
	'+' is not followed by whitespace.	75
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	82
	Line is longer than 120 characters.	85
	'{' is followed by whitespace.	89
	Missing a Javadoc comment.	93

org/apache/geronimo/tomcat/ObjectRetriever.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	Redundant 'public' modifier.	21

org/apache/geronimo/tomcat/interceptor/PolicyContextBeforeAfter.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26
	'{' is not preceded with whitespace.	26
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Line is longer than 120 characters.	33
	Missing a Javadoc comment.	33
	Parameter next should be final.	33
	Parameter policyContextIDIndex should be final.	33
	Parameter callersIndex should be final.	33
	Parameter policyContextID should be final.	33
	Missing a Javadoc comment.	40
	Parameter context should be final.	40
	Parameter httpRequest should be final.	40
	Parameter httpResponse should be final.	40
	Missing a Javadoc comment.	56
	Parameter context should be final.	56
	Parameter httpRequest should be final.	56
	Parameter httpResponse should be final.	56
	'cast' is not followed by whitespace.	62

org/apache/geronimo/tomcat/cluster/FarmWarDeployerGBean.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	27
	'{' is not preceded with whitespace.	27
	Missing a Javadoc comment.	29
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	29
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	'{' is not preceded with whitespace.	34
	Line has trailing spaces.	35
	Line has trailing spaces.	37
	Missing a Javadoc comment.	38
	Parameter tempDir should be final.	38
	Parameter deployDir should be final.	39
	Parameter watchDir should be final.	40
	Parameter watchEnabled should be final.	41
	Parameter processDeployFrequency should be final.	42
	Parameter serverInfo should be final.	43
	'{' is not preceded with whitespace.	47
	'cast' is not followed by whitespace.	53
	'if' construct must use '{}'s.	55
	'if' construct must use '{}'s.	59
	'if' construct must use '{}'s.	63
	Missing a Javadoc comment.	73
	Line is longer than 120 characters.	76
	Missing a Javadoc comment.	96

org/apache/geronimo/tomcat/GeronimoStandardContext.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	66
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	66
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	79
	Parameter ctx should be final.	79
	Line is longer than 120 characters.	93
	Line is longer than 120 characters.	128
	'if' construct must use '{}'s.	154
	'if' construct must use '{}'s.	158
	Missing a Javadoc comment.	172
	'else' construct must use '{}'s.	190
	Missing a Javadoc comment.	194
	Missing a Javadoc comment.	203
	Parameter child should be final.	203
	Line is longer than 120 characters.	223
	Line is longer than 120 characters.	231
	Line is longer than 120 characters.	233
	Line is longer than 120 characters.	236
	Missing a Javadoc comment.	249
	Line has trailing spaces.	257
	Parameter container should be final.	266
	Parameter delegateBoolean should be final.	274
	Parameter reloadable should be final.	286
	Parameter listener should be final.	292
	Parameter repository should be final.	296
	Parameter listener should be final.	308
	Missing a Javadoc comment.	316
	Missing a Javadoc comment.	318
	Parameter request should be final.	318
	Parameter response should be final.	318
	Missing a Javadoc comment.	333
	Missing a Javadoc comment.	337

org/apache/geronimo/tomcat/realm/TomcatEJBWSGeronimoRealm.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	32
	Missing a Javadoc comment.	37
	Parameter request should be final.	37
	Parameter response should be final.	38
	Parameter constraints should be final.	39
	Parameter context should be final.	40
	Missing a Javadoc comment.	46
	Parameter request should be final.	46
	Parameter response should be final.	47
	Parameter constraints should be final.	48

org/apache/geronimo/tomcat/cluster/SenderGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	33
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	33
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Line has trailing spaces.	39
	Missing a Javadoc comment.	40
	'{' is not preceded with whitespace.	40
	Missing a Javadoc comment.	44
	Parameter className should be final.	44
	Parameter initParams should be final.	44
	Comment matches to-do format 'TODO:'.	46
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	'{' is followed by whitespace.	85
	Missing a Javadoc comment.	89

org/apache/geronimo/tomcat/ValveGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	33
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	33
	Missing a Javadoc comment.	35
	Line has trailing spaces.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Line has trailing spaces.	40
	Line has trailing spaces.	41
	Line has trailing spaces.	42
	Missing a Javadoc comment.	42
	'{' is not preceded with whitespace.	42
	Line has trailing spaces.	47
	Missing a Javadoc comment.	48
	Parameter className should be final.	48
	Parameter initParams should be final.	48
	Parameter nextValve should be final.	48
	'{' is not preceded with whitespace.	48
	'{' is not preceded with whitespace.	51
	Line has trailing spaces.	54
	'{' is not preceded with whitespace.	55
	'{' is not preceded with whitespace.	56
	Line has trailing spaces.	57
	Line is longer than 120 characters.	57
	Line has trailing spaces.	63
	Line has trailing spaces.	65
	'cast' is not followed by whitespace.	67
	Line has trailing spaces.	71
	Line has trailing spaces.	73
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	90
	Line has trailing spaces.	93
	Missing a Javadoc comment.	94
	'{' is followed by whitespace.	103
	Missing a Javadoc comment.	107

org/apache/geronimo/tomcat/TomcatEJBWebServiceContext.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - org.apache.geronimo.tomcat.realm.TomcatJAASRealm.	41
	Unused import - org.apache.geronimo.tomcat.realm.TomcatGeronimoRealm.	42
	Missing a Javadoc comment.	46
	'{' is not preceded with whitespace.	46
	Missing a Javadoc comment.	48
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	48
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	53
	Line is longer than 120 characters.	55
	Missing a Javadoc comment.	55
	Parameter contextPath should be final.	55
	Parameter webServiceContainer should be final.	55
	Parameter securityRealmName should be final.	55
	Parameter realmName should be final.	55
	Parameter transportGuarantee should be final.	55
	Parameter authMethod should be final.	55
	Parameter classLoader should be final.	55
	'\|\|' should be on a new line.	78
	'\|\|' should be on a new line.	85
	'\|\|' should be on a new line.	86
	')' is preceded with whitespace.	110
	'{' is not preceded with whitespace.	110
	')' is preceded with whitespace.	112
	'{' is not preceded with whitespace.	112
	')' is preceded with whitespace.	114
	'{' is not preceded with whitespace.	114
	Missing a Javadoc comment.	129
	'{' is not preceded with whitespace.	129
	Missing a Javadoc comment.	131
	Parameter req should be final.	131
	Parameter res should be final.	131
	'500' is a magic number.	144
	',' is not followed by whitespace.	144
	'403' is a magic number.	150
	'500' is a magic number.	164
	Missing a Javadoc comment.	174
	Missing a Javadoc comment.	175
	Missing a Javadoc comment.	176
	Missing a Javadoc comment.	178
	Parameter request should be final.	178
	Missing a Javadoc comment.	182
	Parameter name should be final.	182
	Missing a Javadoc comment.	186
	Line is longer than 120 characters.	189
	Missing a Javadoc comment.	199
	Missing a Javadoc comment.	203
	Missing a Javadoc comment.	207
	Missing a Javadoc comment.	211
	Avoid inline conditionals.	213
	Missing a Javadoc comment.	216
	Parameter name should be final.	216
	Missing a Javadoc comment.	220
	Missing a Javadoc comment.	224
	Parameter name should be final.	224
	Missing a Javadoc comment.	228
	Parameter name should be final.	228
	Parameter value should be final.	228
	Missing a Javadoc comment.	233
	Name 'methods' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	233
	Missing a Javadoc comment.	248
	Missing a Javadoc comment.	249
	Missing a Javadoc comment.	251
	Parameter response should be final.	251
	Missing a Javadoc comment.	255
	Parameter name should be final.	255
	Parameter value should be final.	255
	Missing a Javadoc comment.	259
	Parameter name should be final.	259
	Missing a Javadoc comment.	263
	Missing a Javadoc comment.	267
	Parameter code should be final.	267
	Missing a Javadoc comment.	271
	Missing a Javadoc comment.	275
	Parameter type should be final.	275
	Missing a Javadoc comment.	279
	Missing a Javadoc comment.	283
	Parameter responseString should be final.	283

org/apache/geronimo/tomcat/JAASTomcatPrincipal.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	33
	Parameter name should be final.	33
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Parameter subject should be final.	45
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Parameter roles should be final.	53

org/apache/geronimo/tomcat/BaseGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	27
	Parameter object should be final.	27
	Parameter map should be final.	27
	'{' is not preceded with whitespace.	27
	'{' is not preceded with whitespace.	28
	'while' is not followed by whitespace.	31
	'{' is not preceded with whitespace.	31
	'cast' is not followed by whitespace.	32
	'cast' is not followed by whitespace.	33
	Line has trailing spaces.	34
	Line has trailing spaces.	35
	Line has trailing spaces.	38
	Line has trailing spaces.	40

org/apache/geronimo/tomcat/realm/TomcatGeronimoRealm.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - org.apache.catalina.Wrapper.	21
	Unused import - javax.servlet.ServletRequest.	47
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	58
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	58
	Missing a Javadoc comment.	60
	Name 'info' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	65
	Name 'name' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	70
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	76
	Parameter requestWrapperName should be final.	76
	Expected an @return tag.	93
	Parameter request should be final.	93
	Parameter response should be final.	94
	Parameter constraints should be final.	95
	'if' construct must use '{}'s.	112
	Expected an @return tag.	146
	Parameter request should be final.	146
	Parameter response should be final.	147
	Parameter constraints should be final.	148
	Parameter context should be final.	149
	'&&' should be on a new line.	155
	'if' construct must use '{}'s.	160
	'if' construct must use '{}'s.	166
	'if' construct must use '{}'s.	171
	Line has trailing spaces.	176
	Expected an @return tag.	219
	Parameter principal should be final.	219
	Parameter role should be final.	219
	'name' hides a field.	225
	'cast' is not followed by whitespace.	225
	Expected an @return tag.	266
	Parameter username should be final.	266
	Parameter credentials should be final.	266
	'?' is not preceded with whitespace.	268
	Avoid inline conditionals.	268
	':' is not preceded with whitespace.	268
	Missing a Javadoc comment.	273
	Parameter certs should be final.	273
	Missing a Javadoc comment.	282
	Parameter callbackHandler should be final.	282
	Parameter principalName should be final.	282
	'(' is followed by whitespace.	287
	'!=' is not preceded with whitespace.	287
	'!=' is not followed by whitespace.	287
	')' is preceded with whitespace.	287
	'if' construct must use '{}'s.	289
	'if' construct must use '{}'s.	292
	'if' construct must use '{}'s.	314
	'if' construct must use '{}'s.	323
	'if' construct must use '{}'s.	330
	'if' construct must use '{}'s.	338
	'if' construct must use '{}'s.	342
	'if' construct must use '{}'s.	346
	'if' construct must use '{}'s.	357
	'}' should be on the same line.	374
	'if' construct must use '{}'s.	376

org/apache/geronimo/tomcat/HttpsConnectorGBean.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - org.apache.geronimo.management.geronimo.SecureConnector.	6
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	23
	Line is longer than 120 characters.	25
	Missing a Javadoc comment.	25
	Parameter name should be final.	25
	Parameter protocol should be final.	25
	Parameter host should be final.	25
	Parameter port should be final.	25
	Parameter container should be final.	25
	Parameter serverInfo should be final.	25
	'{' is not preceded with whitespace.	28
	Parameter protocol should be final.	41
	Parameter params should be final.	41
	Parameter protocol should be final.	52
	Expected @param tag for 'protocol'.	52
	'if' is not followed by whitespace.	53
	'+' is not preceded with whitespace.	54
	'+' is not followed by whitespace.	54
	Expected an @return tag.	63
	Parameter name should be final.	72
	Expected @param tag for 'name'.	72
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	81
	Parameter name should be final.	81
	Parameter password should be final.	93
	Expected @param tag for 'password'.	93
	Missing a Javadoc comment.	97
	Parameter password should be final.	97
	Expected an @return tag.	106
	'cast' is not followed by whitespace.	107
	Parameter type should be final.	115
	Expected @param tag for 'type'.	115
	Missing a Javadoc comment.	119
	'cast' is not followed by whitespace.	120
	Missing a Javadoc comment.	123
	Parameter type should be final.	123
	Expected an @return tag.	132
	Parameter algorithm should be final.	141
	Expected @param tag for 'algorithm'.	141
	Expected an @return tag.	155
	'cast' is not followed by whitespace.	156
	Parameter protocol should be final.	165
	Expected @param tag for 'protocol'.	165
	Expected an @return tag.	177
	Avoid inline conditionals.	179
	Parameter clientCert should be final.	190
	Expected @param tag for 'clientCert'.	190
	Expected an @return tag.	198
	'cast' is not followed by whitespace.	199
	Parameter ciphers should be final.	206
	Expected @param tag for 'ciphers'.	206
	Missing a Javadoc comment.	210
	Line is longer than 120 characters.	213
	'{' is followed by whitespace.	229
	Missing a Javadoc comment.	233

org/apache/geronimo/tomcat/connector/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/cluster/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/TomcatGeronimoEmbedded.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' is not preceded with whitespace.	30
	Line has trailing spaces.	31
	Missing a Javadoc comment.	32
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	32
	Line has trailing spaces.	33
	Missing a Javadoc comment.	34
	Parameter path should be final.	34
	Parameter docBase should be final.	34
	Parameter cl should be final.	34
	'if' construct must use '{}'s.	36
	'if' is not followed by whitespace.	36
	'(' is followed by whitespace.	36
	')' is preceded with whitespace.	36
	'+' should be on a new line.	37
	Line has trailing spaces.	44
	'if' construct must use '{}'s.	45
	Line has trailing spaces.	47
	Line has trailing spaces.	57
	Missing a Javadoc comment.	57
	Parameter contextPath should be final.	57
	Line has trailing spaces.	58
	Parameter webServiceContainer should be final.	58
	Line has trailing spaces.	59
	Parameter securityRealmName should be final.	59
	Line has trailing spaces.	60
	Parameter realmName should be final.	60
	Line has trailing spaces.	61
	Parameter transportGuarantee should be final.	61
	Line has trailing spaces.	62
	Parameter authMethod should be final.	62
	Parameter classLoader should be final.	63
	'if' construct must use '{}'s.	65
	'if' is not followed by whitespace.	65
	'(' is followed by whitespace.	65
	')' is preceded with whitespace.	65
	Line is longer than 120 characters.	68
	Line has trailing spaces.	77

org/apache/geronimo/tomcat/realm/TomcatJAASRealm.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Using the '.' form of import should be avoided - javax.security.auth.login..	27
	Missing a Javadoc comment.	38
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	38
	Missing a Javadoc comment.	40
	Name 'info' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	45
	Name 'name' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	50
	Missing a Javadoc comment.	52
	Expected an @return tag.	71
	Parameter username should be final.	71
	Parameter credentials should be final.	71
	'if' construct must use '{}'s.	76
	'if' construct must use '{}'s.	79
	'if' construct must use '{}'s.	101
	'if' construct must use '{}'s.	110
	'if' construct must use '{}'s.	117
	'if' construct must use '{}'s.	123
	'if' construct must use '{}'s.	127
	'if' construct must use '{}'s.	131
	'if' construct must use '{}'s.	142
	Missing a Javadoc comment.	163
	Parameter username should be final.	163
	Parameter subject should be final.	163
	'if' is not followed by whitespace.	177
	'(' is followed by whitespace.	177
	')' is preceded with whitespace.	177
	'if' is not followed by whitespace.	183
	'(' is followed by whitespace.	183
	')' is preceded with whitespace.	183
	'if' is not followed by whitespace.	190
	'(' is followed by whitespace.	190
	')' is preceded with whitespace.	190
	Missing a Javadoc comment.	219
	'{' is not preceded with whitespace.	219
	Missing a Javadoc comment.	224
	Parameter principal should be final.	224
	Parameter role should be final.	224
	'if' construct must use '{}'s.	226
	'\|\|' should be on a new line.	226
	'if' construct must use '{}'s.	231

org/apache/geronimo/tomcat/TomcatSecureConnector.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Expected an @return tag.	31
	Redundant 'public' modifier.	31
	Redundant 'public' modifier.	37
	Expected @param tag for 'name'.	37
	Redundant 'public' modifier.	41
	Expected @param tag for 'password'.	41
	Expected an @return tag.	47
	Redundant 'public' modifier.	47
	Redundant 'public' modifier.	53
	Expected @param tag for 'type'.	53
	Expected an @return tag.	59
	Redundant 'public' modifier.	59
	Redundant 'public' modifier.	65
	Expected @param tag for 'ciphers'.	65

org/apache/geronimo/tomcat/HostGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	41
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	41
	Line has trailing spaces.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Line has trailing spaces.	46
	Missing a Javadoc comment.	47
	Line has trailing spaces.	48
	Missing a Javadoc comment.	49
	'{' is not preceded with whitespace.	49
	Line has trailing spaces.	53
	Missing a Javadoc comment.	53
	Parameter className should be final.	53
	Line has trailing spaces.	54
	Parameter initParams should be final.	54
	Parameter aliases should be final.	55
	Line has trailing spaces.	56
	Parameter realmGBean should be final.	56
	Parameter tomcatValveChain should be final.	57
	Parameter clusterGBean should be final.	58
	Parameter manager should be final.	59
	Comment matches to-do format 'TODO:'.	60
	Line has trailing spaces.	61
	'{' is not preceded with whitespace.	63
	Line has trailing spaces.	66
	'{' is not preceded with whitespace.	67
	Line has trailing spaces.	70
	'{' is not preceded with whitespace.	72
	Line has trailing spaces.	75
	'{' is not preceded with whitespace.	77
	'cast' is not followed by whitespace.	82
	Line has trailing spaces.	83
	Line has trailing spaces.	86
	'{' is not preceded with whitespace.	88
	Line has trailing spaces.	94
	'if' construct must use '{}'s.	95
	'cast' is not followed by whitespace.	96
	'{' is not preceded with whitespace.	99
	'{' is not preceded with whitespace.	100
	'while' is not followed by whitespace.	102
	'{' is not preceded with whitespace.	102
	'cast' is not followed by whitespace.	103
	'cast' is not followed by whitespace.	103
	'{' is not preceded with whitespace.	110
	'cast' is not followed by whitespace.	111
	Line has trailing spaces.	113
	'if' construct must use '{}'s.	115
	'cast' is not followed by whitespace.	116
	Missing a Javadoc comment.	119
	Missing a Javadoc comment.	123
	Missing a Javadoc comment.	127
	Missing a Javadoc comment.	131
	Missing a Javadoc comment.	135
	Line has trailing spaces.	147
	Line has trailing spaces.	148
	Line has trailing spaces.	149
	Line has trailing spaces.	150
	Line has trailing spaces.	151
	Missing a Javadoc comment.	158

org/apache/geronimo/tomcat/interceptor/ComponentContextBeforeAfter.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	25
	'{' is not preceded with whitespace.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	30
	Parameter next should be final.	30
	Parameter index should be final.	30
	Parameter componentContext should be final.	30
	Missing a Javadoc comment.	36
	Parameter context should be final.	36
	Parameter httpRequest should be final.	36
	Parameter httpResponse should be final.	36
	Missing a Javadoc comment.	44
	Parameter context should be final.	44
	Parameter httpRequest should be final.	44
	Parameter httpResponse should be final.	44

org/apache/geronimo/tomcat/util/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/valve/DefaultSubjectValve.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Parameter defaultSubject should be final.	37
	Missing a Javadoc comment.	41
	Parameter request should be final.	41
	Parameter response should be final.	41

org/apache/geronimo/tomcat/TomcatContext.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	38
	Redundant 'public' modifier.	38
	Missing a Javadoc comment.	40
	Redundant 'public' modifier.	40
	Missing a Javadoc comment.	42
	Redundant 'public' modifier.	42
	Missing a Javadoc comment.	44
	Redundant 'public' modifier.	44
	Missing a Javadoc comment.	46
	Redundant 'public' modifier.	46
	Missing a Javadoc comment.	48
	Redundant 'public' modifier.	48
	Missing a Javadoc comment.	50
	Redundant 'public' modifier.	50
	Missing a Javadoc comment.	52
	Redundant 'public' modifier.	52
	Missing a Javadoc comment.	54
	Redundant 'public' modifier.	54
	Missing a Javadoc comment.	56
	Redundant 'public' modifier.	56
	Missing a Javadoc comment.	58
	Redundant 'public' modifier.	58
	Missing a Javadoc comment.	60
	Redundant 'public' modifier.	60
	Missing a Javadoc comment.	62
	Redundant 'public' modifier.	62
	Missing a Javadoc comment.	64
	Redundant 'public' modifier.	64
	Missing a Javadoc comment.	66
	Redundant 'public' modifier.	66
	Missing a Javadoc comment.	68
	Redundant 'public' modifier.	68
	Missing a Javadoc comment.	70
	Redundant 'public' modifier.	70
	Missing a Javadoc comment.	72
	Redundant 'public' modifier.	72
	Missing a Javadoc comment.	74
	Redundant 'public' modifier.	74
	Missing a Javadoc comment.	76
	Redundant 'public' modifier.	76

org/apache/geronimo/tomcat/cluster/CatalinaClusterGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	42
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	42
	Line has trailing spaces.	43
	Missing a Javadoc comment.	44
	Line has trailing spaces.	45
	Missing a Javadoc comment.	46
	Line has trailing spaces.	47
	Missing a Javadoc comment.	48
	'{' is not preceded with whitespace.	48
	'=' is not preceded with whitespace.	49
	'=' is not followed by whitespace.	49
	Line has trailing spaces.	52
	Missing a Javadoc comment.	52
	More than 7 parameters.	52
	Parameter className should be final.	52
	Line has trailing spaces.	53
	Parameter initParams should be final.	53
	Parameter membership should be final.	54
	Parameter receiver should be final.	55
	Parameter sender should be final.	56
	Parameter messageListenerChain should be final.	57
	Parameter tomcatValveChain should be final.	58
	Parameter deployer should be final.	59
	Line has trailing spaces.	60
	Comment matches to-do format 'TODO:'.	61
	Line has trailing spaces.	62
	'{' is not preceded with whitespace.	64
	Line has trailing spaces.	67
	'cast' is not followed by whitespace.	69
	Line has trailing spaces.	70
	Line has trailing spaces.	73
	'{' is not preceded with whitespace.	75
	'cast' is not followed by whitespace.	76
	Line has trailing spaces.	78
	'{' is not preceded with whitespace.	80
	'cast' is not followed by whitespace.	81
	Line has trailing spaces.	83
	'{' is not preceded with whitespace.	85
	'cast' is not followed by whitespace.	86
	'{' is not preceded with whitespace.	90
	'while' is not followed by whitespace.	92
	'{' is not preceded with whitespace.	92
	'cast' is not followed by whitespace.	93
	'{' is not preceded with whitespace.	99
	'while' is not followed by whitespace.	101
	'{' is not preceded with whitespace.	101
	'cast' is not followed by whitespace.	102
	Line has trailing spaces.	106
	'{' is not preceded with whitespace.	108
	'cast' is not followed by whitespace.	109
	Missing a Javadoc comment.	113
	Missing a Javadoc comment.	117
	Missing a Javadoc comment.	121
	Missing a Javadoc comment.	125
	Missing a Javadoc comment.	129
	Line is longer than 120 characters.	132
	Line has trailing spaces.	142
	Line has trailing spaces.	143
	Line has trailing spaces.	144
	Line has trailing spaces.	145
	Missing a Javadoc comment.	154

org/apache/geronimo/tomcat/listener/DispatchListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	48
	Parameter event should be final.	48
	Missing a Javadoc comment.	68
	Parameter webContext should be final.	68
	Parameter request should be final.	69
	Parameter response should be final.	69
	Array brackets at illegal position.	74
	Missing a Javadoc comment.	84
	Parameter webContext should be final.	84
	Parameter request should be final.	85
	Parameter response should be final.	85
	Array brackets at illegal position.	89
	Missing a Javadoc comment.	98
	Parameter request should be final.	98
	Parameter webContext should be final.	99

org/apache/geronimo/tomcat/TomcatWebAppContext.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	76
	Variable 'container' must be private and have accessor methods.	76
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	80
	Variable 'context' must be private and have accessor methods.	80
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	92
	Missing a Javadoc comment.	94
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	100
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	104
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	108
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	112
	Missing a Javadoc comment.	114
	Missing a Javadoc comment.	116
	Missing a Javadoc comment.	118
	Missing a Javadoc comment.	120
	Missing a Javadoc comment.	122
	Line has trailing spaces.	123
	Line has trailing spaces.	124
	Line has trailing spaces.	125
	Missing a Javadoc comment.	126
	Line has trailing spaces.	127
	Missing a Javadoc comment.	128
	Missing a Javadoc comment.	130
	More than 7 parameters.	130
	Parameter classLoader should be final.	131
	Parameter objectName should be final.	132
	Parameter originalSpecDD should be final.	133
	Parameter configurationBaseUrl should be final.	134
	Parameter securityHolder should be final.	135
	Parameter virtualServer should be final.	136
	Parameter componentContext should be final.	137
	Parameter unshareableResources should be final.	138
	Parameter applicationManagedSecurityResources should be final.	139
	Parameter transactionManager should be final.	140
	Parameter trackedConnectionAssociator should be final.	141
	Parameter container should be final.	142
	Parameter tomcatRealm should be final.	143
	Parameter tomcatValveChain should be final.	144
	Parameter cluster should be final.	145
	Parameter manager should be final.	146
	Parameter crossContext should be final.	147
	Parameter disableCookies should be final.	148
	Parameter webServices should be final.	149
	Parameter server should be final.	150
	Parameter application should be final.	151
	Parameter kernel should be final.	152
	'{' is not preceded with whitespace.	188
	'cast' is not followed by whitespace.	189
	'{' is not preceded with whitespace.	190
	'else' is not followed by whitespace.	193
	'{' is not preceded with whitespace.	193
	'{' is not preceded with whitespace.	198
	'while' is not followed by whitespace.	201
	'{' is not preceded with whitespace.	201
	'cast' is not followed by whitespace.	202
	Line has trailing spaces.	233
	Line has trailing spaces.	243
	Missing a Javadoc comment.	246
	Parameter webServiceFactoryMap should be final.	246
	Parameter kernel should be final.	246
	'kernel' hides a field.	246
	'webServices' hides a field.	247
	Line is longer than 120 characters.	253
	Missing a Javadoc comment.	261
	Missing a Javadoc comment.	265
	Missing a Javadoc comment.	269
	Missing a Javadoc comment.	273
	Missing a Javadoc comment.	277
	Missing a Javadoc comment.	281
	Missing a Javadoc comment.	285
	Missing a Javadoc comment.	289
	Missing a Javadoc comment.	298
	Missing a Javadoc comment.	302
	'?' is not preceded with whitespace.	303
	Avoid inline conditionals.	303
	':' is not preceded with whitespace.	303
	Missing a Javadoc comment.	306
	Missing a Javadoc comment.	310
	Parameter docBase should be final.	310
	Missing a Javadoc comment.	314
	Missing a Javadoc comment.	318
	Missing a Javadoc comment.	322
	Missing a Javadoc comment.	326
	Missing a Javadoc comment.	330
	Missing a Javadoc comment.	334
	Missing a Javadoc comment.	338
	Missing a Javadoc comment.	342
	Parameter context should be final.	342
	Missing a Javadoc comment.	346
	'if' is not followed by whitespace.	354
	Inner assignments should be avoided.	354
	'if' is not followed by whitespace.	355
	Inner assignments should be avoided.	355
	'if' is not followed by whitespace.	359
	Missing a Javadoc comment.	370
	Missing a Javadoc comment.	374
	Parameter path should be final.	374
	'path' hides a field.	374
	Avoid inline conditionals.	375
	Missing a Javadoc comment.	378
	Missing a Javadoc comment.	383
	Missing a Javadoc comment.	387
	Missing a Javadoc comment.	391
	Missing a Javadoc comment.	395
	Missing a Javadoc comment.	399
	Missing a Javadoc comment.	403
	Missing a Javadoc comment.	407
	Missing a Javadoc comment.	411
	Missing a Javadoc comment.	415
	'{' is not preceded with whitespace.	415
	Missing a Javadoc comment.	419
	'{' is not preceded with whitespace.	419
	First sentence should end with a period.	428
	Parameter objectName should be final.	432
	'objectName' hides a field.	432
	Expected @param tag for 'objectName'.	432
	'4' is a magic number.	457
	Missing a Javadoc comment.	464
	'?' is not preceded with whitespace.	465
	Avoid inline conditionals.	465
	':' is not preceded with whitespace.	465
	Missing a Javadoc comment.	468
	Missing a Javadoc comment.	472
	Missing a Javadoc comment.	485
	Missing a Javadoc comment.	495
	Missing a Javadoc comment.	504
	Line is longer than 120 characters.	507
	Line is longer than 120 characters.	522
	Missing a Javadoc comment.	567

org/apache/geronimo/tomcat/TomcatWebConnector.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	13
	Redundant 'public' modifier.	13
	Missing a Javadoc comment.	14
	Redundant 'public' modifier.	14
	Missing a Javadoc comment.	15
	Redundant 'public' modifier.	15
	Missing a Javadoc comment.	16
	Redundant 'public' modifier.	16
	Missing a Javadoc comment.	17
	Redundant 'public' modifier.	17
	Missing a Javadoc comment.	18
	Redundant 'public' modifier.	18
	Missing a Javadoc comment.	19
	Redundant 'public' modifier.	19
	Missing a Javadoc comment.	20
	Redundant 'public' modifier.	20
	Missing a Javadoc comment.	21
	Redundant 'public' modifier.	21
	Missing a Javadoc comment.	22
	Redundant 'public' modifier.	22
	Missing a Javadoc comment.	23
	Redundant 'public' modifier.	23
	Missing a Javadoc comment.	24
	Redundant 'public' modifier.	24
	Missing a Javadoc comment.	25
	Redundant 'public' modifier.	25
	Missing a Javadoc comment.	26
	Redundant 'public' modifier.	26
	Missing a Javadoc comment.	27
	Redundant 'public' modifier.	27
	Missing a Javadoc comment.	28
	Redundant 'public' modifier.	28
	Missing a Javadoc comment.	29
	Redundant 'public' modifier.	29
	Missing a Javadoc comment.	30
	Redundant 'public' modifier.	30
	Missing a Javadoc comment.	31
	Redundant 'public' modifier.	31
	Missing a Javadoc comment.	32
	Redundant 'public' modifier.	32
	Missing a Javadoc comment.	33
	Redundant 'public' modifier.	33
	Missing a Javadoc comment.	34
	Redundant 'public' modifier.	34
	Missing a Javadoc comment.	35
	Redundant 'public' modifier.	35
	Missing a Javadoc comment.	36
	Redundant 'public' modifier.	36
	Missing a Javadoc comment.	37
	Redundant 'public' modifier.	37
	Missing a Javadoc comment.	38
	Redundant 'public' modifier.	38
	Missing a Javadoc comment.	39
	Redundant 'public' modifier.	39
	Missing a Javadoc comment.	40
	Redundant 'public' modifier.	40
	Missing a Javadoc comment.	41
	Redundant 'public' modifier.	41
	Missing a Javadoc comment.	42
	Redundant 'public' modifier.	42
	Missing a Javadoc comment.	43
	Redundant 'public' modifier.	43
	Missing a Javadoc comment.	44
	Redundant 'public' modifier.	44
	Missing a Javadoc comment.	45
	Redundant 'public' modifier.	45
	Missing a Javadoc comment.	46
	Redundant 'public' modifier.	46
	Missing a Javadoc comment.	47
	Redundant 'public' modifier.	47
	Missing a Javadoc comment.	48
	Redundant 'public' modifier.	48
	Missing a Javadoc comment.	49
	Redundant 'public' modifier.	49
	Missing a Javadoc comment.	50
	Redundant 'public' modifier.	50
	Missing a Javadoc comment.	51
	Redundant 'public' modifier.	51
	Missing a Javadoc comment.	52
	Redundant 'public' modifier.	52
	Missing a Javadoc comment.	53
	Redundant 'public' modifier.	53
	Missing a Javadoc comment.	54
	Redundant 'public' modifier.	54
	Missing a Javadoc comment.	55
	Redundant 'public' modifier.	55
	Missing a Javadoc comment.	56
	Redundant 'public' modifier.	56
	Missing a Javadoc comment.	57
	Redundant 'public' modifier.	57
	Missing a Javadoc comment.	58
	Redundant 'public' modifier.	58
	Missing a Javadoc comment.	59
	Redundant 'public' modifier.	59
	Missing a Javadoc comment.	60
	Redundant 'public' modifier.	60
	Missing a Javadoc comment.	61
	Redundant 'public' modifier.	61
	Missing a Javadoc comment.	62
	Redundant 'public' modifier.	62
	Missing a Javadoc comment.	63
	Redundant 'public' modifier.	63
	Missing a Javadoc comment.	64
	Redundant 'public' modifier.	64

org/apache/geronimo/tomcat/TomcatLogManagerImpl.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Using the '.' form of import should be avoided - java.util..	26
	Missing a Javadoc comment.	45
	'static' modifier out of order with the JLS suggestions.	45
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	45
	Line is longer than 120 characters.	48
	Missing a Javadoc comment.	48
	'static' modifier out of order with the JLS suggestions.	48
	Missing a Javadoc comment.	49
	'static' modifier out of order with the JLS suggestions.	49
	Missing a Javadoc comment.	50
	'static' modifier out of order with the JLS suggestions.	50
	Missing a Javadoc comment.	51
	'static' modifier out of order with the JLS suggestions.	51
	Missing a Javadoc comment.	52
	'static' modifier out of order with the JLS suggestions.	52
	Missing a Javadoc comment.	56
	'static' modifier out of order with the JLS suggestions.	56
	Missing a Javadoc comment.	57
	'static' modifier out of order with the JLS suggestions.	57
	Missing a Javadoc comment.	60
	'static' modifier out of order with the JLS suggestions.	60
	Line is longer than 120 characters.	61
	Missing a Javadoc comment.	61
	'static' modifier out of order with the JLS suggestions.	61
	Missing a Javadoc comment.	62
	'static' modifier out of order with the JLS suggestions.	62
	Missing a Javadoc comment.	63
	'static' modifier out of order with the JLS suggestions.	63
	Missing a Javadoc comment.	64
	'static' modifier out of order with the JLS suggestions.	64
	Missing a Javadoc comment.	65
	'static' modifier out of order with the JLS suggestions.	65
	Missing a Javadoc comment.	66
	'static' modifier out of order with the JLS suggestions.	66
	Missing a Javadoc comment.	67
	'static' modifier out of order with the JLS suggestions.	67
	Missing a Javadoc comment.	68
	'static' modifier out of order with the JLS suggestions.	68
	Missing a Javadoc comment.	69
	'static' modifier out of order with the JLS suggestions.	69
	Missing a Javadoc comment.	70
	'static' modifier out of order with the JLS suggestions.	70
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	74
	Parameter serverInfo should be final.	74
	Parameter logGbeans should be final.	74
	'if' is not followed by whitespace.	91
	Line has trailing spaces.	92
	'(' is followed by whitespace.	92
	'+' is not preceded with whitespace.	92
	'+' is not followed by whitespace.	92
	'+' is not preceded with whitespace.	92
	'+' is not followed by whitespace.	92
	'+' is not preceded with whitespace.	92
	'+' is not followed by whitespace.	92
	Line has trailing spaces.	99
	Parameter logName should be final.	106
	'!=' is not followed by whitespace.	112
	Parameter logName should be final.	129
	Expected an @return tag.	161
	More than 7 parameters.	161
	Parameter logName should be final.	161
	Expected @param tag for 'logName'.	161
	Parameter host should be final.	161
	Expected @param tag for 'host'.	161
	Parameter user should be final.	161
	Expected @param tag for 'user'.	161
	Parameter method should be final.	161
	Expected @param tag for 'method'.	161
	Parameter uri should be final.	161
	Expected @param tag for 'uri'.	161
	Parameter startDate should be final.	162
	Expected @param tag for 'startDate'.	162
	Parameter endDate should be final.	162
	Expected @param tag for 'endDate'.	162
	Parameter skipResults should be final.	162
	Expected @param tag for 'skipResults'.	162
	Parameter maxResults should be final.	162
	Expected @param tag for 'maxResults'.	162
	'if' construct must use '{}'s.	165
	'if' is not followed by whitespace.	165
	'if' construct must use '{}'s.	166
	'if' is not followed by whitespace.	166
	'if' construct must use '{}'s.	167
	'if' is not followed by whitespace.	167
	'if' construct must use '{}'s.	168
	'if' is not followed by whitespace.	168
	Avoid inline conditionals.	170
	Avoid inline conditionals.	171
	Array brackets at illegal position.	178
	'!=' is not followed by whitespace.	180
	'(' is followed by whitespace.	193
	'==' is not preceded with whitespace.	193
	'==' is not followed by whitespace.	193
	'==' is not preceded with whitespace.	193
	'==' is not followed by whitespace.	193
	'>' is not preceded with whitespace.	194
	'>' is not followed by whitespace.	194
	'<=' is not preceded with whitespace.	194
	'<=' is not followed by whitespace.	194
	'>' is not preceded with whitespace.	194
	'>' is not followed by whitespace.	194
	'>=' is not preceded with whitespace.	194
	'>=' is not followed by whitespace.	194
	Line is longer than 120 characters.	200
	Line is longer than 120 characters.	203
	Avoid inline conditionals.	203
	Line is longer than 120 characters.	204
	Avoid inline conditionals.	204
	'while' is not followed by whitespace.	206
	'if' is not followed by whitespace.	209
	'if' is not followed by whitespace.	214
	'if' is not followed by whitespace.	215
	'if' is not followed by whitespace.	218
	'if' is not followed by whitespace.	221
	'if' is not followed by whitespace.	224
	'if' is not followed by whitespace.	227
	'if' is not followed by whitespace.	230
	'if' is not followed by whitespace.	233
	Must have at least one statement.	236
	'if' is not followed by whitespace.	240
	'if' is not followed by whitespace.	243
	',' is not followed by whitespace.	247
	Missing a Javadoc comment.	262
	',' is not followed by whitespace.	270
	Missing a Javadoc comment.	274
	Missing a Javadoc comment.	282
	Missing a Javadoc comment.	283
	Variable 'pattern' must be private and have accessor methods.	283
	Missing a Javadoc comment.	285
	Parameter fileNamePattern should be final.	285
	Missing a Javadoc comment.	295
	Parameter file should be final.	295
	Parameter fileName should be final.	295
	Line is longer than 120 characters.	302
	Line is longer than 120 characters.	303

org/apache/geronimo/tomcat/realm/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/tomcat/interceptor/BeforeAfter.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	22
	Line has trailing spaces.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	26

org/apache/geronimo/tomcat/TomcatEngine.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	24
	'{' is not preceded with whitespace.	24
	Line has trailing spaces.	27
	Missing a Javadoc comment.	31
	'if' construct must use '{}'s.	32
	Line has trailing spaces.	34
	'{' is not preceded with whitespace.	35
	'if' construct must use '{}'s.	37
	Line has trailing spaces.	40

org/apache/geronimo/tomcat/cluster/MessageListenerGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	14
	Missing a Javadoc comment.	16
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	16
	Missing a Javadoc comment.	18
	Line has trailing spaces.	19
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	22
	Line has trailing spaces.	23
	Line has trailing spaces.	24
	Line has trailing spaces.	25
	Missing a Javadoc comment.	25
	'{' is not preceded with whitespace.	25
	Line has trailing spaces.	30
	Missing a Javadoc comment.	31
	Parameter className should be final.	31
	Parameter initParams should be final.	31
	Parameter nextListener should be final.	31
	'{' is not preceded with whitespace.	31
	'{' is not preceded with whitespace.	34
	Line has trailing spaces.	37
	'{' is not preceded with whitespace.	38
	'{' is not preceded with whitespace.	39
	Line has trailing spaces.	40
	Line has trailing spaces.	42
	Line has trailing spaces.	47
	Line has trailing spaces.	49
	'cast' is not followed by whitespace.	51
	Line has trailing spaces.	55
	Line has trailing spaces.	57
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	74
	Line has trailing spaces.	77
	Missing a Javadoc comment.	78
	Line has trailing spaces.	87
	Line has trailing spaces.	88
	Line has trailing spaces.	89
	Missing a Javadoc comment.	94

org/apache/geronimo/tomcat/TomcatWebContainer.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/tomcat/RealmGBean.java

org/apache/geronimo/tomcat/interceptor/InstanceContextBeforeAfter.java

org/apache/geronimo/tomcat/cluster/ReceiverGBean.java

org/apache/geronimo/tomcat/valve/package.html

org/apache/geronimo/tomcat/interceptor/package.html

org/apache/geronimo/tomcat/TomcatContainer.java

org/apache/geronimo/tomcat/TomcatLogManager.java

org/apache/geronimo/tomcat/TomcatManagerImpl.java

org/apache/geronimo/tomcat/util/SecurityHolder.java

org/apache/geronimo/tomcat/listener/package.html

org/apache/geronimo/tomcat/ConnectorGBean.java

org/apache/geronimo/tomcat/package.html

org/apache/geronimo/tomcat/ManagerGBean.java

org/apache/geronimo/tomcat/cluster/MembershipServiceGBean.java

org/apache/geronimo/tomcat/valve/GeronimoBeforeAfterValve.java

org/apache/geronimo/tomcat/connector/HTTPConnector.java

org/apache/geronimo/tomcat/EngineGBean.java

org/apache/geronimo/tomcat/cluster/ClusterDeployerGBean.java

org/apache/geronimo/tomcat/ObjectRetriever.java

org/apache/geronimo/tomcat/interceptor/PolicyContextBeforeAfter.java

org/apache/geronimo/tomcat/cluster/FarmWarDeployerGBean.java

org/apache/geronimo/tomcat/GeronimoStandardContext.java

org/apache/geronimo/tomcat/realm/TomcatEJBWSGeronimoRealm.java

org/apache/geronimo/tomcat/cluster/SenderGBean.java

org/apache/geronimo/tomcat/ValveGBean.java

org/apache/geronimo/tomcat/TomcatEJBWebServiceContext.java

org/apache/geronimo/tomcat/JAASTomcatPrincipal.java

org/apache/geronimo/tomcat/BaseGBean.java

org/apache/geronimo/tomcat/realm/TomcatGeronimoRealm.java

org/apache/geronimo/tomcat/HttpsConnectorGBean.java

org/apache/geronimo/tomcat/connector/package.html

org/apache/geronimo/tomcat/cluster/package.html

org/apache/geronimo/tomcat/TomcatGeronimoEmbedded.java

org/apache/geronimo/tomcat/realm/TomcatJAASRealm.java

org/apache/geronimo/tomcat/TomcatSecureConnector.java

org/apache/geronimo/tomcat/HostGBean.java

org/apache/geronimo/tomcat/interceptor/ComponentContextBeforeAfter.java

org/apache/geronimo/tomcat/util/package.html

org/apache/geronimo/tomcat/valve/DefaultSubjectValve.java

org/apache/geronimo/tomcat/TomcatContext.java

org/apache/geronimo/tomcat/cluster/CatalinaClusterGBean.java

org/apache/geronimo/tomcat/listener/DispatchListener.java

org/apache/geronimo/tomcat/TomcatWebAppContext.java

org/apache/geronimo/tomcat/TomcatWebConnector.java

org/apache/geronimo/tomcat/TomcatLogManagerImpl.java

org/apache/geronimo/tomcat/realm/package.html

org/apache/geronimo/tomcat/interceptor/BeforeAfter.java

org/apache/geronimo/tomcat/TomcatEngine.java

org/apache/geronimo/tomcat/cluster/MessageListenerGBean.java

org/apache/geronimo/tomcat/TomcatWebContainer.java