Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

FilesInfos infoWarnings warningErrors error
2300454

Rules

RulesViolationsSeverity
PackageHtml3error Error
NewlineAtEndOfFile0error Error
Translation0error Error
JavadocMethod119error Error
JavadocType5error Error
JavadocVariable65error Error
JavadocStyle0error Error
ConstantName16error Error
LocalFinalVariableName0error Error
LocalVariableName0error Error
MemberName0error Error
MethodName0error Error
PackageName0error Error
ParameterName0error Error
StaticVariableName0error Error
TypeName0error Error
Header
  • headerFile: "/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-timer/target/checkstyle-header.txt"
20error Error
AvoidStarImport0error Error
IllegalImport0error Error
RedundantImport3error Error
UnusedImports0error Error
FileLength0error Error
LineLength
  • max: "120"
40error Error
MethodLength0error Error
ParameterNumber1error Error
EmptyForIteratorPad0error Error
NoWhitespaceAfter0error Error
NoWhitespaceBefore0error Error
OperatorWrap0error Error
ParenPad4error Error
TypecastParenPad0error Error
TabCharacter0error Error
WhitespaceAfter2error Error
WhitespaceAround4error Error
ModifierOrder0error Error
RedundantModifier0error Error
AvoidNestedBlocks0error Error
EmptyBlock1error Error
LeftCurly0error Error
NeedBraces0error Error
RightCurly0error Error
AvoidInlineConditionals1error Error
DoubleCheckedLocking0error Error
EmptyStatement0error Error
EqualsHashCode0error Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
3error Error
IllegalInstantiation0error Error
InnerAssignment0error Error
MagicNumber21error Error
MissingSwitchDefault0error Error
RedundantThrows0error Error
SimplifyBooleanExpression0error Error
SimplifyBooleanReturn0error Error
FinalClass0error Error
HideUtilityClassConstructor0error Error
InterfaceIsType0error Error
VisibilityModifier1error Error
ArrayTypeStyle0error Error
FinalParameters141error Error
GenericIllegalRegexp
  • message: "Line has trailing spaces."
  • format: "\s+$"
4error Error
TodoComment0error Error
UpperEll0error Error

Details

org/apache/geronimo/timer/vm/VMStoreThreadPooledTransactionalTimer.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.37
errorParameter repeatCount should be final.37
errorParameter transactionManager should be final.38
errorParameter threadPool should be final.39
errorMissing a Javadoc comment.45
errorMissing a Javadoc comment.59

org/apache/geronimo/timer/TransactionalExecutorTaskFactory.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.30
errorMissing a Javadoc comment.31
errorMissing a Javadoc comment.33
errorParameter transactionManager should be final.33
errorParameter repeatCount should be final.33
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.42
errorParameter userTask should be final.42
errorParameter workInfo should be final.42
errorParameter threadPooledTimer should be final.42

org/apache/geronimo/timer/TransactionalExecutorTask.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.31
errorName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.31
errorMissing a Javadoc comment.33
errorMissing a Javadoc comment.34
errorMissing a Javadoc comment.35
errorMissing a Javadoc comment.37
errorMissing a Javadoc comment.38
errorLine is longer than 120 characters.40
errorMissing a Javadoc comment.40
errorParameter userTask should be final.40
errorParameter workInfo should be final.40
errorParameter threadPooledTimer should be final.40
errorParameter transactionManager should be final.40
errorParameter repeatCount should be final.40
errorMissing a Javadoc comment.48
errorMissing a Javadoc comment.82
errorMissing a Javadoc comment.92
errorMissing a Javadoc comment.100

org/apache/geronimo/timer/ExecutorTaskFactory.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.28

org/apache/geronimo/timer/WorkInfo.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorRedundant import from the same package - org.apache.geronimo.timer.ExecutorFeedingTimerTask.22
errorRedundant import from the same package - org.apache.geronimo.timer.ExecutorTask.23
errorMissing a Javadoc comment.33
errorMissing a Javadoc comment.36
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.40
errorMissing a Javadoc comment.42
errorMissing a Javadoc comment.44
errorMissing a Javadoc comment.46
errorMissing a Javadoc comment.49
errorMissing a Javadoc comment.50
errorMissing a Javadoc comment.53
errorMissing a Javadoc comment.56
errorParameter key should be final.56
errorParameter userId should be final.56
errorParameter userInfo should be final.56
errorParameter time should be final.56
errorParameter period should be final.56
errorParameter atFixedRate should be final.56
errorMissing a Javadoc comment.65
errorMissing a Javadoc comment.69
errorMissing a Javadoc comment.73
errorParameter id should be final.73
errorMissing a Javadoc comment.80
errorMissing a Javadoc comment.84
errorMissing a Javadoc comment.88
errorMissing a Javadoc comment.92
errorMissing a Javadoc comment.96
errorMissing a Javadoc comment.100
errorParameter worker should be final.100
error'worker' hides a field.100
errorParameter taskWrapper should be final.100
error'taskWrapper' hides a field.100
errorMissing a Javadoc comment.105
errorMissing a Javadoc comment.109
errorMissing a Javadoc comment.113
errorMissing a Javadoc comment.117
errorParameter clientHandle should be final.117
errorMissing a Javadoc comment.121
errorMissing a Javadoc comment.125
errorMissing a Javadoc comment.132

org/apache/geronimo/timer/UserTaskFactory.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.28

org/apache/geronimo/timer/jdbc/JDBCWorkerPersistence.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorMissing a Javadoc comment.43
errorName 'createSequenceSQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.43
errorLine is longer than 120 characters.44
errorMissing a Javadoc comment.44
errorName 'createTableSQLWithSequence' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.44
errorLine is longer than 120 characters.45
errorMissing a Javadoc comment.45
errorName 'createTableSQLWithIdentity' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.45
errorMissing a Javadoc comment.46
errorName 'sequenceSQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.46
errorMissing a Javadoc comment.47
errorName 'identitySQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.47
errorLine is longer than 120 characters.48
errorMissing a Javadoc comment.48
errorName 'insertSQLWithSequence' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.48
errorLine is longer than 120 characters.49
errorMissing a Javadoc comment.49
errorName 'insertSQLWithIdentity' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.49
errorMissing a Javadoc comment.50
errorName 'deleteSQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.50
errorLine is longer than 120 characters.51
errorMissing a Javadoc comment.51
errorName 'selectSQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.51
errorLine is longer than 120 characters.52
errorMissing a Javadoc comment.52
errorName 'fixedRateUpdateSQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.52
errorMissing a Javadoc comment.53
errorName 'intervalUpdateSQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.53
errorLine is longer than 120 characters.54
errorMissing a Javadoc comment.54
errorName 'selectByKeySQL' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.54
errorMissing a Javadoc comment.56
errorMissing a Javadoc comment.57
errorMissing a Javadoc comment.58
errorLine is longer than 120 characters.60
errorMissing a Javadoc comment.60
errorParameter serverUniqueId should be final.60
errorParameter datasource should be final.60
errorParameter useSequence should be final.60
errorMissing a Javadoc comment.73
errorParameter workInfo should be final.73
error'3' is a magic number.98
error'4' is a magic number.99
error'5' is a magic number.100
error'6' is a magic number.101
error'7' is a magic number.103
error'7' is a magic number.105
error'8' is a magic number.107
error'3' is a magic number.122
error'4' is a magic number.123
error'5' is a magic number.124
error'6' is a magic number.126
error'6' is a magic number.128
error'7' is a magic number.130
errorMissing a Javadoc comment.161
errorParameter id should be final.161
errorMissing a Javadoc comment.181
errorParameter key should be final.181
errorParameter playback should be final.181
error'3' is a magic number.195
error'4' is a magic number.197
error'5' is a magic number.200
error'6' is a magic number.204
errorLine is longer than 120 characters.205
errorMissing a Javadoc comment.224
errorParameter id should be final.224
errorMissing a Javadoc comment.243
errorParameter id should be final.243
errorParameter period should be final.243
errorMissing a Javadoc comment.264
errorParameter key should be final.264
errorParameter userId should be final.264
error'3' is a magic number.273
error'4' is a magic number.274
error'3' is a magic number.277
error'4' is a magic number.278
errorMissing a Javadoc comment.302
errorParameter task should be final.302
errorMissing a Javadoc comment.307
errorParameter serializedRunnable should be final.307
errorMissing a Javadoc comment.312
errorParameter sql should be final.312
errorMust have at least one statement.318

org/apache/geronimo/timer/NontransactionalExecutorTask.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.28
errorName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.28
errorMissing a Javadoc comment.30
errorMissing a Javadoc comment.31
errorMissing a Javadoc comment.32
errorMissing a Javadoc comment.34
errorParameter userTask should be final.34
errorParameter workInfo should be final.34
errorParameter threadPooledTimer should be final.34
errorMissing a Javadoc comment.40

org/apache/geronimo/timer/jdbc/JDBCStoreThreadPooledTransactionalTimer.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.44
errorParameter repeatCount should be final.44
errorParameter transactionManager should be final.45
errorParameter managedConnectionFactoryWrapper should be final.46
errorParameter threadPool should be final.47
errorParameter kernel should be final.48
errorLine is longer than 120 characters.50
error'cast' is not followed by whitespace.50
errorMissing a Javadoc comment.54
errorLine is longer than 120 characters.62
errorLine is longer than 120 characters.66
errorMissing a Javadoc comment.70

org/apache/geronimo/timer/ExecutorTask.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1

org/apache/geronimo/timer/PersistenceException.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.28
errorMissing a Javadoc comment.32
errorParameter message should be final.32
errorMissing a Javadoc comment.36
errorParameter message should be final.36
errorParameter cause should be final.36
errorMissing a Javadoc comment.40
errorParameter cause should be final.40

org/apache/geronimo/timer/vm/VMStoreThreadPooledNonTransactionalTimer.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.40
errorParameter transactionManager should be final.40
errorParameter threadPool should be final.40
errorMissing a Javadoc comment.46
errorMissing a Javadoc comment.59

org/apache/geronimo/timer/NontransactionalExecutorTaskFactory.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.27
errorMissing a Javadoc comment.30
errorParameter userTask should be final.30
errorParameter workInfo should be final.30
errorParameter threadPooledTimer should be final.30

org/apache/geronimo/timer/vm/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/timer/ExecutorFeedingTimerTask.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.39
errorName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.39
errorMissing a Javadoc comment.41
errorMissing a Javadoc comment.42
errorMissing a Javadoc comment.43
errorVariable 'cancelled' must be private and have accessor methods.43
errorMissing a Javadoc comment.45
errorParameter workInfo should be final.45
errorParameter threadPooledTimer should be final.45
errorMissing a Javadoc comment.50
errorMissing a Javadoc comment.54
errorLine is longer than 120 characters.60
errorLine is longer than 120 characters.63
errorMissing a Javadoc comment.71
errorMissing a Javadoc comment.75
errorMissing a Javadoc comment.85
errorLine has trailing spaces.87
error'(' is followed by whitespace.90
error')' is preceded with whitespace.90
errorLine has trailing spaces.92
error'(' is followed by whitespace.94
error')' is preceded with whitespace.94
errorLine has trailing spaces.96
errorLine has trailing spaces.104
errorMissing a Javadoc comment.105
errorMissing a Javadoc comment.107
errorMissing a Javadoc comment.109
errorParameter worker should be final.109
errorMissing a Javadoc comment.113
errorMissing a Javadoc comment.116
errorParameter status should be final.116

org/apache/geronimo/timer/vm/VMWorkerPersistence.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.43
errorMissing a Javadoc comment.45
errorMissing a Javadoc comment.47
errorParameter workInfo should be final.47
errorMissing a Javadoc comment.53
errorParameter id should be final.53
errorMissing a Javadoc comment.57
errorParameter key should be final.57
errorParameter playback should be final.57
errorMissing a Javadoc comment.67
errorParameter id should be final.67
errorMissing a Javadoc comment.80
errorParameter id should be final.80
errorParameter period should be final.80
errorMissing a Javadoc comment.84
errorParameter key should be final.84
errorParameter userId should be final.84
error'synchronized' is not followed by whitespace.86

org/apache/geronimo/timer/PersistentTimer.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorRedundant import from the same package - org.apache.geronimo.timer.PersistenceException.26
errorLine is longer than 120 characters.35
errorMissing a Javadoc comment.35
errorLine is longer than 120 characters.37
errorMissing a Javadoc comment.37
errorLine is longer than 120 characters.39
errorMissing a Javadoc comment.39
errorLine is longer than 120 characters.41
errorMissing a Javadoc comment.41
errorLine is longer than 120 characters.43
errorMissing a Javadoc comment.43
errorLine is longer than 120 characters.45
errorMissing a Javadoc comment.45
errorMissing a Javadoc comment.47
errorMissing a Javadoc comment.49
errorMissing a Javadoc comment.51
errorMissing a Javadoc comment.53

org/apache/geronimo/timer/ThreadPooledTimer.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorMissing a Javadoc comment.51
errorName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.51
errorMissing a Javadoc comment.53
errorMissing a Javadoc comment.54
errorMissing a Javadoc comment.55
errorMissing a Javadoc comment.56
errorMissing a Javadoc comment.58
errorMissing a Javadoc comment.60
errorMissing a Javadoc comment.63
errorLine is longer than 120 characters.67
errorMissing a Javadoc comment.67
errorParameter executorTaskFactory should be final.67
errorParameter workerPersistence should be final.67
errorParameter executor should be final.67
errorParameter transactionManager should be final.67
errorMissing a Javadoc comment.74
errorMissing a Javadoc comment.78
errorMissing a Javadoc comment.85
errorLine is longer than 120 characters.89
errorMissing a Javadoc comment.89
errorParameter userTaskFactory should be final.89
errorParameter key should be final.89
errorParameter userId should be final.89
errorParameter userInfo should be final.89
errorParameter delay should be final.89
errorLine is longer than 120 characters.97
errorMissing a Javadoc comment.97
errorParameter key should be final.97
errorParameter userTaskFactory should be final.97
errorParameter userId should be final.97
errorParameter userInfo should be final.97
errorParameter time should be final.97
error'==' is not followed by whitespace.98
errorLine is longer than 120 characters.110
errorMissing a Javadoc comment.110
errorParameter key should be final.110
errorParameter userTaskFactory should be final.110
errorParameter userInfo should be final.110
errorParameter delay should be final.110
errorParameter period should be final.110
errorParameter userId should be final.110
errorLine is longer than 120 characters.121
errorMissing a Javadoc comment.121
errorParameter key should be final.121
errorParameter userTaskFactory should be final.121
errorParameter userId should be final.121
errorParameter userInfo should be final.121
errorParameter firstTime should be final.121
errorParameter period should be final.121
error'==' is not followed by whitespace.122
errorLine is longer than 120 characters.131
errorLine is longer than 120 characters.132
errorLine is longer than 120 characters.137
errorMissing a Javadoc comment.137
errorParameter key should be final.137
errorParameter userTaskFactory should be final.137
errorParameter userId should be final.137
errorParameter userInfo should be final.137
errorParameter delay should be final.137
errorParameter period should be final.137
errorLine is longer than 120 characters.148
errorMissing a Javadoc comment.148
errorParameter key should be final.148
errorParameter userTaskFactory should be final.148
errorParameter userId should be final.148
errorParameter userInfo should be final.148
errorParameter firstTime should be final.148
errorParameter period should be final.148
error'==' is not followed by whitespace.149
errorLine is longer than 120 characters.158
errorLine is longer than 120 characters.159
errorMissing a Javadoc comment.164
errorParameter key should be final.164
errorParameter userTaskFactory should be final.164
errorMissing a Javadoc comment.170
errorParameter key should be final.170
errorParameter userId should be final.170
errorMissing a Javadoc comment.174
errorParameter id should be final.174
errorParameter ids should be final.183
errorMissing a Javadoc comment.194
errorParameter worker should be final.194
errorMissing a Javadoc comment.198
errorParameter workInfo should be final.198
errorMissing a Javadoc comment.202
errorParameter workInfo should be final.202
errorMissing a Javadoc comment.214
errorMissing a Javadoc comment.221
errorMissing a Javadoc comment.225
errorLine is longer than 120 characters.229
errorMissing a Javadoc comment.229
errorMore than 7 parameters.229
errorParameter key should be final.229
errorParameter userTaskFactory should be final.229
errorParameter executorTaskFactory should be final.229
error'executorTaskFactory' hides a field.229
errorParameter userId should be final.229
errorParameter userInfo should be final.229
errorParameter time should be final.229
errorParameter period should be final.229
errorParameter atFixedRate should be final.229
errorMissing a Javadoc comment.244
errorParameter sync should be final.244
errorAvoid inline conditionals.246
errorMissing a Javadoc comment.256
errorMissing a Javadoc comment.258
errorMissing a Javadoc comment.259
errorMissing a Javadoc comment.261
errorParameter worker should be final.261
errorParameter time should be final.261
errorMissing a Javadoc comment.266
errorMissing a Javadoc comment.269
errorParameter status should be final.269
errorLine is longer than 120 characters.279
errorMissing a Javadoc comment.285
errorMissing a Javadoc comment.287
errorMissing a Javadoc comment.288
errorMissing a Javadoc comment.289
errorMissing a Javadoc comment.291
errorParameter worker should be final.291
errorParameter time should be final.291
errorParameter period should be final.291
errorMissing a Javadoc comment.297
errorMissing a Javadoc comment.300
errorParameter status should be final.300
errorLine is longer than 120 characters.309
errorMissing a Javadoc comment.315
errorMissing a Javadoc comment.317
errorMissing a Javadoc comment.318
errorMissing a Javadoc comment.319
errorMissing a Javadoc comment.321
errorParameter worker should be final.321
errorParameter time should be final.321
errorParameter period should be final.321
errorMissing a Javadoc comment.327
errorMissing a Javadoc comment.330
errorParameter status should be final.330
errorLine is longer than 120 characters.339
errorMissing a Javadoc comment.345
errorMissing a Javadoc comment.347
errorMissing a Javadoc comment.349
errorMissing a Javadoc comment.351
errorParameter userTaskFactory should be final.351
errorMissing a Javadoc comment.355
errorParameter workInfo should be final.355
errorLine is longer than 120 characters.357
errorMissing a Javadoc comment.371

org/apache/geronimo/timer/jdbc/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/timer/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/timer/jdbc/JDBCStoreThreadPooledNonTransactionalTimer.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.41
errorParameter managedConnectionFactoryWrapper should be final.41
errorParameter transactionManager should be final.42
errorParameter threadPool should be final.43
errorParameter kernel should be final.44
errorLine is longer than 120 characters.46
error'cast' is not followed by whitespace.46
errorMissing a Javadoc comment.50
errorLine is longer than 120 characters.56
errorLine is longer than 120 characters.62
errorMissing a Javadoc comment.66

org/apache/geronimo/timer/Playback.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.27

org/apache/geronimo/timer/WorkerPersistence.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.30
errorMissing a Javadoc comment.32
errorMissing a Javadoc comment.34
errorMissing a Javadoc comment.36
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.40