Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

FilesInfos infoWarnings warningErrors error
1300415

Rules

RulesViolationsSeverity
PackageHtml3error Error
NewlineAtEndOfFile0error Error
Translation0error Error
JavadocMethod95error Error
JavadocType0error Error
JavadocVariable31error Error
JavadocStyle0error Error
ConstantName1error Error
LocalFinalVariableName0error Error
LocalVariableName0error Error
MemberName0error Error
MethodName0error Error
PackageName0error Error
ParameterName0error Error
StaticVariableName0error Error
TypeName0error Error
Header
  • headerFile: "/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-service-builder/target/checkstyle-header.txt"
10error Error
AvoidStarImport0error Error
IllegalImport0error Error
RedundantImport0error Error
UnusedImports5error Error
FileLength0error Error
LineLength
  • max: "120"
66error Error
MethodLength0error Error
ParameterNumber0error Error
EmptyForIteratorPad0error Error
NoWhitespaceAfter0error Error
NoWhitespaceBefore0error Error
OperatorWrap2error Error
ParenPad0error Error
TypecastParenPad0error Error
TabCharacter0error Error
WhitespaceAfter0error Error
WhitespaceAround42error Error
ModifierOrder2error Error
RedundantModifier0error Error
AvoidNestedBlocks0error Error
EmptyBlock3error Error
LeftCurly0error Error
NeedBraces0error Error
RightCurly0error Error
AvoidInlineConditionals16error Error
DoubleCheckedLocking0error Error
EmptyStatement0error Error
EqualsHashCode0error Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
1error Error
IllegalInstantiation0error Error
InnerAssignment0error Error
MagicNumber0error Error
MissingSwitchDefault0error Error
RedundantThrows0error Error
SimplifyBooleanExpression0error Error
SimplifyBooleanReturn0error Error
FinalClass1error Error
HideUtilityClassConstructor0error Error
InterfaceIsType0error Error
VisibilityModifier2error Error
ArrayTypeStyle1error Error
FinalParameters134error Error
GenericIllegalRegexp
  • message: "Line has trailing spaces."
  • format: "\s+$"
0error Error
TodoComment0error Error
UpperEll0error Error

Files

FilesI infoW warningE error
org/apache/geronimo/deployment/service/jsr88/EnvironmentData.java0054
org/apache/geronimo/deployment/service/GBeanBuilder.java0037
org/apache/geronimo/deployment/service/package.html001
org/apache/geronimo/deployment/service/XmlAttributeBuilder.java003
org/apache/geronimo/deployment/service/jsr88/package.html001
org/apache/geronimo/deployment/service/XmlReferenceBuilder.java004
org/apache/geronimo/deployment/xmlbeans/XmlBeansUtil.java0068
org/apache/geronimo/deployment/xmlbeans/package.html001
org/apache/geronimo/deployment/service/jsr88/Artifact.java0025
org/apache/geronimo/deployment/service/SingleGBeanBuilder.java0056
org/apache/geronimo/deployment/service/ServiceConfigBuilder.java0095
org/apache/geronimo/deployment/service/JavaBeanXmlAttributeBuilder.java0016
org/apache/geronimo/deployment/service/EnvironmentBuilder.java0054

Details

org/apache/geronimo/deployment/service/jsr88/EnvironmentData.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorLine is longer than 120 characters.36
errorMissing a Javadoc comment.36
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.39
errorMissing a Javadoc comment.41
errorMissing a Javadoc comment.45
errorParameter dependency should be final.45
errorMissing a Javadoc comment.50
errorMissing a Javadoc comment.54
errorParameter env should be final.54
error'if' is not followed by whitespace.56
error'if' is not followed by whitespace.59
errorMissing a Javadoc comment.70
errorMissing a Javadoc comment.74
errorParameter configId should be final.74
error'if' is not followed by whitespace.77
error'&&' is not preceded with whitespace.77
error'if' is not followed by whitespace.80
error'if' is not followed by whitespace.83
errorMissing a Javadoc comment.89
errorMissing a Javadoc comment.93
errorParameter dependencies should be final.93
error'if' is not followed by whitespace.103
error'if' is not followed by whitespace.104
errorArray brackets at illegal position.115
error'if' is not followed by whitespace.117
errorLine is longer than 120 characters.123
error'if' is not followed by whitespace.123
errorMissing a Javadoc comment.129
errorMissing a Javadoc comment.133
errorParameter hidden should be final.133
errorLine is longer than 120 characters.134
errorAvoid inline conditionals.134
error'if' is not followed by whitespace.135
errorMissing a Javadoc comment.142
errorMissing a Javadoc comment.146
errorParameter fixed should be final.146
errorLine is longer than 120 characters.147
errorAvoid inline conditionals.147
error'if' is not followed by whitespace.148
errorMissing a Javadoc comment.155
errorMissing a Javadoc comment.159
errorParameter inverse should be final.159
error'if' is not followed by whitespace.161
error'if' is not followed by whitespace.162
error'if' is not followed by whitespace.166
errorMissing a Javadoc comment.173
errorMissing a Javadoc comment.177
errorParameter suppress should be final.177
error'if' is not followed by whitespace.179
error'if' is not followed by whitespace.180
error'if' is not followed by whitespace.184
errorMissing a Javadoc comment.193

org/apache/geronimo/deployment/service/GBeanBuilder.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorUnused import - org.apache.geronimo.deployment.ConfigurationBuilder.30
errorUnused import - org.apache.geronimo.kernel.Kernel.47
errorUnused import - org.apache.geronimo.kernel.repository.Repository.49
errorMissing a Javadoc comment.57
errorVariable 'attrRefMap' must be private and have accessor methods.57
errorMissing a Javadoc comment.58
errorVariable 'refRefMap' must be private and have accessor methods.58
errorMissing a Javadoc comment.59
errorMissing a Javadoc comment.60
errorMissing a Javadoc comment.61
errorMissing a Javadoc comment.63
errorParameter xmlAttributeBuilders should be final.63
errorParameter xmlReferenceBuilders should be final.63
errorParameter object should be final.67
errorParameter object should be final.79
errorMissing a Javadoc comment.89
errorParameter container should be final.89
errorParameter environment should be final.89
errorLine is longer than 120 characters.92
errorMissing a Javadoc comment.92
errorParameter container should be final.92
errorParameter applicationContext should be final.92
errorParameter moduleContext should be final.92
errorMissing a Javadoc comment.104
errorLine is longer than 120 characters.109
errorMissing a Javadoc comment.109
errorParameter gbean should be final.109
errorParameter moduleName should be final.109
errorParameter cl should be final.109
errorParameter context should be final.109
errorLine is longer than 120 characters.114
errorLine is longer than 120 characters.120
errorLine is longer than 120 characters.131
errorLine is longer than 120 characters.160
errorMissing a Javadoc comment.183
errorMissing a Javadoc comment.200

org/apache/geronimo/deployment/service/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/deployment/service/XmlAttributeBuilder.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.28
errorMissing a Javadoc comment.30

org/apache/geronimo/deployment/service/jsr88/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/deployment/service/XmlReferenceBuilder.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.31
errorLine is longer than 120 characters.33
errorMissing a Javadoc comment.33

org/apache/geronimo/deployment/xmlbeans/XmlBeansUtil.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorUnused import - org.apache.xmlbeans.SchemaTypeLoader.37
errorUnused import - org.apache.xmlbeans.SchemaType.38
errorClass XmlBeansUtil should be declared as final.45
errorMissing a Javadoc comment.46
errorMissing a Javadoc comment.48
errorName 'substitutionGroups' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.48
errorMissing a Javadoc comment.49
errorLine is longer than 120 characters.52
errorLine is longer than 120 characters.53
errorLine is longer than 120 characters.54
errorLine is longer than 120 characters.55
errorLine is longer than 120 characters.56
errorLine is longer than 120 characters.57
errorLine is longer than 120 characters.58
errorLine is longer than 120 characters.59
errorLine is longer than 120 characters.60
errorLine is longer than 120 characters.61
errorLine is longer than 120 characters.62
errorLine is longer than 120 characters.63
errorLine is longer than 120 characters.64
errorLine is longer than 120 characters.65
errorLine is longer than 120 characters.66
errorLine is longer than 120 characters.67
errorLine is longer than 120 characters.68
errorLine is longer than 120 characters.69
errorLine is longer than 120 characters.70
errorLine is longer than 120 characters.71
errorLine is longer than 120 characters.72
errorLine is longer than 120 characters.73
errorLine is longer than 120 characters.74
errorLine is longer than 120 characters.75
errorLine is longer than 120 characters.76
errorLine is longer than 120 characters.77
errorLine is longer than 120 characters.80
errorLine is longer than 120 characters.81
errorLine is longer than 120 characters.82
errorLine is longer than 120 characters.83
errorLine is longer than 120 characters.84
errorMissing a Javadoc comment.87
errorMissing a Javadoc comment.91
errorParameter file should be final.91
errorMissing a Javadoc comment.100
errorParameter url should be final.100
errorParameter cl should be final.100
errorMissing a Javadoc comment.117
errorParameter is should be final.117
errorMissing a Javadoc comment.126
errorParameter xml should be final.126
errorMissing a Javadoc comment.135
errorParameter element should be final.135
errorMissing a Javadoc comment.144
errorParameter errors should be final.144
errorMissing a Javadoc comment.152
errorParameter substitutionGroup should be final.152
errorParameter substitutions should be final.152
errorMissing a Javadoc comment.160
errorParameter substitutionGroup should be final.160
errorParameter substitutions should be final.160
errorMissing a Javadoc comment.168
errorParameter substitutionGroup should be final.168
errorMissing a Javadoc comment.172
errorParameter substitutionGroup should be final.172
errorParameter container should be final.172
errorMissing a Javadoc comment.180
errorParameter dd should be final.180
errorLine is longer than 120 characters.208
errorMust have at least one statement.211

org/apache/geronimo/deployment/xmlbeans/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/deployment/service/jsr88/Artifact.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorLine is longer than 120 characters.32
errorMissing a Javadoc comment.32
errorMissing a Javadoc comment.34
errorMissing a Javadoc comment.38
errorParameter dependency should be final.38
errorMissing a Javadoc comment.43
errorMissing a Javadoc comment.47
errorParameter dependency should be final.47
errorMissing a Javadoc comment.53
errorMissing a Javadoc comment.57
errorParameter groupId should be final.57
error'if' is not followed by whitespace.59
errorMissing a Javadoc comment.67
errorMissing a Javadoc comment.71
errorParameter artifact should be final.71
errorMissing a Javadoc comment.77
errorMissing a Javadoc comment.81
errorParameter type should be final.81
error'if' is not followed by whitespace.83
errorMissing a Javadoc comment.91
errorMissing a Javadoc comment.95
errorParameter version should be final.95
error'if' is not followed by whitespace.97
errorMissing a Javadoc comment.107

org/apache/geronimo/deployment/service/SingleGBeanBuilder.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.48
errorMissing a Javadoc comment.49
errorMissing a Javadoc comment.50
errorMissing a Javadoc comment.51
errorMissing a Javadoc comment.52
errorMissing a Javadoc comment.53
errorLine is longer than 120 characters.55
errorMissing a Javadoc comment.55
errorParameter abstractName should be final.55
errorParameter gBeanInfo should be final.55
errorParameter classLoader should be final.55
errorParameter context should be final.55
errorParameter moduleName should be final.55
errorParameter xmlAttributeBuilderMap should be final.55
errorParameter xmlReferenceBuilderMap should be final.55
errorMissing a Javadoc comment.65
errorParameter name should be final.65
errorParameter type should be final.65
errorParameter text should be final.65
errorMissing a Javadoc comment.95
errorParameter name should be final.95
errorParameter xmlObject should be final.95
errorMissing a Javadoc comment.110
errorParameter name should be final.110
errorParameter xmlObject should be final.110
errorMissing a Javadoc comment.122
errorParameter name should be final.122
errorParameter pattern should be final.122
errorParameter parentName should be final.122
errorMissing a Javadoc comment.126
errorParameter name should be final.126
errorParameter patterns should be final.126
errorParameter parentName should be final.126
errorMissing a Javadoc comment.134
errorParameter patternType should be final.134
errorMissing a Javadoc comment.139
errorParameter refName should be final.139
errorParameter pattern should be final.139
errorLine is longer than 120 characters.141
errorMissing a Javadoc comment.160
errorParameter pattern should be final.160
errorParameter referenceInfo should be final.160
errorAvoid inline conditionals.161
errorAvoid inline conditionals.162
errorAvoid inline conditionals.163
errorAvoid inline conditionals.164
errorAvoid inline conditionals.165
errorAvoid inline conditionals.166
error'?' is not preceded with whitespace.168
errorAvoid inline conditionals.168
error':' is not preceded with whitespace.168
error'?' is not preceded with whitespace.183
errorAvoid inline conditionals.183
error':' is not preceded with whitespace.183
errorMissing a Javadoc comment.187

org/apache/geronimo/deployment/service/ServiceConfigBuilder.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorMissing a Javadoc comment.68
errorMissing a Javadoc comment.69
errorMissing a Javadoc comment.71
errorMissing a Javadoc comment.72
errorMissing a Javadoc comment.73
errorMissing a Javadoc comment.74
errorMissing a Javadoc comment.75
errorMissing a Javadoc comment.77
errorParameter defaultEnvironment should be final.77
errorParameter repositories should be final.77
errorParameter naming should be final.77
errorLine is longer than 120 characters.81
errorMissing a Javadoc comment.81
errorParameter defaultEnvironment should be final.81
errorParameter repositories should be final.81
errorParameter serviceBuilders should be final.81
errorParameter kernel should be final.81
errorLine is longer than 120 characters.82
errorLine is longer than 120 characters.85
errorMissing a Javadoc comment.85
errorParameter defaultEnvironment should be final.85
errorParameter repositories should be final.85
errorParameter serviceBuilders should be final.85
errorParameter naming should be final.85
errorLine is longer than 120 characters.89
errorMissing a Javadoc comment.89
errorParameter defaultEnvironment should be final.89
errorParameter repositories should be final.89
errorParameter serviceBuilders should be final.89
errorParameter naming should be final.89
errorParameter configurationManager should be final.89
errorLine is longer than 120 characters.100
errorMissing a Javadoc comment.100
errorParameter planFile should be final.100
errorParameter jarFile should be final.100
errorParameter idBuilder should be final.100
error'if' is not followed by whitespace.119
errorLine is longer than 120 characters.139
error'if' is not followed by whitespace.140
error'||' should be on a new line.140
error'||' should be on a new line.141
error'if' is not followed by whitespace.143
error'if' is not followed by whitespace.146
error'if' is not followed by whitespace.151
errorLine is longer than 120 characters.164
errorMissing a Javadoc comment.164
errorParameter plan should be final.164
errorParameter module should be final.164
errorParameter idBuilder should be final.164
errorAvoid inline conditionals.168
error'if' is not followed by whitespace.169
error'+' is not preceded with whitespace.170
error'+' is not followed by whitespace.170
error'+' is not preceded with whitespace.170
error'+' is not followed by whitespace.170
errorLine is longer than 120 characters.175
errorMissing a Javadoc comment.175
errorParameter inPlaceDeployment should be final.175
errorParameter configId should be final.175
errorParameter plan should be final.175
errorParameter jar should be final.175
errorParameter configurationStores should be final.175
errorParameter artifactResolver should be final.175
errorParameter targetConfigurationStore should be final.175
errorLine is longer than 120 characters.178
errorLine is longer than 120 characters.181
errorMissing a Javadoc comment.181
errorParameter inPlaceDeployment should be final.181
errorParameter configId should be final.181
errorParameter moduleType should be final.181
errorParameter jar should be final.181
errorParameter configurationStores should be final.181
errorParameter artifactResolver should be final.181
errorParameter targetConfigurationStore should be final.181
errorLine is longer than 120 characters.182
errorAvoid inline conditionals.182
error'if' is not followed by whitespace.188
errorLine is longer than 120 characters.189
error'+' is not preceded with whitespace.189
error'+' is not followed by whitespace.189
error'+' is not preceded with whitespace.189
error'+' is not followed by whitespace.189
error'configurationManager' hides a field.200
errorLine is longer than 120 characters.202
errorAvoid inline conditionals.207
error'if' is not followed by whitespace.214
errorMissing a Javadoc comment.236
errorParameter context should be final.236
errorParameter directory should be final.236
error'!=' is not followed by whitespace.238
errorMust have at least one statement.241
errorMust have at least one statement.243
errorMissing a Javadoc comment.251
errorMissing a Javadoc comment.270

org/apache/geronimo/deployment/service/JavaBeanXmlAttributeBuilder.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.41
errorMissing a Javadoc comment.43
errorMissing a Javadoc comment.47
errorParameter xmlObject should be final.47
errorParameter type should be final.47
errorParameter cl should be final.47
errorMissing a Javadoc comment.52
errorParameter javabean should be final.52
errorParameter className should be final.52
errorParameter cl should be final.52
errorLine is longer than 120 characters.97
errorLine is longer than 120 characters.118
errorMissing a Javadoc comment.127
errorLine is longer than 120 characters.130
errorMissing a Javadoc comment.135

org/apache/geronimo/deployment/service/EnvironmentBuilder.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorMissing a Javadoc comment.52
error'static' modifier out of order with the JLS suggestions.52
errorMissing a Javadoc comment.53
error'static' modifier out of order with the JLS suggestions.53
errorMissing a Javadoc comment.55
errorParameter environmentType should be final.55
errorMissing a Javadoc comment.76
errorParameter environment should be final.76
errorParameter additionalEnvironment should be final.76
errorLine is longer than 120 characters.83
errorLine is longer than 120 characters.84
errorMissing a Javadoc comment.90
errorParameter environmentType should be final.90
errorParameter defaultEnvironment should be final.90
errorMissing a Javadoc comment.98
errorParameter environment should be final.98
errorLine is longer than 120 characters.106
errorMissing a Javadoc comment.120
errorParameter filters should be final.120
errorMissing a Javadoc comment.127
errorParameter artifacts should be final.127
errorMissing a Javadoc comment.137
errorParameter artifact should be final.137
errorMissing a Javadoc comment.143
errorParameter artifact should be final.143
errorParameter artifactType should be final.143
errorMissing a Javadoc comment.158
errorParameter dependency should be final.158
errorMissing a Javadoc comment.172
errorParameter filterType should be final.172
errorMissing a Javadoc comment.185
errorParameter artifactTypes should be final.185
errorMissing a Javadoc comment.195
errorParameter dependencyArray should be final.195
errorMissing a Javadoc comment.205
errorParameter dependencyType should be final.205
errorMissing a Javadoc comment.218
errorParameter artifactType should be final.218
errorParameter defaultType should be final.218
errorAvoid inline conditionals.219
errorAvoid inline conditionals.220
errorAvoid inline conditionals.222
errorMissing a Javadoc comment.226
errorParameter string should be final.226
errorMissing a Javadoc comment.234
errorMissing a Javadoc comment.238
errorParameter xmlObject should be final.238
errorParameter type should be final.238
errorParameter cl should be final.238
errorLine is longer than 120 characters.252
errorMissing a Javadoc comment.261
errorMissing a Javadoc comment.270
errorParameter text should be final.270