Geronimo :: Security - PMD Results

Last Published: 10 Nov 2006

Geronimo | Apache

Parent Project

Geronimo :: Modules

Project Documentation

Project Information
Project Reports
- Checkstyle
- CPD Report
- JavaDocs
- Maven Surefire Report
- PMD Report
- Source Xref
- Test Source Xref

Built by Maven

PMD Results

The following document contains the results of PMD 3.7.

Files

org/apache/geronimo/security/deploy/Security.java

Violation	Line
Avoid unused imports such as 'java.util.HashSet'	21
Avoid unused imports such as 'java.util.Iterator'	22
Avoid unused imports such as 'java.util.Set'	24

org/apache/geronimo/security/deploy/Role.java

Violation	Line
Avoid unused imports such as 'java.util.Map'	21

org/apache/geronimo/security/keystore/FileKeystoreInstance.java

Violation	Line
Avoid empty catch blocks	420 - 421
Avoid empty catch blocks	457 - 459
Avoid empty catch blocks	459 - 461
Avoid empty catch blocks	461 - 463

org/apache/geronimo/security/keystore/FileKeystoreManager.java

Violation	Line
Avoid unused imports such as 'java.security.KeyManagementException'	28
Avoid unused imports such as 'java.security.NoSuchProviderException'	32
Avoid unused imports such as 'java.security.UnrecoverableKeyException'	35
Avoid unused imports such as 'org.apache.geronimo.management.geronimo.KeyIsLocked'	59
Avoid empty catch blocks	356
Avoid empty catch blocks	369

org/apache/geronimo/security/jaas/UPCredentialLoginModule.java

Violation	Line
Avoid empty catch blocks	101 - 103

org/apache/geronimo/security/jaas/client/LoginModuleProxy.java

Violation	Line
Avoid unused imports such as 'org.apache.geronimo.security.jaas.server.JaasSessionId'	22
Avoid unused imports such as 'org.apache.geronimo.security.jaas.server.JaasLoginServiceMBean'	23

org/apache/geronimo/security/jaas/client/JaasLoginCoordinator.java

Violation	Line
These nested if statements could be combined	229 - 231

org/apache/geronimo/security/jaas/server/JaasSecuritySession.java

Violation	Line
Avoid unused imports such as 'java.security.Principal'	19
Avoid unused imports such as 'java.util.HashSet'	20
Avoid unused imports such as 'java.util.Iterator'	21
Avoid unused imports such as 'java.util.LinkedList'	22
Avoid unused imports such as 'java.util.List'	23
Avoid unused imports such as 'java.util.Set'	25
Avoid unused imports such as 'org.apache.geronimo.security.DomainPrincipal'	30
Avoid unused imports such as 'org.apache.geronimo.security.RealmPrincipal'	31

org/apache/geronimo/security/jaas/server/JaasLoginServiceMBean.java

Violation	Line
Avoid unused imports such as 'java.util.Collection'	20
Avoid unused imports such as 'org.apache.geronimo.common.GeronimoSecurityException'	26

org/apache/geronimo/security/jaas/server/JaasLoginService.java

Violation	Line
Avoid empty catch blocks	218 - 220
Avoid empty catch blocks	223 - 225
Avoid empty catch blocks	404 - 405
Avoid empty catch blocks	405 - 406

org/apache/geronimo/security/jaas/NamedUPCredentialLoginModule.java

Violation	Line
Avoid empty catch blocks	104 - 106

org/apache/geronimo/security/jaas/ConfiguredIdentityNamedUsernamePasswordLoginModule.java

Violation	Line
Avoid empty catch blocks	78 - 80

org/apache/geronimo/security/ContextManager.java

Violation	Line
Avoid empty catch blocks	376 - 377
Avoid empty catch blocks	377 - 378

org/apache/geronimo/security/remoting/jmx/SerializableInvocation.java

Violation	Line
Avoid unused private fields such as 'proxy'	40

org/apache/geronimo/security/jacc/ApplicationPrincipalRoleConfigurationManager.java

Violation	Line
Avoid unused imports such as 'java.security.Permission'	19
Avoid unused imports such as 'java.security.PermissionCollection'	20
Avoid unused imports such as 'java.security.Policy'	21
Avoid unused imports such as 'java.util.Enumeration'	22
Avoid unused imports such as 'java.util.HashMap'	23
Avoid unused imports such as 'javax.security.auth.Subject'	27
Avoid unused imports such as 'javax.security.jacc.PolicyConfiguration'	28
Avoid unused imports such as 'javax.security.jacc.PolicyConfigurationFactory'	29
Avoid unused imports such as 'org.apache.geronimo.gbean.GBeanLifecycle'	34
Avoid unused imports such as 'org.apache.geronimo.security.ContextManager'	36
Avoid unused imports such as 'org.apache.geronimo.security.IdentificationPrincipal'	37
Avoid unused imports such as 'org.apache.geronimo.security.SubjectId'	38

org/apache/geronimo/security/jacc/GeronimoPolicy.java

Violation	Line
Avoid empty catch blocks	89 - 90

org/apache/geronimo/security/realm/providers/SQLLoginModule.java

Violation	Line
Avoid empty catch blocks	125 - 127

org/apache/geronimo/security/realm/providers/GeronimoPasswordCredentialLoginModule.java

Violation	Line
Avoid empty catch blocks	53 - 54

org/apache/geronimo/security/realm/providers/PasswordCallbackHandler.java

Violation	Line
Avoid unused imports such as 'javax.security.auth.callback.CallbackHandler'	21

org/apache/geronimo/security/realm/providers/LDAPLoginModule.java

Violation	Line
Avoid unused imports such as 'java.util.List'	26
No need to import a type that's in the same package	56
No need to import a type that's in the same package	57
Avoid unused private fields such as 'userPassword'	90
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.	130
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.	131
Avoid empty if statements	232
Avoid empty catch blocks	260 - 262
Avoid unused local variables such as 'attr'	334
Avoid unused private methods such as 'getAttributeValue(String,Attributes)'	363

org/apache/geronimo/security/realm/providers/CertificateChainCallback.java

Violation	Line
Avoid unused imports such as 'java.security.cert.X509Certificate'	19

org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java

Violation	Line
Avoid unused private fields such as 'log'	53